| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-19 | |||
| 16:16:51 | mriedem | i don't actually know what the limit is on http response body size | |
| 16:17:05 | mriedem | it's filtering on which to ignore | |
| 16:17:07 | edleafe | mriedem: that's where the paging discussion came up | |
| 16:17:16 | mriedem | we just need to put a limit on how many filtered RPs can be returned | |
| 16:17:53 | edleafe | mriedem: if 5000 hosts can satisfy the request, placement cannot determine which ones are returned and which are not | |
| 16:18:15 | mriedem | edleafe: we do that today with 1.4 right? | |
| 16:18:22 | mriedem | and before that with ComputeNode.get_all() | |
| 16:18:25 | edleafe | mriedem: not that I know of | |
| 16:18:26 | dansmith | mriedem: no limit, since you don't have to provide content-length | |
| 16:18:29 | mriedem | actually with 1.4 we don't limit at all probably | |
| 16:18:40 | dansmith | mriedem: today we just OOM the scheduler if we have too many hosts I think | |
| 16:18:45 | mriedem | but with ComptueNode.get_all(), pre-placement, it was 1000 by default i think | |
| 16:19:35 | mriedem | but maybe we don't, i thought we used the os_api_limit config somewhere in the db api | |
| 16:19:36 | dansmith | mriedem: people with 100k hosts today already pick very coarse-grained because they're on cellsv1, where they pick a cell before they pick a host, which is exactly like limiting to the top N results from placement, | |
| 16:19:44 | dansmith | except we *know* the top N results from placement are valid, | |
| 16:20:00 | dansmith | and we could schedule to a full cell and then get trapped today | |
| 16:21:16 | jaypipes | is this something we need to solve today?' | |
| 16:22:13 | dansmith | jaypipes: you want the sarcastic or real answer? | |
| 16:22:15 | jaypipes | I think it's interesting that people who complain about some of my code looking like "premature optimization" (traits cache, etc) are trying to predict the behaviour of this API call for a deployment of 100K nodes which nobody has. | |
| 16:22:47 | jaypipes | dansmith: it's about a 5-line change to gzip this shit over to the scheduler. | |
| 16:22:51 | mriedem | i guess i don't see where we use max_limit in the db api if the caller (compute api) didn't pass in the limit, so pre-placement filter scheduler (mitaka) would just do ComputeNode.get_all() and pull in everything as dan said | |
| 16:22:59 | jaypipes | dansmith: and it could handle tons of entries, frankly. | |
| 16:23:07 | dansmith | jaypipes: you needn't convince me, as you know :P | |
| 16:23:39 | jaypipes | dansmith: plus, we're talking about the same number of allocation requests as the number of entries returned today when there's a single provider of shared disk. | |
| 16:24:01 | dansmith | jaypipes: you needn't convince me, as you know :P | |
| 16:24:09 | jaypipes | I'm just venting, sorry. | |
| 16:24:22 | dansmith | jaypipes: you needn't convince me, as you know :P | |
| 16:24:58 | edleafe | jaypipes: mriedem was asking about some of the backstory behind the HostState removal stuff | |
| 16:30:29 | openstackgerrit | Merged openstack/python-novaclient master: Make --profile load from environment variables https://review.openstack.org/475251 | |
| 16:35:53 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API https://review.openstack.org/471899 | |
| 16:35:53 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle uuid in HostAPI.compute_node_get https://review.openstack.org/461532 | |
| 16:35:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Consolidate index and detail methods in HypervisorsController https://review.openstack.org/475458 | |
| 16:35:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Use uuid for id in os-services API https://review.openstack.org/464280 | |
| 16:36:08 | mriedem | melwitt: unit test comments addressed ^ | |
| 16:43:43 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API https://review.openstack.org/471899 | |
| 16:47:37 | openstackgerrit | Alex Szarka proposed openstack/nova master: Reduce code duplication https://review.openstack.org/347422 | |
| 17:13:36 | ckopper | danpawlik: are you around? sorry for the radio silence but once you have a minute we could chat a bit about the `img_hide_hypervisor_id` patch and and how to proceed (i.e. do we need `hv_vendor_id`?) | |
| 17:32:51 | mriedem | gibi: i won't be able to make the notification meeting tomorrow, just fyi | |
| 17:34:11 | openstackgerrit | Merged openstack/nova master: Fix a wrong comment https://review.openstack.org/474400 | |
| 17:40:39 | openstackgerrit | Merged openstack/nova master: Add separate instance.create payload type https://review.openstack.org/463001 | |
| 17:41:15 | openstackgerrit | Merged openstack/nova master: api-ref: fix unshelve asynchronous postconditions typo https://review.openstack.org/475386 | |
| 17:43:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Fix and optimize external_events for multiple cells https://review.openstack.org/445142 | |
| 18:11:25 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448 | |
| 18:11:54 | jaypipes | mriedem, dansmith, edleafe, bauzas: ^^ now with reno and more gabbits tests. | |
| 18:12:11 | jaypipes | moving on to scheduler integration now. | |
| 18:17:02 | dansmith | jaypipes: schwing | |
| 18:19:51 | mriedem1 | jaypipes: why are the container objects being registered now | |
| 18:19:57 | mriedem1 | like AllocationRequestResource | |
| 18:23:46 | dansmith | mriedem: because you asked and he wasn't paying attention to the response | |
| 18:24:01 | dansmith | mriedem: those should be register_if(False) like before | |
| 18:27:03 | dansmith | that's my bad for not putting the response in gerrit | |
| 18:40:33 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448 | |
| 18:40:33 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: produce set of allocation candidates https://review.openstack.org/473377 | |
| 18:41:19 | jaypipes | dansmith: all the other objects in the file are registered so I registered these as well. it allows me to do: from nova import objects; allocs = objects.AllocationCandidates.get_by_filters() | |
| 18:41:27 | jaypipes | anyway, guys, addressed your comments. | |
| 18:49:48 | dansmith | jaypipes: register_if(False) should as well I think, | |
| 18:50:07 | dansmith | jaypipes: but as we discussed before, the other objects are registered because they were going to be used for nova RPC initially | |
| 18:50:44 | dansmith | jaypipes: if we leave them registered, then nova services will automatically be able to send/receive them over RPC, which is a bad idea given our plan to sever ties, IMHO | |
| 18:51:01 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448 | |
| 18:51:01 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: produce set of allocation candidates https://review.openstack.org/473377 | |
| 18:51:21 | jaypipes | dansmith: register_if(False) doesn't unfortunately. | |
| 18:51:36 | jaypipes | dansmith: but I hear your concern | |
| 18:51:54 | jaypipes | dansmith: and I def don't want to send any of these over RPC | |
| 18:52:01 | dansmith | jaypipes: well, that's not really intended, but okay | |
| 18:52:03 | jaypipes | dansmith: would you accept a future patch removing all of that? | |
| 18:52:07 | dansmith | jaypipes: either way, I think they should be register_if(False) even if we have to use their full imports | |
| 18:52:19 | mriedem | you could still do: from nova.objects import resource_providers; allocs = resource_providers.AllocationCandidates.get_by_filters() | |
| 18:52:22 | mriedem | which isn't too bad | |
| 18:52:36 | dansmith | jaypipes: sup to you I guess. it's kinda bad to register and them unregister them, although it's only principle | |
| 18:52:50 | dansmith | jaypipes: happy to make the change myself if you want, but dont'want to stomp on your pending changes | |
| 18:53:02 | jaypipes | mriedem, dansmith: k, gimme a few. I'll do that | |
| 18:53:31 | mriedem | otherwise i'm like +10 if that helps | |
| 19:06:39 | openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/467173 | |
| 19:07:40 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: support GET /allocation_candidates https://review.openstack.org/475448 | |
| 19:07:40 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: produce set of allocation candidates https://review.openstack.org/473377 | |
| 19:07:46 | jaypipes | mriedem, dansmith: ok dokey. ^ | |
| 19:12:37 | mriedem | has anyone here ever had a hard time figuring out why their api samples test failed w/o an unexpected response code? | |
| 19:12:44 | mriedem | and spent hours figuring it out? | |
| 19:12:55 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Provide error message in MismatchError for api-samples tests https://review.openstack.org/475489 | |
| 19:12:59 | mriedem | *with i should say | |
| 19:13:07 | mriedem | well wonder no more dear friends ^ | |
| 19:14:10 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Provide error message in MismatchError for api-samples tests https://review.openstack.org/475489 | |
| 19:50:40 | melwitt | mriedem: I hoped someone would figure that out and improve it after cfriesen brought it up last week. *two thumbs up* | |
| 19:51:40 | mriedem | i've got another one coming soon | |
| 19:51:50 | mriedem | generalize_subs is a thing that took me an hour or so to find | |
| 19:51:50 | melwitt | yess | |
| 19:52:18 | mriedem | because i kept getting this http://paste.openstack.org/show/613134/ | |
| 19:52:24 | mriedem | but knew my test and template and subs were all good | |
| 19:53:44 | melwitt | mriedem: that's the useless output I've seen on some transient func test failures in the gate! | |
| 19:54:05 | melwitt | or at least I couldn't tell that anything was wrong from it | |
| 19:54:09 | mriedem | well, i was just going to add a reminder in the error message to check if your test needs to override generalize_subs | |
| 19:54:31 | mriedem | because the api samples functional tests are very much an exercise in what you don't know you need to do to make them work | |
| 19:54:35 | mriedem | so the more hints we can provide the better | |
| 19:55:04 | melwitt | yeah, I think hints of any kind are a vast improvement | |
| 19:55:22 | openstackgerrit | Rick Bartra proposed openstack/nova master: Add policy granularity to the Flavors API https://review.openstack.org/449288 | |
| 20:00:52 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Provide a hint when _verify_response fails https://review.openstack.org/475512 | |
| 20:09:27 | melwitt | mriedem: do you happen to know if novaclient or OSC are capable of doing any automatic paging when e.g. number of servers > 1000 for a server list? | |
| 20:10:55 | mriedem | i think novaclient might, not sure about osc | |
| 20:11:14 | melwitt | thanks. I feel like I heard of something like that but memory is hazy | |
| 20:11:42 | mriedem | https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/shell.py#L1424 | |