Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-14
22:18:59 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.48: Standardization of VM diagnostics https://review.openstack.org/473228
22:19:08 eandersson got 100% on that one test now, lets see if the others are going to be as happy :D
22:19:34 mriedem oomichi: it's one of my questions to alex_xu
22:19:40 mriedem i don't want to use empty schema if it can be avoided
22:19:45 mriedem but yeah it's all WIP right now
22:19:59 mriedem cfriesen: that's a dansmith question
22:20:04 mriedem i know some of them go through the objects,
22:20:13 mriedem but i figure they should be local to the db
22:30:33 eandersson https://github.com/openstack/nova/blob/master/nova/tests/functional/regressions/test_bug_1671648.py#L97
22:32:49 eandersson Looks like a very similar issue
22:35:43 melwitt huh, I added that. barely remember it
22:37:02 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle uuid in HostAPI.compute_node_get https://review.openstack.org/461532
22:37:03 openstackgerrit Matt Riedemann proposed openstack/nova master: Use uuid for id in os-services API https://review.openstack.org/464280
22:37:03 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API https://review.openstack.org/471899
22:37:04 openstackgerrit Matt Riedemann proposed openstack/nova master: Stop caching compute nodes in the request https://review.openstack.org/474382
22:37:04 openstackgerrit Matt Riedemann proposed openstack/nova master: Centralize compute_node_search_by_hypervisor in os-hypervisors https://review.openstack.org/474381
22:37:11 mriedem easy pickins on those bottom two changes
22:40:14 eandersson mriedem, so your suggestion fixed most issues, but it's still hitting this in 4 tests > not self.driver.node_is_available(nodename)
22:40:25 openstackgerrit Merged openstack/nova master: Count server group members to check quota https://review.openstack.org/457859
22:42:18 eandersson I see - FAKE_NODES need to have both hosts
22:48:28 melwitt mriedem: just curious, how was the compute node request cache messing up what you're working on?
22:49:16 openstackgerrit Merged openstack/nova master: Make compute_node_statistics() work across cells https://review.openstack.org/473931
22:53:23 openstackgerrit Erik Olof Gunnar Andersson proposed openstack/nova master: Re-worked ram filter and weights to support overcommit https://review.openstack.org/390984
22:53:40 eandersson That was effort, but I think I got it figured out
22:54:29 eandersson I could probably have left fake_network where it was though
22:59:22 eandersson thanks melwitt
23:02:53 melwitt eandersson: np. you might probably be asked to split the test fix into its own patch ahead of your scheduler patch. the issue in the server group tests is probably affecting other things too and is its own separate bug
23:03:18 eandersson Yea - was thinking the same.
23:04:15 eandersson Gonna go and get luncch and Zuul is hopefully all green :D delayed lunch by like... 4 hours trying to figure this out :D
23:04:27 eandersson *by the time I get back
#openstack-nova - 2017-06-15
00:06:28 openstackgerrit Erik Olof Gunnar Andersson proposed openstack/nova master: Re-worked ram filter and weights to support overcommit https://review.openstack.org/390984
00:08:31 openstackgerrit Erik Olof Gunnar Andersson proposed openstack/nova master: Re-worked ram filter and weights to support overcommit https://review.openstack.org/390984
00:11:59 mriedem melwitt: it wasn't
00:12:11 mriedem melwitt: but the amount of gorp in the hypervisors api controller code hurts me
00:12:12 mriedem inside
00:12:40 mriedem so before i add more complication in there, i'm trying to trim the fat a bit
00:32:57 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: cleanup PUT /os-hypervisors/statistics docs https://review.openstack.org/474250
00:37:21 openstackgerrit Matt Riedemann proposed openstack/nova master: Stop caching compute nodes in the request https://review.openstack.org/474382
00:37:22 openstackgerrit Matt Riedemann proposed openstack/nova master: Handle uuid in HostAPI.compute_node_get https://review.openstack.org/461532
00:37:23 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API https://review.openstack.org/471899
00:37:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Centralize compute_node_search_by_hypervisor in os-hypervisors https://review.openstack.org/474381
00:37:24 openstackgerrit Matt Riedemann proposed openstack/nova master: Use uuid for id in os-services API https://review.openstack.org/464280
01:03:08 openstackgerrit Erik Olof Gunnar Andersson proposed openstack/nova master: Re-worked ram filter and weights to support overcommit https://review.openstack.org/390984
01:20:12 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix a wrong comment https://review.openstack.org/474400
01:32:45 openstackgerrit Erik Olof Gunnar Andersson proposed openstack/nova master: Fixing issues with functional server_group tests https://review.openstack.org/474404
01:35:14 eandersson melwitt ^
01:35:46 eandersson Assuming that looks good I'll have my previous patch depend on it
01:43:30 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-cloudpipe endpoint instead of stevedore https://review.openstack.org/474116
02:00:47 eandersson melwitt pretty sure something larger is wrong with these tests
02:02:22 eandersson Based on how _FAKE_NODES is implemented it makes me believe that all the active nodes should be listed in set_nodes
02:02:35 eandersson e.g. set_nodes(['host1', 'host2'])
02:02:49 eandersson but that breaks a lot of the tests
02:08:22 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593
02:09:25 alex_xu oomichi: mriedem https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/keypairs.py#L94 is for backward-compatible, the API accept any invalid query parameters, we can't set it addtionalProperties as False, it break the API contract
02:09:41 alex_xu mriedem: and I'm checking other questions :)
02:17:20 alex_xu mriedem: oh, I got the original question. I agree without those empty validation, the API still works correctly. But I guess we still want to show the API contract explicitly, the empty schema means there is no any valid query parameter for this api version
02:19:23 alex_xu mriedem: I initialy thought we add the query parameter validation decorator for all the APIs.
02:54:50 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593
03:12:32 mriedem alex_xu: can you comment on this todo question i have in here then? https://review.openstack.org/#/c/471899/10/nova/api/openstack/compute/hypervisors.py@109
03:12:46 mriedem i'll try to get back to it tomorrow
04:41:04 openstackgerrit Deepak Mourya proposed openstack/python-novaclient master: Replace assertGreaterEqual with assertNotEmpty https://review.openstack.org/474447
05:48:12 openstackgerrit Shunli Zhou proposed openstack/nova master: Transform servergroup.create notification https://review.openstack.org/454023
06:32:34 cheran @here
06:33:25 cheran @here https://specs.openstack.org/openstack/nova-specs/specs/kilo/approved/request-spec-object.html anyone can help me in accesing filter from request_spec in mitaka release
06:35:34 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955
06:39:05 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
06:40:05 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
06:40:30 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926
06:41:45 cheran We have a filter which uses the *filter_properties* in _schedule() implementation, in mitaka the FilterSchudler interface is changed to use the request_spec obj
06:42:12 cheran So wondering how I can get the filter_properties from the reqest_spec
06:51:17 openstackgerrit Erik Olof Gunnar Andersson proposed openstack/nova master: Fixing issues with functional server_group tests https://review.openstack.org/474404
07:16:27 openstackgerrit Merged openstack/nova master: conf: remove console_driver opt https://review.openstack.org/441485
07:25:21 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-networks instead of stevedore https://review.openstack.org/474463
07:39:17 openstackgerrit Erik Olof Gunnar Andersson proposed openstack/nova master: Fixing issues with functional server_group tests https://review.openstack.org/474404
07:46:20 openstackgerrit Erik Olof Gunnar Andersson proposed openstack/nova master: Fixing issues with functional server_group tests https://review.openstack.org/474404
07:46:21 openstackgerrit Erik Olof Gunnar Andersson proposed openstack/nova master: Re-worked ram filter and weights to support overcommit https://review.openstack.org/390984
07:51:44 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-networks instead of stevedore https://review.openstack.org/474463
07:51:45 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-quota-classes endpoint instead of stevedore https://review.openstack.org/461641
07:51:45 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-cloudpipe endpoint instead of stevedore https://review.openstack.org/474116
07:51:46 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Use plain routes list for os-tenant-networks instead of stevedore https://review.openstack.org/474475
08:00:59 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
08:01:38 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926
08:02:18 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
08:26:54 openstackgerrit jichenjc proposed openstack/nova master: [placement] Add doc for resource provider usages https://review.openstack.org/450105
08:31:28 openstackgerrit Shunli Zhou proposed openstack/nova master: Transform servergroup.create notification https://review.openstack.org/454023
08:33:39 openstackgerrit jichenjc proposed openstack/nova master: [placement] Add /GET allocation doc for placement https://review.openstack.org/450550
08:42:15 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for traits https://review.openstack.org/474186
08:45:28 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add snapshot id to the snapshot notifications https://review.openstack.org/453077
08:45:28 openstackgerrit Balazs Gibizer proposed openstack/nova master: explain payload inheritance in notification devref https://review.openstack.org/453667
08:54:01 gibi bauzas, johnthetubaguy or other cores already awake: there is a simple bugfix that only needs a +A https://review.openstack.org/#/c/421981/ if you have time. :)
08:54:11 bauzas gibi: looking
08:54:15 gibi bauzas: thanks!
09:07:11 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add snapshot id to the snapshot notifications https://review.openstack.org/453077
09:07:11 openstackgerrit Balazs Gibizer proposed openstack/nova master: explain payload inheritance in notification devref https://review.openstack.org/453667
09:08:41 openstackgerrit Li Yingjun proposed openstack/nova master: Fix duplicate Neutron ports on instance reschedule https://review.openstack.org/467509
09:22:00 bauzas p!spy
09:25:13 openstackgerrit Balazs Gibizer proposed openstack/nova master: remove null_safe_int from module scope https://review.openstack.org/455778
09:29:44 openstackgerrit Balazs Gibizer proposed openstack/nova master: remove null_safe_int from module scope https://review.openstack.org/455778
09:30:21 openstackgerrit jichenjc proposed openstack/nova master: Update api-ref to indicate swap param https://review.openstack.org/474517
09:30:40 openstackgerrit Vladyslav Drok proposed openstack/nova master: neutron: re-raise 401 for a non-admin client https://review.openstack.org/422696

Earlier   Later