Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-12
15:53:34 sfinucan efried: Nope - I just wanted to explain why it was done that way
15:53:43 sfinucan My phrasing wasn't great, admittedly
15:54:06 efried "Dodgy test removed." <== what is this referring to?
15:54:26 efried Cause the dodgy test you point out in PS15 doesn't appear to have been removed.
15:54:37 sfinucan efried: mriedem's comments on Jan 27 03:42
15:55:09 sfinucan efried: The 'test_glanceclient_session_cached' test is removed, right?
15:55:30 sfinucan that's the test I referred to (it's attempted mocking of a global is apparently not do'able)
15:57:34 efried sfinucan [Still digging]
15:59:59 efried sfinucan Phew, that took me longer than it should. Okay, I'm happy. I got confused because those two comments looked like they were related to each other.
16:00:06 efried sfinucan Thanks!
16:00:50 sfinucan efried: Cool cool. Sorry for the poor phrasing https://imgur.com/Lffqx89
16:16:53 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add key_name field to InstancePayload https://review.openstack.org/463002
16:16:53 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779
16:16:54 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add separate instance.create payload type https://review.openstack.org/463001
16:16:54 openstackgerrit Balazs Gibizer proposed openstack/nova master: Add keypairs field to InstanceCreatePayload https://review.openstack.org/419730
16:19:18 mriedem oomichi: sdague: checking my understanding on something, which i think is a bug - the forced_down field in the PUT /os-services/force-down API uses the boolean parameter type in the schema https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/schemas/services.py#L42
16:19:38 mriedem which can be something like 'yes' https://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L190
16:20:02 sdague mriedem: ok
16:20:04 mriedem which isn't converted to an actual boolean https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/services.py#L136
16:20:28 mriedem which methinks will explode https://github.com/openstack/nova/blob/master/nova/objects/service.py#L151
16:20:32 sdague mriedem: yeh, that should be turned into a real boolean
16:20:45 sdague mriedem: agreed
16:20:55 mriedem alright, writing up a bug
16:24:35 openstackgerrit Maciej Kucia proposed openstack/nova master: [doc] Updated sqlalchemy URL in migrate readme https://review.openstack.org/472549
16:24:39 openstackgerrit Maciej Kucia proposed openstack/nova master: [doc] Updated sqlalchemy URL in migrate readme https://review.openstack.org/472549
16:25:28 openstack Launchpad bug 1697497 in OpenStack Compute (nova) "PUT /os-services/force-down won't work with non-boolean forced_down field" [Medium,Triaged]
16:25:28 mriedem https://bugs.launchpad.net/nova/+bug/1697497
16:26:46 openstackgerrit Gábor Antal proposed openstack/nova master: Transform aggregate.update_metadata notification https://review.openstack.org/460625
16:38:27 openstackgerrit Merged openstack/nova master: [placement] Add api-ref for aggregates https://review.openstack.org/470932
16:50:49 openstackgerrit Dan Smith proposed openstack/nova master: Remove old service version check for mitaka https://review.openstack.org/472395
17:03:08 mriedem dtp: fyi that i've got the PUT /os-services/{service_id} change for this https://review.openstack.org/#/c/464280/ done locally, just working on tests and docs changes for it
17:05:22 openstackgerrit Gábor Antal proposed openstack/nova master: Add json style checking for sample notifications https://review.openstack.org/443677
17:11:11 dansmith cdent: fwiw, I also think those need not be OVOs
17:11:14 dansmith and maybe not even Os
17:11:53 cdent I guess people like the O aspect because of enforcement?
17:13:56 dansmith the field type enforcement?
17:14:27 stvnoyes mriedem: johnthetubaguy: The live migrate rv is ready. I was able to successfully live migrate (with an attached volume) back and forth using the new cinder v3 api. Please take a look when you get a chance. thanks. https://review.openstack.org/#/c/463987/
17:14:32 dansmith perhaps, but we're pulling stuff out of a pretty rigid DB schema and will filter it through jsonschema validation on the sending side at least, so I'm not sure I really see the point
17:14:52 dansmith 's just me tho
17:15:53 cdent dansmith: well your thoughts on the matter are certainly much more well formed than mine, so ... congratulations!
17:26:09 dtp mriedem coolio
17:51:23 openstackgerrit Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660
18:09:10 openstackgerrit Merged openstack/nova master: Remove translation of log messages https://review.openstack.org/466621
18:09:42 openstackgerrit Merged openstack/nova master: Convert additional disassociate tests to mock https://review.openstack.org/471408
18:16:16 openstackgerrit Jay Pipes proposed openstack/nova master: placement: produce set of alternative allocations https://review.openstack.org/473377
18:19:39 oomichi mriedem: re: forced_down: A nice catch, I agree that is a bug
18:20:59 efried Is that a football analogy?
18:21:18 mriedem turned over on downs?
18:21:38 oomichi now 20 parameters are using parameter_types.boolean, it would be nice to dig them from the same pov
18:21:53 openstack Launchpad bug 1697497 in OpenStack Compute (nova) "PUT /os-services/force-down won't work with non-boolean forced_down field" [Medium,Triaged]
18:21:53 mriedem oomichi: https://bugs.launchpad.net/nova/+bug/1697497 if you want to fix it
18:22:31 oomichi mriedem: if you don't mind, i will
18:23:34 oomichi mriedem: sdague: I am wondering the bug-fix requires microversion bump. strictly, maybe that requires it
18:23:59 mriedem oomichi: no, it's a 500 otherwise
18:24:03 sdague when did that get added in?
18:24:04 mriedem oomichi: start with the test and you'll see
18:24:10 mriedem sdague: 2.11 is liberty
18:24:11 sdague yeh, this feels like a backport
18:24:25 oomichi mriedem: cool, ok we can fix without bumping
18:24:26 mriedem o.vo will give you a ValueError
18:24:29 mriedem which would be a 500
18:53:09 openstackgerrit Merged openstack/nova master: XenAPI: Remove bittorrent.py which is already deprecated https://review.openstack.org/468273
18:53:43 openstackgerrit Merged openstack/nova master: nfs fix for xenial images https://review.openstack.org/329466
18:54:14 openstackgerrit Merged openstack/nova master: raise exception if create Virtuozzo container with swap disk https://review.openstack.org/397829
18:54:44 openstackgerrit Merged openstack/nova master: xen: pass Xen console in cmdline https://review.openstack.org/469826
18:55:13 openstackgerrit Merged openstack/nova master: Adopts keystoneauth with glance client. https://review.openstack.org/412634
19:17:50 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: Test service token in Glance https://review.openstack.org/419666
19:22:03 openstackgerrit Merged openstack/nova master: Use plain routes list for os-consoles, os-console-auth-tokens endpoint instead of stevedore https://review.openstack.org/462175
19:38:22 openstackgerrit Ken'ichi Ohmichi proposed openstack/nova master: Add bool_from_string for force-down action https://review.openstack.org/473564
19:39:00 oomichi mriedem: sdague: ^^^
19:39:53 sdague oomichi: nice
19:44:35 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/472814
19:46:44 openstackgerrit Dan Smith proposed openstack/nova master: DNM: Canary https://review.openstack.org/473565
19:48:14 openstackgerrit Merged openstack/nova master: Use plain routes list for block_device_mapping instead of stevedore https://review.openstack.org/462180
19:48:57 openstackgerrit Merged openstack/nova master: Remove unused variable https://review.openstack.org/473210
19:55:54 mriedem thanks oomichi
19:57:59 mriedem oomichi: question in there about using strict=True
20:02:20 mriedem sdague: i think we might want to hold off on https://review.openstack.org/#/c/473564/
20:02:49 oomichi mriedem: I think strict parameter is not so matter here because the input is already validated with jsonschema before
20:02:50 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/472814
20:03:32 mriedem oomichi: hmm, good point - how about a negative test to show that though?
20:03:42 mriedem by passing forced_down='invalid'
20:04:31 oomichi mriedem: that is for coparing a response with expectation. The response should be also boolean instead of string
20:05:01 mriedem oomichi: i don't understand what you mean
20:05:10 oomichi mriedem: ah do you want to add 'invalid' as a negative test
20:05:13 mriedem yes
20:05:15 oomichi mriedem: I can do that
20:05:18 mriedem assert it raises ValidationError
20:06:07 oomichi yeah, making
20:16:47 openstackgerrit Ken'ichi Ohmichi proposed openstack/nova master: Add bool_from_string for force-down action https://review.openstack.org/473564
20:17:23 mriedem oomichi: looks good, just waiting for zuul
20:18:02 oomichi mriedem: no problem, thanks for taking care :)
20:18:06 mriedem you could remove the is_legacy_v2() thing
21:00:17 openstackgerrit Jay Pipes proposed openstack/nova master: placement: produce set of alternative allocations https://review.openstack.org/473377
21:01:06 jaypipes dansmith, cdent, edleafe, mriedem: now with moar functional testing. ^
21:01:26 cdent but does it slice, dice and julienne?
21:05:58 dansmith jaypipes: are you working on the api exposure bit next?
21:06:12 jaypipes dansmith: yes
21:07:12 dansmith melwitt: I assume you're working on those comments on your upper placement usages thing and will fix the rebase need when you push/
21:08:15 melwitt dansmith: yes. currently working on test coverage for recheck_quotas cases as I rebase the quotas series

Earlier   Later