Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-06-07
19:20:36 dansmith you were going to fix it too, but just not worry about changing the behavior if you get the wrong compute node I think, because it's not destructive
19:20:44 dansmith fix it == make it use uuids
19:20:56 mriedem yeah that's what i'm working on now
19:21:14 dansmith doesn't hurt to make it behave the same if you want, it's just not critical I think
19:21:33 mriedem yeah it's definitely not as bad as delete
19:25:24 openstackgerrit Rafael Folco proposed openstack/nova master: Delete all inventory has its own method DELETE https://review.openstack.org/460147
19:36:23 mriedem uuuuuuuuuuuuuuggggggggggggggghhhhhhhhhhhhhhhh
19:36:27 mriedem so,
19:36:41 mriedem returning compute nodes from the api with uuids means we're also going to need to change the paging links
19:36:54 mriedem the paging stuff plumbed all the way down to the database is using id
19:37:51 dansmith gross
19:37:54 mriedem dansmith: so if the marker in https://github.com/openstack/nova/blob/master/nova/objects/compute_node.py#L402 can be an id or uuid, i assume that means i'll need a new remotable method?
19:37:57 dansmith same with services?
19:38:02 mriedem we don't have paging on services
19:38:04 mriedem thank god
19:38:36 dansmith mriedem: well, yeah, you should have a new remotable
19:38:40 mriedem also,
19:38:52 mriedem this likely means we aren't handling paging correctly right now with multiple cells
19:38:56 dansmith because otherwise we have no way to know that the other end doesn't support it
19:38:57 dansmith also,
19:39:06 dansmith you could do a get by uuid, then use the id and make the paged call
19:39:10 dansmith which is dumb, but..
19:39:14 dansmith or
19:39:21 dansmith you could cheat and do that only if you pass a uuid and it barfs
19:39:49 dansmith well, if the marker is integer id, you *can't* do paging right
19:41:53 mriedem so get the compute by uuid, which we can then look up the host mapping and know which cell it's in, and then do a cell-targeted context to page by the int id for that compute node
19:41:55 mriedem right?
19:42:16 mriedem i was just thinking about how we page across cells for instances
19:42:17 mriedem by uuid
19:42:39 dansmith um
19:42:58 dansmith you can't get compute node by id or uuid without a host mapping already in your hand
19:43:09 mriedem if we have 10 compute nodes in 2 cells, and our marker is the 10th CN in cell1 and we have a limit of 11, then wouldn't you expect to continue paging to the next cell?
19:43:34 dansmith yes/
19:44:23 mriedem "you can't get compute node by id or uuid without a host mapping already in your hand"
19:44:32 mriedem we don't get a host mapping when doing a show on os-hypervisors
19:44:41 mriedem that's the thing where we have an int id today and iterate the cells looking for one
19:44:49 mriedem which is https://github.com/openstack/nova/blob/master/nova/compute/api.py#L4568
19:45:35 mriedem seems we should have stored the compute_nodes.uuid in the host_mappings table,
19:45:46 mriedem then if we're given a uuid, we could have looked up the host mapping by uuid to find the cell rather than iterate
19:46:15 dansmith mriedem: you can't, because a hostmapping is for nova-compute not for the ComputeNode right?
19:46:20 dansmith actually,
19:46:36 dansmith maybe that's wrong. I guess ironic needs discovery when adding new ironic nodes
19:46:54 mriedem the host mapping is the the compute node
19:47:00 mriedem mapped by compute_node.host
19:47:04 mriedem rather than uuid
19:47:07 mriedem for whatever reason...
19:47:13 dansmith my "you can't" statement was in response to your "get by compute uuid, then look up host mapping" comment
19:47:22 dansmith if you've found it, you need not lookup the hostmapping at that point
19:47:28 mriedem we can look up the host mapping via compute_node.host
19:47:41 mriedem sure, i was thinking about the paging across cells thing
19:47:44 dansmith you can, but you've already found it at that point
19:47:55 dansmith you don't need the hostmapping if you already know what cell it's in,
19:47:59 dansmith and if you found it, you know
19:48:06 dansmith right?
19:48:54 mriedem idk
19:48:57 mriedem been up since 4
19:48:58 mriedem this sucks
19:49:19 mriedem i'm just going to TODO bomb this change for now
20:05:13 zigo rm_work: You should ask jamespage about lxd.
20:05:46 rm_work will do, thanks
20:08:17 melwitt merge conflict extravaganza!
20:10:40 openstackgerrit Eric Fried proposed openstack/nova master: Adopts keystoneauth with glance client. https://review.openstack.org/412634
20:11:08 openstackgerrit Eric Fried proposed openstack/nova master: Add service_token for nova-glance interaction https://review.openstack.org/419662
20:11:40 openstackgerrit Eric Fried proposed openstack/nova master: Add PowerVM to nova support matrix https://review.openstack.org/470999
20:11:53 openstackgerrit Eric Fried proposed openstack/nova master: Trim the fat from InstanceInfo https://review.openstack.org/471146
20:13:10 openstackgerrit Eric Fried proposed openstack/nova master: Query deleted instance records during _destroy_evacuated_instances https://review.openstack.org/467774
20:13:22 sdague efried: +2 on the glanceclient conversion
20:13:35 efried sdague Sweet, thanks.
20:13:53 sdague and the one after it with the service token
20:13:55 sdague all very nice
20:13:57 efried jenkins just posted supposed merge conflicts on a whole boatload of changes.
20:14:30 sdague yeh, I went through a lot of +2ed changes yesterday and sent a bunch of stuff to merge
20:14:40 sdague so that's not super surprising
20:14:44 efried sdague I can't really take credit - Sarafraj did it all before he got the OSIC punt
20:15:00 sdague efried: well thanks for carrying it across the finish line
20:15:03 efried sdague Yeah, but I don't see any real conflicts there. Everything I've been able to rebase with the button.
20:15:19 sdague yeh, gerrit is super conservative
20:15:25 efried Is there, like, a certain number of intervening merges that automatically posts merge conflicts?
20:16:50 efried Anyway, sdague, thanks for all the reviews! Seems to be really helping to clear the queue.
20:16:54 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Handle uuids in os-hypervisors API https://review.openstack.org/471899
20:17:14 openstackgerrit Gage Hugo proposed openstack/nova master: Admin API Policy contingent on is_admin_project https://review.openstack.org/384148
20:18:58 comstud mriedem: when you think of shit, you think of comstud?
20:20:42 openstackgerrit Eric Fried proposed openstack/nova master: remove ugly local import https://review.openstack.org/450787
20:22:14 efried melwitt They all seem trivially gerrit-button-resolvable.
20:25:32 melwitt efried: thanks, was just complaining without looking first :) I was in the middle of updating the bottom change anyway
20:28:51 openstackgerrit melanie witt proposed openstack/nova master: Add FixedIPList.get_count_by_project() https://review.openstack.org/446246
20:28:52 openstackgerrit melanie witt proposed openstack/nova master: Add get_count_by_vm_state() to InstanceList object https://review.openstack.org/446244
20:28:52 openstackgerrit melanie witt proposed openstack/nova master: Add FloatingIPList.get_count_by_project() https://review.openstack.org/446247
20:28:53 openstackgerrit melanie witt proposed openstack/nova master: Remove 'reserved' count from used limits https://review.openstack.org/446242
20:28:53 openstackgerrit melanie witt proposed openstack/nova master: Add SecurityGroupList.get_counts() https://review.openstack.org/446245
20:28:54 openstackgerrit melanie witt proposed openstack/nova master: Count server groups to check quota https://review.openstack.org/446240
20:28:54 openstackgerrit melanie witt proposed openstack/nova master: Remove useless quota_usage_refresh from nova-manage https://review.openstack.org/446243
20:28:55 openstackgerrit melanie witt proposed openstack/nova master: Count instances to check quota https://review.openstack.org/416521
20:28:55 openstackgerrit melanie witt proposed openstack/nova master: Count networks to check quota https://review.openstack.org/446241
20:28:56 openstackgerrit melanie witt proposed openstack/nova master: Count server group members to check quota https://review.openstack.org/457859
20:28:56 openstackgerrit melanie witt proposed openstack/nova master: Add InstanceGroup._remove_members_in_db https://review.openstack.org/457858
20:28:57 openstackgerrit melanie witt proposed openstack/nova master: Count security groups to check quota https://review.openstack.org/457860
20:28:59 openstackgerrit melanie witt proposed openstack/nova master: Make Quotas object favor the API database https://review.openstack.org/410945
20:29:00 openstackgerrit melanie witt proposed openstack/nova master: Count fixed ips to check quota https://review.openstack.org/457861
20:29:01 openstackgerrit melanie witt proposed openstack/nova master: Add online migration to move quotas to API database https://review.openstack.org/410946

Earlier   Later