Earlier  
Posted Nick Remark
#openstack-nova - 2017-06-07
10:08:30 sdague and didn't read timestamps
10:09:15 mriedem surprise
10:09:29 mriedem i've come to haunt both your days and nights
10:09:53 bauzas mriedem: I saw you were fighting with a func test failure about traits
10:10:03 mriedem bauzas: fixed
10:10:03 bauzas mriedem: go to bed but just lemme know if you need help on it
10:10:06 bauzas \o/
10:10:17 mriedem https://review.openstack.org/#/c/471508/
10:10:40 bauzas 12:55AM my time
10:10:42 bauzas too late
10:11:13 bauzas mriedem: seriously, you're beginning your day ?
10:11:18 bauzas go to bed
10:11:30 mriedem carpe diem
10:11:59 bauzas keep your breath for Pike-2 tomorrow
10:12:31 bauzas or I'll harass you with RFC1738 remarks :p
10:12:32 mriedem psh, it's just a tag
10:14:43 openstackgerrit falseuser proposed openstack/nova master: A way to keep the UEFI nvram contents on libvirt+qemu/kvm https://review.openstack.org/471706
10:15:38 bauzas best gerrit user ever ^
10:23:00 openstackgerrit Huan Xie proposed openstack/nova master: XenAPI: Create linux bridge in dest host during live migration https://review.openstack.org/451657
10:24:58 openstackgerrit falseuser proposed openstack/nova master: A way to keep the UEFI nvram contents on libvirt+qemu/kvm https://review.openstack.org/471706
10:25:57 openstackgerrit Matt Riedemann proposed openstack/nova master: libvirt: Check if domain is persistent before detaching devices https://review.openstack.org/441204
10:34:27 kashyap mdbooth: or sfinucan: Do you know if we can hot-unplug the virtio-balloon device from a guest?
10:34:50 sfinucan no idea, I'm afraid
10:35:08 kashyap No worries :-) Asking for a QEMU migration developer who was debugging an issue related to it
10:36:48 mdbooth kashyap: You mean from nova's pov?
10:36:56 kashyap mdbooth: Yes
10:37:08 kashyap mdbooth: Reason I ask is:
10:38:15 kashyap Dave Gilbert from QEMU is debugging a migration bug in old 7.2, we can work around it by `rmmod`ing 'virtio-balloon' in the guest prior to migratation, but the bug reporter doesn't have logins to their guests. So the question is whether we can do a hot-unplug of the virtio-balloon device.
10:38:22 mriedem bauzas: cinder peeps seem generally happy with https://review.openstack.org/#/c/469579/
10:38:47 bauzas cool, will review shortly after lunch
10:40:41 mriedem merci
10:40:47 openstackgerrit Merged openstack/nova master: Use plain routes list for server ips endpoint https://review.openstack.org/468334
10:41:37 mriedem sfinucan: since you're the conf master, any opinions on if the new config option in this change https://review.openstack.org/#/c/446240/ should be in the quota group or api group? since it's about quotas, but used in the api
10:42:04 mriedem ultimately probably doesn't matter, and if i were looking to tweak things with quota, i'd probably be looking in the quota group, not the api group, so i think this is correc
10:42:07 mriedem *correct
10:43:13 sfinucan mriedem: it's much of a muchness, but [quota] seems good to me
10:45:31 openstackgerrit Sylvain Bauza proposed openstack/nova master: Fix cell0 naming when QS params on the connection https://review.openstack.org/471487
10:45:55 mdbooth kashyap: Firstly, does libvirt allow us to do that?
10:45:55 bauzas mriedem: see the above, you'll understand why it wasn't working previosuly
10:46:09 mdbooth kashyap: Because if so, it's a trivial matter of programming.
10:46:26 mdbooth If not, then we definitely can't do that.
10:46:31 bauzas mriedem: tl,dr: testing with a connection string including a % wasn't compatible with what SQLA was expecting anyway
10:46:52 bauzas so we just need to unquote the output
10:46:59 kashyap mdbooth: From Nova, it isn't possible. Onto your question about libvirt support -- checking...
10:47:03 bauzas that's where I was confused
10:47:10 mdbooth kashyap: However, this would be a nasty hack. We'd need to know how to identify that the hack was required. We'd also need to identify exactly at which point the hack was required.
10:47:57 openstackgerrit Merged openstack/nova master: Use plain routes list for instance actions endpoint https://review.openstack.org/468338
10:48:12 mdbooth kashyap: Nova certainly doesn't explicitly track or expose the balloon device in any way. However, if we needed to manipulate it during the migration workflow the libvirt driver could absolutely do that.
10:48:19 kashyap mdbooth: What would be a nasty nack?
10:48:20 mdbooth But it would be nasty.
10:48:29 mriedem bauzas: ok, that's simpler than i thought it would be
10:48:32 kashyap mdbooth: You mean, _if_ there weren't a clean libvirt API?
10:48:44 openstackgerrit Merged openstack/nova master: Use plain routes list for os-fping endpoint https://review.openstack.org/468349
10:48:48 mdbooth kashyap: If there's no clean libvirt api then we can't do it.
10:49:09 mdbooth kashyap: If there is a clean libvirt api we can do it, but it would be a hack.
10:49:30 openstackgerrit Pooja Jadhav proposed openstack/nova master: Nova flavor-list swap should be 0 when no value is specified https://review.openstack.org/471715
10:49:39 openstackgerrit Matt Riedemann proposed openstack/nova master: Remove unused CONF import from placement/auth.py https://review.openstack.org/471716
10:49:43 openstack bugzilla.redhat.com bug 1450524 in qemu-kvm-rhev "qemu-kvm: VQ 0 size 0x100 Guest index 0x2010 inconsistent with Host index 0x2171: delta 0xfe9f" [High,Assigned] - Assigned to jasowang
10:49:43 kashyap mdbooth: Yep, noted. Apparently, this bug (https://bugzilla.redhat.com/show_bug.cgi?id=1450524) Dave is trying to address is already fixed in a certain newer QEMU.
10:50:15 bauzas mriedem: FWIW, once I feel we get consensus on the patch, will backport it to stable/newton and ocata
10:50:30 mdbooth kashyap: TBH, that reduces my motivation to introduce dirty hacks. If it's already fixed, the user can upgrade. If they don't want to upgrade... well that's a price they have to pay.
10:50:49 kashyap mdbooth: Yes, I agree. That's why I thought it is worthwhile to mention that
10:51:08 kashyap No need to add "hacks" when they aren't warranted
10:51:46 mdbooth RHEL 7.2 to RHEL 7.3 is not an onerous update (stupid 3rd party kernel modules not withstanding)
10:52:08 kashyap mdbooth: I _think_ the bug is during migration -- so even if the user upgrades
10:52:34 kashyap IIUC, for the fix to take effect, they need a cold boot (stop / start) for the Nova guest to pick up the new machine type
10:53:01 mdbooth Why is a new machine type required?
10:54:49 sfinucan mriedem: Could you take another look at the PCI weigher today? See if I've cleared things up enough?
10:58:13 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Make 'get_domain' private https://review.openstack.org/417378
11:00:02 openstackgerrit Matt Riedemann proposed openstack/nova master: Fix cell0 naming when QS params on the connection https://review.openstack.org/471487
11:00:20 mriedem bauzas: fixed that typo, +2
11:00:24 mriedem sfinucan: oh maybe
11:00:31 mriedem it hurts my brain though, looking at weighers
11:00:38 mriedem *especially* pci weighers
11:00:45 openstackgerrit falseuser proposed openstack/nova master: Delete the instance files after revert a resize task https://review.openstack.org/469814
11:01:18 mriedem sdague: bauzas: sfinucan: this is a simple file move patch https://review.openstack.org/#/c/471425/ which would unblock a bp from getting completed
11:01:41 sfinucan mriedem: I'd recommend a strong drink and two aspirin
11:01:56 mriedem sfinucan: ok let me look after the joy of the quotas changes
11:03:03 sfinucan ta
11:08:36 sfinucan mriedem: Is it just me, or is that moved file totally unused?
11:08:46 sfinucan wait - nvm
11:09:10 sfinucan (it's an actual test - not a base class 🙈)
11:09:44 kashyap mdbooth: Sorry, got distracted :-(
11:10:18 kashyap To answer your question...
11:11:21 kashyap The new machine type comes as part of the upgrade of QEMU
11:11:56 kashyap And, for the fix to take effect, the guest should pick it up.
11:12:37 kashyap (And the fix seem to take effect only via an explicit start / stop; not via migrating -- that's the issue).
11:18:17 openstackgerrit Matt Riedemann proposed openstack/nova master: Add functional test for two-cell scheduler behaviors https://review.openstack.org/452006
11:22:21 openstackgerrit Sean Dague proposed openstack/python-novaclient master: Prevent 2.32 release note from showing up in 9.0.0 release notes https://review.openstack.org/471383
11:31:44 openstackgerrit Merged openstack/python-novaclient master: Skip rebuild functional test due to persistent vif plugging timeout https://review.openstack.org/471533
11:35:02 openstackgerrit Stephen Finucane proposed openstack/nova-specs master: Clarify 'cells-count-resources-to-check-quota-in-api' https://review.openstack.org/471729
11:36:40 openstackgerrit Merged openstack/nova master: Completely remove mox from unit/network/test_linux_net.py https://review.openstack.org/445504
11:40:31 mriedem sfinucan: done https://review.openstack.org/#/c/379524/
11:42:41 sfinucan mriedem: Am I correct in saying that scheduler filters run before the weighers?
11:43:32 mriedem yes
11:43:42 mriedem FilterScheduler._schedule method
11:51:32 openstackgerrit Merged openstack/nova master: Use plain routes list for hosts endpoint instead of stevedore https://review.openstack.org/459231
11:53:12 mriedem sean-k-mooney: would you agree with this? https://review.openstack.org/#/c/441183/15/nova/network/model.py@87
11:53:16 mriedem s/would/do/
11:59:58 openstackgerrit OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/469581

Earlier   Later