Posted	Nick	Remark
#openstack-nova - 2017-06-06
14:19:56	mriedem	if this is going to go back that far
14:20:02	sfinucan	gotcha. round 3
14:21:03	mriedem	so reno still includes this note on master unreleased because the revert doesn't delete the file, so it still looks changed
14:22:29	mdbooth	sfinucan: It is pleasantly succinct and very readable though, isn't it?
14:23:14	bauzas	mriedem: if so, you just need to revert the file in the master tree
14:23:23	bauzas	and do a stable-only note
14:23:35	mriedem	bauzas: revert the file as in delete the file?
14:23:37	bauzas	FWIW, I'm just discovering new options with reno
14:23:40	bauzas	yup
14:23:50	mriedem	bauzas: yes deleting is an option
14:24:03	bauzas	in theory, notes are attached to a commit
14:24:12	bauzas	so, when a commit is changing a thing, you have the note
14:24:18	bauzas	the beauty of that is with backports
14:24:27	bauzas	because the note will follow the code
14:24:50	bauzas	but sometimes, you're doing cleanups in notes, and you're discovering you forgot something specific on a branch
14:25:08	bauzas	then a single commit only including a reno file is worth it for that stable branch
14:25:40	bauzas	merging on master necessarly means it appears on the unreleased page
14:25:49	bauzas	since we scan all commits since the beginning
14:26:06	bauzas	(as it's defined per the release management team rules)
14:33:28	openstackgerrit	Felipe Monteiro proposed openstack/nova-specs master: Patrole (RBAC) Nova Gating https://review.openstack.org/471145
14:36:38	openstackgerrit	Matt Riedemann proposed openstack/python-novaclient master: Prevent 2.32 release note from showing up in 9.0.0 release notes https://review.openstack.org/471383
14:38:02	mriedem	bauzas: sfinucan: sdague: ^ is where i'm at
14:43:48	openstackgerrit	Balazs Gibizer proposed openstack/nova master: Improve assertJsonEqual error reporting https://review.openstack.org/428199
14:45:57	openstackgerrit	Stephen Finucane proposed openstack/nova master: Convert floating IP tests to ddt https://review.openstack.org/471360
14:45:58	openstackgerrit	Stephen Finucane proposed openstack/nova master: Catch neutronclient.NotFound on floating deletion https://review.openstack.org/410815
14:46:54	sfinucan	mriedem, sdague: I _think_ that should be all good now
14:47:24	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622
14:47:26	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387
14:47:33	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082
14:47:41	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941
14:47:42	openstackgerrit	Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021
14:49:53	mriedem	sfinucan: reviewed
14:51:13	openstackgerrit	Stephen Finucane proposed openstack/nova master: use plain routes list for os-virtual-interfaces https://review.openstack.org/462173
14:51:13	openstackgerrit	Stephen Finucane proposed openstack/nova master: Use plain routes list for os-services endpoint instead of stevedore https://review.openstack.org/460818
14:51:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: use plain routes list for hypervisor endpoint instead of stevedore https://review.openstack.org/459235
14:51:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: Use plain routes list for hosts endpoint instead of stevedore https://review.openstack.org/459231
14:51:16	openstackgerrit	Merged openstack/nova master: [placement] Add api-ref for resource classes https://review.openstack.org/467596
14:52:11	openstackgerrit	Merged openstack/nova master: Remove mox from nova.tests.unit.objects.test_instance.py https://review.openstack.org/441784
14:52:59	openstackgerrit	Merged openstack/nova master: Check instance existing before check in mapping https://review.openstack.org/433470
14:53:37	openstackgerrit	Merged openstack/nova master: Remove mox from unit/cells/test_cells_messaging.py https://review.openstack.org/448021
14:54:15	openstackgerrit	Merged openstack/nova master: Stop using mox int unit/virt/xenapi/image/test_utils.py https://review.openstack.org/342626
14:54:54	openstackgerrit	Merged openstack/nova master: Remove mox from cells/test_cells_rpc_driver.py https://review.openstack.org/447412
14:55:33	openstackgerrit	Merged openstack/nova master: Ensure image conversion flushes output data to disk https://review.openstack.org/443230
14:56:14	openstackgerrit	Merged openstack/nova master: Remove mox from nova/tests/unit/consoleauth/test_consoleauth.py https://review.openstack.org/448386
15:15:14	artom	mriedem, what's going on with https://review.openstack.org/#/c/471353?
15:16:00	mriedem	i backported it
15:16:00	artom	You appear to have backported some extra exception handling, and an unrelated fix for console log permissions?
15:16:22	mriedem	huh?
15:16:50	mriedem	oh i didn't see you had backported already
15:16:53	artom	Ah, no, sorry
15:16:58	mriedem	you were diffing right?
15:17:03	artom	Yeah
15:17:49	mriedem	i also rebased on top of lee's backport
15:17:54	mriedem	to resolve the exception conflict
15:18:01	mriedem	https://review.openstack.org/#/c/460296/
15:18:16	artom	Doh, of course
15:18:24	artom	I didn't notice it was the top patch in a two-patch series
15:19:19	mriedem	will need to do similar if backporting to newton, which i assume we are
15:19:25	mriedem	since it was reported against rhosp mitaka
15:19:32	artom	Yeah, I posted the newton backport
15:19:42	mriedem	on top of lee's newton backport?
15:19:47	mriedem	because if not, you should redo it
15:19:48	artom	No
15:19:57	artom	https://review.openstack.org/#/c/471356/
15:20:38	mriedem	let me -1 that quick for you
15:20:39	mriedem	:)
15:21:03	artom	You're welcome :)
15:30:44	openstackgerrit	Eric Berglund proposed openstack/nova master: Add PowerVM to nova support matrix https://review.openstack.org/470999
15:30:48	pksingh	alex_xu: Hello
15:32:32	artom	mriedem, done.
15:34:21	openstackgerrit	Eric Fried proposed openstack/nova master: Add service_token for nova-glance interaction https://review.openstack.org/419662
15:37:50	pksingh	Hello Guys, i found nova has depricated this API, https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/floating_ips.py#L216
15:38:23	pksingh	i.e. associate-floating-ip, then how floating IP is updated in database, by some periodic task?
15:39:12	artom	pksingh, I think you're supposed to use Neutron: https://developer.openstack.org/api-ref/networking/v2/index.html?expanded=update-floating-ip-detail#update-floating-ip
15:39:23	mriedem	pksingh: that api is not deprecated
15:39:50	mriedem	i'm not sure why it says https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/floating_ips.py#L205
15:40:10	mriedem	hmm, api-ref says the same
15:40:29	pksingh	mriedem: i checked here https://developer.openstack.org/api-ref/compute/?expanded=add-associate-floating-ip-addfloatingip-action-deprecated-detail#add-associate-floating-ip-addfloatingip-action-deprecated
15:40:43	mriedem	yeah my mistake https://docs.openstack.org/developer/nova/api_microversion_history.html#id39
15:41:25	pksingh	mriedem: so, now how you get Flating IPs in nova database?
15:41:26	mriedem	pksingh: the spec has the details https://specs.openstack.org/openstack/nova-specs/specs/pike/approved/deprecate-multinic-proxy-api.html
15:41:31	mriedem	you use neutron apis
15:41:56	mriedem	neutron floatingip-create EXT_NET_ID VM_PORT_ID
15:42:09	openstackgerrit	Eric Berglund proposed openstack/nova master: Add PowerVM to nova support matrix https://review.openstack.org/470999
15:43:05	pksingh	mriedem: thanks i got that point, to assign floating IP to instance , use neutron API
15:43:18	pksingh	mriedem: then how do you update this table https://developer.openstack.org/api-ref/compute/?expanded=add-associate-floating-ip-addfloatingip-action-deprecated-detail#add-associate-floating-ip-addfloatingip-action-deprecated
15:43:36	pksingh	mriedem: sorry wron link, https://github.com/openstack/nova/blob/065cd6a8d69c1ec862e5b402a3150131f35b2420/nova/db/sqlalchemy/models.py#L910
15:43:49	mriedem	pksingh: you don't
15:44:01	mriedem	the nova db tables for network resources are only ever used for nova-network
15:44:14	mriedem	if you use neutron, regardless of microversion, those tables weren't used
15:44:36	mriedem	if you had some out of tree code that was relying on those tables getting updated, that out of tree code was incorrect
15:45:02	pksingh	mriedem: ok, great, so to get floating IPs, any how we need to use neutron APIs
15:45:10	mriedem	yes
15:45:25	mriedem	or use a microversion<2.44
15:45:53	mriedem	but it's in your best long-term interest to use the networking API directly (neutron)
15:46:55	mriedem	gibi: i'll apologize ahead of time for not making any progress on notification stuff while you were out for 2 weeks
15:49:27	pksingh	mriedem: thanks a lot for your help, one more question
15:49:49	pksingh	mriedem: so nova will not show floating IP in server detail get request
15:50:16	mriedem	pksingh: floating ips will still show up in the server 'addresses' details
15:50:39	pksingh	mriedem: ok, from where do you get it?

Earlier   Later