| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-02 | |||
| 16:18:44 | leakypipes | cdent: so we don't allow changing resource class names in 1.7 and beyond? | |
| 16:18:53 | cdent | because it was not only a bad flow, but also an issue with the external issue | |
| 16:19:21 | cdent | leakypipes: if you are using a high microversion, correct, you cannot not rename a resource class | |
| 16:19:42 | cdent | you can delete and create another | |
| 16:19:44 | cdent | or rather | |
| 16:19:45 | cdent | create another | |
| 16:19:46 | cdent | everything external is using the name | |
| 16:19:47 | cdent | we can't allow changing it | |
| 16:19:58 | dansmith | ++ | |
| 16:20:35 | figleaf | cdent: ah, good | |
| 16:20:46 | cdent | I kind of feel like we should de-document the old way | |
| 16:20:52 | cdent | but that would lead to problems | |
| 16:21:09 | cdent | so perhaps a warning on the 1.2-1.6 microversion? | |
| 16:21:24 | dansmith | cdent: I think we should drop it from the docs, TBH | |
| 16:21:25 | cdent | I mean the doc for put /resource_classes/{name} | |
| 16:21:39 | dansmith | nobody is using this but us yet, so no reason to document something that is already obsolete | |
| 16:21:48 | claudiub | efried: not as it should. it doesn't consume the self / cls argument. if you are patching a function or a static method, it works fine though. | |
| 16:21:59 | dansmith | also, is PUT the right verb for "create or verify existence" ? | |
| 16:22:11 | dansmith | I would expect POST and return 409 if exists, no? | |
| 16:22:37 | cdent | PUT is the standard for idempotency when you know the url of the resoruce | |
| 16:22:50 | cdent | the idea here is that you can PUT /resource_classes/{name} all day long | |
| 16:23:00 | dansmith | hrm, okay | |
| 16:23:07 | cdent | and it will always return some form of success | |
| 16:23:10 | claudiub | mriedem: you didn't answer my one question :D : the cinder 3rd party ci requirements state that "CI's do not need to kick off tests until Jenkin's has given a +1", is there a similar policy for nova as well? ( https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers#Third_Party_CI_Requirements ) | |
| 16:23:10 | dansmith | seems wrong, but I guess I don't have time to convince the rest of the world today | |
| 16:23:30 | cdent | dansmith: the decision was driven by code in the resource tracker which was doing to "get_or_create_resource_class" | |
| 16:23:40 | cdent | I wanted to change it to "do one call to do both" | |
| 16:23:42 | cdent | which is PUT | |
| 16:24:25 | artom | I think with PUT you're supposed to send the entire resource, and PATCH is for when you just send the changes? | |
| 16:24:33 | leakypipes | dansmith, cdent: added a note on 467596 to add a big fat warning in the UPDATE t1.2 through 1.6 section. | |
| 16:24:35 | dansmith | that way we can't log whether we created it, which means we can't highlight with a warning "I just created CUSTOM_GUP, hope you didn't typo that" | |
| 16:24:43 | cdent | artom: yes, but this is a different issue. a resource class PUT has no body | |
| 16:25:22 | cdent | dansmith: different resposne code on create or existence: | |
| 16:25:24 | artom | cdent, then we should only allow HEAD on it :D | |
| 16:25:41 | cdent | artom: :P | |
| 16:26:16 | artom | Bikeshedding about HTTP verbs? You don't say ;) | |
| 16:26:18 | dansmith | cdent: I see. less obvious, IMHO, but doesn't matter | |
| 16:26:27 | dansmith | I/we aren't bikeshedding | |
| 16:26:31 | dansmith | just chatting | |
| 16:27:07 | cdent | dansmith: of course that's not what the code is doing now, it doesn't log on success, and I'm pretty sure it didn't before? | |
| 16:27:32 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Use VIR_DOMAIN_BLOCK_REBASE_COPY_DEV when rebasing https://review.openstack.org/465205 | |
| 16:28:05 | dansmith | cdent: I haven't even looked, and I assume we won't know we need to log such a thing until the flood of bugs complaining about it | |
| 16:28:20 | dansmith | cdent: but if we have a way to tell so we can add that in the future then that's fine | |
| 16:28:33 | dansmith | that == that log line | |
| 16:28:46 | cdent | (just check, it isn't, at least not on the RT side, but yeah, there's a way to distinguish) | |
| 16:28:53 | cdent | s/check/checked/ | |
| 16:28:54 | artom | sfinucan ^^ addressed your feedback, except in one case where I don't agree :P | |
| 16:31:12 | sfinucan | artom: That's all g with me | |
| 16:31:37 | harlowja | mriedem whats up | |
| 16:31:48 | harlowja | `we should probably deprecate/remove tooz service group api driver` | |
| 16:32:13 | harlowja | i'd say that'd be ok, though its really up to u guys if u want to do that, and just go direct to etcd | |
| 16:32:41 | harlowja | both imho are the same level of effort of undoing/redoing the stuff in nova that is specific to a database (for service groups) | |
| 16:33:23 | harlowja | that was the main problem that was hit i think when trying to refactor that stuff, is there are a bunch of places in nova that are tied to a database for that stuff (because calling serivice group stuff a driver interface is somewhat of a lie) | |
| 16:33:39 | leakypipes | harlowja: yup. | |
| 16:34:34 | harlowja | refactoring to etcd (and a database for daatabase driver users), will likely be the same effort as refactoring to tooz in the end | |
| 16:34:41 | harlowja | so ya, meh, do as u want :-P | |
| 16:35:16 | harlowja | penick yahoo never continued down the path of that after vilobh left right? | |
| 16:35:48 | harlowja | (ie continuing the service group refactor to tooz and/or whatever else) | |
| 16:36:00 | artom | sfinucan, thanks g | |
| 16:36:23 | artom | (We so gangsta) | |
| 16:39:27 | harlowja | leakypipes mriedem what are your plans for that thing? | |
| 16:39:32 | harlowja | just go directly to etcd3? | |
| 16:39:46 | harlowja | or try again to have 2 drivers (one for database, one for etcd3 or ???) | |
| 16:45:25 | openstackgerrit | Merged openstack/python-novaclient master: Help message for aggregate-update is ambiguous https://review.openstack.org/469753 | |
| 16:48:00 | openstackgerrit | Merged openstack/nova master: libvirt: fix call args to destroy() during live migration rollback https://review.openstack.org/469958 | |
| 16:52:19 | leakypipes | harlowja: my long term wishes are to get rid of the services from the REST API entirely. | |
| 16:52:28 | leakypipes | harlowja: and detach the servicegroup API entirely from the database. | |
| 16:52:46 | leakypipes | harlowja: and use something like os-lively for servicegroup liveness and maintenance API. | |
| 16:52:59 | harlowja | wfm | |
| 16:53:08 | harlowja | remove all the thigns, lol | |
| 16:54:49 | harlowja | leakypipes if u do it right, be nice to make something that other projects can use | |
| 16:55:10 | harlowja | (as u know i think) | |
| 17:08:18 | openstackgerrit | Jay Pipes proposed openstack/nova master: Delete all inventory has its own method DELETE https://review.openstack.org/460147 | |
| 17:08:24 | leakypipes | mriedem: addressed your comments on ^^ | |
| 17:15:26 | leakypipes | rfolco: hope you don't mind, I just pushed some quick fixes and a new unit test on your patch 460147 | |
| 17:19:49 | rfolco | leakypipes, Thanks a lot. Appreciate your help. | |
| 17:19:57 | leakypipes | np | |
| 17:41:12 | openstack | Launchpad bug 1679750 in OpenStack Compute (nova) "Allocations are not cleaned up in placement for instance 'local delete' case" [Medium,Confirmed] - Assigned to Sylvain Bauza (sylvain-bauza) | |
| 17:41:12 | melwitt | mriedem: before I go looking around, do you know if this bug is still a bug, by chance? https://bugs.launchpad.net/nova/+bug/1679750 | |
| 17:45:34 | cfriesen_ | mriedem: thanks for the update...was AFK this morning. | |
| 17:47:22 | melwitt | mriedem: nevermind, looks like it is. I'll start writing the functional test you described in the bug | |
| 17:49:56 | melwitt | cdent: what did you mean by "Did you want this file in the parent?" I was trying to guess what to do with the new microversion based on resource_classes*.yaml gabbits | |
| 17:50:49 | melwitt | cdent: oh wait, nevermind. yes, I put it in the wrong commit by accident | |
| 17:50:53 | cdent | melwitt: as far as I could tell that file was only testing /allocations not /usages so I thought perhaps it was meant for the earlier commit | |
| 17:50:58 | cdent | jinxish | |
| 17:51:05 | melwitt | yeah, I messed that up. thanks | |
| 17:51:39 | cdent | leakypipes: since we've been trading on the traits sync patch, just a heads up: it's failling some functional tests, I'll fix it | |
| 17:55:15 | leakypipes | cdent: cheers | |
| 18:02:05 | mriedem | melwitt: i don't think so, unless it's part of bauzas' series on claims in the scheduler | |
| 18:02:38 | melwitt | mriedem: ah, good point, I'll skim through those to see | |
| 18:03:39 | openstackgerrit | Chris Dent proposed openstack/nova master: Sync os-traits to Traits database https://review.openstack.org/469578 | |
| 18:04:31 | cdent | that's it for me | |
| 18:04:38 | cdent | have a good weekend everyone | |
| 18:05:45 | mriedem | leakypipes: dansmith: renaming custom resource classes? why? isn't that like renaming a flavor (which we don't allow)? | |
| 18:05:58 | mriedem | just because we can do a thing doesn't mean we should | |
| 18:05:59 | dansmith | mriedem: or renaming an enum yeah | |
| 18:07:46 | mriedem | or is that pre-1.7 behavior? | |
| 18:08:07 | mriedem | i guess so https://review.openstack.org/#/c/467596/4/placement-api-ref/source/resource_class.inc@75 | |
| 18:08:10 | dansmith | yeah | |
| 18:09:59 | mriedem | ok i thought this was something someone wanted to do | |