Posted	Nick	Remark
#openstack-nova - 2017-06-02
15:15:48	efried	claudiub Doesn't mock.patch autospec work in the decorator form?
15:16:57	sfinucan	I think pylint would catch those issues (too many args/invalid kwargs for function)
15:17:11	sfinucan	but it'd introduce so many false positives as to make it not worth effort
15:17:16	sfinucan	mriedem: Ever seen mypy?
15:17:55	mriedem	no
15:18:23	sfinucan	worth checking it out. I'm thinking of integrating it into some of the virt/libvirt code
15:18:26	cdent	do you like it sfinucan ?
15:18:38	sfinucan	The Sphinx source uses it pretty much everywhere
15:18:42	cdent	it seems simultaneously really useful but also noisy
15:18:55	sfinucan	cdent: I like it in it's Python 3 form
15:19:04	sfinucan	with proper annotations rather than comments
15:19:08	cdent	and lack of noise was one of the things that keeps me loyal to python
15:19:35	sfinucan	the opt-in nature of the whole thing is pretty attractive to
15:19:41	cdent	yes
15:19:49	sfinucan	*too, even
15:21:06	sfinucan	But the Python 2 variant is better than nothing, for some of the more complex stuff (like nearly everything in virt/libvirt)
15:25:42	mriedem	cfriesen_: pep8 on your chnage
15:25:43	mriedem	*change
15:33:57	openstackgerrit	Jay Pipes proposed openstack/nova master: Sync os-traits to Traits database https://review.openstack.org/469578
15:38:54	mriedem	dansmith: heh i guess this is a duplicate https://review.openstack.org/#/c/460377/ of https://review.openstack.org/#/c/431722/
15:38:56	mriedem	drats
15:39:22	dansmith	mriedem: it's all yours :)
15:40:42	mriedem	looks like the only difference is you dropped the online data migrations, and in mine i think i was asking myself about that
15:40:46	mriedem	b/c of skip level upgrading people
15:41:09	mriedem	https://review.openstack.org/#/c/460377/6/nova/objects/flavor.py@648
15:41:34	dansmith	mriedem: as I've said before, I don't think leaving migrations in the tree for that reason makes sense
15:41:46	mriedem	i tend to agree
15:44:21	mriedem	well i reckon i better sort out if there are any other differences here and drop mine - although i am of course partial to my commit message
15:48:34	dansmith	mriedem: I just abandoned mine so you can't do that :P
15:49:23	mriedem	hells bells
15:49:32	mriedem	i figured i'd just rebase yours
15:55:55	openstackgerrit	Merged openstack/nova master: Connecting Nova to DRBD storage nodes directly https://review.openstack.org/256292
16:00:27	leakypipes	mriedem, melwitt, dansmith, bauzas: easy wins (placement-api-ref) starting here: https://review.openstack.org/#/c/452707/
16:00:43	dansmith	dibs
16:01:10	mriedem	i'm gonna clean up cfriesen_'s change and +2 before it lunch
16:01:13	mriedem	so maybe post-lunch
16:03:27	dansmith	leakypipes: are those not rendered in the docs job anywhere?
16:04:16	cdent	dansmith: different doc job, let me find link
16:04:25	leakypipes	cdent: thx
16:04:36	dansmith	found it
16:04:40	cdent	gate-placement-api-ref-nv
16:06:31	openstackgerrit	Artom Lifshitz proposed openstack/nova master: Convert instance to primitive for metadata cache https://review.openstack.org/469978
16:07:46	dansmith	we're really spoiling our users with this api_ref nonsense
16:09:43	leakypipes	dansmith: lol
16:09:50	mriedem	dansmith: don't worry, we still have plenty of config options that change the behavior of the API in ways not communicated,
16:09:58	mriedem	so we can still screw them
16:10:06	openstackgerrit	Matt Riedemann proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514
16:10:50	mriedem	^ and below are +2'ed
16:10:56	mriedem	looks big but it's mostly api-ref and api samples
16:11:08	mriedem	now it's burger time
16:11:22	mriedem_burgerti	damn
16:12:00	artom	The little known Bugatti knock-off, Burgerti
16:12:46	leakypipes	"It's Burger! It's Burger time!".
16:13:49	dansmith	leakypipes: we're allowing renaming of resource classes?
16:15:06	leakypipes	dansmith: yes.
16:15:17	leakypipes	dansmith: only custom ones of course.
16:15:28	dansmith	isn't that going to confuse things?
16:15:35	figleaf	to make them even more customer
16:15:52	dansmith	like, we have requests in flight that refer to the old name
16:15:55	leakypipes	dansmith: no. internally custom ones are just an integer code. the name can be whatever the user wants.
16:16:10	dansmith	and/or someone creates two and swaps them
16:16:20	dansmith	don't we communicate between services using the symbolic names?
16:16:22	figleaf	leakypipes: they will have to match whatever's in the flavor, though, no?
16:16:23	leakypipes	dansmith: we leave that as an exercise for the readeer? :)
16:16:33	dansmith	yeah what figleaf said
16:17:00	figleaf	dansmith: not feeling super today?
16:17:00	dansmith	I just see no reason to allow that.. might as well just delete and re-create so you get a new integer id and no confusion
16:17:07	dansmith	figleaf: definitely am not
16:17:36	leakypipes	dansmith: you and figleaf make a good point. cdent is our API master so I defer to him.
16:18:03	figleaf	dunno if it has much to do with the API
16:18:13	cdent	I already fixed that in microversion 1.7
16:18:40	dansmith	cdent: fixed what? https://review.openstack.org/#/c/467596/4 says we can rename them
16:18:44	leakypipes	cdent: so we don't allow changing resource class names in 1.7 and beyond?
16:18:53	cdent	because it was not only a bad flow, but also an issue with the external issue
16:19:21	cdent	leakypipes: if you are using a high microversion, correct, you cannot not rename a resource class
16:19:42	cdent	you can delete and create another
16:19:44	cdent	or rather
16:19:45	cdent	create another
16:19:46	cdent	everything external is using the name
16:19:47	cdent	we can't allow changing it
16:19:58	dansmith	++
16:20:35	figleaf	cdent: ah, good
16:20:46	cdent	I kind of feel like we should de-document the old way
16:20:52	cdent	but that would lead to problems
16:21:09	cdent	so perhaps a warning on the 1.2-1.6 microversion?
16:21:24	dansmith	cdent: I think we should drop it from the docs, TBH
16:21:25	cdent	I mean the doc for put /resource_classes/{name}
16:21:39	dansmith	nobody is using this but us yet, so no reason to document something that is already obsolete
16:21:48	claudiub	efried: not as it should. it doesn't consume the self / cls argument. if you are patching a function or a static method, it works fine though.
16:21:59	dansmith	also, is PUT the right verb for "create or verify existence" ?
16:22:11	dansmith	I would expect POST and return 409 if exists, no?
16:22:37	cdent	PUT is the standard for idempotency when you know the url of the resoruce
16:22:50	cdent	the idea here is that you can PUT /resource_classes/{name} all day long
16:23:00	dansmith	hrm, okay
16:23:07	cdent	and it will always return some form of success
16:23:10	claudiub	mriedem: you didn't answer my one question :D : the cinder 3rd party ci requirements state that "CI's do not need to kick off tests until Jenkin's has given a +1", is there a similar policy for nova as well? ( https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers#Third_Party_CI_Requirements )
16:23:10	dansmith	seems wrong, but I guess I don't have time to convince the rest of the world today
16:23:30	cdent	dansmith: the decision was driven by code in the resource tracker which was doing to "get_or_create_resource_class"
16:23:40	cdent	I wanted to change it to "do one call to do both"
16:23:42	cdent	which is PUT

Earlier   Later