| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-06-02 | |||
| 10:12:33 | openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/447505 | |
| 10:27:44 | openstackgerrit | NidhiMittalHada proposed openstack/python-novaclient master: Reset-state's default parameter needs correction https://review.openstack.org/463477 | |
| 10:41:31 | kashyap | mriedem: When you're about, as someone who dabbles with libvirt / block layers sometimes, might want to look at this - https://review.openstack.org/#/c/465205/ | |
| 10:41:35 | kashyap | It is ready to merge | |
| 10:41:42 | kashyap | And, fairly straight-forward | |
| 10:49:10 | openstackgerrit | NidhiMittalHada proposed openstack/python-novaclient master: client.logger.warning wrongly used in migrations https://review.openstack.org/463508 | |
| 11:01:28 | openstackgerrit | NidhiMittalHada proposed openstack/python-novaclient master: Help message for aggregate-update is ambiguous https://review.openstack.org/469753 | |
| 11:03:25 | openstackgerrit | Michael Still proposed openstack/nova master: First attempt at adding a privsep user to nova. https://review.openstack.org/459166 | |
| 11:15:58 | openstackgerrit | Dirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility) https://review.openstack.org/470252 | |
| 11:27:35 | openstackgerrit | Chris Dent proposed openstack/nova master: Fix ChanceScheduler returning a wrong node https://review.openstack.org/466725 | |
| 11:31:06 | openstackgerrit | Dirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility) https://review.openstack.org/470252 | |
| 11:53:28 | bauzas | cdent: thanks for rebasing https://review.openstack.org/#/c/466725/ | |
| 11:56:14 | openstackgerrit | Dirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility) https://review.openstack.org/470252 | |
| 12:09:17 | openstackgerrit | Dirk Mueller proposed openstack/nova-specs master: Fix citation references (Sphinx 1.6.x compatibility) https://review.openstack.org/470252 | |
| 12:28:08 | openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/447505 | |
| 12:47:26 | mriedem | sfinucan: kashyap: someone from your team (sahid?) should probably take a look at this libvirt realtime feature bug v | |
| 12:47:29 | mriedem | https://bugs.launchpad.net/nova/+bug/1695056 | |
| 12:47:29 | openstack | Launchpad bug 1695056 in OpenStack Compute (nova) "libvirt realtime feature mlockall: Cannot allocate memory" [Undecided,New] | |
| 12:50:57 | openstackgerrit | Alex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications https://review.openstack.org/465526 | |
| 12:51:20 | openstackgerrit | Alex Szarka proposed openstack/nova master: Add method for verify multiple versioned notifications https://review.openstack.org/465526 | |
| 12:58:56 | openstackgerrit | Alex Szarka proposed openstack/nova master: Transform instance.exists notification https://review.openstack.org/403660 | |
| 13:07:29 | openstackgerrit | Alex Szarka proposed openstack/nova master: Refactor instance-exists docstring and unit test https://review.openstack.org/462738 | |
| 13:13:00 | openstackgerrit | Eric Fried proposed openstack/nova master: Bump python-glanceclient minimum to 2.7.0 https://review.openstack.org/470281 | |
| 13:21:19 | openstack | bug 1646896 in OpenStack Compute (nova) "System hangs when using NFS storage backend with loopback mounts" [Low,Confirmed] https://launchpad.net/bugs/1646896 | |
| 13:21:19 | openstackgerrit | Mihail proposed openstack/nova master: proposed fix for bug 1646896 - System hangs when using NFS storage backend with loopback mounts, Closes-Bug: #1646896 https://review.openstack.org/422041 | |
| 13:23:56 | openstackgerrit | Chris Friesen proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | |
| 13:28:53 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Replace messaging.get_transport with get_rpc_transport https://review.openstack.org/469659 | |
| 13:38:03 | mriedem | sfinucan: bauzas: one of you want to pull the +W on this libvirt volume driver change? https://review.openstack.org/#/c/256292/ it's pretty trivial | |
| 13:40:55 | bauzas | mriedem: ack, looking | |
| 13:41:49 | rfolco | mriedem, would you please look at https://review.openstack.org/#/c/460231/ and https://review.openstack.org/#/c/460147/, both with one +2. | |
| 13:42:44 | mriedem | rfolco: yeah i can in a bit | |
| 13:42:55 | rfolco | mriedem, thx++ | |
| 13:43:51 | openstack | Launchpad bug 1439855 in OpenStack Compute (nova) "encrypted iSCSI volume fails to attach, name too long" [Medium,Confirmed] | |
| 13:43:51 | mriedem | lyarwood: for when you're off sabbatical, this is right up your encrypted volume alley https://bugs.launchpad.net/nova/+bug/1439855 | |
| 13:44:19 | openstackgerrit | Mihail proposed openstack/nova master: proposed fix for bug 1646896 - System hangs when using NFS storage backend with loopback mounts, Closes-Bug: #1646896 https://review.openstack.org/422041 | |
| 13:44:19 | openstack | bug 1646896 in OpenStack Compute (nova) "System hangs when using NFS storage backend with loopback mounts" [Low,Confirmed] https://launchpad.net/bugs/1646896 | |
| 13:58:12 | openstackgerrit | Matt Riedemann proposed openstack/nova master: placement: Specific error for inventory in use https://review.openstack.org/460231 | |
| 13:58:24 | openstack | bug 1646896 in OpenStack Compute (nova) "System hangs when using NFS storage backend with loopback mounts" [Low,Confirmed] https://launchpad.net/bugs/1646896 | |
| 13:58:24 | openstackgerrit | Mihail proposed openstack/nova master: proposed fix for bug 1646896 - System hangs when using NFS storage backend with loopback mounts, Closes-Bug: #1646896 https://review.openstack.org/422041 | |
| 14:00:54 | bauzas | mriedem: had a comment on https://review.openstack.org/#/c/256292/6 | |
| 14:02:49 | bauzas | mriedem: out of curiosity, do you know if Tooz driver is still a thing for our SG API or whether we should consider etcd ? | |
| 14:04:22 | openstackgerrit | Claudiu Belu proposed openstack/nova master: POC: tests: autospecs all the mock.patch usages https://review.openstack.org/447505 | |
| 14:07:29 | mlavalle | mriedem: hey. I am looking at https://bugs.launchpad.net/nova/+bug/1694417 | |
| 14:07:30 | openstack | Launchpad bug 1694417 in OpenStack Compute (nova) "dhcp_domain used when use_neutron is not set" [Undecided,Incomplete] | |
| 14:07:34 | claudiub | mriedem: hi. i've found a nice pretty little bug. :) https://review.openstack.org/#/c/447505/13/nova/virt/libvirt/driver.py | |
| 14:08:17 | mlavalle | mriedem: seems that for the time being, we should wait for reply from the submitter | |
| 14:09:02 | sfinucan | mriedem, melwitt: All ze comments in https://review.openstack.org/#/c/379524/ _should_ be addressed now, if you fancy taking a gander today | |
| 14:09:40 | sfinucan | bauzas: RE: comments in https://review.openstack.org/#/c/256292/6/nova/virt/libvirt/volume/drbd.py | |
| 14:09:50 | sfinucan | instance is automatically exposed by oslo.log | |
| 14:10:04 | sfinucan | by way of the default formatter | |
| 14:10:10 | bauzas | mmmm okay | |
| 14:10:29 | melwitt | yeah, you can do that on any log message | |
| 14:10:31 | sfinucan | at least, iirc. mriedem has suggested I do something similar a few times previously | |
| 14:10:37 | sfinucan | *prior? | |
| 14:13:10 | claudiub | mriedem: also, one question: the cinder 3rd party ci requirements state that "CI's do not need to kick off tests until Jenkin's has given a +1", is there a similar policy for nova as well? ( https://wiki.openstack.org/wiki/Cinder/tested-3rdParty-drivers#Third_Party_CI_Requirements ) | |
| 14:20:50 | efried | claudiub I have that same thought every couple months ;-) Problem is that it would make overall completion take longer. Which is the lesser evil? | |
| 14:23:27 | claudiub | efried: i guess it depends on the size of the ci. at some point, all the ci resources could be allocated / in use. anyways, even though a ci can be configured to wait for jenkins to vote +1, it can still be triggered manually via "check some-ci" if needed. | |
| 14:23:37 | mriedem | bauzas: we should probably deprecate/remove tooz service group api driver | |
| 14:23:40 | mriedem | bauzas: it's not tested, | |
| 14:23:45 | mriedem | and i don't know if anyone outside of yahoo was using it | |
| 14:23:51 | mriedem | might be worth asking harlowja | |
| 14:24:07 | mriedem | bauzas: etcd is probably a better idea, and is something we can test in the gate | |
| 14:24:19 | mriedem | like i the multinode job or nova-next job | |
| 14:24:21 | mriedem | *in | |
| 14:24:30 | efried | claudiub Looks like mriedem missed that one in https://review.openstack.org/#/c/452958/ -- you going to propose the fix? | |
| 14:25:10 | mriedem | bauzas: instance=instance is common in all of our logging :) | |
| 14:25:15 | claudiub | ah, sure. will do. | |
| 14:25:37 | mriedem | efried: claudiub: missed what? | |
| 14:25:56 | mriedem | claudiub: i already have a patch for that | |
| 14:26:05 | claudiub | ah, ok. | |
| 14:26:15 | mriedem | claudiub: efried: https://review.openstack.org/#/c/469958/ | |
| 14:26:21 | mriedem | bauzas: sfinucan: melwitt: dansmith: jaypipes: ^ | |
| 14:26:31 | mriedem | and https://review.openstack.org/#/c/469740/ | |
| 14:26:36 | mriedem | live migration rollback is borked w/o those two | |
| 14:26:52 | bauzas | mriedem: about instance=instance, sorry for my ignorance | |
| 14:27:16 | sfinucan | mriedem: In a meeting, but I'll look at them soon as I'm done | |
| 14:27:39 | efried | claudiub Perhaps you can suggest how to use autospec for https://review.openstack.org/#/c/469958/1/nova/tests/unit/virt/libvirt/test_driver.py ? | |
| 14:30:33 | efried | claudiub And https://review.openstack.org/#/c/469740/2/nova/tests/unit/compute/test_compute_mgr.py | |
| 14:32:19 | claudiub | efried: well, mock.patch does accept an "autospec" argument, but it doesn't work properly under the current release of mock. I have sent a bug report and bug fix for it: https://github.com/testing-cabal/mock/issues/396 | |
| 14:32:44 | claudiub | that should be the cleanest way; but it didn't get much attention unfortunately. | |
| 14:32:45 | efried | claudiub Riiight, I've been (sorta) following that. | |
| 14:35:09 | claudiub | actually, it seems the mock library hasn't been updated in 6 months. | |
| 14:56:04 | mriedem | rfolco: questions/issues in https://review.openstack.org/#/c/460147/ | |
| 14:56:06 | mriedem | cdent: ^ | |
| 14:56:42 | rfolco | mriedem, will address asap | |
| 14:57:01 | mriedem | i could be wrong | |
| 14:58:53 | cdent | mriedem: on which particular part? | |
| 14:59:59 | mriedem | any? | |
| 15:00:20 | mriedem | we used to check for 200 in the response from the 1.0 call | |
| 15:00:27 | mriedem | now we're checking a range, which is different and scary | |
| 15:00:32 | mriedem | and we're not handling 404 in case the RP is already gone | |
| 15:00:54 | cdent | the range thing is the generic version of "success" that is a mode of being a tolerant client. trendy | |
| 15:01:16 | cdent | the missing 404 is a good point, not sure if that's caught somewhere else or not, but very good of you to point it out | |
| 15:01:25 | cdent | probably means a missing gabbi test | |
| 15:01:45 | rfolco | I thought that was covered, would confirm | |
| 15:01:45 | mriedem | i expect the fallback code to be the same as before, and the range thing is different, which is why i flagged it | |
| 15:01:46 | cdent | s/gabbi/functional resource tracker/ | |
| 15:02:06 | mriedem | hard to review stuff like this if refactored parts are changed | |
| 15:02:19 | mriedem | if you want the range, do it in a preceeding change | |
| 15:02:22 | cdent | mriedem: i think an earlier review caused that change, opportunistic | |