Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-05-31
18:29:31 mriedem i guess i'm not following what your issue is
18:30:01 mriedem you have a user doing POST /os-volume_boot ?
18:30:24 cfriesen I'm trying to find the actual API code used for the POST /os-volumes_boot case. I think it ends up using the same create() routine as POST /servers with "block_device_mapping_v2"
18:30:38 cfriesen yeah, kilo code, they're doing POST /os-volume_boot
18:31:03 mriedem yes it's an extension on POST /servers
18:31:07 mriedem https://developer.openstack.org/api-ref/compute/
18:31:07 mriedem you can't post to os-volumes_boot
18:31:21 cfriesen you could in Kilo apparently
18:32:09 mriedem ok looking at the route list in master you can too
18:32:40 cfriesen it's just explicitly using server_controller in master, which is a lot easier to follow
18:32:47 mriedem https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/routes.py#L383
18:32:59 cfriesen cool, I'm sorted out. thanks
18:33:14 mriedem i'm pretty sure we don't test that alias anywhere
18:33:16 mriedem btw
18:33:50 cfriesen I'll let them know they shouldn't be using it
18:34:01 cfriesen it's documented as deprecated
18:35:52 mriedem cfriesen: documented as deprecated in your product?
18:35:55 mriedem b/c it's not even mentioned in the api-ref
18:37:03 cfriesen mriedem: right, I was misremembering. It's os-volumes that is documented as deprecated
18:37:12 mriedem yeah that's the proxy api
18:43:46 jaypipes sfinucan: hmmm. "ListOfDictOfNullableStringsOrListField". you like that? :)
18:43:59 dansmith wat
18:44:16 mriedem List<Object>
18:44:16 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: Test requesting microversion for attachment_create and falling back https://review.openstack.org/469618
18:44:20 mriedem just do that ^
18:44:25 mriedem List<?> is even better
18:49:18 jaypipes mriedem: boost::variant<std::map<std::string, boost::optional<std::string>>, std::list<std::string>>
18:49:23 jaypipes mriedem: how's that? :)
18:51:22 jaypipes hehe
18:53:29 mriedem ship it
18:57:04 openstackgerrit Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807
18:57:05 openstackgerrit Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215
18:57:06 openstackgerrit Jay Pipes proposed openstack/nova master: placement: adds ProviderTree for nested resources https://review.openstack.org/415920
18:57:06 openstackgerrit Jay Pipes proposed openstack/nova master: placement: integrate ProviderTree to report client https://review.openstack.org/415921
18:57:07 openstackgerrit Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693
18:57:08 openstackgerrit Jay Pipes proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138
18:59:53 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: Test requesting microversion for attachment_create and falling back https://review.openstack.org/469618
18:59:54 openstackgerrit Matt Riedemann proposed openstack/nova master: Use 3.27 microversion when creating new style volume attachments https://review.openstack.org/469609
19:00:36 jaypipes mriedem, dansmith, melwitt: your reviews on https://review.openstack.org/#/c/461574/ and the remainder of the series would be awesome. tia.
19:01:13 dansmith jaypipes: I'll trade you for https://review.openstack.org/#/c/464059
19:01:27 jaypipes dansmith: accepted.
19:04:41 cdent jaypipes, edleafe: sort of security fix for os-traits https://review.openstack.org/#/c/469625/
19:04:47 ildikov mriedem: jgriffith: if that's the desired microversion direction we could try to put the attach PoC on top of that chain
19:04:53 mriedem ildikov: that's the idea
19:05:11 mriedem ildikov: https://review.openstack.org/#/c/469618/ is an example
19:05:19 mriedem but would eventually be jgriffith's poc
19:06:23 jaypipes cdent: ty ty ty!
19:06:49 ildikov mriedem: ah ok, missed that one, but that's what I had in mind too
19:07:35 mriedem jaypipes: cdent: i think we can test that with a devstack wip change before it's released
19:07:35 ildikov mriedem: glad we're on the same page :)
19:07:40 mriedem give me a few
19:07:46 mriedem jaypipes: which was your change that was failing on that again?
19:07:48 jaypipes mriedem: cool, that would be awesomesauce.
19:07:55 jaypipes mriedem: sec
19:08:06 mriedem bbq sauce will suffice
19:08:13 jaypipes mriedem: https://review.openstack.org/#/c/462770/
19:08:17 mriedem ack
19:08:36 mriedem can we rebase that quick?
19:08:42 mriedem i'm going to use it as a depends-on
19:08:48 mriedem by we i mean you
19:08:57 openstackgerrit Chris Dent proposed openstack/nova master: Sync os-traits to Traits database https://review.openstack.org/469578
19:09:18 cdent mriedem: my version of the same functionality has the same problem but is smaller ^
19:10:27 mriedem cdent: ok
19:10:27 openstackgerrit Dan Smith proposed openstack/nova master: Target cell on local delete https://review.openstack.org/464059
19:10:27 openstackgerrit Dan Smith proposed openstack/nova master: Fix live migration devstack hook for multicell environment https://review.openstack.org/458537
19:13:46 edleafe cdent: reviewed the pkgutil fix. One minor issue and I think it's good
19:13:54 cdent thanks edleafe
19:15:22 cdent dood, can I claim "unrelated change" and "didn't you write that?"?
19:15:56 edleafe cdent: sure, but since you're messing with the code...
19:16:22 cdent perhaps a follow up?
19:16:28 edleafe I was going to fix that, but I noticed it just after it merged
19:21:16 jgriffith ildikov mriedem If you both are good with it and there's no feedback from anybody else I'll just add that to my poc now
19:22:03 ildikov jgriffith: works for me
19:23:10 mriedem jgriffith: let me see if this actually works in my DNM change first
19:26:07 jgriffith yeah, I'm waiting
19:26:36 jgriffith or just rebase it in later... whichever works out
19:28:23 edleafe cdent: for the followup, what about making those vars CONSTANTs?
19:28:46 cdent can do
19:29:01 edleafe I can do it, unless you're already into it
19:32:13 openstackgerrit Merged openstack/nova master: Update policy description for os-volumes https://review.openstack.org/466471
19:32:21 jaypipes efried: I appreciate the good, verbose code comments in your SSP patches.
19:32:42 efried jaypipes Thanks.
19:33:31 cdent edleafe: already doing it
19:36:13 cdent edleafe: https://review.openstack.org/#/c/469631/
19:37:14 openstackgerrit Merged openstack/nova master: Updated from global requirements https://review.openstack.org/469577
19:37:19 openstackgerrit melanie witt proposed openstack/nova master: WIP Add project_id and user_id to PUT /allocations https://review.openstack.org/469634
19:37:19 openstackgerrit melanie witt proposed openstack/nova master: Add database migration and model for consumers https://review.openstack.org/469633
19:37:20 openstackgerrit melanie witt proposed openstack/nova master: WIP Add GET /usages https://review.openstack.org/469635
19:40:37 mriedem cdent: jaypipes: testing that os-traits fix here https://review.openstack.org/469636
19:42:27 jaypipes cool, thx mriedem
19:43:27 mriedem jaypipes: cdent: we should probably get a src tempest dsvm job setup on the os-traits repo
19:43:39 jaypipes mriedem: ++
19:43:54 mriedem again, by we, i mean the turd in my pocket
19:44:25 cdent working at home going well, I see
19:44:36 mriedem never heard that saying?
19:45:06 cdent yeah, but it was more fun to think you've become so lazy...
19:45:35 mriedem i wouldn't soil these beautiful chinos
19:50:47 openstackgerrit Mathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322
20:05:16 cfriesen mriedem: sdague: I think https://review.openstack.org/#/c/434514/ is basically ready, all comments have been addressed. It'd be nice if it didn't sit around for so long that another microversion goes in underneath it.
20:06:51 mriedem sean is camping all week i think

Earlier   Later