Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-05-31
14:51:45 openstackgerrit Alvaro Lopez Garcia proposed openstack/nova master: Ensure that periodic reclaim cleans DB deleted instances https://review.openstack.org/323250
14:56:21 openstackgerrit Mathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322
14:58:30 openstackgerrit Merged openstack/nova master: Avoid lazy-load error when getting instance AZ https://review.openstack.org/468147
15:08:50 openstackgerrit Merged openstack/nova master: Add configuration options for certificate validation https://review.openstack.org/457678
15:21:07 ftersin mdbooth: hi. are you around?
15:22:10 clarkb gabor_antal: it looks like inspect.trace() returns empty list if there is no exception currently being raised. SO possibly that is related to the problem?
15:24:28 gabor_antal clarkb: yeah, it looks like. But there is an exception being raised as running functional tests returns ok so it is raised and catched and notification is being sent
15:30:51 openstackgerrit Merged openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/458805
15:45:06 openstackgerrit Merged openstack/nova master: Ensure the value of filter parameter is unicode https://review.openstack.org/468614
15:45:07 sfinucan mriedem: Yup, that makes sense. Thanks
16:08:01 sfinucan ftersin: mdbooth is away all this week. He'll be back Monday though
16:08:39 ftersin thanks
16:33:18 sfinucan alex_xu, gmann: We're seeing a load of merge conflicts with https://review.openstack.org/#/q/topic:bp/api-no-more-extensions-pike+status:open
16:33:52 sfinucan Is there anything we could do to minimize these? Perhaps putting in all the routes in nova/api/openstack/compute/routes.py but commented out?
16:34:01 sfinucan I'll do it if you're OK with me doing so
16:34:28 openstackgerrit Merged openstack/nova master: Add policy description for os-networks https://review.openstack.org/465452
16:40:22 sfinucan It's low priority but there are a lot of mox-mock conversion patches waiting for an additional +2 https://review.openstack.org/#/q/topic:bp/remove-mox-pike
16:40:55 sfinucan If any core has bandwidth, getting some of those in would be sweet. They're easy wins for Python3 compatibility
16:41:11 mriedem https://review.openstack.org/#/c/342043/ failed jenkins
16:41:48 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/469577
16:41:57 openstackgerrit Chris Dent proposed openstack/nova master: Sync os-traits to Traits database https://review.openstack.org/469578
16:42:12 cdent jaypipes, edleafe: there ^ is alternate for traits sync
16:42:29 sfinucan So it did. I can take a look at it
16:42:51 openstackgerrit Matt Riedemann proposed openstack/nova master: WIP: Use microversions for new style volume attachments https://review.openstack.org/469579
16:42:52 mriedem jgriffith: stvnoyes: ildikov: ^ here is the start of microversion handling with cinderclient, needs tests yet
16:45:30 openstackgerrit OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/469581
16:49:20 sfinucan mriedem: That whole test file is a bit of a mess. Given that it's for cells v1, is it worth doing surgery on it or are we better to just keep mox until the whole feature is removed?
16:49:48 mriedem it's definitely low priority
16:50:32 sfinucan meh, I'll leave it so
16:58:45 cdent avolkov: are you and jichenjc colliding on some of the api-ref stuff? looks like there may be some duplicatio of effort on resource class related docs: https://review.openstack.org/#/q/status:open+topic:placement-api-ref-add-resource-classes-put
17:18:34 cdent jaypipes, edleafe, bauzas: quick microversions in placement hygiene thing from alex needs some review: https://review.openstack.org/#/c/458049/
17:18:51 avolkov cdent: oh, missed those patches
17:19:05 edleafe cdent: reviewed the traits sync patch. Looks much clearer
17:19:13 cdent avolkov: yeah, I think the change in topic made them harder to find
17:20:25 openstackgerrit Ed Leafe proposed openstack/nova master: Pass the number of hosts to return explicitly https://review.openstack.org/465767
17:20:25 openstackgerrit Ed Leafe proposed openstack/nova master: Have scheduler claim resources https://review.openstack.org/463993
17:20:26 openstackgerrit Ed Leafe proposed openstack/nova master: Return multiple hosts from select_destinations https://review.openstack.org/465768
17:20:26 openstackgerrit Ed Leafe proposed openstack/nova master: Pass a list of instance UUIDs to scheduler https://review.openstack.org/465171
17:27:00 openstackgerrit Chris Dent proposed openstack/nova master: Sync os-traits to Traits database https://review.openstack.org/469578
17:28:57 cdent edleafe: did you see my comments on ps 11 of https://review.openstack.org/#/c/463993/ ? don't want them lost now that you've rebased
17:50:29 edleafe cdent: yes, I just wanted to clean things up first before making changes
17:51:03 cdent roger
17:52:25 edleafe cdent: I removed the patch that got rid of host_subset_size, so there was that
18:13:25 openstackgerrit Matt Riedemann proposed openstack/nova master: Use microversions for new style volume attachments https://review.openstack.org/469579
18:13:26 openstackgerrit Matt Riedemann proposed openstack/nova master: Use 3.27 microversion when creating new style volume attachments https://review.openstack.org/469609
18:13:51 mriedem ildikov: jgriffith: stvnoyes: ^ ok should be ready for review with tests
18:14:23 mriedem i'm going to push a DNM change on top of that to request something like 3.99 for attachment_create and see it raise the expected error so we can fallback to the old style attach
18:19:17 cfriesen where's the nova api code for boot-from-volume?
18:19:58 mriedem cfriesen: everywhere
18:21:49 cfriesen mriedem: okay let me rephrase that. I see that in the current release it's using server_controller. Is that basically true for earlier releases as well?
18:22:49 cfriesen mriedem: I'm looking at kilo code and only see one two mentions of 'os-volumes_boot'
18:23:09 cfriesen make that "two"
18:23:22 mriedem if POST /servers body has a "block_device_mapping_v2" entry in it, it's boot from volume
18:23:51 mriedem the compute api code translates and validates that to BlockDeviceMappingList
18:24:00 mriedem those get created in the cell in conductor along with the instance(s)
18:24:38 mriedem eventually _prep_block_devices in the compute manager create the volumes in cinder (if a volume id wasn't provided), waits for it to be available and then attaches it to the guest
18:25:14 mriedem the code for bfv and bdms is *everywhere* though
18:25:33 cfriesen and POST /os-volumes_boot ? I see that the ResourceExtension inherits 'servers', does that mean it uses api.openstack.compute.servers.Controller.create
18:28:30 mriedem for v2
18:28:30 mriedem i think os-volumes_boot was some old extension thing
18:28:35 mriedem not a thing in v2.1 anymore
18:28:49 mriedem btw, bfv is right...behind....you!
18:29:14 cfriesen yeah, deprecated now. silly customers running old code
18:29:31 mriedem i guess i'm not following what your issue is
18:30:01 mriedem you have a user doing POST /os-volume_boot ?
18:30:24 cfriesen I'm trying to find the actual API code used for the POST /os-volumes_boot case. I think it ends up using the same create() routine as POST /servers with "block_device_mapping_v2"
18:30:38 cfriesen yeah, kilo code, they're doing POST /os-volume_boot
18:31:03 mriedem yes it's an extension on POST /servers
18:31:07 mriedem https://developer.openstack.org/api-ref/compute/
18:31:07 mriedem you can't post to os-volumes_boot
18:31:21 cfriesen you could in Kilo apparently
18:32:09 mriedem ok looking at the route list in master you can too
18:32:40 cfriesen it's just explicitly using server_controller in master, which is a lot easier to follow
18:32:47 mriedem https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/routes.py#L383
18:32:59 cfriesen cool, I'm sorted out. thanks
18:33:14 mriedem i'm pretty sure we don't test that alias anywhere
18:33:16 mriedem btw
18:33:50 cfriesen I'll let them know they shouldn't be using it
18:34:01 cfriesen it's documented as deprecated
18:35:52 mriedem cfriesen: documented as deprecated in your product?
18:35:55 mriedem b/c it's not even mentioned in the api-ref
18:37:03 cfriesen mriedem: right, I was misremembering. It's os-volumes that is documented as deprecated
18:37:12 mriedem yeah that's the proxy api
18:43:46 jaypipes sfinucan: hmmm. "ListOfDictOfNullableStringsOrListField". you like that? :)
18:43:59 dansmith wat
18:44:16 mriedem List<Object>
18:44:16 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: Test requesting microversion for attachment_create and falling back https://review.openstack.org/469618
18:44:20 mriedem just do that ^
18:44:25 mriedem List<?> is even better
18:49:18 jaypipes mriedem: boost::variant<std::map<std::string, boost::optional<std::string>>, std::list<std::string>>
18:49:23 jaypipes mriedem: how's that? :)
18:51:22 jaypipes hehe
18:53:29 mriedem ship it
18:57:04 openstackgerrit Jay Pipes proposed openstack/nova master: placement: adds REST API for nested providers https://review.openstack.org/384807
18:57:05 openstackgerrit Jay Pipes proposed openstack/nova master: placement: allow filter providers in tree https://review.openstack.org/377215
18:57:06 openstackgerrit Jay Pipes proposed openstack/nova master: placement: adds ProviderTree for nested resources https://review.openstack.org/415920
18:57:06 openstackgerrit Jay Pipes proposed openstack/nova master: placement: integrate ProviderTree to report client https://review.openstack.org/415921
18:57:07 openstackgerrit Jay Pipes proposed openstack/nova master: placement: update client to set parent provider https://review.openstack.org/385693
18:57:08 openstackgerrit Jay Pipes proposed openstack/nova master: placement: add nested resource providers https://review.openstack.org/377138
18:59:53 openstackgerrit Matt Riedemann proposed openstack/nova master: DNM: Test requesting microversion for attachment_create and falling back https://review.openstack.org/469618

Earlier   Later