| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-26 | |||
| 16:38:52 | efried | Did you maybe have an old venv? tox -r? | |
| 16:40:18 | sdague | efried: I did a -r | |
| 16:41:01 | efried | sdague hmph, can't explain it. | |
| 16:41:14 | sdague | yeh, neither can I, oh well | |
| 16:42:07 | efried | sdague Jenkins seems to agree with me, so yeah, oh well. | |
| 16:48:59 | sdague | efried: yeh, I'll completely blow away the directory at some point and reset | |
| 16:53:51 | sdague | ok, the oslo.middleware request_id change + mv 2.46 is green - https://review.openstack.org/#/c/467998 | |
| 17:25:08 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089 | |
| 17:29:02 | openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/468494 | |
| 17:30:01 | openstackgerrit | Sean Dague proposed openstack/nova master: Updated from global requirements https://review.openstack.org/468089 | |
| 17:30:28 | sdague | melwitt: I'm sticking that behind the other one which is mv sensitive so that it doesn't cause a merge issue late | |
| 17:31:09 | sdague | melwitt: if you want to poke at https://review.openstack.org/#/c/467998 - it would be much appreciated | |
| 17:32:30 | melwitt | sdague: ack | |
| 17:35:58 | leakypipes | cdent: fabulous: "Your reward is a brief moment of respite from the despair of existence." | |
| 17:37:21 | cdent | leakypipes: you made it to the end! bask in this brief moment! | |
| 17:43:11 | leakypipes | cdent: :) | |
| 17:43:35 | cdent | too late, the moment is over | |
| 17:47:22 | openstack | Launchpad bug 1693228 in OpenStack Compute (nova) "Nova quota show/set give errors in verify_project_id" [Undecided,New] | |
| 17:47:22 | mriedem | sdague: https://bugs.launchpad.net/nova/+bug/1693228 | |
| 17:47:34 | mriedem | looks like some url munging problems http:// |
|
| 17:48:32 | melwitt | sdague, mriedem: do we need a reno on the mv 2.46 change? | |
| 17:48:40 | melwitt | for the new microversion | |
| 17:48:48 | mriedem | melwitt: umm, probably | |
| 17:49:02 | melwitt | other than that, it looks reasonable to me | |
| 17:49:06 | mriedem | sdague: does the global request id just get generated or does the user pass it in on the request? | |
| 17:49:28 | mriedem | either way, the point of the microversion is to signal to users that they can get that thing back from this cloud and use it to trace through other services | |
| 17:49:35 | mriedem | so it's probably good to call it out in release notes as a feature | |
| 17:49:42 | melwitt | yeah, was thinking the same | |
| 17:53:04 | sdague | mriedem: ok, so there are 2 things going on here, that are related, but slightly different | |
| 17:53:40 | sdague | global_request_id is an inbound value, with a request header of X-OpenStack-Request-ID | |
| 17:53:44 | sdague | you set that | |
| 17:53:52 | sdague | there is also an outbound response header | |
| 17:54:04 | sdague | X-OpenStack-Request-ID - which is locally generated | |
| 17:54:22 | sdague | that's been true for every service except Nova for years | |
| 17:54:35 | sdague | Nova was doing the same thing with X-Compute-Request-ID | |
| 17:55:19 | sdague | in order to get the inbound behavior without copy/paste we needed to adopt the oslo lib | |
| 17:55:25 | sdague | which meant getting the oslo behavior | |
| 17:55:45 | sdague | mriedem: I can add a reno | |
| 17:55:56 | mriedem | ok | |
| 17:56:09 | sdague | you want it in this patch, or a follow on? | |
| 17:56:13 | mriedem | same one | |
| 17:56:23 | sdague | ok, through the jenkins gauntlet again :) | |
| 17:59:57 | openstack | Launchpad bug 1693228 in OpenStack Compute (nova) "Nova quota show/set give errors in verify_project_id" [Undecided,Triaged] | |
| 17:59:57 | mriedem | lbragstad: jamielennox|away: can you take a look at this? https://bugs.launchpad.net/nova/+bug/1693228 | |
| 18:00:12 | lbragstad | mriedem: sure | |
| 18:00:19 | mriedem | since ocata nova tries to validate a project id in our quotas API by calling /v3/projects/{project_id} | |
| 18:00:37 | mriedem | this assumes you have keystone v3 since v2 has been deprecated since i think mitaka | |
| 18:00:51 | mriedem | the person in the bug report said that nova hard-coding /v3/ in the url prefix is wrong | |
| 18:00:52 | lbragstad | mriedem: i'm digging into some stable maintenance things for keystone at the moment, but i'll look into that next | |
| 18:00:53 | openstackgerrit | Sean Dague proposed openstack/nova master: Migrate to oslo request_id middleware - mv 2.46 https://review.openstack.org/467998 | |
| 18:01:12 | sdague | right, this is the versioned vs. unversioned keystone endpoint issue | |
| 18:01:22 | mriedem | ok - only thing that gives me pause is the v3 api-ref uses /v3/ too https://developer.openstack.org/api-ref/identity/v3/#show-project-details | |
| 18:01:31 | sdague | https://review.openstack.org/#/c/438049/ | |
| 18:01:58 | sdague | mriedem: so that's the result they will get if they made their identity url use the versioned one | |
| 18:02:21 | sdague | it's the same thing tripleo hit | |
| 18:03:18 | sdague | there is other keystoneauth magic we could lean on here | |
| 18:03:30 | sdague | the half baked patch I had died on the vine | |
| 18:04:38 | sdague | actually, I think https://review.openstack.org/#/c/438049/6/nova/api/openstack/identity.py might be the fix for them as well | |
| 18:04:54 | sdague | I didn't like it at the time because of how much magic hiding of issues it does | |
| 18:04:55 | mriedem | hit kolla too https://review.openstack.org/#/c/463500/ | |
| 18:06:28 | sdague | yeh. | |
| 18:06:33 | mriedem | so with that patch of yours, | |
| 18:06:49 | mriedem | they go from a 400 (because of endpoint not found) to a 404 (Because endpoint not found) | |
| 18:06:55 | mriedem | but with a helpful message | |
| 18:07:18 | sdague | actually, they wouldn't get a 404 | |
| 18:07:19 | mriedem | or does ksa actually do magic to find the right v3 endpoint? | |
| 18:07:25 | sdague | yep, it does | |
| 18:07:30 | mriedem | oh well that's neat | |
| 18:07:38 | sdague | that's the magic I wasn't all that comfortable with | |
| 18:07:43 | mriedem | oh | |
| 18:07:47 | mriedem | well | |
| 18:07:53 | sdague | but, honestly, it's probably the right UX for operators | |
| 18:07:59 | mriedem | yeah, plus upgrade impact isn't fun | |
| 18:08:03 | sdague | yep | |
| 18:08:35 | sdague | ok, so how about the following deal. You look at mv 2.46 again, and I'll fix this patch | |
| 18:08:42 | sdague | which we'll probably want to backport | |
| 18:08:48 | openstackgerrit | John Griffith proposed openstack/nova master: cinder: add attachment_create method https://review.openstack.org/459111 | |
| 18:08:49 | openstackgerrit | John Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285 | |
| 18:08:49 | openstackgerrit | John Griffith proposed openstack/nova master: cinder: add attachment_update method https://review.openstack.org/459113 | |
| 18:09:16 | mriedem | sdague: ok | |
| 18:18:44 | mriedem1 | superdan: want to update the link in the channel topic to https://wiki.openstack.org/wiki/Nova/Pike_Release_Schedule ? | |
| 18:18:58 | superdan | oh alright | |
| 18:24:37 | mriedem1 | 2.46 reviewed | |
| 18:25:49 | openstackgerrit | John Griffith proposed openstack/nova master: WIP/POC Implement new attach Cinder flow https://review.openstack.org/330285 | |
| 18:28:55 | lbragstad | mriedem: so you don't need anything from a ksa perspective, just double checking | |
| 18:31:21 | mriedem | lbragstad: sean is on it | |
| 18:31:22 | mriedem | thanks | |
| 18:32:49 | mriedem | leakypipes: figleaf: cdent: is there anything that merged recently which might be causing this? http://logs.openstack.org/32/468232/1/gate/gate-tempest-dsvm-cells-ubuntu-xenial/ad969ba/logs/screen-n-cpu.txt.gz?level=TRACE#_May_26_17_29_52_292260 | |
| 18:32:58 | mriedem | looks like a race to cleanup allocations in the resource tracker when an instance is deleted | |
| 18:33:04 | openstack | Launchpad bug 1693899 in OpenStack Compute (nova) "Cleaning up stale resource allocations can fail with InstanceNotFound" [Undecided,New] | |
| 18:33:04 | mriedem | https://bugs.launchpad.net/nova/+bug/1693899 | |
| 18:33:08 | mriedem | just started in the last 24 hours or so | |
| 18:33:32 | mriedem | https://github.com/openstack/nova/commit/439f67e7bc795f171af8248400c3f3e17a0bbe7e ? | |
| 18:33:43 | mriedem | yup | |
| 18:36:24 | artom | mriedem, the InstanceNotFound test thing - better to squash the two patches into one in the backport, or leave separate? | |
| 18:36:56 | mriedem | artom: gonna be hard to separate them since it's writing a test for something already fixed on master | |
| 18:37:27 | artom | mriedem, it could be fix first then test in the top patch. But yeah, squash makes more sense | |
| 18:37:34 | mriedem | unless you mean the test backport comes after the fix backport on stable too | |
| 18:37:38 | mriedem | ok | |
| 18:37:41 | mriedem | either way | |