Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-05-05
20:53:53 mriedem just blame it on thorst_afk
20:53:57 efried Always.
20:54:21 thorst_afk he's always afk
20:54:38 melwitt hah
20:56:16 efried Honestly, I'm not sure how https://review.openstack.org/#/c/443189/ got a merge conflict but its predecessors didn't.
20:56:32 efried It didn't touch any non-PowerVM files.
20:57:32 mriedem https://review.openstack.org/#/c/456877/7/nova/tests/unit/compute/test_compute.py@10260
20:57:32 mriedem melwitt: i'm suprised this doesn't result in a keyerror
20:57:36 mriedem since it's not using a kwarg
20:57:58 mriedem oh i know why
20:58:02 mriedem it's using attachment_id as the message
20:58:55 melwitt mriedem: yeah, that might match because of python named argument matching?
20:59:08 mriedem no i think it's because
20:59:08 mriedem def __init__(self, message=None, **kwargs):
20:59:12 mriedem if not message:
20:59:23 mriedem if you overwrite the message, we don't try the msg % kwargs
20:59:26 mriedem and get the KeyError
20:59:37 melwitt oh, I see.
21:00:00 openstackgerrit Matt Riedemann proposed openstack/nova master: Add Cinder v3 detach to shutdown_instance https://review.openstack.org/456877
21:02:03 melwitt I was thinking of the named argument thing but that works in the opposite way. you can specify positional args as kwargs by name (and in wrong order) and it will still work
21:02:56 melwitt s/positional/normal/
21:03:47 efried aHA!
21:03:51 efried It's melwitt's fault!
21:04:14 efried https://review.openstack.org/#/c/462764/3/nova/tests/unit/virt/powervm/test_driver.py
21:04:33 melwitt lol, you meant literally
21:04:34 mriedem heh, well, it's really your fault
21:05:14 mriedem stvnoyes: btw, reverify is ignored
21:05:15 mriedem use recheck
21:06:07 efried So, hm, is there any way for me to fix my merge conflict without rebasing the predecessors?
21:18:34 thingee hey anyone oppose me proposing the deprecation of the trusted filter?
21:18:54 thingee it has been experimental since it has existed in may 28 2012
21:20:06 cdent new things crawl out of the woodwork every day
21:20:52 thingee aight, I'll send an email to ops list to see if anyone cares.
21:21:00 cdent good plan
21:22:34 thingee http://lists.openstack.org/pipermail/openstack-operators/2017-May/013371.html boom
21:39:31 stvnoyes mriedem: ok thanks. I had read somewhere that reverify was used to re-kick a gate test, but it must have been stale info
22:20:47 openstackgerrit Mike Perez proposed openstack/nova master: Deprecate scheduler trusted filter https://review.openstack.org/463065
22:24:08 openstackgerrit Mike Perez proposed openstack/nova master: Deprecate scheduler trusted filter https://review.openstack.org/463065
22:42:55 mordred sdague: I feel like maybe I'm skipping too much of that thread
22:51:01 mordred sdague: oh - nope. reading more of it does not make my life any better
23:11:51 mriedem thingee: that reminds me https://review.openstack.org/#/c/457812/
23:12:09 mriedem stvnoyes: in the long ago reverify would do the same thing as recheck, but i think they stopped handling that a few months ago
23:12:39 thingee mriedem: deprecate all the filters
23:13:19 mriedem thingee: btw, what prompted this?
23:18:53 thingee The board/tc meeting discussed a goal of simplification. Reduction of options and what not
23:18:56 thingee mriedem: ^
23:19:28 thingee I was pointed to this when I was gathering ideas
23:20:12 thingee mriedem: let me know if you have suggestion of things worth looking into
23:20:20 mriedem thingee: holy crap we probably have a ton
23:20:29 mriedem thingee: i know we deprecated a lot of things in ocata,
23:20:40 mriedem i think you could just be looking for things that are deprecated for removal
23:21:02 mriedem assuming someone doesn't already have a patch up to remove those things and we just haven't seen it yet
23:21:07 thingee mriedem: yeah I removed something out of nova recently that was marked deprecated. not sure if I saw anything else, but I'll double check
23:23:50 mriedem thingee: grep for deprecated_since='15.0.0', and you'll see a few things
23:24:06 mriedem although,
23:24:21 mriedem i'd avoid anything under nova/conf/network as those are probably for nova-network which isn't gone yet
23:24:39 mriedem really anything that's deprecated related to nova-network is just signaling right now
23:25:03 mtreinish mriedem: an even longer time ago reverify would just run the gate queue again and not rerun check
23:25:09 mriedem anyway, got to run
23:25:11 mriedem mtreinish: i know
23:25:12 mriedem sheesh
23:25:40 mtreinish thingee: also you can look at logstash we always emit a ton of deprecation warnings during gate jobs: http://logstash.openstack.org/#/dashboard/file/logstash.json?query=message:%5C%22deprecated%5C%22%20AND%20loglevel:%5C%22WARNING%5C%22%20AND%20build_branch:%5C%22master%5C%22
23:25:59 mriedem mtreinish: i didn't want to expose my nerd-like internal knowledge about the slight differences between recheck and reverify and the check vs gate queues :)
23:26:04 mtreinish thingee: I made a push to try and clean that up a while ago, but it never really fixed the problem: http://lists.openstack.org/pipermail/openstack-dev/2015-December/081984.html
23:26:23 mtreinish mriedem: heh, fair enough
23:26:36 mriedem mtreinish: btw, you still owe me that cloudpipe cli/api deprecation patch for novaclient
23:26:46 mtreinish oh, I do don't I
23:26:54 mtreinish I'll look at that in a couple min
23:27:05 mriedem i'm gonna go gamble
23:27:46 mtreinish enjoy
#openstack-nova - 2017-05-06
00:02:25 openstackgerrit Chris Friesen proposed openstack/nova master: Tweak the cpu_realtime_mask handling slightly https://review.openstack.org/461456
04:09:39 openstackgerrit falseuser proposed openstack/nova master: [BugFix] Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388
04:26:43 openstackgerrit falseuser proposed openstack/nova master: [BugFix] Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388
05:45:26 openstackgerrit falseuser proposed openstack/nova master: [BugFix] Include the video ram when comparing the difference of two flavors https://review.openstack.org/460388
06:01:15 openstackgerrit christopher.uhler proposed openstack/nova master: Libvirt volume driver for Veritas HyperScale https://review.openstack.org/443951
16:15:24 chatter29 hey guys
16:15:26 chatter29 allah is doing
16:15:32 chatter29 sun is not doing allah is doing
16:15:34 chatter29 to accept Islam say that i bear witness that there is no deity worthy of worship except Allah and Muhammad peace be upon him is his slave and messenger
17:58:56 dtp mriedem, are you here?
20:16:49 Venkat Hi
20:16:57 jaypipes Hi :)
20:17:02 lrensing turn that frown upside down jaypipes
20:17:04 phealy who was the sad panda from upstream university? I've been here for a while ;)
20:17:11 jaypipes lrensing: :)
20:17:16 csatari We are already here...
20:17:20 jaypipes heh
20:17:47 pureheart hello...
20:17:56 jaypipes phealy, csatari: yeah, I know. was just kidding around :)
20:17:59 jaypipes pureheart: hi!
20:18:42 pureheart :>
#openstack-nova - 2017-05-07
10:27:58 abhi89 dansmith: Hi.. can you please review https://review.openstack.org/#/c/462561/
13:26:56 gmann alex_xu: looks good but few alias can be removed - https://review.openstack.org/#/c/462825/3
14:56:37 openstackgerrit Mike Perez proposed openstack/nova master: Deprecate scheduler trusted filter https://review.openstack.org/463065
17:18:02 mriedem asettle: found out nicolasbock, nova docs cpl, will be at the summit
17:18:08 mriedem so he'll be at your docs forum session on monday
17:35:11 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/463157
19:30:01 openstackgerrit Mike Perez proposed openstack/nova master: Remove conductor topic configuration option https://review.openstack.org/463193
19:43:25 openstackgerrit Mike Perez proposed openstack/nova master: Remove compute topic configuration option https://review.openstack.org/463197
19:44:43 openstackgerrit Mike Perez proposed openstack/nova master: Deprecate scheduler trusted filter https://review.openstack.org/463065

Earlier   Later