| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-04 | |||
| 12:18:30 | sdague | yep | |
| 12:18:52 | sean-k-mooney | anyway it might just be a nice sideffect to get that fucntionality back | |
| 12:19:28 | sean-k-mooney | i used to jsut run in offline mode instad but that ment you still had to recreated the vms/netwoks/flavour ... | |
| 12:19:41 | sean-k-mooney | thats not hard jsut extra steps | |
| 12:21:40 | alex_xu_ | johnthetubaguy: sdague sfinucan appreciate if you can help this two easy api-ref changes https://review.openstack.org/461998 https://review.openstack.org/458738 | |
| 12:22:20 | sdague | sean-k-mooney: yeh, let me know how it works. If we need some tweaks to make that use can solid for you, that would be cool | |
| 12:22:41 | sdague | there was so much hacktastic around getting screen to be reliable, I look forward to that code being deleted with fire | |
| 12:26:27 | sshnaidm | has anybody seen nova errors like: AttributeError: 'Instance' object has no attribute '_save_tags' ? | |
| 12:33:20 | johnthetubaguy | sshnaidm: I think I saw a bug and patch up for that somewhere | |
| 12:34:30 | johnthetubaguy | sshnaidm: I think gibi has this patch up: https://review.openstack.org/#/c/450265/ | |
| 12:34:57 | johnthetubaguy | dansmith: I wasn't sure about the object change in this one actually https://review.openstack.org/#/c/450265/ | |
| 12:36:48 | sshnaidm | johnthetubaguy, thanks, so as I understand it's not critical, right? | |
| 12:37:38 | johnthetubaguy | sshnaidm: I believe so | |
| 12:47:07 | sou | Hey, I am stuck with an issue for past 2 days | |
| 12:47:15 | sou | I am trying a nova rebuild | |
| 12:47:20 | sou | and it fails all the time | |
| 12:47:44 | sou | with error: ERROR oslo_messaging.rpc.dispatcher [req-b5730d47-3c34-4949-9836-01139238f829 8a205b2aa31c4c1185a417c6e99e852c fcb05e141ede4164ab6db9ad0724a08e - - -] Exception during message handling: id | |
| 12:48:24 | sou | nothing else in logs | |
| 12:48:45 | sou | the exception is generated from /usr/lib/python2.7/site-packages/glanceclient/openstack/common/apiclient/base.py | |
| 12:48:52 | sou | line 494, in __getattr__ | |
| 12:49:05 | sou | any one else has faced similar issue? | |
| 12:49:16 | sou | I am using Kilo version | |
| 12:49:43 | sou | compute nodes uses KVM and images are lvm | |
| 12:52:21 | johnthetubaguy | sou: please try #openstack, see channel topic | |
| 12:53:31 | sou | Thanks @johnthetubadguy | |
| 13:26:24 | openstackgerrit | Alex Xu proposed openstack/nova master: Use plain routes list for os-interface endpoint instead of stevedore https://review.openstack.org/459979 | |
| 13:26:24 | openstackgerrit | Alex Xu proposed openstack/nova master: Use plain routes list for server-tags instead of stevedore https://review.openstack.org/461645 | |
| 13:26:25 | openstackgerrit | Alex Xu proposed openstack/nova master: Use plain routes list for server-migrations endpoint instead of stevedore https://review.openstack.org/461646 | |
| 13:30:09 | abhi89 | johnthetubaguy: can we back port this fix https://review.openstack.org/#/c/460305/ to stable/ocata.. we were looking to have this change in this release in our product.. | |
| 13:30:47 | johnthetubaguy | abhi89: I think that should be OK | |
| 13:31:07 | dansmith | johnthetubaguy: yes, as you said, and as convention in the code, the empty save handler is the right approach | |
| 13:33:01 | abhi89 | johnthetubaguy: grt.. i will cherry pick the fix to ocata.. | |
| 13:33:24 | gibi | mriedem: hi! I could not attend on the nova meeting today, I left small notes on the agenda | |
| 13:33:32 | mriedem | gibi: ok thanks | |
| 13:45:34 | mriedem | gibi: do we need to call out https://review.openstack.org/#/c/401992/ when it's approved? | |
| 13:46:54 | mriedem | melwitt: sdague: dansmith: looks like the use_journal=True thing was causing the cells job failures http://status.openstack.org/elastic-recheck/#1580728 | |
| 13:47:03 | mriedem | we should still get https://review.openstack.org/#/c/461912 in though | |
| 13:48:44 | dansmith | mriedem: okay, I've yet to see my devstack patch fail with journald remoed | |
| 13:48:54 | dansmith | well, fail for a related reason anyway | |
| 13:49:13 | abhi89 | johnthetubaguy: please review cherry picked fix https://review.openstack.org/#/c/462561/ for stable/ocata | |
| 13:56:10 | mriedem | nova meeting in 4 minutes in #openstack-meeting | |
| 14:32:48 | mtreinish | kashyap: fwiw, I was talking about the grenade line there. It's not 100% obvious that it's there for making sure systemd isn't used on grenade | |
| 14:33:05 | mtreinish | I had to think it through out loud to understand the logic in that if | |
| 14:33:07 | kashyap | mtreinish: Noted. :-) | |
| 14:33:40 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform aggregate.updateprop notification https://review.openstack.org/462576 | |
| 14:34:56 | nammo | Hi How can I remove a RetryFilter? | |
| 14:35:12 | nammo | I removed it from nova.conf but it still exists | |
| 14:37:49 | bauzas | manjeets__: pull it out from enabled_filters | |
| 14:38:05 | bauzas | oops | |
| 14:38:08 | bauzas | nammo: ^ | |
| 14:38:40 | nammo | bauzas: Thanks for your response | |
| 14:38:40 | openstackgerrit | Gábor Antal proposed openstack/nova master: [WIP] Transform aggregate.update_metadata notification https://review.openstack.org/460625 | |
| 14:38:52 | nammo | I did it but it still show up in logs | |
| 14:39:00 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: test for agg association not sharing https://review.openstack.org/461901 | |
| 14:39:00 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: tests for non-shared with shared https://review.openstack.org/461899 | |
| 14:39:01 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: shared resources when finding providers https://review.openstack.org/461574 | |
| 14:39:01 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: test non-shared out of inventory https://review.openstack.org/461900 | |
| 14:39:02 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: get providers sharing capacity https://review.openstack.org/460798 | |
| 14:39:21 | jaypipes | dansmith: fixed that silly copy/paste error in the functional test ^^ | |
| 14:39:26 | jaypipes | dansmith: thx for your reviews! | |
| 14:40:12 | dansmith | jaypipes: did you see the rest? I think I had a -1 on all of them | |
| 14:40:21 | nammo | bauzas: I restarted n-sch, n-cond | |
| 14:40:29 | nammo | Is that sufficient? | |
| 14:40:38 | bauzas | nammo: only n-sch | |
| 14:41:58 | nammo | bauzas: No it is not working for me :( | |
| 14:44:43 | nammo | bauzas: http://paste.openstack.org/show/608874/ | |
| 14:46:51 | jaypipes | dansmith: I've fixed some issues. with regards to the long code comment, where do you want me to put that stuff? | |
| 14:47:17 | dansmith | jaypipes: I dunno, it was just an idea.. I'd like to avoid moving the actual db query code elsewhere | |
| 14:47:54 | bauzas | jaypipes: FWIW, I was reviewing your bottom change, but I was thinking about using Workbench | |
| 14:47:55 | jaypipes | dansmith: right... I moved that code into the module-level scope per your request. | |
| 14:48:11 | bauzas | jaypipes: because $sql | |
| 14:48:25 | dansmith | jaypipes: yep, I saw, and I appreciate that. I'm referring to edleafe and cdent's desire to see it moved farther away | |
| 14:48:54 | jaypipes | dansmith: oh. sorry, do you agree with that? | |
| 14:49:29 | dansmith | jaypipes: agree with what? I just said I didn't want to see that code move out, so if we need to make things smaller, maybe we should move the comments out | |
| 14:50:51 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform aggregate.update_metadata notification https://review.openstack.org/460625 | |
| 14:51:22 | cdent | I'm not wed to the idea of moving it out, is fine in the same file, but I find huge python files difficult to think about | |
| 14:51:44 | jaypipes | dansmith: right, and I was asking where you'd like to move the SQL comments. | |
| 14:51:57 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: test for agg association not sharing https://review.openstack.org/461901 | |
| 14:51:57 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: tests for non-shared with shared https://review.openstack.org/461899 | |
| 14:51:58 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: shared resources when finding providers https://review.openstack.org/461574 | |
| 14:51:58 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: test non-shared out of inventory https://review.openstack.org/461900 | |
| 14:52:10 | dansmith | jaypipes: and I said "I dunno" :P | |
| 14:52:19 | dansmith | jaypipes: my preference would be to not move things out of that file | |
| 14:52:30 | jaypipes | dansmith: ah, sorry, I missed that. :) | |
| 14:52:39 | bauzas | cdent: jaypipes: dansmithwhat needs to move ? | |
| 14:52:56 | bauzas | I'm fine with leaving ORM code as it is | |
| 14:53:09 | bauzas | if that's the point | |
| 14:58:04 | jaypipes | bauzas: the discussion is not around the ORM code but rather there is a discussion about how long the code comment with SQL is on that function. | |
| 14:58:20 | bauzas | well | |
| 14:58:22 | bauzas | okay | |
| 14:58:29 | bauzas | not sure it's a problme | |
| 14:58:54 | bauzas | when I wrote the long docstring, I also fixed the comment when I changed the calls | |
| 14:59:19 | bauzas | that's why I'd like to at least pdb your change for verifying the SQL query | |
| 14:59:39 | mriedem | won't we want the big ass sql comment for the complicated orm code? | |
| 14:59:51 | mriedem | as dansmith said earlier in the week, this is all fine but i won't be debugging it :) | |
| 14:59:52 | bauzas | it's just part of a reviewer duty /me shrugs | |
| 15:00:00 | dansmith | there is no question about ORM stuff AT ALL | |
| 15:00:12 | dansmith | it's about where to put these comments about the sql | |
| 15:00:22 | bauzas | tbc, I'm fine with the current situation | |
| 15:00:34 | bauzas | having large docstrings is good wit hme | |