Earlier  
Posted Nick Remark
#openstack-nova - 2017-05-03
20:33:23 jaypipes :)
20:33:40 mriedem mutable media,
20:33:41 mriedem dag
20:33:43 mriedem nerd alert!
20:34:16 jaypipes mriedem: all trees are DAGs but not all DAGs are trees..
20:34:32 mriedem i know
20:34:40 mriedem oh, well,
20:34:42 mriedem yeah nvm
20:34:56 mriedem anyway, when i think of bidirectional i just think of graphs,
20:35:02 mriedem and single parent directional i think of trees
20:35:05 mriedem which are also graphs
20:35:06 jaypipes it's cool, I removed the term DAG.
20:35:23 mriedem i thought about not saying anything lest i look the fool
20:37:28 dansmith and yet.. still happened
20:37:38 melwitt lol
20:38:40 mriedem hey, you didn't know what sight words ere
20:38:41 mriedem *were
20:38:43 mriedem dummy
20:39:03 mriedem that reminds me to send you a picture of the thing i'm now a bad parent for
20:39:19 dansmith they definitely didn't call them that when I was a kid
20:39:23 dansmith at least, not in my school
20:51:18 jaypipes mriedem, dansmith: OK, removed a few slides from the New Hope deck. Down to 26 "real" slides, which should be perfect for the slot.
20:51:48 jaypipes now... to whittle down the 1582 slides in my second deck...
20:53:48 mriedem i can't possibly go through them all again, but i think it looks really nice
20:54:13 jaypipes mriedem: I appreciate both your and dansmith's comments. thanks again.
20:54:28 mriedem dansmith: cells v2 meeting in 6 minutes?
20:54:29 dansmith I didn't offer any useful feedback
20:54:32 dansmith mriedem: yeah
20:54:57 jaypipes dansmith: you just being you is useful feedback. :)
20:55:07 dansmith heh
20:59:10 melwitt sdague: here's the unit test I'm trying for oslo.versionedobjects https://review.openstack.org/462288
21:00:58 melwitt to me it seems like __repr__ is doing the right thing to encode as ascii (the default) before returning if not python3, else things you could expect to work like str() would blow up in python2 if applied to the returned repr
21:29:55 mriedem dansmith: i'm not sure how you don't love 'modularity' as a theme...
21:30:03 mriedem it makes total sense if you're trying to synergize
21:30:16 dansmith mriedem: my mistake
21:37:43 clarkb melwitt: if thats the case maybe you need to do a lossy repr?
21:38:06 melwitt mriedem, dansmith: what about hyperconvergence
21:38:34 melwitt clarkb: what do you mean?
21:38:51 mriedem melwitt: only thought leaders who drive innovative results deal with hyperconvergance
21:38:57 clarkb melwitt: convert to ascii and ignore errors
21:39:49 clarkb melwitt: https://docs.python.org/2/library/codecs.html#codec-base-classes has a list of the encoding optisn you can use
21:40:08 clarkb strict is default which is why you get the error. But you could ignore or replace. or use backslashreplace
21:51:35 mriedem jaypipes: does 11am ET work tomorrow for you?
21:51:41 mriedem 30 min hangout?
21:51:53 jaypipes mriedem: yup.
22:00:39 EmilienM mriedem: sounds like re-enabling WSGI didn't work well: http://logs.openstack.org/81/462281/1/check/gate-puppet-openstack-integration-4-scenario002-tempest-centos-7/7a37824/logs/nova/nova-compute.txt.gz#_2017-05-03_20_58_25_083
22:02:06 mriedem EmilienM: that doesn't look like anything that would be related to running with wsgi
22:02:54 EmilienM I agree
22:26:18 openstackgerrit melanie witt proposed openstack/nova master: Use six.text_type() when logging Instance object https://review.openstack.org/461912
22:29:33 melwitt mriedem, dansmith: there's the hopefully final version. ^ I'm not sure if the unit test is good enough, if I should instead do an exact comparison of the repr
22:36:02 melwitt clarkb: the repr is already converting to ascii with no errors. the UnicodeDecodeError is raised here https://github.com/python/cpython/blob/2e576f5/Lib/logging/__init__.py#L338 which implies it's trying to do an implicit conversion to unicode. I don't understand that
22:40:31 mriedem melwitt: nit inline
22:40:37 mriedem otherwise lgtm
22:40:53 melwitt mriedem: k, looking
22:41:29 melwitt ah, thanks
22:45:58 openstackgerrit melanie witt proposed openstack/nova master: Use six.text_type() when logging Instance object https://review.openstack.org/461912
22:50:19 mriedem melwitt: should you be using assertIsInstance instead of assertIs?
22:50:42 mriedem i'm not entirely sure what the difference is, but i thought assertIs was like, == but without checking __eq__
22:50:45 mriedem like same object in memory
22:51:04 mriedem https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertIs
22:51:20 melwitt mriedem: I tried that first and it failed and said to check exact type, use assertIs https://docs.python.org/2/library/unittest.html#unittest.TestCase.assertIsInstance
22:51:59 mriedem oh huh, weird
22:52:00 mriedem ok
22:52:01 mriedem +2
22:52:31 melwitt thanks
22:59:18 mriedem mtreinish: a few things in https://review.openstack.org/#/c/459470/ yet
23:01:47 dansmith mriedem: is and == are different
23:03:00 dansmith >>> 1 == True
23:03:00 mtreinish mriedem: ok, I'll respin that now
23:03:01 dansmith True
23:03:02 dansmith >>> 1 is True
23:03:03 dansmith False
23:04:38 dansmith mriedem: ah you said it above and I missed.. "same object in memory" is right
23:05:00 dansmith mriedem: but assertIsInstance is a subclass check
23:16:17 openstackgerrit Matthew Treinish proposed openstack/nova master: Remove cloudpipe APIs https://review.openstack.org/459470
23:16:20 mtreinish mriedem: ^^^ that should address your comments
#openstack-nova - 2017-05-04
00:00:25 openstackgerrit Matthew Treinish proposed openstack/nova master: Remove cloudpipe APIs https://review.openstack.org/459470
00:26:25 mriedem dansmith: yeah gawd
00:43:00 mriedem mtreinish: we shall see
00:53:36 mriedem mtreinish: hells yes
00:53:37 mriedem +2
00:53:49 mriedem alex_xu_: oomichi: https://review.openstack.org/#/c/459470/6
01:09:38 mtreinish mriedem: awesome, thanks
01:11:33 mtreinish mriedem: I think once that merges it'll be my first nova bp implemented since the coverage extension back in grizzly
01:11:45 mriedem mtreinish: oh it's not done yet,
01:11:49 mriedem novaclient changes buddy
01:12:37 mriedem i don't think it mentions it
01:12:47 mtreinish it doesn't
01:13:07 mriedem certs was already deprecated in novaclient https://github.com/openstack/python-novaclient/commit/b6aea669630dc88296bdded963051a35cc9f995e
01:13:21 mriedem but cloudpipe wasn't https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/cloudpipe.py
01:13:38 mriedem i can probably do that if you want, i've been doing a lot of that in novaclient lately
01:13:51 mtreinish mriedem: if you want, otherwise I'd push those up tomorrow
01:14:32 mriedem mtreinish: you should probably do it since it'll just enable me to procrastinate on summit prep
01:14:52 mtreinish mriedem: heh, what do you think it is for me?
01:14:54 mriedem don't use the certs one as an example, use the one that deprecated os-hosts in novaclient
01:15:07 mriedem use this as the example https://github.com/openstack/python-novaclient/commit/ea3b9f7fef28a7f06b51a3b176c85a1fc33cecaa
01:15:10 mtreinish ok
01:15:54 mriedem mtreinish: there is a nova onboarding session at the summit you can attend too
01:15:57 mriedem since you're a new contributor again
01:17:05 mtreinish mriedem: heh, I'll consider it

Earlier   Later