| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-05-03 | |||
| 17:33:45 | mriedem | sdague: that means we might lose some things that we were indexing from syslog into logstash before, | |
| 17:33:49 | mriedem | but that's probably a small set, idk | |
| 17:33:54 | mriedem | libvirt things for sure though... | |
| 17:34:14 | sdague | mriedem: it does, so if there are important things, I'd suggest just adding topics | |
| 17:34:43 | sdague | mriedem: there is a reason I'm asking you what topics you want, because I expect you are one of the top users :) | |
| 17:34:55 | sdague | so I'm totally good with mriedems private label topics list | |
| 17:35:02 | clarkb | dnsmasq | |
| 17:35:13 | clarkb | thats been useful to debug dhcp things int he past | |
| 17:35:38 | sdague | clarkb: it has, though usually not with a spot check | |
| 17:35:52 | mriedem | i dumped the current open e-r queries that rely on syslog in the patch | |
| 17:35:54 | sdague | it will still be in the journal dump | |
| 17:36:02 | mriedem | i haven't dug into what they are looking for though, because i'm lunching | |
| 17:36:07 | sdague | mriedem: ok | |
| 17:36:14 | sdague | speaking of, I need to do that | |
| 17:36:26 | sdague | then will be intermittent for the rest of the day | |
| 17:37:02 | sdague | I fast approved the disable on use_journal - https://review.openstack.org/#/c/462163/ - so hopefully in a couple of hours that will be in | |
| 17:38:25 | mriedem | cool | |
| 17:39:25 | mriedem | cfriesen: are you going to be at the summit? | |
| 17:39:46 | mriedem | because there is a session where all of your questions can be answered! | |
| 17:40:06 | mriedem | unless they have something to do with numa and pci, then we'll be asking you for the answeres | |
| 17:40:08 | mriedem | *answers | |
| 17:51:01 | mriedem | jaypipes: i had no idea wookiee had 2 es | |
| 17:51:36 | jaypipes | mriedem: you're welcome :) | |
| 17:51:41 | jaypipes | TIL... | |
| 17:51:42 | mriedem | i actually like this format | |
| 17:51:51 | mriedem | puts mine to shame | |
| 17:51:54 | mriedem | damn you | |
| 17:53:34 | mriedem | rxtx factors, ha | |
| 17:53:49 | mriedem | didn't i see sfinucan trying to remove all of that? | |
| 17:55:22 | mriedem | or maybe that's a joke b/c rxtx factors would normally be an extra spec, but aren't | |
| 17:55:26 | mriedem | for whatever reason | |
| 17:57:13 | melwitt | dansmith: do you know what is the purpose of this stringify that puts extra quotes around a string? https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/fields.py#L269 | |
| 17:57:31 | sean-k-mooney | mriedem: aren't rx/tx factors more of a qos thing. e.g. sould they still exist now that neutron has a qos api | |
| 17:57:50 | mriedem | sean-k-mooney: they are only used for port qos yeah | |
| 17:58:04 | dansmith | melwitt: it's because that ends up in the repr, right? | |
| 17:58:20 | mriedem | sean-k-mooney: https://github.com/openstack/nova/blob/master/nova/network/neutronv2/api.py#L1088 | |
| 17:58:33 | mriedem | sean-k-mooney: that's the only place we ues them for neutron in nova | |
| 17:58:39 | mriedem | but they probably shouldn't be in nova | |
| 17:58:49 | melwitt | dansmith: yeah. I'm trying to wrap my head around this stuff for when a StringField contains a unicode thing. and I was wondering what the adding of the quotes around the StringField value does if it's already a string? | |
| 17:59:00 | mriedem | if you want qos on your port, create the port in neutron and provide it when creating the server | |
| 17:59:10 | melwitt | dansmith: I'm probably dumbly missing something here | |
| 17:59:13 | dansmith | melwitt: it's just for display | |
| 17:59:37 | dansmith | melwitt: so you end up with Instance<name="foo bar"> and not Instance<name=foo bar> | |
| 17:59:38 | sean-k-mooney | mriedem: so they were part of the old port qos support. i think this inclunces the libvirt xml generation somehow if i remember correctly | |
| 17:59:45 | melwitt | dansmith: right, okay. thank you | |
| 18:02:33 | mriedem | sean-k-mooney: i don't see that happening | |
| 18:03:20 | mriedem | sean-k-mooney: in fact the only place i see rxtx* in nova/virt is in the xenapi driver | |
| 18:03:33 | sean-k-mooney | ya im looking at the git repo currently and i cant find it either but i taguht it used too.. | |
| 18:03:36 | mriedem | and it's based on a flag that's only set if you're using nova-network | |
| 18:03:38 | sean-k-mooney | well its set here https://github.com/openstack/nova/blob/501a0fe65afabb7e6a8b1e2d1ca0fbcea941d2d1/nova/tests/unit/virt/libvirt/test_vif.py#L507 | |
| 18:03:45 | sean-k-mooney | but i dont know if its used | |
| 18:03:57 | mriedem | sean-k-mooney: that's just a flavor | |
| 18:04:02 | mriedem | the rxtx_factor is defined on the nova flavor | |
| 18:04:03 | sean-k-mooney | yes | |
| 18:04:20 | mriedem | we don't use that when plugging the vifs in libvirt though, or creating the domain xml, from what i can tell | |
| 18:04:38 | johnthetubaguy | mriedem: thats a rackspace special for quark | |
| 18:04:44 | johnthetubaguy | mriedem: AFAIK | |
| 18:04:48 | mriedem | it's probably time to deprecate rxtx_factor in our flavor api | |
| 18:04:59 | mriedem | and say if you need qos on ports, get it from neutron | |
| 18:05:09 | johnthetubaguy | mriedem: +1 that | |
| 18:05:42 | mriedem | sdague: jaypipes: dansmith: let's remember to put something in the onboarding session about "if you don't know why it's in nova, or what uses/used it, it's probably something to enable out of tree things for rackspace" | |
| 18:05:49 | mriedem | i need constant reminding of that | |
| 18:06:01 | sean-k-mooney | mriedem: ah look at https://docs.openstack.org/admin-guide/compute-flavors.html "this parameter is only available for Xen or NSX based systems." | |
| 18:06:39 | mriedem | sean-k-mooney: ha | |
| 18:06:41 | mriedem | nsx | |
| 18:06:46 | mriedem | the vmware driver doesn't use it | |
| 18:07:07 | mriedem | we should probably update the admin guide to basically say don't use that | |
| 18:07:29 | sean-k-mooney | mriedem: if you try to use that with nutons bandwith limit qos policies you will get consusing behavior | |
| 18:07:30 | mriedem | sean-k-mooney: this is the description from our compute api-ref: "The receive / transmit factor (as a float) that will be set on ports if the network backend supports the QOS extension. Otherwise it will be ignored. It defaults to 1.0." | |
| 18:07:54 | johnthetubaguy | mriedem: so here it is: https://github.com/openstack/nova/blob/cbbe486cd961e7f002c6e9ebdfdfa10527aa6b03/nova/network/manager.py#L551 | |
| 18:08:07 | mriedem | johnthetubaguy: yeah that's what got me to the xen driver | |
| 18:08:09 | mriedem | the rxtx_cap | |
| 18:08:13 | johnthetubaguy | yeah | |
| 18:09:11 | sean-k-mooney | is this code used only when nova networks is used? | |
| 18:09:32 | johnthetubaguy | mriedem: looks very nova-network only I think, given where that code lives. | |
| 18:10:11 | openstackgerrit | Matthew Treinish proposed openstack/nova master: Remove cloudpipe APIs https://review.openstack.org/459470 | |
| 18:10:13 | mtreinish | mriedem: ^^^ I added the missing release note | |
| 18:10:18 | sean-k-mooney | johnthetubaguy: mriedem so it can die with nova-networks in queens when cells v1 is removed | |
| 18:10:56 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: tests for non-shared with shared https://review.openstack.org/461899 | |
| 18:10:57 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: test non-shared out of inventory https://review.openstack.org/461900 | |
| 18:10:57 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: test for agg association not sharing https://review.openstack.org/461901 | |
| 18:10:58 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: shared resources when finding providers https://review.openstack.org/461574 | |
| 18:11:54 | mriedem | sean-k-mooney: no it's also used here for neutron https://github.com/openstack/nova/blob/501a0fe65afabb7e6a8b1e2d1ca0fbcea941d2d1/nova/network/neutronv2/api.py#L1087 | |
| 18:12:11 | mriedem | sean-k-mooney: but as you said, having a nova flavor override your qos settings from neutron is confusing at best | |
| 18:12:15 | mriedem | broken at worst | |
| 18:12:27 | mriedem | so in queens we should deprecate that field | |
| 18:12:36 | jaypipes | dansmith: separated _get_all_with_shared() into a module-level function per your request. ^^^ | |
| 18:12:57 | sean-k-mooney | mriedem: yes its prably best to have neutron be the only source of truth when it come to network qos | |
| 18:13:18 | sean-k-mooney | mriedem: have the quots/rate limits been removed form nova yet? | |
| 18:14:13 | mriedem | sean-k-mooney: the extra specs? | |
| 18:14:15 | mriedem | probably not | |
| 18:14:40 | sean-k-mooney | yes. i think they go hand in had with the rxtx_factor removal | |
| 18:14:55 | mriedem | note there is 0 contract on extra specs really | |
| 18:15:32 | jaypipes | and edleafe, I added a fun little ASCII diagram to (probably poorly) describe the "butterfly join" ;) | |
| 18:15:46 | sean-k-mooney | yes but if is reqst a max bandwith or min in neutron nova should proably not override it | |
| 18:16:26 | mriedem | sean-k-mooney: i don't disagree | |
| 18:16:30 | cfriesen | mriedem: thanks....I am going to be at the Summit, as will Steven Webster (our actual PCI guy) | |
| 18:17:29 | cfriesen | mriedem: reason I asked about the version was that we've got a weird case where one compute node is coming up after an upgrade with version 0 instead of version 9 | |
| 18:18:26 | jaypipes | rfolco: answered your question on that error patch :) | |
| 18:18:34 | jaypipes | rfolco: thanks much for hopping on that! | |