| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-28 | |||
| 13:56:48 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Don't delete allocation if instance being scheduled https://review.openstack.org/460177 | |
| 13:56:48 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Delete existing allocations for move operations or retries https://review.openstack.org/460433 | |
| 13:56:49 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add reserved_host_cpus option https://review.openstack.org/460113 | |
| 13:56:49 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: WIP: Allocate instance by the conductor https://review.openstack.org/460455 | |
| 13:57:09 | bauwser | leakypipes: mriedem: https://review.openstack.org/460113 is now with a reno file | |
| 13:58:26 | leakypipes | bauwser: +2 from me. thx for adding the reno. :) | |
| 13:58:50 | bauwser | leakypipes: and ty for adding the TODO note for the reserved value <3 | |
| 13:59:00 | leakypipes | :) np | |
| 13:59:28 | mriedem | leakypipes: you removed the ... :( | |
| 13:59:29 | openstackgerrit | Béla Vancsics proposed openstack/nova master: [WIP] Transform aggregate.update_metadata notification https://review.openstack.org/460625 | |
| 13:59:36 | mriedem | leakypipes: like, ...murder?! | |
| 14:01:33 | mriedem | leakypipes: https://review.openstack.org/#/c/457782/3/nova/virt/libvirt/driver.py | |
| 14:06:06 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: implement get_inventory() for libvirt https://review.openstack.org/457782 | |
| 14:06:06 | leakypipes | mriedem: sorry, fixed. | |
| 14:06:09 | leakypipes | ^ | |
| 14:08:25 | openstackgerrit | Stephen Finucane proposed openstack/nova master: trivial: Remove dead code https://review.openstack.org/460662 | |
| 14:08:54 | mriedem | bauwser: comments inline https://review.openstack.org/#/c/460113/ | |
| 14:09:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: Replace reserved_host_disk_mb with reserved_host_disk_gb https://review.openstack.org/460661 | |
| 14:09:08 | mriedem | bauwser: if you want to defer talking about the overheads stuff until we actually replace claims with allocations, that's fine | |
| 14:09:08 | openstackgerrit | Stephen Finucane proposed openstack/nova master: conf: Reword 'reserved_host_memory_mb' help text https://review.openstack.org/461054 | |
| 14:09:30 | bauwser | mriedem: jinx my mind | |
| 14:09:41 | bauwser | mriedem: I didn't wrote that for that reason | |
| 14:09:54 | bauwser | mriedem: adding that conf opt is separate from the use we could have for it | |
| 14:10:34 | bauwser | but given we don't use it now, it's unrelated, and either way both the 3 reserved opts need some doc string modifcation once we merge claims | |
| 14:10:44 | mriedem | leakypipes: https://review.openstack.org/#/c/457782/4/nova/tests/unit/virt/libvirt/test_driver.py :) | |
| 14:10:52 | mriedem | bauwser: true | |
| 14:11:23 | bauwser | mriedem: that said, very good point because I didn't changed that for the claims change | |
| 14:11:40 | bauwser | so you should leave a note for the top change | |
| 14:11:45 | mriedem | bauwser: throw a DocImpact on your claims change too so we get a docs bug | |
| 14:11:57 | bauwser | mriedem: fair to say | |
| 14:12:32 | sfinucan | melwitt: Could you have a look at mriedem's comments on this change? https://review.openstack.org/#/c/453174/2/releasenotes/notes/add-nova-manage-quota-commands-3ad1eb3186f9e29d.yaml | |
| 14:12:44 | mriedem | bauwser: left a comment | |
| 14:13:02 | bauwser | <3 | |
| 14:13:17 | mriedem | sfinucan: i've got a tattoo now that has a picture of melwitt telling me "s/quota/usage/" | |
| 14:13:20 | mriedem | literally scarred | |
| 14:13:27 | melwitt | lol | |
| 14:14:11 | melwitt | DID SOMEONE SAY QUOTAS >:| | |
| 14:14:20 | mriedem | ha | |
| 14:14:22 | mriedem | just like that | |
| 14:15:02 | melwitt | yeah, that has angry eyebrows on it | |
| 14:15:11 | mriedem | and a duck bill | |
| 14:16:52 | sfinucan | mriedem: can't argue with that. Thanks for reviewing those, btw | |
| 14:17:05 | sfinucan | mriedem: Seeing as you're at it, this one is the really interesting one -> https://review.openstack.org/#/c/453808/ | |
| 14:17:09 | sfinucan | ;) | |
| 14:17:14 | sfinucan | *a | |
| 14:17:23 | sfinucan | (they're all really interesting, naturally) | |
| 14:17:32 | mriedem | sfinucan: i glanced over that one last night | |
| 14:22:21 | sfinucan | bauwser: How does 'reserved_host_cpus' differ from 'vcpu_pin_set' https://review.openstack.org/#/c/460113/ | |
| 14:22:26 | sfinucan | outside of being less specific | |
| 14:22:42 | bauwser | sfinucan: well | |
| 14:23:15 | melwitt | sfinucan: I added a comment on the review | |
| 14:23:25 | sfinucan | melwitt: Cheers :) | |
| 14:24:20 | sfinucan | melwitt: I can't use underscore-separated command names (usage_refresh) with cliff :( | |
| 14:24:27 | sfinucan | see last comment on that patchset | |
| 14:24:30 | melwitt | sfinucan: even as the subcommand? oh | |
| 14:24:52 | sfinucan | nope. it's why I need to do this https://review.openstack.org/#/c/453809/ | |
| 14:24:58 | melwitt | I was thinking only the first command had that limitation | |
| 14:25:34 | sfinucan | Afraid so. You can switch off that behavior but it's all or nothing | |
| 14:26:16 | sfinucan | ...which would prevent us nesting commands entirely, which we can't do | |
| 14:26:23 | sfinucan | cliff is broken by design but the community won't listen to me and switch to click :P | |
| 14:27:06 | melwitt | okay. I guess our choices are refresh or usagerefresh then. I'm not too concerned about it since my quotas patch set removes that nova-manage command anyway, so meh | |
| 14:27:33 | mriedem | why wouldn't we just have: nova-manage usage refresh? | |
| 14:27:38 | mriedem | don't call the subcommand QuotaCommands | |
| 14:27:43 | mriedem | call it UsageCommands | |
| 14:28:02 | melwitt | it might be mysterious what kind of usage is it talking about | |
| 14:28:08 | melwitt | "usage of what" | |
| 14:28:13 | mriedem | that's part of the excitement | |
| 14:28:15 | mriedem | but yeah | |
| 14:28:25 | melwitt | +1 to excitement | |
| 14:28:31 | mriedem | nova-manage quota usage_refresh then | |
| 14:28:37 | mriedem | or you can't _? | |
| 14:28:41 | melwitt | he said we can't have any underscores anywhere | |
| 14:28:52 | mriedem | we have nova-manage api_db | |
| 14:29:07 | mriedem | nova-manage quota_usage refresh? | |
| 14:29:08 | melwitt | he has a patch up to make that apidb https://review.openstack.org/#/c/453809/ | |
| 14:29:21 | mriedem | gdi, the whole world is upside down | |
| 14:29:31 | melwitt | yeah | |
| 14:29:48 | mriedem | when EmilienM and every other deployment tooling person comes screaming, i'm pointing them all at sfinucan | |
| 14:29:55 | melwitt | hah yup | |
| 14:30:02 | EmilienM | hey hi | |
| 14:30:06 | melwitt | it's all your fault sfinucan :) | |
| 14:30:11 | mriedem | but EmilienM, sfinucan wanted to use click! | |
| 14:30:14 | EmilienM | you'll notice I didn't complain for a while | |
| 14:30:22 | mriedem | EmilienM: that's only because you don't care anymore | |
| 14:30:28 | EmilienM | no, it's because things work | |
| 14:30:34 | mriedem | we can fix that | |
| 14:30:55 | EmilienM | :) | |
| 14:36:42 | sfinucan | melwitt, mriedem: So, what's your poison? 'usage refresh' or 'quotas refresh' | |
| 14:36:51 | sfinucan | I'm pretty sure we can't do camel case either | |
| 14:36:59 | bauwser | mriedem: so, seeing https://review.openstack.org/#/c/457577/1 and its cherry-picks, we can easily fix the problem like that ? | |
| 14:37:01 | sfinucan | I could do 'quotausage' but that's ugly | |
| 14:37:36 | sfinucan | mriedem: maybe the deployment guys will like the shiny new (auto-generated) man pages though? :) | |
| 14:37:41 | melwitt | sfinucan: commenting on the review, I think the choices are effectively 'quota usagerefresh' or 'quota refresh' and I'm not too opinionated about it bc it's going to be removed soon as part of the quota counting stuff I'm doing | |
| 14:38:14 | sfinucan | melwitt: Ooh, that's happening this cycle right? Could I just deprecate the whole command instead? | |
| 14:38:53 | sfinucan | "this particular commands *isn't* accessibly via the API, but it won't be used soon so we're deprecating it too" | |
| 14:39:06 | sfinucan | s/accessibly/accessible/ | |
| 14:39:37 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: implement get_inventory() for libvirt https://review.openstack.org/457782 | |
| 14:39:40 | leakypipes | mriedem: sigh :) fixed ^ | |
| 14:40:27 | melwitt | sfinucan: yeah. if deprecate == remove, I guess I'd be wary of going that far because we can't 100% guarantee when quota counting will get merged and any time lag there would be a gap in the command not being available | |
| 14:40:33 | mriedem | bauwser: i took pause with it too, and there wasn't discussion from alex_xu or sdague in the change, | |