Posted	Nick	Remark
#openstack-nova - 2017-04-27
20:46:52	sdague	mriedem: looking
20:47:20	sdague	mriedem: bam!
20:48:06	mriedem	thanks
20:48:31	mriedem	did you see the easter egg i put in there for you?
20:55:05	mriedem	nova meeting in #openstack-meeting in 5 minutes
20:56:54	dansmith	mriedem: I'm going to skip the nova meeting today.. feeling crappy and doing a few other things
20:57:05	dansmith	mriedem: I think you can fill everyone in on the extensive discussions at the cells meeting, right?
20:57:12	mriedem	god i hope so
20:58:14	abhi89	melwitt: I will trying doing what you have told. Thanks for your input..
21:00:35	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/460515
21:03:57	openstackgerrit	Steve Noyes proposed openstack/nova master: Add Cinder v3 detach to shutdown_instance https://review.openstack.org/456877
21:56:34	mriedem	hferenc: gibi: blasted the ML :)
22:43:40	mriedem	mtreinish: some easy stuff to fix up in https://review.openstack.org/#/c/459460
23:15:32	Kevin_Zheng	mriedem: hi, for https://review.openstack.org/#/c/459569 , the assertion fails now, I think it is not what we expected?
23:16:48	mtreinish	mriedem: so on the pokicy bits, I tried to delete them before but a bunch of testing started complaining there was no policy for the endpoint
23:17:07	mtreinish	s/pokicy/policy/
23:23:06	openstackgerrit	Matthew Treinish proposed openstack/nova master: Remove nova-cert https://review.openstack.org/459460
23:23:46	mtreinish	mriedem: ^^^
23:31:55	mriedem	mtreinish: probably some policy test to see that all apis have policy registered,
23:32:09	mriedem	but i'd think we could remove that for os-certificates as we don't actually use the policy
23:33:34	mriedem	Kevin_Zheng: you mean this right? http://logs.openstack.org/69/459569/6/check/gate-nova-python27-ubuntu-xenial/3f13311/console.html#_2017-04-27_07_11_57_717635
23:35:19	mriedem	Kevin_Zheng: maybe rather than assert equality, which might not be implemented for ObjectListBase.__eq__, assert the length is the same, is 1, and the single tag between both is the same
23:35:22	Kevin_Zheng	yeah
23:35:23	mtreinish	mriedem: ok, I'll look at that tomorrow, or later tonight
23:35:50	Kevin_Zheng	mriedem: ok, got it
23:36:15	mriedem	Kevin_Zheng: yeah it doesn't implement __eq__ https://github.com/openstack/oslo.versionedobjects/blob/master/oslo_versionedobjects/base.py#L778
23:36:34	mriedem	mtreinish: you must be getting soft in your old age
23:38:39	mtreinish	mriedem: heh, that must be it
23:43:24	openstackgerrit	Chris Friesen proposed openstack/python-novaclient master: 2.46: Show flavor info in server details https://review.openstack.org/435141
23:43:59	cfriesen	mriedem: what's the story on needing functional tests for this ^ ? I noticed that the last couple of changes you made in novaclient had no function tests.
23:45:31	mriedem	cfriesen: do as i say, not as i do
23:46:00	mriedem	cfriesen: we'll likely want functional tests for those since it's a new microversion that changes the output
23:46:19	mriedem	cfriesen: 2.43 and 2.44 were just deprecations, so i think unit tests were sufficient
23:46:34	mriedem	and 2.45 wasn't changing output really, it was handling the response differently
23:47:24	mriedem	when you have to mess with the fixture stuff too much it gets weird https://review.openstack.org/#/c/435141/5/novaclient/tests/unit/fixture_data/servers.py
23:49:16	mriedem	cfriesen: but it looks like you did a lot of work with the fixture stuff already, and i'm probably not going to dig through all of that code tonight
23:49:33	mriedem	i've got a mother in law en route
23:54:22	cfriesen	mriedem: kay, I'll give it a shot
23:56:50	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add ability to query for ComputeNodes by their mapped value https://review.openstack.org/427902
23:56:50	openstackgerrit	Matt Riedemann proposed openstack/nova master: Make discover_hosts only query for unmapped ComputeNode records https://review.openstack.org/427903
23:56:51	openstackgerrit	Matt Riedemann proposed openstack/nova master: Add ComputeNode.mapped field https://review.openstack.org/427901
#openstack-nova - 2017-04-28
00:25:51	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.46 - Enable cold migration with target host https://review.openstack.org/406707
00:25:59	openstackgerrit	Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.46 - List/Show all server migration types https://review.openstack.org/430839
01:22:20	openstackgerrit	Jay Pipes proposed openstack/nova master: placement: get providers sharing capacity https://review.openstack.org/460798
01:22:28	jaypipes	alex_xu, mriedem, dansmith, edleafe, bauzas: ^^
01:22:46	jaypipes	more of dansmith's favourite SQL-fu.
01:25:27	openstackgerrit	Matthew Treinish proposed openstack/nova master: Remove nova-cert https://review.openstack.org/459460
01:46:37	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Avoid forcing translation on logging calls https://review.openstack.org/413876
01:46:46	openstackgerrit	Takashi NATSUME proposed openstack/nova master: api-ref: Fix examples for add/removeFixedIp action https://review.openstack.org/456053
01:46:57	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Refactor a test method including 7 test cases https://review.openstack.org/395436
02:04:10	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(2/4) https://review.openstack.org/459569
02:06:49	openstackgerrit	Dao Cong Tien proposed openstack/nova master: Stop using mox int unit/virt/xenapi/image/test_utils.py https://review.openstack.org/342626
02:10:11	openstackgerrit	Kiseok Kim proposed openstack/nova master: Fixed a broken link in API Plugins document https://review.openstack.org/460398
02:28:10	openstackgerrit	Matthew Treinish proposed openstack/nova master: Remove nova-cert https://review.openstack.org/459460
03:25:52	mriedem	jaypipes: ok hon
03:25:58	mriedem	jaypipes: it's gonna have to be tomorrow at this point
03:26:06	mriedem	but i did get your libvirt get_inventory patch reviewed today
03:26:08	mriedem	with gusto!
03:27:37	openstackgerrit	jichenjc proposed openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/460813
04:03:31	openstackgerrit	jichenjc proposed openstack/nova master: Use plain routes list for os-services endpoint instead of stevedore https://review.openstack.org/460818
04:06:33	openstackgerrit	jichenjc proposed openstack/nova master: Use plain routes list for limits endpoint instead of stevedore https://review.openstack.org/460813
04:16:00	openstackgerrit	jichenjc proposed openstack/nova master: e plain routes list for os-simple-tenant-usage https://review.openstack.org/460821
04:23:50	openstackgerrit	jichenjc proposed openstack/nova master: use plain routes list for os-simple-tenant-usage https://review.openstack.org/460821
04:26:28	openstackgerrit	jichenjc proposed openstack/nova master: Use plain routes list for os-certificates endpoint instead of stevedore https://review.openstack.org/460813
05:15:37	openstackgerrit	jichenjc proposed openstack/nova master: Use plain routes list for os-services endpoint instead of stevedore https://review.openstack.org/460818
06:04:01	openstackgerrit	jichenjc proposed openstack/nova master: Use plain routes list for os-certificates endpoint instead of stevedore https://review.openstack.org/460813
06:08:20	openstackgerrit	jichenjc proposed openstack/nova master: Use plain routes list for os-certificates endpoint instead of stevedore https://review.openstack.org/460813
06:11:42	openstackgerrit	jichenjc proposed openstack/nova master: use plain routes list for os-simple-tenant-usage https://review.openstack.org/460821
06:47:48	openstackgerrit	Takashi NATSUME proposed openstack/nova-specs master: Amend the "list-show-all-server-migration-types" spec https://review.openstack.org/460847
07:40:43	openstackgerrit	Takashi NATSUME proposed openstack/nova master: api-ref: Fix unnecessary description in servers-admin-action https://review.openstack.org/460866
07:54:50	openstackgerrit	Takashi NATSUME proposed openstack/nova master: WIP: Specify keymap on server boot (1/2) https://review.openstack.org/458752
08:49:46	slaweq_	hello, I have a question about old Juno release of Nova
08:50:12	slaweq_	I'm investigating why pci_device connected to instance is "duplicated" during migration
08:50:37	slaweq_	I found that it's probably because of lazy loading of pci_devices attribute in instance object
08:51:04	slaweq_	do You maybe know if there was such bug in Juno, maybe it's already fixed in newer releases? :)
09:05:35	openstackgerrit	jichenjc proposed openstack/nova master: Trivial fix: fix broken links https://review.openstack.org/460883
09:06:55	openstackgerrit	Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot(3/4) https://review.openstack.org/459593
10:36:13	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-manage: Deprecate 'log' commands https://review.openstack.org/453176
10:36:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-manage: Deprecate 'project', 'account' commands https://review.openstack.org/453174
10:36:14	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-manage: Deprecate 'host' commands https://review.openstack.org/453175
10:36:15	openstackgerrit	Stephen Finucane proposed openstack/nova master: nova-manage: Deprecate 'agent' commands https://review.openstack.org/450795
10:37:20	sfinucan	sdague: Could you take a look at those (and the other two patches in the series) at some point, please? ^
10:40:07	openstackgerrit	Lee Yarwood proposed openstack/nova master: libvirt: Attach and detach encryptors during swap_volume https://review.openstack.org/460244
10:49:48	openstackgerrit	Stephen Finucane proposed openstack/nova master: Remove flavor-rxtx policy https://review.openstack.org/444036
10:50:56	sfinucan	alex_xu: Could you take a look at https://review.openstack.org/#/c/444036, please? Would like to know if there's any reason to keep a separate policy for an API extension around (I don't think so)
10:53:40	johnthetubaguy	sfinucan: I would rather we deprecate that kind of thing, people could be using that
10:54:09	sfinucan	johnthetubaguy: The policy or the API endpoint?
10:55:02	sfinucan	If the former, have we a procedure for deprecating API policies? I was following the precedent of https://review.openstack.org/#/c/459608 and just removing them
10:56:00	johnthetubaguy	sfinucan: thats different to one that actually has a really effect
10:56:05	johnthetubaguy	real
10:56:52	sfinucan	I'm still trying to parse how that extension works, but I don't think it has
10:57:22	johnthetubaguy	sfinucan: it leaks information to the user about the rxtx limits on a given flavor
10:57:27	sfinucan	All the API samples for flavors-detail etc. show a 'rxtx_factor' parameter
10:57:33	sfinucan	e.g. doc/api_samples/flavors/flavors-detail-resp.json
10:57:36	johnthetubaguy	sfinucan: or rather you can hide that limit from the user
10:57:48	johnthetubaguy	sfinucan: correct, the default policy allows you to see that
10:58:09	sfinucan	ah, so if we defaulted to false those API samples would need to be updated
10:58:39	johnthetubaguy	sfinucan: I believe so
10:59:23	johnthetubaguy	sfinucan: its in the change: https://review.openstack.org/#/c/444036/13/nova/api/openstack/compute/flavor_rxtx.py
11:00:54	johnthetubaguy	sfinucan: now there is a slightly stupid thing, there is nothing in tree that actually uses that property, AFAIK

Earlier   Later