Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-04-26
15:22:54 mordred efried: so basically the parameters you need to create an adapter are the same parameters you need to find an endpoint from the service catalog
15:23:30 mordred and if we add them there, then we can just re-use that method ot register the right opts in all the places we want to let nova users put in all of the different filters
15:23:39 mordred (similar to how we use register_session_opts now)
15:24:04 efried mordred I dig it. Can you point me to something in the keystone source that'll give me a hint as to how an "adapter" differs from a "session" or an "auth"?
15:24:17 mriedem swebster: see my comment in https://review.openstack.org/#/c/453938/2/nova/network/neutronv2/api.py after the fact - can you push a small change to update that code comment block for the migration = None case?
15:24:26 mordred one could also make the argument that an load_adapter_from_opts would be a nice equivilent method ot keystoneauth that we could use in the places we want just a plain keystoneuath REST interface
15:24:28 openstackgerrit Gábor Antal proposed openstack/nova master: [WIP] Transform instance.live_migration_rollback notification https://review.openstack.org/402124
15:24:33 mordred efried: absolutely! one sec ...
15:25:09 swebster mriedem: no problem, will do
15:25:37 mordred efried: so - if you start from here: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/__init__.py#L31-L32
15:25:46 efried mordred And next question: Where do I propose changes? review.openstack.org via https://git.openstack.org/openstack/keystoneauth ?
15:26:13 efried mordred Yuh, found that, and saw how it was being used by other groups (cinder, ironic).
15:26:18 mordred efried: you can see this: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/loading/session.py
15:26:37 mordred so I believe what would be wanted is a similar keystoneauth1/loading/adapter.py
15:27:25 mordred the actual adapter code is here: https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/adapter.py - which lists the different adapter constructor params - I'm not sure all of those need to be conf options though
15:28:16 mordred efried: I'd say for your purposes, https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/adapter.py#L32-L37 are the ones that want conf options
15:28:56 efried mordred Except service_name, which people thought was useless?
15:29:07 mordred https://github.com/openstack/keystoneauth/blob/master/keystoneauth1/adapter.py#L38 is useful once you're actually calling get_endpoint - but I think that's a different nova-level thing not a conf option
15:29:43 mordred efried: yes - I do wish service_name would diaf, but I think also johnthetubaguy made a good point mentioning it - just because I don't like it doesn't mean that people out there may not have used it for something
15:30:18 mordred efried: for instance, in the infra account for rackspace public cloud, there actually used to be 2 entries for "compute" - because of history with pre-openstack rackspace
15:30:25 mordred and we had to use service_name to get it to pick the right one
15:30:44 mordred so if we're adding the conf_options to keystoneauth, we might as well be complete :)
15:30:59 efried mordred Fair enough.
15:31:31 efried mordred At a glance here, I would need to have the union of [session opts] with these adapter opts, right?
15:31:36 openstackgerrit Gábor Antal proposed openstack/nova master: [WIP] Transform instance.live_migration_rollback notification https://review.openstack.org/402124
15:31:36 mordred efried: fwiw, I recently wrote a spec: https://review.openstack.org/#/c/459405/ - which explains this entire thing in excruciating detail
15:31:51 efried ooo
15:31:54 mordred in case you've ever wanted to learn _WAY_ more about what's going on here than any human should know
15:31:58 efried That'll be helpful.
15:32:09 cdent "explains"
15:32:34 mordred efried: yah - each service grouping needs the session opts and the adapter opts in order to fully desscribe how to connect to a service
15:32:56 mordred efried: the sesion opts obvs go to the Session, and then the adapter opts are how the service endpoint is found
15:32:59 mordred cdent: :)
15:33:09 mordred cdent: ooh! you made reviews for me - I'm excited
15:33:22 cdent mordred: i'm afraid they are disappointingly short
15:34:01 swebster mriedem: do you recommend updating that existing review, or should I start a new branch/review for the comment change? Since the original change already got merged
15:34:04 efried mordred I believe I understand. This is just what I was looking for. Ima have questions for you later about os-client-config (once you get out of cdent-land)
15:34:24 cdent Yay! I have a land, how do I get there?
15:35:03 efried cdent Take the red pill
15:35:39 mriedem swebster: the existing review is merged
15:35:46 mriedem so it has to be new
15:35:51 jbernard mriedem: im not sure either
15:35:59 swebster mriedem: thx
15:36:02 mriedem jbernard: i pushed a rev of the d-g change with tracing
15:36:04 jbernard mriedem: ahh, you added a recheck, thanks
15:36:28 jbernard mriedem: something unrelated appears to have merged, the graph is not looking good this morning
15:37:48 mordred efried: cool - let's definitely chat later about the occ things - I'll ping when I'm done with the next round of updates on this spec
15:38:08 efried mordred Roger wilco, and thanks.
15:38:16 mordred cdent: one of your feedbacks brings up a thing that morgan had mentioned too and I came up with a good idea for making it better - so while short, they are helpful!
15:38:54 jbernard mriedem: http://logs.openstack.org/32/459832/1/check/gate-tempest-dsvm-full-devstack-plugin-ceph-ubuntu-xenial/85d7f13/console.html#_2017-04-26_14_11_03_609997
15:39:02 jbernard mriedem: looks like maybe it's being skipped over
15:39:24 mriedem artom: why not also setting capabilities for vmware and ironic drivers in https://review.openstack.org/#/c/415520/29 ?
15:40:05 efried Is it a done thing to refer to a nova blueprint from another project? (For these keystoneauth changes, I would be referring to https://blueprints.launchpad.net/nova/+spec/use-service-catalog-for-endpoints, which is listed under project nova)
15:40:21 efried Would the blueprint have to be tagged to be registered under keystone as well, and approved there?
15:40:23 mriedem jbernard: oh
15:40:24 mriedem {plugin-repo}
15:40:27 mriedem rather than ${plugin-repo}
15:40:53 artom mriedem, err, whoops. Not sure why that happened
15:41:09 mriedem artom: let me just -1 you right here real quick...
15:41:11 openstackgerrit Sylvain Bauza proposed openstack/nova master: WIP: Don't delete allocation if instance being scheduled https://review.openstack.org/460177
15:41:19 artom mriedem, fair
15:41:42 mriedem artom: although if the compute manager or whatever is checking that flag just does a .get('foo', False) that would be fine too
15:41:44 jbernard mriedem: i thought the $ was not needed in yaml
15:41:49 morgan mordred: ++
15:41:51 mriedem jbernard: i'm in bash
15:41:51 bauzas mriedem: POC above for the discussion we had https://review.openstack.org/460177
15:42:08 mriedem jbernard: i mean this is d-g which is bash
15:42:33 artom mriedem, that would be smarter, yes - though I think the precedent is to *not* do that
15:42:56 jbernard mriedem: ooooh, in the wrapper
15:43:05 mriedem artom: maybe not, it's less explicit i guess, idk
15:43:07 artom Maybe we need a has_capability in the generic virt driver, which then check the capabilities dict in the smart way
15:43:19 artom As opposed to overriding everything everttime
15:43:21 openstackgerrit Mikhail Feoktistov proposed openstack/nova master: Add is_vz_container function https://review.openstack.org/445947
15:43:44 mriedem encoding a default in the compute manager does duplicate the defaults, which kind of sucks
15:43:49 mriedem but i don't think those things ever change
15:44:21 mriedem apparently efried and the powervm driver aren't even cool enough yet to override capabilities
15:44:47 artom Default in the manager? I meant manager -> driver.has_capability('foo') -> return self.capabilities.get('foo', <default>)
15:45:00 efried mriedem That was changed per YOUR review comment, nah?
15:45:00 mriedem and no that's not an invitation to tell me to review whichever powervm patch adds capabilities overrides
15:45:30 mriedem artom: meh
15:45:35 mriedem artom: we're over thinking this i think
15:45:59 artom *shrug* it'd be a net improvement, no matter how small ;)
15:46:11 artom But it can be done separately
15:46:22 mriedem i agree with doing it separately
15:50:24 mriedem johnthetubaguy: we should be good to go here https://review.openstack.org/#/c/456896/
15:50:45 mriedem johnthetubaguy: we're going to need to find a 3rd sucker, i mean core, to help review the new cinder api changes if i'm going to be contributing to the series
15:52:16 johnthetubaguy mriedem: cool, I will take a peak at that now
15:52:17 cdent bauzas: left a comment on your WIP that I wanted to be sure you didn't miss since your -W
15:53:59 stackempty hola .. does anyone know if something like this is already available https://specs.openstack.org/openstack/nova-specs/specs/newton/approved/flavor-root-disk-none.html
15:54:17 mriedem stackempty: you've just stepped into something
15:55:02 mriedem stackempty: see http://lists.openstack.org/pipermail/openstack-dev/2017-February/113063.html
15:55:08 mriedem the "Enable Cinder as an ephemeral storage backend for Nova" part
15:56:16 mriedem stackempty: if you're going to be at the forum https://www.openstack.org/summit/boston-2017/summit-schedule/events/18738/using-cinder-for-nova-ephemeral-storage-backend?BackURL=https%3A%2F%2Fwww.openstack.org%2Fsummit%2Fboston-2017%2Fsummit-schedule%2Fglobal-search%3Ft%3DRiedemann%23eventid%3D18738
15:56:25 sfinucan jaypipes, johnthetubaguy: I'm going to add a 'reserved_host_disk_gb' option if that makes sense?
15:56:34 sfinucan to resolves the TODOs in https://review.openstack.org/#/c/457782/2/nova/scheduler/client/report.py
15:57:05 mriedem "It would be better to claim disk in MB, but that is hard now."
15:57:39 mriedem i don't see that changing anytime soon
15:57:45 mriedem claiming disk in mb vs gb i mean
15:57:59 mriedem stackempty: so the answer is not yet,
15:58:09 mriedem stackempty: that feature from that spec never landed and was abandoned,

Earlier   Later