| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-26 | |||
| 13:07:13 | sdague | sfinucan: yeh, though is that going to destroy intentional formatting? | |
| 13:07:34 | kashyap | sfinucan: That, too! | |
| 13:07:37 | sfinucan | i.e. Wenn ich krank bin, | |
| 13:07:39 | sfinucan | ... | |
| 13:07:54 | sfinucan | yada yada random guttural words | |
| 13:07:55 | sdague | I feel like we went around in circles here before on oslo.config where force rewrapping is not always the answer | |
| 13:08:20 | sfinucan | sdague: It would if we're doing things like bullet points | |
| 13:08:28 | sdague | yeh | |
| 13:08:43 | sdague | which are often useful | |
| 13:08:49 | sfinucan | but I didn't spot any of those during my reviews so I _think_ we're good here | |
| 13:08:55 | sdague | right, yet :) | |
| 13:09:12 | sdague | yeh, we should be ok for now, but I am sure it will show up as a desire | |
| 13:09:20 | sfinucan | Well, hopefully by time that happens we'll be using the oslo.policy version | |
| 13:09:25 | sfinucan | then it's their problem | |
| 13:09:55 | sdague | so, out of curiosity, what was the key issue with the wrapping? was it losing 2 columns to the comment? | |
| 13:10:07 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged nic attachment https://review.openstack.org/415622 | |
| 13:10:08 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete nic metadata when detaching interface https://review.openstack.org/435387 | |
| 13:10:10 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged volume attachment https://review.openstack.org/418100 | |
| 13:10:12 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Delete disk metadata when detaching volume https://review.openstack.org/435082 | |
| 13:10:17 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: API support for tagged device attachment https://review.openstack.org/376021 | |
| 13:10:17 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Plumbing for tagged volume attachment https://review.openstack.org/391941 | |
| 13:10:19 | openstackgerrit | Artom Lifshitz proposed openstack/nova master: Libvirt support for tagged nic attachment https://review.openstack.org/415520 | |
| 13:10:22 | sfinucan | Pretty much, yeah | |
| 13:11:10 | sfinucan | and the outputter was presumably doing a dumb, N char wrap | |
| 13:11:43 | sfinucan | artom: Anything new in those or simple resolution of that merge conflict | |
| 13:11:44 | sfinucan | ? | |
| 13:11:50 | openstackgerrit | Daniel Pawlik proposed openstack/nova master: Added kvm_hidden feature https://review.openstack.org/459753 | |
| 13:15:08 | artom | sfinucan, rebase and api version bump because something else took 2.43, 2.44 and 2.45 | |
| 13:16:04 | artom | dansmith, mriedem, actually, since sfinucan brought it up, can you take a look at that series? Rebasing it with a new API version is a pain, I would greatly appreciate if we could merge before I have to version bump again :) | |
| 13:16:07 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402 | |
| 13:18:16 | mriedem | artom: is the tempest test passing? | |
| 13:19:08 | artom | mriedem, well, not right this instant, but yes, I got it to pass by waiting for the default cache expiry duration | |
| 13:20:54 | sean-k-mooney | sfinucan: ya the readme change makes sense to me | |
| 13:21:40 | sean-k-mooney | i have +2ed the review but ill hold off on the +W untill the gate jobs have run | |
| 13:22:18 | sean-k-mooney | i want to make sure the embeeded image render corretly but the rst files look fine | |
| 13:23:14 | sfinucan | sean-k-mooney: There's an embedded image? | |
| 13:23:20 | sfinucan | oh - the pypi badge | |
| 13:23:23 | sfinucan | Cool :) | |
| 13:23:41 | sean-k-mooney | yep the pypi ones | |
| 13:23:42 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | |
| 13:24:07 | efried | sdague mriedem ^^ trivial (but manual) rebase FYI. | |
| 13:25:18 | sean-k-mooney | sfinucan: wait https://review.openstack.org/#/c/398277/ was merged? | |
| 13:25:27 | sean-k-mooney | has the code landed in ovs yet? | |
| 13:25:35 | sean-k-mooney | if not this should not have been merged | |
| 13:25:51 | artom | mriedem, I'll ping you again when I have the latest code passing ;) | |
| 13:25:59 | sfinucan | sean-k-mooney: I thought the same thing, hence https://review.openstack.org/#/c/460093/ | |
| 13:26:32 | sfinucan | I think we might have jumped the gun a tad bit on that one | |
| 13:26:57 | sean-k-mooney | sfinucan: ya actully thats the review i just saw and was like why are you fixing something thats not merged | |
| 13:27:12 | sfinucan | Should we revert or use the docs to suggest "this might not work" | |
| 13:27:18 | sean-k-mooney | sfinucan: i guess jay didnt see that it was still pending in ovs | |
| 13:28:02 | sean-k-mooney | i would lean towards revert but lets ask jay and moshe | |
| 13:28:16 | sfinucan | jaypipes, moshele? ^ | |
| 13:28:32 | sean-k-mooney | jaypipes: moshele https://review.openstack.org/#/c/398277/ was merged before the ovs support? | |
| 13:29:56 | sean-k-mooney | jaypipes: moshele should we revert or merge sfinucan docs change to reflect that this wont work untill support is added to ovs 2.8 | |
| 13:30:14 | sfinucan | sean-k-mooney: OVS 2.8 _tentative_ | |
| 13:30:16 | sfinucan | ;) | |
| 13:31:14 | sean-k-mooney | sfinucan: yes im aware which is why i was a little concered that we merged support for something that may or may not be in the next release of ovs | |
| 13:33:04 | sean-k-mooney | ok got to run to a meeting but ya assuming the bages render correctly the readme change looks good. | |
| 13:33:40 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: 2.45: createImage/createBackup image_id is in response body https://review.openstack.org/457008 | |
| 13:35:26 | mriedem | alex_xu: we don't use api_versions.wraps on shell commands in https://review.openstack.org/#/c/459496/ or the one after it | |
| 13:37:36 | jaypipes | sean-k-mooney: :( sorry guys, I missed that. | |
| 13:37:51 | jaypipes | sean-k-mooney: will it be a problem, though, until we cut a new os-vif release?\ | |
| 13:37:59 | jaypipes | sfinucan: ^^ | |
| 13:38:58 | alex_xu | mriedem: emm...I remember we use that before, for example https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/shell.py#L2279 | |
| 13:39:29 | mriedem | alex_xu: i think that's just to handle the behavior change, not to indicate deprecation | |
| 13:42:10 | jaypipes | dansmith, mriedem: super-friendly reminder on https://review.openstack.org/#/c/457782/ :) others (alex_xu, sfinucan, bauzas, cdent, edleafe) feel free to peruse as well. | |
| 13:42:52 | openstack | Launchpad bug 1662650 in neutron "[RFE] Advance configuration of SR-IOV ports- api extension" [Wishlist,Triaged] - Assigned to Trevor McCasland (twm2016) | |
| 13:42:52 | jaypipes | sfinucan, sean-k-mooney: either of you seen this? https://bugs.launchpad.net/neutron/+bug/1662650 | |
| 13:42:54 | mriedem | ack | |
| 13:43:31 | bauzas | jaypipes: count me in for reviews | |
| 13:43:51 | dansmith | jaypipes: yep, got it open | |
| 13:44:28 | mdbooth | dansmith: Just reviewing your https://review.openstack.org/#/c/458634/ and noticed it's collected a merge conflict. | |
| 13:44:32 | mdbooth | Want me to push the fix? | |
| 13:44:40 | jaypipes | sfinucan, sean-k-mooney: as kevinbenton says 'it's basically just "pipe this bag of flags to the SR-IOV nic"'. it's probably worth getting familiar with what AT&T is attempting to do there and do it right in os-vif? | |
| 13:45:03 | jaypipes | dansmith, mriedem, bauzas: cheers. | |
| 13:45:13 | dansmith | mdbooth: I have a change to one of the patches on top of that, so I'll do it | |
| 13:45:20 | mdbooth | dansmith: k | |
| 13:47:53 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.soft_delete notifications https://review.openstack.org/460029 | |
| 13:48:13 | mdbooth | dansmith: Incidentally, I was trying to write a tcl upvar style test which poisoned the local variable passed to target_cell in the parent stack frame, but it seems writing to locals() in cpython doesn't do anything under most circumstances. | |
| 13:48:46 | dansmith | mdbooth: oh man, I haven't thought about tcl in forever | |
| 13:49:01 | mdbooth | dansmith: I mostly try not to :) | |
| 13:49:07 | mdbooth | It was my first commercial language | |
| 13:49:11 | dansmith | heh | |
| 13:49:35 | dansmith | it was my advisor's favorite language, so I wrote a bunch of stuff in it in college, but.. I barely remember any of it | |
| 13:49:37 | mdbooth | upvar was the worst, but I thought I'd actually found a niche for it | |
| 13:49:38 | dansmith | still have a book | |
| 13:50:10 | jaypipes | I could never used a programming language named "Tickle". | |
| 13:50:41 | mdbooth | jaypipes: It's as good as any reason | |
| 13:50:47 | jaypipes | :) | |
| 13:50:57 | mriedem | yet you watch flubber every friday night | |
| 13:50:59 | mriedem | religiously | |
| 13:51:35 | jaypipes | lmao | |
| 13:51:47 | jaypipes | mriedem: shh, don't tell anyone that./ | |
| 13:51:52 | mriedem | sorry | |
| 13:53:21 | openstackgerrit | Sylvain Bauza proposed openstack/nova master: Add reserved_host_cpus option https://review.openstack.org/460113 | |
| 13:54:25 | sfinucan | jaypipes: RE: "will it be a problem, though, until we cut a new os-vif release?" I guess it won't be, but do we want our next release to hinge on "has this feature landed in OVS"? | |
| 13:54:42 | sfinucan | there's also the chance that the feature won't land/will be different | |
| 13:54:49 | sfinucan | unlikely, in fairness, but possible | |
| 13:54:57 | jaypipes | sfinucan: le sigh... sorry, didn't realize that was the case :( | |
| 13:55:03 | jaypipes | sfinucan: k, revert it then. | |