Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-04-20
20:03:17 dansmith that yeah
20:03:27 mriedem it appears it's ok except for something with cells 1
20:03:35 mriedem which i haven't debugged yet
20:03:54 dansmith okay, that's a different block than I'm working on right?
20:04:05 mriedem that whole block was written before https://review.openstack.org/#/c/367557/
20:04:06 mriedem yes
20:04:17 mriedem ^ is what deletes the instance in conductor
20:04:23 mriedem if the build request is gone
20:04:41 mriedem and that code likely suffers from the same quota/local delete mess that _delete handles
20:04:48 mriedem i.e. we do the same gd local delete thing in 3 places
20:04:50 dansmith okay, I'm confused
20:06:11 dansmith I don't think we can remove the targeting dance that does different things with the instance and the quota stuff, until the patches I have below this that avoid mutating the context, right?
20:06:26 mriedem i haven't seen your patches yet
20:06:27 mriedem so idk
20:06:41 mriedem but that's why i didn't dig into removing the context dance yet
20:06:53 mriedem that's why i started with https://review.openstack.org/#/c/455007/
20:06:55 dansmith right, so I guess Idon't understand the "oh come on" comment :)
20:07:05 mriedem since there was a big fat note in there about removing it after we deleted the instance in conducto
20:07:28 mriedem "oh come on" as in i thought we were doing the same thing, before i actually looked at your change
20:07:32 mriedem beyond the commit title
20:07:33 mriedem sucka
20:08:01 mriedem we are trying to converge on the same thing though - which is cleanup the 3-headed local delete monster we have
20:08:33 dansmith ...okay
20:08:39 mriedem or not
20:23:13 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598
20:23:56 efried edmondsw ^^ Done and done. Thanks for the review.
20:34:13 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598
20:35:09 mriedem are we going to be backporting this? https://review.openstack.org/#/c/456397/
20:35:11 mriedem dansmith: ^?
20:35:31 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: power_on/off and reboot https://review.openstack.org/427380
20:36:26 openstackgerrit Matt Riedemann proposed openstack/python-novaclient master: 2.43: createImage/createBackup image_id is in response body https://review.openstack.org/457008
20:42:25 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #3: TaskFlow https://review.openstack.org/438729
20:49:46 cfriesen any libvirt experts here? apparently libvirt doesn't like "cache=writethrough io=native" for a disk, but I don't see nova being aware of this. (We hit the issue by trying to use a disk with only 4K blocks, so it failed the direct-io test and set a cache mode of "writethrough")
20:52:58 openstackgerrit Matt Riedemann proposed openstack/nova master: 2.43: Remove Location header from createImage and createBackup responses https://review.openstack.org/455443
20:52:58 openstackgerrit Matt Riedemann proposed openstack/nova master: api-ref: move createBackup to server-actions https://review.openstack.org/452971
20:54:09 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288
20:54:10 cfriesen second question...if we have a disk with 4K blocks and no 512B fallback, and we use "cache=none", does the guest need to be able to handle 4KB blocks or does qemu handle that?
20:54:34 cfriesen I realize it's not really a nova question...but I thought there might be folks on here who've run into it.
21:04:27 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598
21:14:02 mriedem efried: i hope you were done making changes to that patch
21:14:15 efried mriedem Which 'un?
21:14:21 mriedem https://review.openstack.org/438598
21:14:45 efried mriedem I certainly hope so too ;-)
21:14:47 efried Thanks!
21:44:17 mriedem easy patches in need of a +W https://review.openstack.org/#/q/topic:bump-min-libvirt+status:open
21:46:11 dansmith mriedem: yeah we shoud, you want me to?
21:46:15 dansmith *should
21:46:47 mriedem dansmith: sure
21:49:35 dansmith mriedem: https://review.openstack.org/#/q/Ia7e773674a4976fc03deee3f08a6ddb45568ec11,n,z
21:52:24 mriedem ooo and you didn't even go lazy and backport both via the master change using gerrit
21:52:32 mriedem you knew i'd check that
21:53:01 mriedem +2s all around
21:53:48 dansmith I didn't
21:53:53 dansmith I just never use the gerrit ui for much of anything
21:53:59 dansmith 'cause I don't trust it
21:54:20 mriedem i have the gerrit ui do my taxes and travel planning
21:54:26 dansmith heh
21:59:59 efried I always trust the gerrit UI to do rebases & cherry-picks when it's able. Until now. It just broke me.
22:02:01 clarkb fwiw you shouldn't really need gerrit to do rebases for you
22:02:14 clarkb it can't resolve conflicts and thats the only time rebases should be necessary
22:02:45 efried clarkb Unless you're dealing with a stack of changes.
22:03:01 clarkb oh I always curate the stack locally
22:03:41 efried clarkb When it's a trivial rebase, I like the two-clicks-on-gerrit rather than the multi-step download/rebase/upload. All that extra typing!
22:04:07 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288
22:05:03 efried 'cept ^^ where it effed up.
22:05:30 clarkb right I mean rather than push just a parent change in a stack then clicking buttons I will push the entire stack to avoid pushing any buttons
22:06:45 efried clarkb I dig it.
22:08:45 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402
22:22:28 mriedem always rebase an entire stack locally
22:22:34 mriedem unless you're crazy
22:28:49 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189
22:34:50 mriedem efried: https://review.openstack.org/#/c/427380/ failed powervm in-tree ci
22:34:55 mriedem error: could not apply fb15915... PowerVM Driver: spawn/destroy #3: TaskFlow
22:35:28 mriedem you need to rebase that change don't you?
23:08:05 openstackgerrit christopher.uhler proposed openstack/nova master: Libvirt volume driver for Veritas HyperScale https://review.openstack.org/443951
23:11:02 mriedem smcginnis: what is https://www.openstack.org/summit/boston-2017/summit-schedule/events/18681/track-chairs-recap-and-discussion ?
23:38:03 openstackgerrit Matt Riedemann proposed openstack/nova master: Using max api version in notification sample test https://review.openstack.org/443686
23:38:04 openstackgerrit Matt Riedemann proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185
23:38:05 openstackgerrit Matt Riedemann proposed openstack/nova master: add tags field to instance.update notification https://review.openstack.org/407228
23:39:32 mriedem gibi: for your morning coffee, the rebuild notifications in this change have duplicate entries for auto_disk_config https://review.openstack.org/#/c/419185/21/doc/notification_samples/instance-rebuild-end.json
23:41:45 mriedem maybe just a carried over typo
23:47:23 openstackgerrit Matt Riedemann proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185
23:48:40 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.43 - Enable cold migration with target host https://review.openstack.org/406707
23:48:55 openstackgerrit Takashi NATSUME proposed openstack/python-novaclient master: Microversion 2.43 - List/Show all server migration types https://review.openstack.org/430839
#openstack-nova - 2017-04-21
00:09:17 openstackgerrit Sean Dague proposed openstack/nova master: PowerVM Driver: power_on/off and reboot https://review.openstack.org/427380
01:43:18 openstackgerrit Huan Xie proposed openstack/nova master: WIP: XenAPI use os-xenapi v2 in nova https://review.openstack.org/453493
02:04:28 chatter29 hey guys
02:04:31 chatter29 allah is doing
02:04:37 chatter29 sun is not doing allah is doing
02:04:39 chatter29 to accept Islam say that i bear witness that there is no deity worthy of worship except Allah and Muhammad peace be upon him is his slave and messenger
02:23:23 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters in servers-action-console-output https://review.openstack.org/458713
02:24:01 openstackgerrit Lei Zhang proposed openstack/nova master: Add sync traits command for placement https://review.openstack.org/450125
03:00:30 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Use 'note' directive https://review.openstack.org/458717
03:15:30 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Explicitly define enum type as string in schema https://review.openstack.org/456430
03:21:33 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot https://review.openstack.org/394321
04:19:18 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers-actions (2/4) https://review.openstack.org/455568
04:19:35 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers-actions (3/4) https://review.openstack.org/455570
04:19:58 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers-actions (4/4) https://review.openstack.org/455573
04:20:16 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers-actions.inc https://review.openstack.org/454565
05:53:45 openstackgerrit Alex Xu proposed openstack/python-novaclient master: Add `instance-uuid` flag to the migration-list https://review.openstack.org/458728

Earlier   Later