| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-19 | |||
| 18:23:05 | dansmith | I think she's got it so it can count inefficiently without placement | |
| 18:23:06 | dansmith | iirc | |
| 18:23:24 | mriedem | alright | |
| 18:23:25 | dansmith | we really can't miss landing this this cycle, so whatever makes the most sense time-wise I guess | |
| 18:23:29 | mriedem | i wanted something easier to review | |
| 18:23:40 | melwitt | sorry peeps | |
| 18:23:41 | mriedem | oh we can miss it | |
| 18:23:48 | mriedem | we can miss it real good | |
| 18:28:37 | hypothermic_cat | lyarwood: mriedem: johnthetubaguy: this one for the new detach flow is ready for review: https://review.openstack.org/#/c/438750/ | |
| 18:28:45 | hypothermic_cat | I will add it to the etherpad too | |
| 18:29:25 | mriedem | ok | |
| 18:29:46 | mriedem | hypothermic_cat: doesn't the commit message need updating? | |
| 18:31:30 | hypothermic_cat | mriedem: bah, yes, that should be too :) | |
| 18:31:42 | mriedem | let me go through the rest first | |
| 18:31:54 | hypothermic_cat | mriedem: or well, actually I updated it | |
| 18:32:07 | mriedem | "for each case of terminate_connection" is wrong | |
| 18:32:45 | hypothermic_cat | mriedem: but I can remove the "overview" part from it as it seems to be confusing | |
| 18:33:14 | mriedem | yeah, just don't change anything yet | |
| 18:39:17 | mriedem | hypothermic_cat: there you go, comments inline | |
| 18:41:35 | mriedem | hypothermic_cat: i'm confused about the changes, are they not in a series? | |
| 18:42:14 | mriedem | you're going to have conflicts if those aren't done in a series | |
| 18:42:19 | hypothermic_cat | mriedem: I tried not to have a like 8 patches long series to be able to get more hands on the code, etc | |
| 18:42:25 | hypothermic_cat | mriedem: that's a pain to maintain | |
| 18:42:31 | mriedem | conflicts aren't fun either | |
| 18:42:48 | hypothermic_cat | these are small changes there won't be that much conflict | |
| 18:42:59 | hypothermic_cat | I have a few that have a common base | |
| 18:43:12 | mriedem | ok i was thinking more about the crud operations in nova/volume/cinder.py | |
| 18:43:25 | mriedem | those are common and should be at the bottom of the series | |
| 18:43:36 | hypothermic_cat | if we can get the base in then there's at least two IIRC that can be independent from the rest for instance | |
| 18:44:00 | hypothermic_cat | mriedem: those are only in this base detach patch right now | |
| 18:44:31 | mriedem | ok i asked for the attachment_update one to be split out of that change | |
| 18:44:34 | mriedem | until it's used | |
| 18:44:36 | hypothermic_cat | mriedem: I should've marked the other as WIP, will do that a bit later | |
| 18:44:40 | mriedem | which is why i figured things were in a series | |
| 18:45:18 | hypothermic_cat | hmm, I think we don't even use that right now, so I might simply need to delete it | |
| 18:45:29 | hypothermic_cat | as we have delete and create for things like swap | |
| 20:18:25 | openstackgerrit | Feodor Tersin proposed openstack/nova master: libvirt: Use config types to parse XML for instance disks https://review.openstack.org/410667 | |
| 20:18:26 | openstackgerrit | Feodor Tersin proposed openstack/nova master: libvirt: Use config types to parse XML for root disk https://review.openstack.org/411941 | |
| 20:18:26 | openstackgerrit | Feodor Tersin proposed openstack/nova master: libvirt: Add missing tests for utils.find_disk https://review.openstack.org/414750 | |
| 20:18:43 | jaypipes | mriedem, dansmith: any chance either of you would be able to review https://review.openstack.org/#/c/448282/ and series? :) | |
| 20:19:45 | dansmith | jaypipes: like you're looking for odds or what? | |
| 20:19:49 | dansmith | I'd say about 33% | |
| 20:20:18 | jaypipes | dansmith: fair enough :) | |
| 20:21:55 | mriedem | jaypipes: once i get my state of the union for pike-1 email done | |
| 20:22:14 | jaypipes | cheers | |
| 20:28:31 | dansmith | jaypipes: say yes to my comment on the bottom patch and I will approve | |
| 20:29:52 | jaypipes | dansmith: you mean like this? https://github.com/openstack/os-traits/blob/master/os_traits/__init__.py#L27 | |
| 20:30:18 | dansmith | jaypipes: but accessible from the command line | |
| 20:30:36 | jaypipes | dansmith: sure I can add that. | |
| 20:30:37 | dansmith | maybe just make this do it: "python -mos_traits" | |
| 20:31:00 | jaypipes | dansmith: yep, I can add a patch that does that. | |
| 20:31:30 | dansmith | jaypipes: ack, +W | |
| 20:31:34 | jaypipes | cheers | |
| 20:32:55 | openstackgerrit | Steve Noyes proposed openstack/nova master: Update detach to use V3 Cinder API https://review.openstack.org/438750 | |
| 20:42:15 | dansmith | vladikr: still around? | |
| 20:42:28 | dansmith | vladikr: can you look over this and see if there's anything missing from this that we should add? https://review.openstack.org/#/c/448283/4 | |
| 20:43:01 | vladikr | dansmith, sure, looking | |
| 20:52:56 | hypothermic_cat | mriedem: update posted, hope it looks better now | |
| 20:58:13 | mriedem | hypothermic_cat: ok | |
| 21:00:58 | vladikr | dansmith, seems fine overall. sriov VFs can be also "trusted" by it's PF. This will allow it to set a custom mac and enter promiscuous mode | |
| 21:02:00 | vladikr | dansmith, perhaps it should state the function (virtual/physical)? | |
| 21:02:14 | dansmith | vladikr: I'm in another meeting, but can you just comment on the review? | |
| 21:02:22 | vladikr | sure | |
| 21:02:26 | dansmith | thanks | |
| 21:06:12 | cburgess | Does the libvirt LXC driver still work? or is that dead-ish code? | |
| 21:19:19 | flwang | mriedem: ping | |
| 21:24:10 | openstackgerrit | Jon Bernard proposed openstack/nova master: Add tempest-dsvm-ceph-rc https://review.openstack.org/456292 | |
| 21:25:40 | mriedem | cburgess: hard to say, we have a job in the experimental queue for it, but it's never been passing - it might be better now on the kernel in 16.04 though, i think the last time i looked at it, there were kernel issues with trusty | |
| 21:25:42 | mriedem | flwang: pong | |
| 21:25:57 | cburgess | mriedem Ew ok | |
| 21:26:06 | flwang | mriedem: may i get your comments on this spec https://review.openstack.org/#/c/190919/ ? | |
| 21:26:24 | flwang | especially if nova is still happy to keep the 'backup' function | |
| 21:27:16 | flwang | mriedem: Paul Murray commented it's not really necessary to backup a volume-backed instance, may i know your opinions? thanks | |
| 21:28:23 | flwang | mriedem: i revisited this spec because i got an email yesterday asked me why I gave up this patch, which means it's useful i think | |
| 21:31:20 | efried | jaypipes mriedem mordred How does a guy get "the" ServiceCatalog initially? I can find APIs to ask keystone for endpoint URLs, but presumably that goes to keystone every time, and we want to load up the service catalog just once. | |
| 21:31:21 | melwitt | dansmith: I replied to your comment on the quota review. I'm not sure what to make of the Quotas object. I used it as a place to do the api/main db straddle because no other place made sense, but it's not a true object like the others | |
| 21:32:28 | mordred | efried: it actually doesn't go to keystone every time | |
| 21:32:37 | jaypipes | efried: check out the code that starts here: https://github.com/openstack/nova/blob/master/nova/scheduler/client/report.py#L195-L198 | |
| 21:32:58 | mordred | efried: the keystoneauth functoins to ask for endpoint urls all work from the catalog - unless they need to do version discovery because of what you requested | |
| 21:33:07 | mordred | if they do need to do version discovery, that is cached | |
| 21:33:30 | mordred | and yes- what jaypipes pasted is a good code example | |
| 21:33:30 | efried | mordred Okay, so I can really just use endpoint URL APIs. | |
| 21:33:32 | mordred | yes | |
| 21:33:53 | mordred | you, in fact, _should_ use the endpoint url apis - definitely don't try to do it yourself :) | |
| 21:34:10 | efried | neat. | |
| 21:35:21 | dansmith | melwitt: do those methods need to be remoted? | |
| 21:36:48 | melwitt | dansmith: I'm not sure. I thought the already existing update_limit and create_limit were that these should be too | |
| 21:37:08 | melwitt | *because the already existing | |
| 21:37:17 | dansmith | melwitt: are they ever called from compute? that's the reason they'd need to be remotable | |
| 21:37:21 | cfriesen | Hi folks...nova.virt.libvirt.driver.LibvirtDriver._supports_direct_io() checks whether we can mmap a 512-byte aligned block. How is this supposed to work with disks with 4K sectors? | |
| 21:37:26 | dansmith | since we're moving them to the api, I'd tend to thing not | |
| 21:37:54 | dansmith | melwitt: the problem is returning an unversioned dict from a supposedly-versioned ovo method | |
| 21:38:15 | dansmith | melwitt: those are all expected to, in almost all cases, return a class of the object, unless they return nothing | |
| 21:38:16 | jaypipes | cfriesen: probably good to just update the code to check the block size of the local disk before that mmap check. | |
| 21:38:24 | mriedem | cked instances) | |
| 21:38:24 | mriedem | flwang: i think paul's comments and questions are valid, i.e. you do backups for persistence of ephemeral disk, but if you're using volumes you already have persistence, and as john pointed out it's really an orchestration API that nova has been trying to pull away from, because we do orchestration API poorly in general (think boot from volume where nova creates a new volume, or the shelve API which is mostly broken for volum | |
| 21:38:24 | melwitt | hm. I think in the nova-network case compute would read limits for fixed ips | |
| 21:38:37 | mriedem | flwang: so i don't have great interest in adding support to the backup api personally | |
| 21:39:08 | cfriesen | jaypipes: I was wondering if we could just unconditionally switch to 4K | |
| 21:39:25 | flwang | mriedem: ok, got it. then i may stop putting more effort on that. thanks for the comments | |