Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-04-19
16:21:18 rfolco cdent, that helped. Thanks.
16:21:42 melwitt dansmith: you don't know ... harry potter??
16:21:48 cdent rfolco: add me to the review(s) when stuff's ready please, so I can be sure to look at them and also to add them to the weekly email
16:21:55 dansmith melwitt: never seen it
16:22:01 melwitt omg
16:22:14 bauzas melwitt: seriously, he doesn't loose a lot
16:22:17 dansmith melwitt: well, I watched five minutes of it, and couldn't handle it
16:22:35 dansmith LOTR and harry potter, I just can't stomach
16:22:49 bauzas dansmith: dammit, the platform 9 3/4 was shown at 10 mins after the beginning
16:22:58 dansmith oh well :)
16:24:10 bauzas either way, I have to change my glasses this week
16:24:23 bauzas so probably I'll review better
16:25:56 dansmith bauzas: in my defense, the tests did add a cell, but I neglected to create the instance in the new cell, so .. I intended to have coverage to prove I was doing the right thing, I just failed.. twice
16:35:52 openstackgerrit melanie witt proposed openstack/nova master: Mock timeout in test__get_node_console_with_reset_wait_timeout https://review.openstack.org/458161
16:37:32 mriedem dansmith: is this for the server groups thing?
16:37:41 dansmith yeah
16:38:13 mriedem could just write a functional test instead,
16:38:21 mriedem i'm finding that's easier with some of the api driven stuff and multi-cell
16:38:43 dansmith mriedem: this one is basically functional.. uses the actual db
16:38:57 dansmith mriedem: it didn't catch it because I made the same mistake in the test as the code
16:45:10 melwitt mriedem: I wonder if there's a bug in the backoff looping timer, it doesn't make sense that it wouldn't time out at all
16:45:34 melwitt it's supposed to end early if the backoff would put it over the specified timeout
16:46:14 openstackgerrit Dan Smith proposed openstack/nova master: Make server groups api aware of multiple cells for membership https://review.openstack.org/457338
16:46:15 openstackgerrit Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487
16:46:15 openstackgerrit Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174
16:46:18 openstackgerrit Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736
16:46:21 mriedem melwitt: i didn't dig into how the jitter stuff works in there
16:46:41 melwitt yeah. I'm looking at it out of curiosity
16:46:50 mriedem melwitt: i figured maybe there was a bug in the fake stub method logic
16:47:00 mriedem but didn't dig into it
16:47:06 melwitt hm, yeah
16:47:32 melwitt I was thinking we shouldn't be doing real timeouts anyway, but it doesn't make sense that it wouldn't time out that way too
16:50:24 openstackgerrit Feodor Tersin proposed openstack/nova master: Implement ScaleIO image backend https://review.openstack.org/407440
16:53:50 openstackgerrit Matt Riedemann proposed openstack/nova-specs master: Fix typo in deprecate-os-hosts spec https://review.openstack.org/458165
17:13:45 dansmith gdi py35
17:41:16 openstackgerrit Matt Riedemann proposed openstack/nova master: Deprecate os-hosts API https://review.openstack.org/456504
17:41:29 mriedem ^ is doctastic
17:54:42 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/458185
17:56:29 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/451049
18:12:54 openstackgerrit Steve Noyes proposed openstack/nova master: Add Cinder V3 Detach calls https://review.openstack.org/438750
18:19:19 dansmith I see melwitt pushed up the revised quotapalooza
18:19:44 dansmith I'm glad, but also sad, 'cause now we have to review it
18:21:06 mriedem i think my afternoon just got busy with something else...
18:22:44 mriedem do we want/need to get the placement usages API stuff in first?
18:22:49 mriedem before counting quotas?
18:23:05 dansmith I think she's got it so it can count inefficiently without placement
18:23:06 dansmith iirc
18:23:24 mriedem alright
18:23:25 dansmith we really can't miss landing this this cycle, so whatever makes the most sense time-wise I guess
18:23:29 mriedem i wanted something easier to review
18:23:40 melwitt sorry peeps
18:23:41 mriedem oh we can miss it
18:23:48 mriedem we can miss it real good
18:28:37 hypothermic_cat lyarwood: mriedem: johnthetubaguy: this one for the new detach flow is ready for review: https://review.openstack.org/#/c/438750/
18:28:45 hypothermic_cat I will add it to the etherpad too
18:29:25 mriedem ok
18:29:46 mriedem hypothermic_cat: doesn't the commit message need updating?
18:31:30 hypothermic_cat mriedem: bah, yes, that should be too :)
18:31:42 mriedem let me go through the rest first
18:31:54 hypothermic_cat mriedem: or well, actually I updated it
18:32:07 mriedem "for each case of terminate_connection" is wrong
18:32:45 hypothermic_cat mriedem: but I can remove the "overview" part from it as it seems to be confusing
18:33:14 mriedem yeah, just don't change anything yet
18:39:17 mriedem hypothermic_cat: there you go, comments inline
18:41:35 mriedem hypothermic_cat: i'm confused about the changes, are they not in a series?
18:42:14 mriedem you're going to have conflicts if those aren't done in a series
18:42:19 hypothermic_cat mriedem: I tried not to have a like 8 patches long series to be able to get more hands on the code, etc
18:42:25 hypothermic_cat mriedem: that's a pain to maintain
18:42:31 mriedem conflicts aren't fun either
18:42:48 hypothermic_cat these are small changes there won't be that much conflict
18:42:59 hypothermic_cat I have a few that have a common base
18:43:12 mriedem ok i was thinking more about the crud operations in nova/volume/cinder.py
18:43:25 mriedem those are common and should be at the bottom of the series
18:43:36 hypothermic_cat if we can get the base in then there's at least two IIRC that can be independent from the rest for instance
18:44:00 hypothermic_cat mriedem: those are only in this base detach patch right now
18:44:31 mriedem ok i asked for the attachment_update one to be split out of that change
18:44:34 mriedem until it's used
18:44:36 hypothermic_cat mriedem: I should've marked the other as WIP, will do that a bit later
18:44:40 mriedem which is why i figured things were in a series
18:45:18 hypothermic_cat hmm, I think we don't even use that right now, so I might simply need to delete it
18:45:29 hypothermic_cat as we have delete and create for things like swap
20:18:25 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Use config types to parse XML for instance disks https://review.openstack.org/410667
20:18:26 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Use config types to parse XML for root disk https://review.openstack.org/411941
20:18:26 openstackgerrit Feodor Tersin proposed openstack/nova master: libvirt: Add missing tests for utils.find_disk https://review.openstack.org/414750
20:18:43 jaypipes mriedem, dansmith: any chance either of you would be able to review https://review.openstack.org/#/c/448282/ and series? :)
20:19:45 dansmith jaypipes: like you're looking for odds or what?
20:19:49 dansmith I'd say about 33%
20:20:18 jaypipes dansmith: fair enough :)
20:21:55 mriedem jaypipes: once i get my state of the union for pike-1 email done
20:22:14 jaypipes cheers
20:28:31 dansmith jaypipes: say yes to my comment on the bottom patch and I will approve
20:29:52 jaypipes dansmith: you mean like this? https://github.com/openstack/os-traits/blob/master/os_traits/__init__.py#L27
20:30:18 dansmith jaypipes: but accessible from the command line
20:30:36 jaypipes dansmith: sure I can add that.
20:30:37 dansmith maybe just make this do it: "python -mos_traits"
20:31:00 jaypipes dansmith: yep, I can add a patch that does that.
20:31:30 dansmith jaypipes: ack, +W
20:31:34 jaypipes cheers
20:32:55 openstackgerrit Steve Noyes proposed openstack/nova master: Update detach to use V3 Cinder API https://review.openstack.org/438750
20:42:15 dansmith vladikr: still around?

Earlier   Later