Posted	Nick	Remark
#openstack-nova - 2017-04-12
09:03:34	Dinesh_Bhor	alaski: I can see your ML thread: http://lists.openstack.org/pipermail/openstack-dev/2015-June/067996.html
09:09:46	johnthetubaguy	Dinesh_Bhor: can I help with context?
09:10:06	gibi	mgagne: I left some comment in the spec https://review.openstack.org/#/c/453272/
09:10:24	johnthetubaguy	Dinesh_Bhor: we allow custom scheduler filters and weighers, they can have their own hints, if we blocked those in the API, it would break things. Does that help?
09:11:12	openstackgerrit	赵明俊 proposed openstack/nova master: [BugFix] Check the instance task status to release the memory quota for vram https://review.openstack.org/456050
09:11:32	openstackgerrit	Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for DELETE RP inventory https://review.openstack.org/455215
09:11:33	openstackgerrit	Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for GET RP inventory https://review.openstack.org/455213
09:11:33	openstackgerrit	Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for PUT RP inventory https://review.openstack.org/455214
09:11:34	openstackgerrit	Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for DELETE RP inventories https://review.openstack.org/452708
09:13:43	openstackgerrit	Béla Vancsics proposed openstack/nova master: Transform instance.resize_confirm notification https://review.openstack.org/390654
09:16:34	openstackgerrit	Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for DELETE RP inventory https://review.openstack.org/455215
09:16:35	openstackgerrit	Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for GET RP inventory https://review.openstack.org/455213
09:16:35	openstackgerrit	Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for PUT RP inventory https://review.openstack.org/455214
09:17:33	alex_xu	Dinesh_Bhor: johnthetubaguy yea, we relax that strict validation, so it already fixed
09:18:16	johnthetubaguy	alex_xu: +1 thats fixed a while back, not sure what the question was really
09:19:06	Dinesh_Bhor	alex_xu, johnthetubaguy: ok, understood. One more question if any user tries to pass invalid custom scheduler hint then is it the job of nova to handle it correctly?
09:19:25	openstackgerrit	Stephen Finucane proposed openstack/nova-specs master: doc: Remove crud from Sphinx conf.py https://review.openstack.org/456129
09:19:25	openstackgerrit	Stephen Finucane proposed openstack/nova-specs master: Mitigate 'no "man_pages" config value' error https://review.openstack.org/456128
09:20:04	Dinesh_Bhor	invalid means in wrong format. I mean actually I passed '{"os:scheduler_hints": {"key": null}'
09:20:34	Dinesh_Bhor	alex_xu, johnthetubaguy: ^^ which caused ValueError at a-api
09:20:36	alex_xu	Dinesh_Bhor: it is open for custom scheduler, your custom filter will handle the invalid hint
09:24:47	alex_xu	Dinesh_Bhor: that is kind of thing should be fixed
09:25:37	alex_xu	Dinesh_Bhor: we should limit the input for hints is string
09:27:17	Dinesh_Bhor	alex_xu: ok, understood, thanks
09:28:04	alex_xu	johnthetubaguy Dinesh_Bhor : the requestspec break the API a little, it limits the schedule hints to string
09:28:43	johnthetubaguy	limiting to a string seems reasonable
09:29:00	johnthetubaguy	longer term, I we need the registration system we spoke about before
09:30:34	alex_xu	?
09:30:34	alex_xu	johnthetubaguy: longer term, the scheduler hints will be removed? I guess placement won't support that
09:30:35	johnthetubaguy	alex_xu: not sure myself, I can see the scheduler bit always living in Nova and having hints
09:30:50	johnthetubaguy	alex_xu: I am unclear there, what I mean it, nova still picks the "best" of the possible hosts placement says
09:30:59	alex_xu	johnthetubaguy: I guess scheduler bits always living Nova for some filters can be implemented by placement?
09:31:17	alex_xu	s/can be/can't be/
09:31:18	johnthetubaguy	alex_xu: maybe, yeah
09:31:36	johnthetubaguy	I guess it needs a better name
09:31:37	johnthetubaguy	"preference engine" maybe?
09:31:49	alex_xu	:)
09:37:35	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add description to policies in security_groups.py https://review.openstack.org/452309
09:38:45	openstackgerrit	Jens Rosenboom proposed openstack/nova master: Fix network metadata information - part 2/3 https://review.openstack.org/450212
09:53:47	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Add description to policies in hypervisors.py https://review.openstack.org/451294
10:13:36	openstackgerrit	Lee Yarwood proposed openstack/nova-specs master: Libvirt: Native LUKS file and host device decryption by QEMU https://review.openstack.org/437070
10:14:47	lyarwood	kashyap: ^ updated, just noticed that I didn't call out the lack of support for network volumes so feel free to -1 if you think that's required
10:16:12	kashyap	lyarwood: Will look in a few
10:55:08	openstackgerrit	Takashi NATSUME proposed openstack/nova-specs master: List/show all server migration types https://review.openstack.org/407237
11:00:51	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: Remove check_detach https://review.openstack.org/446671
11:26:31	openstackgerrit	Ildiko Vancsa proposed openstack/nova master: Add Cinder V3 Detach calls https://review.openstack.org/438750
11:28:20	openstackgerrit	Andrey Volkov proposed openstack/nova master: [WIP] [placement] Add api-ref resource provider https://review.openstack.org/456176
11:49:14	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/455960
12:13:44	openstackgerrit	Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257
12:23:26	openstackgerrit	Andrey Volkov proposed openstack/nova master: [placement] Fix placement-api-ref check tool https://review.openstack.org/456198
12:25:07	openstackgerrit	Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for PUT RP inventory https://review.openstack.org/455214
12:25:07	openstackgerrit	Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for DELETE RP inventory https://review.openstack.org/455215
12:25:08	openstackgerrit	Andrey Volkov proposed openstack/nova master: [WIP] [placement] Add api-ref resource provider https://review.openstack.org/456176
12:34:45	sfinucan	sdague: When we deprecate an API in a microversion, does there come a point where we can delete all the code behind it?
12:35:27	sfinucan	for example, is the deprecated nova-network API code still in the code base but not exercised?
12:35:43	sfinucan	alex_xu: You might be able to answer that for me too ^ :)
12:36:49	mriedem	sfinucan: nova-network is still used for cells v1
12:36:58	sdague	sfinucan: nova-net is kind of a special case
12:37:04	mriedem	sfinucan: also, we deprecate an api at a microversion so things don't work at that microversion or later, but 2.1 still works
12:37:48	sfinucan	mriedem: Right, but what about for other APIs. Would we ever delete the code behind the APIs you'd like to deprecate this cycle, e.g. os-hosts?
12:38:35	sfinucan	I imagine we can't because then microversion {version before deprecation} wouldn't respond the same way
12:38:52	sfinucan	...but, if so, what's the point of deprecating anything if we can't eventually remove the code
12:39:33	sdague	you deprecate things as well to signal folks not to use that bit because it's not well maintained
12:41:24	sfinucan	sdague: but crucially we had to keep that code ad infinitum and keep testing it?
12:43:12	openstackgerrit	Stephen Finucane proposed openstack/nova master: Fix network metadata information - part 3/3 https://review.openstack.org/450297
12:47:55	openstackgerrit	dane-fichter proposed openstack/nova master: Remove backend dependency for key types https://review.openstack.org/456204
12:47:57	mriedem	sfinucan: if we ever start raising required minimums,
12:48:02	mriedem	then we could delete some older code
12:48:12	mriedem	sfinucan: ironic wants to do that, and i think it's going to be discussed at the forum
12:49:31	sfinucan	mriedem: Ohhh, now that you mention it I do recall that being discussed at...the PTG (?) Thanks for the info :)
12:50:40	dane-fichter	mriedem: pushed a fix for that cursive bug
12:50:59	dane-fichter	mriedem: do we need to do the same for the hash algs too?
12:51:03	sfinucan	johnthetubaguy: As our (my) resident "is reno required" expert - thoughts on https://review.openstack.org/#/c/450211 ?
12:51:57	mriedem	dane-fichter: comments in https://review.openstack.org/#/c/456204/1
12:52:14	johnthetubaguy	sfinucan: that looks like a breaking API change, so feels like users will need a heads up about that
12:52:38	frickler	johnthetubaguy: sfinucan: reno for all three patches is in the final one: https://review.openstack.org/#/c/450297/3
12:53:10	sfinucan	frickler: Aha - I didn't spot that :) Thanks for the heads up
12:53:26	johnthetubaguy	sfinucan: I find it hard to review anything in the metadata right now, due to the general poor testing around that whole thing
12:53:35	frickler	sfinucan: added it for you after your earlier review ;)
12:53:55	sfinucan	johnthetubaguy: Aye, that's on my backlog of things to do this cycle
12:55:04	johnthetubaguy	sfinucan: that looks like an API change without a spec, the reno covers the details I guess...
12:55:24	frickler	sfinucan: not sure the W+1 on the first patch is intentional? doesn't seem to fit with your -1 review
12:55:25	alex_xu	sfinucan: yea, as mriedem said, we can raise the min version of microversion. but we won't raise the min version easily
12:55:36	sfinucan	johnthetubaguy: Think there's a spec required?
12:55:42	sfinucan	dammit
12:55:44	alex_xu	nova api meeting is in 5 mins at #openstack-meeting-4
12:55:51	openstackgerrit	Stephen Finucane proposed openstack/nova master: Fix network metadata information - part 1/3 https://review.openstack.org/450211
12:56:21	openstackgerrit	Stephen Finucane proposed openstack/nova master: Fix network metadata information - part 2/3 https://review.openstack.org/450212
12:56:27	johnthetubaguy	sfinucan: I duno, that would be my default take for an API change, just so we have agreement on the change, we did talk about adding this in a new metadata version only
12:56:33	openstackgerrit	Stephen Finucane proposed openstack/nova master: Fix network metadata information - part 3/3 https://review.openstack.org/450297
12:57:09	mriedem	the release note makes it sound like the changes are additive, but yeah it's hard when we don't test the thing and it's an unversioned json blob
12:59:17	johnthetubaguy	frickler: its a good change, don't get me wrong, just getting my head around protecting the folks that relay on the old behaviour in some way
13:00:07	sfinucan	Yeah, the changes to the metadata API are all additive (by design, from the looks of things)
13:00:16	sfinucan	I don't personally think a spec is necessary for this but I'll leave that to others to decide
13:00:36	moreless_	I have some error in my nova log files, I think it is crediterncails problem but I am not sure if it is my username and password or authentication mechanism it says it is using "AMQPLAIN" is it how it should be?
13:00:48	alex_xu	nova api meeting is running
13:01:26	frickler	well, the third one isn't, it changes the type ipv6_dhcp so something else, but then nobody IMO can be using it in a reasonable way currently, else the change wouldn't be necessary
13:02:11	mriedem	frickler: i'd probably ask clarkb, mordred, jroll and mgagne to take a look at the changes
13:02:31	mriedem	mgagne was recently updating the nw metadata json in an old spec that introduced it, so i know he cares
13:03:06	mordred	frickler: we definitey care - but we'd LOVE for it to be something sane

Earlier   Later