| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-11 | |||
| 21:52:50 | mriedem | but not nullable | |
| 21:53:14 | mriedem | aggregate uuid is nullable=False, but not read-only https://github.com/openstack/nova/blob/master/nova/objects/aggregate.py#L244 | |
| 21:53:34 | dansmith | yeah | |
| 21:53:48 | dansmith | there was a reason for the agg one not being read-only | |
| 21:53:56 | mriedem | so should be nullable=False and read_only=True? | |
| 21:54:17 | dansmith | tbh, just make it nullable=False (i.e. don't specify it) | |
| 21:54:22 | dansmith | the readonly has been problematic recently, | |
| 21:54:25 | mriedem | ok | |
| 21:54:37 | dansmith | so I'd leave that off, which is why it is in aggregate | |
| 21:57:11 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598 | |
| 21:57:35 | efried | mriedem ^^ back atcha. | |
| 21:58:01 | efried | Still a couple uncertainties inline. | |
| 21:59:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add online data migration for populating services.uuid https://review.openstack.org/454899 | |
| 21:59:26 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add uuid to Service model https://review.openstack.org/453025 | |
| 22:36:03 | mriedem | mgagne: http://lists.openstack.org/pipermail/openstack-dev/2017-April/115292.html | |
| 22:37:03 | mriedem | browne: efried: BobBall: would be good to check out https://review.openstack.org/#/c/453272/ and see if vmware, powervm and xen drivers can support this API eventually | |
| 22:37:08 | mgagne | mriedem: Thanks for starting the conversation and doing proper follow up | |
| 22:37:11 | mriedem | claudiub: you too but i think hyperv already does | |
| 22:38:09 | mriedem | mgagne: does the cinder extend volume api have a confirm / reject state like nova resize does? | |
| 22:38:39 | mgagne | mriedem: cinder doesn't have this confirmation system | |
| 22:39:27 | mgagne | mriedem: as you mention, there are pending questions: capabilities from virt driver. But also error handling in Nova since event system is async, Cinder can't query back for status. | |
| 22:39:56 | mriedem | mgagne: the nova api could fail fast in one case, | |
| 22:39:59 | mriedem | that the computes aren't new enough | |
| 22:40:06 | claudiub | mriedem: yeah, that's something i was going to comment on. | |
| 22:40:17 | mriedem | i.e. if we know the instance is running on an ocata compute, we know it's going to fail, and we could fail the request to cinder with a 409 or something | |
| 22:40:22 | mgagne | mriedem: this means a sync call to compute node? or could capabilities be cached somewhere in database? | |
| 22:40:29 | claudiub | it seems that it only talks about iscsi volumes. | |
| 22:40:37 | mriedem | mgagne: we have the nova-compute service version in the database | |
| 22:40:51 | claudiub | while for hyper-v we support iscsi, smb, and fibre channel volumes. | |
| 22:40:51 | mriedem | mgagne: so we know if the compute host is running ocata or pike code, | |
| 22:40:58 | mgagne | cool, didn't know about that | |
| 22:41:01 | mriedem | or what the minimum nova-compute is in the deployment | |
| 22:41:31 | claudiub | for smb, afaik, the hyper-v driver might have to do the volume resize. didn't read the whole spec to see if that's possible in nova | |
| 22:41:34 | mgagne | claudiub: yes, the proposed implementation is very "optimist" by assuming only libvirt+iscsi exists in its presumed perfect world =) | |
| 22:41:39 | mriedem | claudiub: yeah good point - mgagne: how do we know which brick connector to get? do we have to get the connection_info dict from cinder for the given volume? | |
| 22:42:10 | mgagne | mriedem: iirc, extend_volume takes connection_info in parameter so I assume it knows that to do with that | |
| 22:42:38 | mgagne | mriedem: I can check, just a bit busy with some openstack upgrade atm =) | |
| 22:43:02 | mriedem | oh, hmm, | |
| 22:43:09 | mriedem | i guess we have the bdm.connection_info | |
| 22:43:16 | mriedem | and can lookup the bdm by instance and volume id | |
| 22:43:20 | mgagne | yes, nova has it afaik in bdm | |
| 22:46:32 | claudiub | mriedem: anyways. since there's blueprints talk. i was going to propose a sriov + hyperv spec to nova. i finally have some hardware to work / test on. :D it would be a pretty straight-forward implementation IMO, especially since we already support pci passthrough in hyper-v. do I need a spec for that? | |
| 22:47:10 | mriedem | claudiub: i thought you had a spec for that at one point? | |
| 22:47:18 | mriedem | maybe it was just a blueprint and a patch that was abandoned? | |
| 22:47:37 | claudiub | i don't think I had, never had the hardware to test that feature before. | |
| 22:47:37 | mriedem | claudiub: i think i'm fine with a specless feature parity blueprint though | |
| 22:48:11 | claudiub | cool, will submit the blueprint and some POC code by the end of the week. | |
| 23:03:12 | openstackgerrit | Mathieu Gagné proposed openstack/nova-specs master: Nova support for attached volume extend https://review.openstack.org/453272 | |
| 23:24:46 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers-actions (1/4) https://review.openstack.org/455563 | |
| 23:48:25 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers-actions (2/4) https://review.openstack.org/455568 | |
| 23:48:34 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers-actions (3/4) https://review.openstack.org/455570 | |
| 23:48:41 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Parameter verification for servers-actions (4/4) https://review.openstack.org/455573 | |
| 23:48:48 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers-actions.inc https://review.openstack.org/454565 | |
| #openstack-nova - 2017-04-12 | |||
| 00:02:03 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444 | |
| 00:02:31 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Refactor a test method including 7 test cases https://review.openstack.org/395436 | |
| 00:02:47 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Refactor a test method including 3 test cases https://review.openstack.org/394738 | |
| 00:06:41 | mgagne | so... about that nova-specs gate breakage... "sphinx.errors.SphinxWarning: WARNING: no "man_pages" config value found; no manual pages will be written" is there any change I can rebase on to get it fixed? | |
| 00:22:26 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.rescue notifications https://review.openstack.org/385644 | |
| 00:27:58 | openstackgerrit | STEW TY proposed openstack/nova master: Transform instance.rescue notifications https://review.openstack.org/385644 | |
| 00:39:01 | clarkb | mgagne: did that fail earlier today? there was an issue breaking docs builds and may hve affected nova-specs? | |
| 00:39:09 | clarkb | mgagne: you might just try recheckign as it was a test node issue | |
| 00:39:17 | mgagne | will recheck right now | |
| 01:00:03 | mgagne | clarkb: no luck after a recheck https://review.openstack.org/#/c/453272/ | |
| 01:14:57 | mriedem | clarkb: was failing all afternoon | |
| 01:15:49 | mriedem | maybe a new sphinx release and we're legitimately broken | |
| 01:28:28 | mriedem | hmm, sphinxcontrib-fulltoc 1.2.0 released on 4/10 | |
| 01:28:59 | mriedem | we should be using 1.1 though https://github.com/openstack/requirements/blob/master/upper-constraints.txt#L479 | |
| 01:30:32 | mriedem | maybe pbr 2.1.0? | |
| 01:33:37 | mriedem | bingo https://github.com/openstack-dev/pbr/commit/2d7c0045f402b31d6223437ba25423eeb32278e1 | |
| 01:33:39 | mriedem | clarkb: ^ | |
| 01:33:45 | mriedem | it's pbr 2.1.0 | |
| 01:36:03 | openstack | Launchpad bug 1681983 in PBR "2.1.0: sphinx.errors.SphinxWarning: WARNING: no "man_pages" config value found; no manual pages will be written" [Undecided,New] | |
| 01:36:03 | mriedem | https://bugs.launchpad.net/pbr/+bug/1681983 | |
| 01:39:42 | mriedem | blacklist patch https://review.openstack.org/455865 | |
| 01:41:07 | clarkb | you cant blacklist pbr | |
| 01:41:23 | clarkb | its installed bfore anyrhing that could blacklist is executed | |
| 01:42:05 | mriedem | shirt | |
| 01:42:07 | mriedem | heh | |
| 01:42:09 | clarkb | it may work in this case because its a post install step though but generally ya | |
| 01:48:05 | mordred | clarkb, mriedem: I +A'd the u-c blacklist, but also what clarkb said is correct so I don't expect it'll do much - while the pbr issue gets worked, commenting out the man_pages line in conf.py fixes theissue | |
| 02:38:21 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Workaround pbr 2.1.0 man_pages bug https://review.openstack.org/455885 | |
| 02:54:32 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Deprecate multinic, os-virtual-interfaces, and floating IP action APIs https://review.openstack.org/384261 | |
| 02:54:39 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Nova support for attached volume extend https://review.openstack.org/453272 | |
| 02:55:00 | openstackgerrit | Matt Riedemann proposed openstack/nova-specs master: Amend spec for placement project/user association https://review.openstack.org/454352 | |
| 02:58:27 | Kevin_Zheng | ping mriedm | |
| 02:58:53 | Kevin_Zheng | ping mriedem | |
| 02:59:11 | mriedem | Kevin_Zheng: hi | |
| 03:00:04 | Kevin_Zheng | mriedem: Hi, about https://review.openstack.org/#/c/455183/2 , I don't quite get your suggestion | |
| 03:02:32 | mriedem | Kevin_Zheng: i left a reply, see if that makes sense | |
| 03:02:42 | Kevin_Zheng | mriedem thanks | |
| 03:02:49 | mriedem | if the for loop does not break, then we raise exception.ConsoleNotAvailable() | |
| 03:03:00 | mriedem | if the for loop does break, pty is set | |
| 03:10:47 | Kevin_Zheng | mriedem: thanks, I just searched it, that makes sense :) | |
| 03:11:24 | mriedem | cool | |
| 03:13:10 | mriedem | alex_xu: gmann: have you ever noticed that the host power actions on the os-hosts API are all GETs? | |
| 03:13:14 | mriedem | GET /os-hosts/{host_name}/reboot | |
| 03:13:20 | mriedem | that's really odd | |
| 03:15:44 | gmann | mriedem: yea all start etc are GET | |
| 03:26:05 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Fix HTTP 500 raised for getConsoleLog for stopped instance https://review.openstack.org/455183 | |
| 03:31:54 | mriedem | gmann: i also see there are Tempest negative tests that hit the os-hosts enable/disable/reboot/shutdown/start APIs, those should probably all be moved out of tempest and into nova unit tests, if we don't already have that coverage, but I bet we do | |