| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-11 | |||
| 13:15:01 | peter-hamilton | johnthetubaguy: do you have a minute to discuss cert validation? | |
| 13:23:20 | andymccr | cdent: are you about? | |
| 13:23:37 | cdent | andymccr: hi, yes | |
| 13:23:54 | andymccr | cdent: hey :) if you have a second - is there a reason why CONTENT_LENGTH has to be set to an int? https://github.com/openstack/nova/commit/6dd047a3307a1056077608fd5bc2d1c3b3285338 | |
| 13:24:16 | openstack | Launchpad bug 1681843 in OpenStack Compute (nova) "Nova-placement returns "ValueError: invalid literal for int() with base 10: ''"" [Undecided,New] | |
| 13:24:16 | andymccr | im having issues in that content_length is present, but empty so its failing with a valueError: https://bugs.launchpad.net/nova/+bug/1681843 | |
| 13:24:32 | andymccr | i figure the easiest fix is just to remove the int() (which works) but wanted to make sure im not overlooking anything | |
| 13:25:27 | cdent | andymccr: need to catch up and get my brain right, just a sec | |
| 13:25:41 | andymccr | cdent: no problem. lemme know if i can explain anything better/further | |
| 13:25:49 | peter-hamilton | jaypipes: do you have a sec to discuss cert validation? | |
| 13:26:13 | jaypipes | peter-hamilton: here on IRC? or in a hangout or something? | |
| 13:26:25 | peter-hamilton | jaypipes: here's fine, just some quick questions | |
| 13:26:35 | jaypipes | peter-hamilton: go for it. | |
| 13:27:02 | peter-hamilton | jaypipes: are you ok with adding two conf options, (1) to enable/disable cert validation, and (2) to provide a default list of trusted cert IDs | |
| 13:27:17 | peter-hamilton | jaypipes: the goal would be to smooth the migration path and user experience | |
| 13:27:25 | peter-hamilton | jaypipes: these were recommended by johnthetubaguy | |
| 13:27:39 | jaypipes | peter-hamilton: if that smooths the integration path, I'm all for it.' | |
| 13:28:32 | peter-hamilton | jaypipes: cool, i'm folding those in | |
| 13:28:37 | jaypipes | rock on brother. | |
| 13:30:53 | openstackgerrit | Andy McCrae proposed openstack/nova master: Don't force CONTENT_LENGTH to be an int() https://review.openstack.org/455710 | |
| 13:31:11 | cdent | andymccr: hmmm. that's icky behavior by nginx. what that check is trying to do is detect that there is a body with some length, without actually looking at the body, and then complain if there's no content-type header | |
| 13:31:40 | cdent | so if nginx is sending both, but with empty values, neither line is correct | |
| 13:32:33 | andymccr | cdent: agreed, although im confused as to why we need to force it to be an int? if there are no integer comparisons after that | |
| 13:33:11 | cdent | andymccr: probably because i was being overzealous: the spec says that if the header is present it's value is made up of DIGITS | |
| 13:33:20 | andymccr | ahh | |
| 13:33:54 | andymccr | cdent: any issue with removing the int? alternatively, we could get it, check it's not None and then make sure it's an int? | |
| 13:34:03 | andymccr | (or something slightly more efficient i assume) | |
| 13:34:10 | cdent | so yeah, your fix is probably okay, but if you're in there, addressing nginx'isms then you probably need to fix the content-type thing too | |
| 13:35:37 | cdent | a) drop the int b) if not environ.get('CONTENT_TYPE', ''): | |
| 13:35:55 | cdent | andymccr: that would get the correct behavior wouldn't it? | |
| 13:36:18 | andymccr | cdent: hmm thinking. | |
| 13:37:11 | andymccr | cdent: how it is now worked on content_type, because i guess it is defined, so they're both defined (but empty) - trying to think if there is another use case (that isnt this) where that would cause an issue | |
| 13:37:39 | mriedem | jaypipes: johnthetubaguy: sdague: at some point i need to talk with you about the os-interface response body and how we want that to look | |
| 13:37:49 | cdent | andymccr: the thing we are trying to prevent here is an empty content-type | |
| 13:38:05 | cdent | and I was thinking that the environ would only have the key if the header was present | |
| 13:38:09 | andymccr | cdent: so when CONTENT_LENGTH is not empty, make sure CONTENT_TYPE is also not empty | |
| 13:38:15 | cdent | yes | |
| 13:38:16 | andymccr | ohh i see what you mean | |
| 13:38:41 | andymccr | ok lemme fix! | |
| 13:40:15 | cdent | andymccr: thank you! | |
| 13:42:28 | frickler | did nova stop writing libvirt.xml into the instance-dir with ocata? or do I just need a specific option for it? | |
| 13:49:56 | openstackgerrit | Andy McCrae proposed openstack/nova master: Don't force CONTENT_LENGTH to be an int() https://review.openstack.org/455710 | |
| 13:58:19 | sdague | mriedem: I was looking through that this morning | |
| 13:58:40 | jaypipes | mriedem: sure, just gimme a few. need to restart my workstation.. | |
| 13:58:49 | sdague | mriedem: I guess the question is, what do we think people need to do with this? | |
| 14:00:05 | mriedem | sdague: alex_xu: just left replies in https://review.openstack.org/#/c/455023/ | |
| 14:00:15 | mriedem | sdague: to list ports attached to their server | |
| 14:00:25 | mriedem | sdague: same reason we have os-volume_attachments | |
| 14:00:38 | sdague | so that they can go operate on those ports in neutron? | |
| 14:00:48 | mriedem | or detach a port from the server in the same api | |
| 14:00:49 | sdague | like after they get that, what do they do with it next? | |
| 14:01:26 | mriedem | GET /os-interface - nothing attached, POST /os-interface/port_id - attach a port, GET /os-interface, see my port is attached, DELETE /os-interface/port_id - detach the port | |
| 14:01:35 | jaypipes | mriedem: ok, back... | |
| 14:01:43 | mriedem | jaypipes: replied to comments inline | |
| 14:01:54 | johnthetubaguy | peter-hamilton: thanks for taking a look at those | |
| 14:02:04 | peter-hamilton | johnthetubaguy: not a problem | |
| 14:02:10 | mriedem | alex_xu: pointed out duplication with the /ips API such that we could drop the fixed_ips and mac_addr part of os-interface | |
| 14:02:18 | peter-hamilton | johnthetubaguy: can you provide more info on versionedobjects? | |
| 14:02:20 | mriedem | we could drop port_state since it doesn't really make sense | |
| 14:02:23 | mriedem | or help | |
| 14:02:28 | peter-hamilton | johnthetubaguy: i'm not that familiar with them | |
| 14:02:42 | mriedem | peter-hamilton: https://github.com/openstack/oslo.versionedobjects | |
| 14:02:44 | sdague | /ips is all super weird, and that's all in the main server doc iirc | |
| 14:02:52 | peter-hamilton | mriedem: thanks! | |
| 14:02:58 | johnthetubaguy | peter-hamilton: sure thing, the rest of those instance extra entries are basically serialised versioned objects, helps with upgrades, etc, long term | |
| 14:03:06 | mriedem | sdague: it is, in fact, more of /ips is in the main server doc than it is in /ips | |
| 14:03:09 | mriedem | sdague: details wise | |
| 14:03:26 | peter-hamilton | johnthetubaguy: ok, so it would just match the current convention for InstanceExtras | |
| 14:03:33 | johnthetubaguy | peter-hamilton: yeah | |
| 14:03:42 | mriedem | peter-hamilton: the nova objects are in https://github.com/openstack/nova/tree/master/nova/objects | |
| 14:03:49 | peter-hamilton | johnthetubaguy: thanks | |
| 14:03:56 | mriedem | instance_extra stuff is used in https://github.com/openstack/nova/blob/master/nova/objects/instance.py | |
| 14:04:09 | peter-hamilton | johnthetubaguy: i'm fine with making that a versionedobject then | |
| 14:04:15 | mriedem | https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/models.py#L372 | |
| 14:04:28 | peter-hamilton | johnthetubaguy: i'm working through some updates to the spec now | |
| 14:04:30 | johnthetubaguy | peter-hamilton: the extra bit of detail might be here, in case that helps with context: https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L718 | |
| 14:04:39 | mriedem | if we store something in the nova database and it's passed over rpc, it should be a versioned object | |
| 14:04:43 | peter-hamilton | johnthetubaguy: thanks, i'll look it over | |
| 14:04:45 | johnthetubaguy | peter-hamilton: sweet, will try hit that as soon as its updated | |
| 14:04:58 | johnthetubaguy | +1 mriedem | |
| 14:08:27 | dansmith | mriedem: is this docs failure known? http://logs.openstack.org/92/443292/15/check/gate-nova-docs-ubuntu-xenial/a9a4dc5/console.html | |
| 14:08:45 | dansmith | seems like the kind of thing that would be wide failure | |
| 14:08:46 | mriedem | dansmith: not by me | |
| 14:08:53 | dansmith | okay | |
| 14:09:04 | mriedem | lemme checkade logstash | |
| 14:09:09 | sdague | mriedem: I don't understand the dropping of mac address, how would you determine what guest interface is what port if you don't have that? | |
| 14:09:35 | alex_xu | sdague: good point~ | |
| 14:10:04 | mriedem | sdague: I only mentioned that b/c the /ips API also has it | |
| 14:10:12 | mriedem | so maybe we remove mac from /ips and leave in os-interface | |
| 14:10:14 | sdague | dansmith: it looks like that job ran on python 3.5, which is the issue | |
| 14:10:30 | dansmith | sdague: talking in infra now, it's known | |
| 14:10:37 | sdague | mriedem: well, if you have > 1 port I'm not sure how ips helps | |
| 14:10:40 | mriedem | yeah http://logstash.openstack.org/#dashboard/file/logstash.json?query=message%3A%5C%22AttributeError%3A%20'dict_keys'%20object%20has%20no%20attribute%20'sort'%5C%22&from=7d | |
| 14:11:39 | dansmith | pabelanger said they'd send out a note shortly | |
| 14:11:46 | openstackgerrit | Gábor Antal proposed openstack/nova master: Add json style checking for sample notifications https://review.openstack.org/443677 | |
| 14:11:56 | mriedem | the /ips api is also a bit goofed up since it keys off the network label | |
| 14:12:24 | mriedem | so it's less about showing fixed/floating ips for a server and more about showing addresses for a server within a network | |
| 14:13:06 | mriedem | and of course we have /os-fixed-ips/ | |
| 14:13:29 | mriedem | but that's not tied to the server | |
| 14:13:47 | mriedem | and /os-floating-ips but that's not tied to a server either | |