| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-07 | |||
| 17:45:08 | mriedem | yes | |
| 17:45:17 | samarendra | ok | |
| 17:45:28 | mriedem | see if https://review.openstack.org/#/c/454823/ looks ok | |
| 17:49:46 | samarendra | mriedem: +1 | |
| 18:01:01 | mriedem | no jaypipes huh | |
| 18:01:21 | mriedem | dansmith: re: https://review.openstack.org/#/c/407228/ do you know if we changed to always pre-load instances with 'tags' loaded by default now? | |
| 18:01:42 | mriedem | i'm not really sure why we care about sending instance tags on every instance action payload | |
| 18:01:55 | dansmith | mriedem: I have a -1 on the patch to do that | |
| 18:02:05 | dansmith | https://review.openstack.org/#/c/415298/15 | |
| 18:02:10 | dansmith | haven't really gotten an answer on it | |
| 18:02:39 | mriedem | hmm, so that comes AFTER https://review.openstack.org/#/c/407228/ | |
| 18:02:53 | mriedem | and ^ will lazy-load instance tags on every instance action notification | |
| 18:02:54 | dansmith | I imagine the desire to have it in notifications is so you can do something for all instances tagged a certain way, | |
| 18:02:56 | mriedem | which is a buttload | |
| 18:02:57 | dansmith | but it does seem expensive | |
| 18:03:00 | dansmith | mriedem: yeah I know | |
| 18:03:24 | mriedem | seems we should figure out the lazy-load thing before we start blasting that everywhere | |
| 18:03:32 | mriedem | it'd be one thing if it were instance create/update | |
| 18:03:43 | dansmith | maybe I'm being silly, but it seems like we should pre-load tags anywhere we need to avoid that patch getting any more lazy-loads, then merge that patch | |
| 18:03:55 | dansmith | without making it default | |
| 18:03:56 | dansmith | agree | |
| 18:04:34 | mriedem | yeah i agree with you | |
| 18:05:23 | dansmith | you gonna slap the sad trombone on that bottom one? | |
| 18:06:24 | mriedem | wa mfing wa | |
| 18:06:45 | mriedem | sneti: are you around? | |
| 18:07:42 | mriedem | i think we basically just send tags for instance create and update | |
| 18:07:47 | mriedem | and none of the action payloads | |
| 18:08:15 | mriedem | i believe the whole intent of this is to get instance tags into searchlight for filling in the compute rest api server show response | |
| 18:08:26 | mriedem | to do that, i don't need to blast out tags for suspend/resume actions | |
| 18:08:43 | dansmith | ah, yeah | |
| 18:09:13 | mriedem | https://blueprints.launchpad.net/nova/+spec/additional-notification-fields-for-searchlight | |
| 18:09:13 | mriedem | it even says in the bp | |
| 18:09:17 | mriedem | Step1: Add simple fields to instance.create and instance.update | |
| 18:10:56 | dansmith | sonofa bee | |
| 18:11:14 | mriedem | alright cool, next thing | |
| 18:11:22 | mriedem | so on your workaround patch, | |
| 18:11:37 | mriedem | i wasn't sure if we should call that option out in the track_instance_changes option help text too or not | |
| 18:11:42 | mriedem | or if we should mention it in a reno | |
| 18:11:55 | dansmith | mriedem: or both, yeah I was going to do that | |
| 18:12:03 | dansmith | I'm currently unfscking my discover patch you conflicted with :P | |
| 18:12:04 | mriedem | i mean, a reno might raise eyebrows, which maybe you want or don't want | |
| 18:12:15 | mriedem | given it's the default behavior maybe it's better to not ruffle feathers, idk | |
| 18:12:34 | dansmith | I dunno, I think it's a good highlight for getting claims in the scheduler | |
| 18:12:38 | mriedem | sure | |
| 18:12:46 | mriedem | if you do a reno, i'd just put it in the 'other' section | |
| 18:12:52 | mriedem | not sure it's really a feature or issue or anything | |
| 18:12:56 | dansmith | okay | |
| 18:12:56 | mriedem | maybe known issue | |
| 18:13:27 | mriedem | like, hey, if you plan on having a big deployment and you don't want upcalls from all computes to the api, set this thing, which is temporary until claims in the scheduler | |
| 18:13:35 | mriedem | which is why it's a known issue and we're adding the backdoor workarsound | |
| 18:14:09 | dansmith | ack | |
| 18:15:02 | mriedem | melwitt: the first 4 changes here have my +2 https://review.openstack.org/#/c/442162/ they are super fun i swear - after the first one it's pretty easy | |
| 18:15:07 | mriedem | the first one is mostly just mechanics | |
| 18:18:35 | jbernard | melwitt: not yet, i plan to look at that next | |
| 18:23:52 | mriedem | efried: the long awaited +2 https://review.openstack.org/#/c/438119/11 | |
| 18:24:01 | efried | Wohoo!!! | |
| 18:24:10 | efried | thorst ^^ | |
| 18:25:01 | thorst | omg | |
| 18:25:15 | thorst | thank you | |
| 18:30:43 | mriedem | ooo actually | |
| 18:30:53 | mriedem | let me crush your souls real quick | |
| 18:31:20 | thomasem | *gulp* | |
| 18:31:47 | openstackgerrit | Mathieu Gagné proposed openstack/nova master: Add ability to signal and perform online volume size change https://review.openstack.org/454322 | |
| 18:32:07 | mriedem | https://review.openstack.org/#/c/438119/11/nova/virt/powervm/driver.py | |
| 18:32:07 | mriedem | efried: thorst: we don't translate log messages anymore | |
| 18:32:12 | mriedem | so you can remove the _LI usage in there | |
| 18:32:15 | openstackgerrit | Vladik Romanovsky proposed openstack/nova master: Support HTTP CONNECT in websocket proxy https://review.openstack.org/454226 | |
| 18:34:25 | efried | mriedem Roger that. | |
| 18:37:38 | nicodemus_ | hello again... I'm having some trouble with a few instances in a Mitaka deploy. In short, a few instances were migrated from one compute node to another, but then a DB issue happened and I had to restore the DB to a point prior to the migration. | |
| 18:38:41 | nicodemus_ | An instance in compute "A" is running but has no networking setup, so I modified the instances table to reflect that it's in compute A (DB said it was on compute B) | |
| 18:39:23 | nicodemus_ | So, I'm trying to migrate it from compute A to compute B but have an "InstanceActionNotFound" error on nova-api logs :( | |
| 18:40:11 | nicodemus_ | this is the full trace: http://paste.openstack.org/show/605774/ | |
| 18:40:28 | nicodemus_ | has anyone come across such issue? | |
| 18:45:32 | sdague | mriedem: btw, just to see, I inverted the livesnapshot flag - https://review.openstack.org/#/c/454323/ | |
| 18:45:46 | sdague | 2 different tempest runs failed on snapshotting paused images | |
| 18:45:59 | sdague | so... I think that remains a can of worms | |
| 18:47:45 | mriedem | those could just be latent bugs | |
| 18:47:58 | mriedem | we likely don't have a check in the libvirt driver to not live snapshot a paused guest | |
| 18:48:17 | mriedem | could probably just open a bug for that | |
| 18:48:57 | mriedem | yeah we get the power state here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1541 | |
| 18:49:05 | mriedem | and determine if it's live snapshot here https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1552 | |
| 18:49:07 | mriedem | but don't check the state | |
| 18:49:18 | mriedem | here we check the state https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1571 | |
| 18:49:20 | mriedem | later | |
| 18:49:59 | mriedem | https://github.com/openstack/nova/blob/master/nova/compute/power_state.py#L34 | |
| 18:50:10 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/delete #1: no-ops https://review.openstack.org/438119 | |
| 18:50:11 | efried | mriedem ^^ back atcha. Thanks! | |
| 18:50:31 | efried | thorst esberglu adreznec ^^ FYI and +1 | |
| 18:50:49 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in security_groups.py https://review.openstack.org/452309 | |
| 18:53:29 | mriedem | sdague: guessing maybe something with this? https://github.com/openstack/nova/blob/master/nova/virt/libvirt/driver.py#L1661 | |
| 18:53:37 | mriedem | pause vs suspend wrt qemu confuses me though | |
| 18:55:22 | mriedem | http://logs.openstack.org/23/454323/1/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/07a0fe4/logs/screen-n-cpu.txt.gz?level=TRACE#_2017-04-06_20_40_25_285 | |
| 18:55:29 | mriedem | trying to snapshot a non-running instance: (state: 3 expected: 1) | |
| 18:56:24 | mriedem | libvirtError: Domain not found: no domain with matching uuid 'f2e92033-2fc7-44c4-8dda-70ce75620071' (instance-00000014) | |
| 18:57:24 | sdague | mriedem: well, it works some of the time | |
| 18:58:00 | mriedem | sdague: i don't know what that means | |
| 18:58:08 | mriedem | you haven't rechecked this | |
| 18:58:13 | mriedem | you mean it passes in some jobs? | |
| 18:59:34 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598 | |
| 18:59:47 | mriedem | efried: doh | |