| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-07 | |||
| 02:36:49 | gmann | mriedem: i remember we stopped imageRef as url, but need to check for flavorRef | |
| 02:38:30 | gmann | mriedem: flavorRef is not restricted to id only - https://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L323 | |
| 02:39:39 | mriedem | yeah it can be a url | |
| 02:40:02 | mriedem | we parse it here https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L254 | |
| 02:40:15 | gmann | yea - https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L599 | |
| 02:40:33 | gmann | we did for imageRef as glance all work with uuid | |
| 02:43:05 | mriedem | i suspect the test is failing because it's running at the same time as another test which maybe stubs out the flavor db query method | |
| 02:43:26 | mriedem | value = max(value or 0, flavor['root_gb'])" | |
| 02:43:33 | mriedem | TypeError: unorderable types: int() > str() | |
| 02:44:39 | mriedem | or, | |
| 02:44:52 | mriedem | it could be an image snapshot with min_disk stored with a string value | |
| 02:51:18 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/453896 | |
| 02:52:32 | gmann | but root_gb will be all int, stub db might be something causing this | |
| 02:53:55 | mriedem | yeah i don't see anything | |
| 02:54:04 | mriedem | root_gb in all tests, at least functional tests, is an int | |
| 02:54:11 | mriedem | and i don't see min_disk set anywhere in tests | |
| 02:54:20 | mriedem | anyway, not the end of the world | |
| 02:55:26 | gmann | yea just greped on that | |
| 03:03:44 | gmann | mriedem: i suspect this -https://github.com/openstack/nova/blob/master/nova/tests/unit/fake_request_spec.py#L31 | |
| 03:04:34 | gmann | mriedem: image_fixtures - https://github.com/openstack/nova/blob/master/nova/tests/unit/image_fixtures.py#L54 | |
| 03:05:38 | mriedem | gmann: maybe the first, i'm seeing this in functional test runs so it shouldn't be the latter | |
| 03:06:01 | gmann | yea on functional db tests doing first one | |
| 03:07:19 | openstackgerrit | YuYang proposed openstack/nova master: VMware:fix get VM root device conditional verify https://review.openstack.org/454441 | |
| 03:08:36 | mriedem | gmann: yeah, that might be it | |
| 03:08:39 | mriedem | seems worth changing anyway | |
| 03:08:44 | mriedem | or, | |
| 03:09:06 | mriedem | the fake image service used in the tests needs to mimic the actual nova.image.glance code that casts min_disk to an int during show() | |
| 03:09:50 | gmann | yea | |
| 03:09:53 | gmann | mriedem: yea even many unit tests populate min_disk as string, we should change those to int to avoid any confusion | |
| 03:10:43 | gmann | mriedem: but that bug not reproducible always, its just happen on parallel tests run as you said | |
| 03:11:11 | gmann | may be we can give try and see if again it happen in case anywhere prob exist | |
| 03:13:58 | mriedem | let's see | |
| 03:14:16 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Image meta min_disk should be int in fake_request_spec https://review.openstack.org/454442 | |
| 03:22:45 | mriedem | alright thanks for the help gmann | |
| 03:22:48 | mriedem | i've got to call it a day | |
| 03:22:50 | mriedem | ttyl | |
| 03:23:59 | gmann | mrhillsman: thanks. ll review that | |
| 03:24:21 | gmann | oops mrhillsman ignore :) | |
| 03:25:47 | openstackgerrit | Shunli Zhou proposed openstack/nova master: Transform servergroup.create notification https://review.openstack.org/454023 | |
| 05:48:53 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/453896 | |
| 06:12:35 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/453896 | |
| 06:16:21 | openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/454531 | |
| 06:28:46 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add a removeFloatingIp example https://review.openstack.org/453026 | |
| 06:45:26 | openstackgerrit | Tadas Ustinavičius proposed openstack/nova master: Updating blueprint with more informative note. https://review.openstack.org/445558 | |
| 06:52:03 | openstackgerrit | YuYang proposed openstack/nova master: VMware:fix get VM root device conditional verify https://review.openstack.org/454441 | |
| 06:57:00 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/453896 | |
| 07:11:41 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Example verification for servers-actions.inc https://review.openstack.org/454565 | |
| 07:11:48 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/453896 | |
| 07:17:36 | openstackgerrit | Gábor Antal proposed openstack/nova master: Transform instance.volume_attach notification https://review.openstack.org/401992 | |
| 07:19:38 | jaosorior | gibi: do instance metadata updates push an instance.update notification? | |
| 07:20:15 | jaosorior | gibi: also, what was the site for the notification work status? | |
| 07:25:54 | gibi | jaosorior: hi! worklist is on https://vntburndown-gibi.rhcloud.com/index.html | |
| 07:26:28 | gibi | jaosorior: let me check the code to answer the instance.update on metadata question | |
| 07:28:42 | openstackgerrit | Maho Koshiya proposed openstack/nova master: Add interfaces functional negative tests https://review.openstack.org/442892 | |
| 07:30:28 | jaosorior | gibi: thanks a lot | |
| 07:39:56 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Add live-migration-force-after-timeout https://review.openstack.org/430218 | |
| 07:39:57 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: [WIP] API: Add os-migrateLive input parameters https://review.openstack.org/454578 | |
| 07:42:37 | gibi | jaosorior: deleting a metadata has the notification code https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L1108 | |
| 07:43:13 | jaosorior | gibi: but, setting it? | |
| 07:43:26 | gibi | jaosorior: and there is notification for instance.save https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L794 but I have to look more | |
| 07:43:40 | gibi | jaosorior: to see if that is called for metadata too | |
| 07:44:26 | jaosorior | instance.save ... interesting | |
| 07:44:31 | jaosorior | didn't know about that one | |
| 07:44:36 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: [WIP] API: Add os-migrateLive input parameters https://review.openstack.org/454578 | |
| 07:54:32 | seitan | Nova libvirt part: https://blueprints.launchpad.net/nova/+spec/custom-emulator-path thank you for your help. | |
| 07:54:32 | seitan | Good morning. I'm struggling with my first blueprint in Nova. There are many points, where I fail with my patch (still haven't figured out correct workflow with gerrit). But patch submission should be second step as I'm guessing now. If I understand documentation correcly, - my blueprint has to be approved before submitting any code? If so, should I attend Nova IRC meeting next week and propose my blueprint there? My blueprint is small patch for | |
| 07:57:11 | gibi | jaosorior: it seems that metadata change goes through instance.save so there should be notification but I will spin up a devstack and try it out | |
| 07:58:08 | jaosorior | gibi: dude! that would be awesome! | |
| 07:58:26 | jaosorior | gibi: is this something that works as well for legacy notifications? or is it exclusive for versioned notifications? | |
| 07:59:22 | jaosorior | gibi: also, instance.save is then called for both new instances and when updating instances? | |
| 07:59:47 | gibi | jaosorior: instance.update codepath quite similar for both legacy and versioned so it should work for both | |
| 08:00:39 | gibi | jaosorior: when instance is created then first instance.create() will be called and there will be instance.create notification | |
| 08:01:26 | gibi | jaosorior: after instance create the instance goes through couple of state changes so there will be instance.save() calls and instance.update notifications emitted | |
| 08:02:36 | jaosorior | gibi: oh, so instance.update will also run for new instances, not only when one updates parameters for them? | |
| 08:03:04 | jaosorior | say I do a nova boot, will I receive an instance.update notification? | |
| 08:17:04 | bauzas | tonyb: around by that time ? | |
| 08:18:04 | bauzas | tonyb: I have a bugfix that we merged in Pike and Ocata-RC2, but I wonder if it would be worth cherry-picking it for Newton too | |
| 08:18:19 | bauzas | tonyb: https://review.openstack.org/#/c/392643/6 looks to me reasonable | |
| 08:20:30 | bauzas | tonyb: FWIW https://review.openstack.org/#/c/454593/ comments welcome | |
| 08:38:24 | frickler | sfinucan: sorry for missing the meeting yesterday and thanks for taking up my patches. I'm going to add reno+tests and then let's see what other reviewers think | |
| 08:41:14 | gibi | jaosorior: you will receive instance.update when nova update the instance state during the boot | |
| 08:42:24 | gibi | jaosorior: here is a functional test that shows what notifications are triggered during nova boot https://github.com/openstack/nova/blob/master/nova/tests/functional/notification_sample_tests/test_instance.py#L157 | |
| 08:43:30 | jaosorior | I see | |
| 08:43:44 | jaosorior | gibi: is there a specific notification for instance.save? Would probably be less cumbersome than listening on instance.update | |
| 08:46:59 | openstackgerrit | Chris Dent proposed openstack/nova master: Optional separate database for placement API https://review.openstack.org/362766 | |
| 08:47:33 | gibi | jaosorior: there is no specific notification for instance.save, you have to listen to instance.update | |
| 08:47:39 | jaosorior | ok | |
| 08:47:41 | jaosorior | that works | |
| 08:47:46 | jaosorior | gibi: thanks a lot dude | |
| 08:47:56 | gibi | jaosorior: I'm still in a process testing the metadata update question | |
| 08:47:57 | johnthetubaguy | seitan: hi, can I help with your blueprint? | |
| 08:48:07 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Add live-migration-force-after-timeout https://review.openstack.org/430218 | |
| 08:48:23 | johnthetubaguy | seitan: is this the patch you are wondering about: https://review.openstack.org/#/c/445558 | |
| 08:52:30 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: [WIP] API: Add os-migrateLive input parameters https://review.openstack.org/454620 | |
| 08:56:18 | gibi | jaosorior: here are the notifications from a devstack about an nova boot | |
| 08:56:21 | gibi | jaosorior: http://paste.openstack.org/show/605721/ | |
| 08:56:55 | jaosorior | brilliant | |
| 08:56:58 | gibi | jaosorior: and then here are the notifications about a nova meta |
|
| 08:57:23 | gibi | jaosorior: it confirms that instance.update is emitted for meta set | |
| 08:57:35 | jaosorior | gibi: excellent, this is very useful for me. Thanks a lot | |