| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-06 | |||
| 22:08:11 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/453896 | |
| 22:09:06 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in remote_consoles.py https://review.openstack.org/454372 | |
| 22:09:11 | mriedem | edleafe: trinary logic is much less readable to me when you're wrapping lines | |
| 22:09:37 | mriedem | especially when thrown into dict comprehension or something | |
| 22:09:39 | mriedem | just the worst | |
| 22:50:37 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Don't send instance updates from compute if not using filter scheduler https://review.openstack.org/453916 | |
| 22:52:59 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in quota_sets.py https://review.openstack.org/454383 | |
| 23:14:55 | openstackgerrit | Sujitha proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730 | |
| 23:14:55 | openstackgerrit | Sujitha proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | |
| 23:14:56 | openstackgerrit | Sujitha proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185 | |
| 23:14:59 | openstackgerrit | Sujitha proposed openstack/nova master: Adding tags field to InstancePayload https://review.openstack.org/407228 | |
| 23:37:53 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | |
| 23:38:08 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | |
| 23:38:39 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926 | |
| 23:38:53 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | |
| #openstack-nova - 2017-04-07 | |||
| 00:14:31 | mriedem | dansmith: oh no | |
| 00:14:40 | mriedem | TypeAffinityFilter uses instance.instance_type_id :( | |
| 00:14:53 | dansmith | sigh | |
| 00:15:08 | mriedem | "TypeAffinityFilter doesn't allow more than one VM type per host." | |
| 00:15:10 | mriedem | what a dumb filter | |
| 00:17:41 | dansmith | well, | |
| 00:17:46 | mriedem | we could send a simple dict from the computes with just uuid and instance_type_id, or a simple object | |
| 00:17:47 | dansmith | if you want only one large per host I guess | |
| 00:17:48 | mriedem | InstanceInfo | |
| 00:18:02 | dansmith | you're already looking up all the instances, | |
| 00:18:07 | dansmith | you can know what their flavor is | |
| 00:18:10 | dansmith | also | |
| 00:18:22 | dansmith | instance_type_id will be wrong after a year of running your cloud anyway I'm sure | |
| 00:18:27 | dansmith | yeah, it's kinda dumb | |
| 00:19:17 | mriedem | well we're looking them up on either the compute or the scheduler | |
| 00:19:25 | mriedem | but yeah we have the info, but we have to send something specific from the computes | |
| 00:19:45 | mriedem | and yeah the flavor id probably changes | |
| 00:19:46 | mriedem | derp | |
| 00:20:03 | mriedem | let's just deprecate the filter :) | |
| 00:20:21 | dansmith | isn't it using the int id of the flavor? | |
| 00:20:27 | dansmith | that's what instance.instance_type_id is | |
| 00:20:29 | dansmith | which is even worse | |
| 00:22:17 | mriedem | yes | |
| 00:22:46 | mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/type_filter.py#L35 | |
| 00:23:00 | mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/utils.py#L96 | |
| 00:23:19 | mriedem | so i had x1.large with an extra spec | |
| 00:23:29 | mriedem | something was wrong with it and i needed to 'update' it | |
| 00:23:41 | mriedem | so i deleted that flavor and recreated with a new x1.large as type id 2 | |
| 00:23:44 | mriedem | now both are on my same compute | |
| 00:23:52 | mriedem | even though they probably didn't fit anyway | |
| 00:27:16 | mriedem | jogo added it 5 years ago | |
| 00:33:27 | dansmith | mriedem: right | |
| 00:33:31 | mriedem | heh, shouldn't it be called TypeAntifAffinityFilter? | |
| 00:34:45 | mriedem | asked about it in the ops list | |
| 01:49:37 | mriedem | dansmith: just noticed this http://logs.openstack.org/16/453916/4/check/gate-tempest-dsvm-py35-ubuntu-xenial/09850e6/logs/screen-n-sch.txt.gz?level=TRACE#_2017-04-06_23_11_45_834 | |
| 01:51:07 | mriedem | looks like maybe that's just on startup and not causing build failures | |
| 01:56:52 | openstack | Launchpad bug 1680661 in OpenStack Compute (nova) "HostMappingNotFound during update_instance_info" [Medium,Triaged] | |
| 01:56:52 | mriedem | https://bugs.launchpad.net/nova/+bug/1680661 | |
| 01:56:54 | mriedem | yeah it's a race on startup | |
| 01:57:37 | mriedem | the compute host is sending it's instance info (which is empty) to the scheduler before the compute host is mapped to the cell, and since it's an empty list the scheduler host manager tries to go back to the database to look up the instances on the compute node, which isn't mapped and we get the HostMappingNotFound | |
| 02:05:08 | mriedem | seems the compute shouldn't be sending anything if there are no instances to send... | |
| 02:12:29 | openstackgerrit | Matt Riedemann proposed openstack/nova master: WIP: Handle new hosts for updating instance info in scheduler https://review.openstack.org/454426 | |
| 02:15:17 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: Support tag instances when boot https://review.openstack.org/394321 | |
| 02:23:12 | openstackgerrit | XieYingYun proposed openstack/nova master: Optimize the link address https://review.openstack.org/454120 | |
| 02:33:24 | openstack | Launchpad bug 1680667 in OpenStack Compute (nova) "TypeError: unorderable types: int() > str() in get_system_metadata_from_image" [Undecided,New] | |
| 02:33:24 | mriedem | gmann: you should take a look at this https://bugs.launchpad.net/nova/+bug/1680667 | |
| 02:33:41 | mriedem | i really don't know how this works - but there are some functional tests that create a server by passing a URL for the flavorRef | |
| 02:34:00 | mriedem | but i don't see how that works, because the server create API looks up the flavor by id, expecting it to be an integer id, not a URL | |
| 02:36:27 | mriedem | ah common.get_id_from_href is supposed to parse the url | |
| 02:36:49 | gmann | mriedem: i remember we stopped imageRef as url, but need to check for flavorRef | |
| 02:38:30 | gmann | mriedem: flavorRef is not restricted to id only - https://github.com/openstack/nova/blob/master/nova/api/validation/parameter_types.py#L323 | |
| 02:39:39 | mriedem | yeah it can be a url | |
| 02:40:02 | mriedem | we parse it here https://github.com/openstack/nova/blob/master/nova/api/openstack/common.py#L254 | |
| 02:40:15 | gmann | yea - https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L599 | |
| 02:40:33 | gmann | we did for imageRef as glance all work with uuid | |
| 02:43:05 | mriedem | i suspect the test is failing because it's running at the same time as another test which maybe stubs out the flavor db query method | |
| 02:43:26 | mriedem | value = max(value or 0, flavor['root_gb'])" | |
| 02:43:33 | mriedem | TypeError: unorderable types: int() > str() | |
| 02:44:39 | mriedem | or, | |
| 02:44:52 | mriedem | it could be an image snapshot with min_disk stored with a string value | |
| 02:51:18 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/453896 | |
| 02:52:32 | gmann | but root_gb will be all int, stub db might be something causing this | |
| 02:53:55 | mriedem | yeah i don't see anything | |
| 02:54:04 | mriedem | root_gb in all tests, at least functional tests, is an int | |
| 02:54:11 | mriedem | and i don't see min_disk set anywhere in tests | |
| 02:54:20 | mriedem | anyway, not the end of the world | |
| 02:55:26 | gmann | yea just greped on that | |
| 03:03:44 | gmann | mriedem: i suspect this -https://github.com/openstack/nova/blob/master/nova/tests/unit/fake_request_spec.py#L31 | |
| 03:04:34 | gmann | mriedem: image_fixtures - https://github.com/openstack/nova/blob/master/nova/tests/unit/image_fixtures.py#L54 | |
| 03:05:38 | mriedem | gmann: maybe the first, i'm seeing this in functional test runs so it shouldn't be the latter | |
| 03:06:01 | gmann | yea on functional db tests doing first one | |
| 03:07:19 | openstackgerrit | YuYang proposed openstack/nova master: VMware:fix get VM root device conditional verify https://review.openstack.org/454441 | |
| 03:08:36 | mriedem | gmann: yeah, that might be it | |
| 03:08:39 | mriedem | seems worth changing anyway | |
| 03:08:44 | mriedem | or, | |
| 03:09:06 | mriedem | the fake image service used in the tests needs to mimic the actual nova.image.glance code that casts min_disk to an int during show() | |
| 03:09:50 | gmann | yea | |
| 03:09:53 | gmann | mriedem: yea even many unit tests populate min_disk as string, we should change those to int to avoid any confusion | |
| 03:10:43 | gmann | mriedem: but that bug not reproducible always, its just happen on parallel tests run as you said | |
| 03:11:11 | gmann | may be we can give try and see if again it happen in case anywhere prob exist | |
| 03:13:58 | mriedem | let's see | |
| 03:14:16 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Image meta min_disk should be int in fake_request_spec https://review.openstack.org/454442 | |
| 03:22:45 | mriedem | alright thanks for the help gmann | |
| 03:22:48 | mriedem | i've got to call it a day | |
| 03:22:50 | mriedem | ttyl | |