| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-06 | |||
| 21:10:00 | dansmith | just an uuid :) | |
| 21:10:20 | mriedem | so we agree we don't need to catch the full instance object in the host manager right? | |
| 21:10:24 | mriedem | *cache | |
| 21:10:34 | dansmith | AFAIK yeah | |
| 21:10:36 | mriedem | HOWEVER | |
| 21:10:43 | mriedem | you know if we changed it to just uuids, | |
| 21:10:50 | mriedem | we'd break someone's out of tree filter/weigher | |
| 21:11:00 | mriedem | that was using this to lookup some shit on the instance object fields | |
| 21:11:44 | dansmith | EDONTCARE | |
| 21:11:58 | mriedem | like, my super kewl filter checks all instances that have instance.config_driver = True and puts them on the same host! | |
| 21:12:30 | mriedem | i guess the answer for them is, well, you take the uuid, and go back to the db to look up the full instance object | |
| 21:12:42 | cdent | yes, that | |
| 21:14:15 | mriedem | ok, well, maybe i'll spend some time tinkering with this for the rest of the day, starting with the unnecessary joins in the db api | |
| 21:14:23 | mriedem | since that shouldn't be controversial | |
| 21:14:36 | mriedem | what to name my topic branch... | |
| 21:15:36 | openstackgerrit | melanie witt proposed openstack/nova-specs master: Amend spec for placement project/user association https://review.openstack.org/454352 | |
| 21:16:00 | cdent | mriedem: I'm very interested in this stuff so if you could keep me in the loop that would be dandy and write a helacious complete commit message that would be awesome. I'm not sure I was able to extact all the good bits from you and dan talking | |
| 21:16:12 | mriedem | i'll try | |
| 21:16:21 | cdent | thanks | |
| 21:28:05 | openstackgerrit | melanie witt proposed openstack/nova-specs master: Amend spec for placement project/user association https://review.openstack.org/454352 | |
| 21:28:18 | mriedem | dansmith: https://blueprints.launchpad.net/nova/+spec/put-host-manager-instance-info-on-a-diet | |
| 21:28:20 | mriedem | sdague: ^ | |
| 21:28:22 | mriedem | johnthetubaguy: ^ | |
| 21:28:31 | mriedem | i'm going for specless blueprint just since it's a couple of changes | |
| 21:30:27 | mnaser | hi everyone, i suspect that we're running into weird race conditions in the CI of Kolla related to the order of services being started.. is there a 'recommended' start list? | |
| 21:30:39 | openstackgerrit | Mathieu Gagné proposed openstack/nova-specs master: Multiple Fixed-IPs support in network information https://review.openstack.org/312626 | |
| 21:30:47 | mriedem | mnaser: controller services first | |
| 21:30:51 | mriedem | computes at the end | |
| 21:31:02 | mnaser | mriedem besides that, the rest shouldn't matter too much (i.e. scheduler before conductor?) | |
| 21:31:20 | mriedem | scheduler depends on placement as of ocata | |
| 21:31:33 | mriedem | scheduler and conductor are codependent | |
| 21:31:44 | mriedem | bring up the api last? | |
| 21:31:46 | mriedem | yeah | |
| 21:32:37 | mnaser | mriedem right now, order is: placement => nova-api => nova-scheduler => nova-conductor => nova-consoleauth => nova-novncproxy => nova-spicehtml5proxy => nova-serialproxy => nova-compute | |
| 21:32:45 | mnaser | however that order leads to this happening in gate sometimes: NotFound: Basic.publish: (404) NOT_FOUND - no exchange 'scheduler_fanout' in vhost '/' | |
| 21:33:11 | mriedem | this is a new problem? | |
| 21:33:31 | mnaser | i dont think its a nova issue but it seems to come and go so i was wondering if it was racing somewhere | |
| 21:33:38 | mriedem | never heard of that | |
| 21:33:57 | mnaser | okay, so must be a kolla thing, ill try to look some more | |
| 21:34:59 | mnaser | mriedem nvm, docker issue. its killing the process and mucking things up, sorry for noise | |
| 21:35:09 | mriedem | np | |
| 21:48:06 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Fix test_instance_get_all_by_host https://review.openstack.org/454360 | |
| 21:48:07 | mriedem | yay! ^ me help good | |
| 21:58:54 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Add live-migration-force-after-timeout https://review.openstack.org/430218 | |
| 22:08:11 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/453896 | |
| 22:09:06 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in remote_consoles.py https://review.openstack.org/454372 | |
| 22:09:11 | mriedem | edleafe: trinary logic is much less readable to me when you're wrapping lines | |
| 22:09:37 | mriedem | especially when thrown into dict comprehension or something | |
| 22:09:39 | mriedem | just the worst | |
| 22:50:37 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Don't send instance updates from compute if not using filter scheduler https://review.openstack.org/453916 | |
| 22:52:59 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in quota_sets.py https://review.openstack.org/454383 | |
| 23:14:55 | openstackgerrit | Sujitha proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730 | |
| 23:14:55 | openstackgerrit | Sujitha proposed openstack/nova master: Add BDM to InstancePayload https://review.openstack.org/448779 | |
| 23:14:56 | openstackgerrit | Sujitha proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185 | |
| 23:14:59 | openstackgerrit | Sujitha proposed openstack/nova master: Adding tags field to InstancePayload https://review.openstack.org/407228 | |
| 23:37:53 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | |
| 23:38:08 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | |
| 23:38:39 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926 | |
| 23:38:53 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | |
| #openstack-nova - 2017-04-07 | |||
| 00:14:31 | mriedem | dansmith: oh no | |
| 00:14:40 | mriedem | TypeAffinityFilter uses instance.instance_type_id :( | |
| 00:14:53 | dansmith | sigh | |
| 00:15:08 | mriedem | "TypeAffinityFilter doesn't allow more than one VM type per host." | |
| 00:15:10 | mriedem | what a dumb filter | |
| 00:17:41 | dansmith | well, | |
| 00:17:46 | mriedem | we could send a simple dict from the computes with just uuid and instance_type_id, or a simple object | |
| 00:17:47 | dansmith | if you want only one large per host I guess | |
| 00:17:48 | mriedem | InstanceInfo | |
| 00:18:02 | dansmith | you're already looking up all the instances, | |
| 00:18:07 | dansmith | you can know what their flavor is | |
| 00:18:10 | dansmith | also | |
| 00:18:22 | dansmith | instance_type_id will be wrong after a year of running your cloud anyway I'm sure | |
| 00:18:27 | dansmith | yeah, it's kinda dumb | |
| 00:19:17 | mriedem | well we're looking them up on either the compute or the scheduler | |
| 00:19:25 | mriedem | but yeah we have the info, but we have to send something specific from the computes | |
| 00:19:45 | mriedem | and yeah the flavor id probably changes | |
| 00:19:46 | mriedem | derp | |
| 00:20:03 | mriedem | let's just deprecate the filter :) | |
| 00:20:21 | dansmith | isn't it using the int id of the flavor? | |
| 00:20:27 | dansmith | that's what instance.instance_type_id is | |
| 00:20:29 | dansmith | which is even worse | |
| 00:22:17 | mriedem | yes | |
| 00:22:46 | mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/type_filter.py#L35 | |
| 00:23:00 | mriedem | https://github.com/openstack/nova/blob/master/nova/scheduler/filters/utils.py#L96 | |
| 00:23:19 | mriedem | so i had x1.large with an extra spec | |
| 00:23:29 | mriedem | something was wrong with it and i needed to 'update' it | |
| 00:23:41 | mriedem | so i deleted that flavor and recreated with a new x1.large as type id 2 | |
| 00:23:44 | mriedem | now both are on my same compute | |
| 00:23:52 | mriedem | even though they probably didn't fit anyway | |
| 00:27:16 | mriedem | jogo added it 5 years ago | |
| 00:33:27 | dansmith | mriedem: right | |
| 00:33:31 | mriedem | heh, shouldn't it be called TypeAntifAffinityFilter? | |
| 00:34:45 | mriedem | asked about it in the ops list | |
| 01:49:37 | mriedem | dansmith: just noticed this http://logs.openstack.org/16/453916/4/check/gate-tempest-dsvm-py35-ubuntu-xenial/09850e6/logs/screen-n-sch.txt.gz?level=TRACE#_2017-04-06_23_11_45_834 | |
| 01:51:07 | mriedem | looks like maybe that's just on startup and not causing build failures | |
| 01:56:52 | openstack | Launchpad bug 1680661 in OpenStack Compute (nova) "HostMappingNotFound during update_instance_info" [Medium,Triaged] | |
| 01:56:52 | mriedem | https://bugs.launchpad.net/nova/+bug/1680661 | |
| 01:56:54 | mriedem | yeah it's a race on startup | |
| 01:57:37 | mriedem | the compute host is sending it's instance info (which is empty) to the scheduler before the compute host is mapped to the cell, and since it's an empty list the scheduler host manager tries to go back to the database to look up the instances on the compute node, which isn't mapped and we get the HostMappingNotFound | |
| 02:05:08 | mriedem | seems the compute shouldn't be sending anything if there are no instances to send... | |