| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-04-06 | |||
| 14:38:13 | mriedem | sfinucan: artom: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_metadata.py is what i was thinking of | |
| 14:38:46 | mriedem | we'd have to fix mikal's sins here for network data https://github.com/openstack/nova/blob/master/nova/tests/functional/test_metadata.py#L64 | |
| 14:39:02 | mriedem | since ^ is all using nova-network right now | |
| 14:44:07 | bauzas | mriedem: wait, we unset instance.host when we offload the instance from the compute ? | |
| 14:44:18 | bauzas | (after shelving) | |
| 14:45:01 | bauzas | I know it requires a reschedule, but I was thinking we were keeping the reference before the unshelve and that were just overriding the host value | |
| 14:45:13 | dansmith | bauzas: no, once offloaded, it loses host, AFAIK | |
| 14:45:23 | bauzas | dansmith: so in the compute? | |
| 14:45:28 | bauzas | because AFAIK, you shelve | |
| 14:45:40 | bauzas | and then, a couple of mins after (config) then it's offloaded | |
| 14:46:02 | bauzas | AFAIK, it's a periodic task running on the compute which offloads the instance off | |
| 14:46:06 | dansmith | right | |
| 14:47:03 | bauzas | dansmith: okay, for my knowledge, reading again the code | |
| 14:51:18 | mriedem | we immediately offload by default | |
| 14:51:20 | mriedem | bauzas: ^ | |
| 14:51:29 | mriedem | it's based on config | |
| 14:51:36 | johnthetubaguy | mriedem: +1 | |
| 14:51:37 | mriedem | the time defaults to 0 | |
| 14:51:55 | mriedem | and then yes the instance does not have a host or node set on it | |
| 14:52:50 | bauzas | mriedem: right, because the opt value is 0 | |
| 14:53:00 | bauzas | mriedem: that's what I meant sorry | |
| 14:53:02 | bauzas | it's time-based | |
| 14:53:06 | bauzas | if 0, do that now | |
| 14:58:29 | mriedem | heads up, apparently pypi mirror issues | |
| 14:58:32 | mriedem | so jobs are failing | |
| 15:01:34 | dansmith | yeah | |
| 15:01:35 | dansmith | was just seeing that | |
| 15:02:00 | openstackgerrit | Vladik Romanovsky proposed openstack/nova master: Support HTTP CONNECT in websocket proxy https://review.openstack.org/454226 | |
| 15:26:30 | bauzas | mriedem: dansmith: I'm puzzled, can't find where instance.host is unset in the compute manager method for shelve offloading | |
| 15:27:11 | mriedem | bauzas: in the RT | |
| 15:27:18 | mriedem | super tight coupling | |
| 15:27:22 | mriedem | equals super fun | |
| 15:27:34 | bauzas | mriedem: orly? man | |
| 15:27:45 | dansmith | here? https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4400-L4400 | |
| 15:27:57 | mriedem | actually yeah | |
| 15:27:58 | mriedem | not RT | |
| 15:28:02 | mriedem | i was thinking of ALLOW_RESOURCE_REMOVAL in rt | |
| 15:28:10 | dansmith | took me like eight whole seconds :) | |
| 15:28:23 | mriedem | https://github.com/openstack/nova/blob/master/nova/compute/manager.py#L4396 is what i was thinking of | |
| 15:28:34 | mriedem | which uses https://github.com/openstack/nova/blob/master/nova/compute/resource_tracker.py#L939 | |
| 15:28:43 | mriedem | and https://github.com/openstack/nova/blob/master/nova/compute/vm_states.py#L78 | |
| 15:28:49 | mriedem | alaski had to draw that picture for me once | |
| 15:28:54 | mriedem | i'll always be indebted | |
| 15:31:29 | bauzas | mriedem: I was surprised when you said that hence my "orly" | |
| 15:31:47 | bauzas | mriedem: because I don't remember where in RT we do set instance.host | |
| 15:32:01 | bauzas | we play with compute tracking | |
| 15:32:17 | bauzas | so it would defend the purpose of the RT if we would play with the instance fields in there | |
| 15:32:28 | bauzas | dansmith: thanks, missed that - so I'm blind | |
| 15:32:39 | dansmith | :) | |
| 15:33:39 | mriedem | i would not be surprised at all of RT or Claims messed with instance fields | |
| 15:33:44 | mriedem | s/of/if/ | |
| 15:34:31 | bauzas | mriedem: they look them up | |
| 15:34:39 | bauzas | mriedem: but they don't touch them | |
| 15:34:53 | bauzas | or I would seriously -2 any change for that | |
| 15:35:04 | bauzas | resource *tracking* | |
| 15:35:12 | bauzas | not resource *setting* :p | |
| 15:36:30 | mriedem | you might -2 that but that doesn't mean someone else won't +W before you see it | |
| 15:38:54 | cdent | fa | |
| 15:38:59 | cdent | ww | |
| 15:41:43 | bauzas | mriedem: question about https://review.openstack.org/#/c/453859/1/nova/compute/api.py | |
| 15:41:55 | mriedem | shoot | |
| 15:42:09 | bauzas | mriedem: if we nullify instance.host when shelve_offload, why do we need to verify the instance state too ? | |
| 15:42:30 | mriedem | bauzas: read the commit message? | |
| 15:43:19 | mriedem | basically that whole block is about cases where the instance isn't scheduled to a cell | |
| 15:43:19 | bauzas | mriedem: ok, this time, you can *really* blame me in public | |
| 15:43:23 | mriedem | or that was the original assumption | |
| 15:43:34 | mriedem | that assumption breaks down when instance.host is None and vm_state is shelved offloaded | |
| 15:43:39 | mriedem | b/c that means the instance did get scheduled to a cell | |
| 15:43:45 | mriedem | and we need to do the old style local delete flow below | |
| 15:43:58 | mriedem | all explained in the commit message in exquisite detail | |
| 15:45:14 | bauzas | mriedem: I see L1974 so I understand now | |
| 15:45:43 | mriedem | fwiw i'm going to be trying to unwind this mess once this fix is in | |
| 15:46:37 | mriedem | dansmith: i eagerly await your updates to https://review.openstack.org/#/c/442162/ | |
| 15:46:58 | mriedem | b/c then we can get the bottom 5 changes in | |
| 15:47:15 | dansmith | mriedem: yep in my queue | |
| 15:47:50 | mriedem | i drank one too many cups of coffee to counteract my nyquil hangover and now i'm all amped up | |
| 16:39:44 | mriedem | ildikov: just an issue with the wording in the reno https://review.openstack.org/#/c/444253/ | |
| 16:40:24 | openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | |
| 16:40:24 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162 | |
| 16:40:25 | openstackgerrit | Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292 | |
| 16:40:26 | mriedem | dansmith: are you still using this? https://review.openstack.org/#/c/421399/ | |
| 16:40:26 | openstackgerrit | Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487 | |
| 16:40:27 | openstackgerrit | Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293 | |
| 16:40:28 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861 | |
| 16:40:28 | dansmith | mriedem: have you reviewed that yet? | |
| 16:40:30 | openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | |
| 16:40:39 | mriedem | dansmith: reviewed what yet? | |
| 16:40:44 | dansmith | mriedem: the thing I just pushed up | |
| 16:40:47 | dansmith | mriedem: what about now? | |
| 16:40:48 | dansmith | mriedem: now? | |
| 16:40:51 | mriedem | i see | |
| 16:40:51 | mriedem | oh | |
| 16:41:05 | mriedem | let me get out my red pen | |
| 16:41:13 | dansmith | mriedem: I haven't gotten to the actual subnode part of my devstack patch to know if I need that again or not | |
| 16:41:16 | dansmith | mriedem: I think I will | |
| 16:41:35 | dansmith | mriedem: if it's bothering you I can resubmit it under my name so you can abandon | |
| 16:41:36 | dansmith | I've long since given up trying to keep my dashboard clean | |
| 16:41:39 | ildikov | mriedem: cool, I'll fix it now, tnx | |
| 16:44:27 | mriedem | dansmith: it's fine, i just clean up every few weeks | |
| 16:45:35 | mdnadeem | ildikov, dansmith , mriedem , Hello guys, i have a query | |