| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-29 | |||
| 10:07:27 | mdbooth | The change itself looks fine, but I'm wondering if we have a policy on making changes which are only relevant to things which aren't in tree. | |
| 10:20:53 | openstack | Launchpad bug 1643911 in OpenStack Compute (nova) "libvirt randomly crashes on xenial nodes with "*** Error in `/usr/sbin/libvirtd': malloc(): memory corruption:"" [Medium,Confirmed] | |
| 10:20:53 | kashyap | mdbooth: Saw your comment on https://bugs.launchpad.net/bugs/1643911, will respond in a few | |
| 10:20:57 | kashyap | What a nasty bug | |
| 10:24:15 | johnthetubaguy | mdbooth: its a good question, usually it boils down to how would we test and maintain said code, although I think thats the driver that is slowly moving in tree, unless I got it mixed up | |
| 10:24:15 | mdbooth | kashyap: Is it the one Dan B investigated? | |
| 10:24:51 | kashyap | mdbooth: Partly only. He didn't spend any more time, beyond the discussion I noted in the comments. | |
| 10:25:08 | kashyap | There _seems_ to be a bug somewhere. But running Valgrind is not feasible, as it'll be horrendously slow | |
| 10:34:40 | openstackgerrit | Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for GET RP inventories https://review.openstack.org/449765 | |
| 10:57:21 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Merge server create schema for availability zone extension https://review.openstack.org/451331 | |
| 10:58:46 | gmann | alex_xu: this one - https://review.openstack.org/#/c/451194/2 | |
| 10:59:10 | gmann | alex_xu: this also looks fine or we can remove those directly like this - https://review.openstack.org/451331 | |
| 10:59:35 | gmann | alex_xu: or should i make those patches dependent on your one ? | |
| 11:00:54 | alex_xu | gmann: yes, 451331 can depend on 451194 | |
| 11:01:14 | alex_xu | gmann: 451194 is for get rid of stevedore quickly | |
| 11:01:19 | alex_xu | gmann: just like this https://review.openstack.org/#/c/451195/4/setup.cfg | |
| 11:01:37 | alex_xu | gmann: then we can merge those schema and extension later | |
| 11:02:03 | alex_xu | gmann: anyway the goal is removing stevedore first | |
| 11:02:45 | alex_xu | gmann: the step what I think is here https://etherpad.openstack.org/p/api-no-more-extensions-pike | |
| 11:03:52 | openstackgerrit | Huan Xie proposed openstack/nova master: WIP: Fix race condition when neutron is using minimized poll https://review.openstack.org/444230 | |
| 11:07:23 | gmann | alex_xu: cool. that is very nice etherpad | |
| 11:07:31 | alex_xu | gmann: thanks | |
| 11:07:43 | gmann | alex_xu: about 3rd and 6th , they are not same ? | |
| 11:08:32 | alex_xu | gmann: 3rd is build controller like this https://review.openstack.org/#/c/445864/5/nova/api/openstack/compute/routes.py@67 | |
| 11:08:55 | alex_xu | gmann: 6th is like your patch, merge those extended controller into servers controller | |
| 11:09:54 | alex_xu | gmann: the focus should be 3rd now, after 3rd finished, we can remove the stevedore | |
| 11:10:00 | gmann | alex_xu: merge extended controller is 8 right? | |
| 11:10:30 | alex_xu | gmann: 8th is about the 'server create' extension point | |
| 11:10:52 | alex_xu | gmann: sorry for I didn't describe clear about those | |
| 11:11:02 | openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Specify keymap on server boot https://review.openstack.org/448830 | |
| 11:11:29 | alex_xu | gmann: 6th is for merge those thing https://github.com/openstack/nova/blob/master/setup.cfg#L73 8th is for merge those https://github.com/openstack/nova/blob/master/setup.cfg#L158 | |
| 11:11:29 | openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration https://review.openstack.org/334732 | |
| 11:11:54 | openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: List/show all server migration types https://review.openstack.org/407237 | |
| 11:13:36 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Refactor a test method including 7 test cases https://review.openstack.org/395436 | |
| 11:13:58 | gmann | alex_xu: you mean to merge all externsions not just server one in 6th right? | |
| 11:14:07 | alex_xu | gmann: yes | |
| 11:14:10 | gmann | alex_xu: and 3rd is to merge the URl mapping and controller bits | |
| 11:15:14 | alex_xu | gmann: yes, 3rd is to use the plain route list instead of stevedore https://review.openstack.org/#/c/445864/7/nova/api/openstack/compute/routes.py@119 | |
| 11:15:41 | gmann | alex_xu: yea. | |
| 11:16:14 | gmann | alex_xu: so mainly 7 and 8 also kind of same as 6 but you separated for server create | |
| 11:16:22 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Refactor a test method including 3 test cases https://review.openstack.org/394738 | |
| 11:16:27 | alex_xu | gmann: yea | |
| 11:16:45 | gmann | alex_xu: so you want 6, 7 and 8 in last ? i thought first these and then stevedore things | |
| 11:17:56 | alex_xu | gmann: yes, 6,7,8 will spend a lot of time for us, if we do those first, I feel we need a long time to reach the point of remove stevedore | |
| 11:18:00 | openstackgerrit | Jaivish Kothari(janonymous) proposed openstack/os-vif master: Argument should have 2 params https://review.openstack.org/451338 | |
| 11:18:18 | alex_xu | gmann: so I try to remove the stevedore first, then let us cleanup 6,7,8 slowly | |
| 11:18:37 | alex_xu | gmann: I hope 3rd is easier than 6,7,8 | |
| 11:19:21 | gmann | alex_xu: i like 6.7.8 easy :) but yea those can take much time so its good to remove the small bits early | |
| 11:20:00 | gmann | alex_xu: i can help on 3rd too. let's see we can touch 6,7,8 also in Pike at least little bit | |
| 11:20:30 | alex_xu | gmann: thanks! | |
| 11:27:07 | openstackgerrit | Huan Xie proposed openstack/nova master: WIP: Fix race condition when neutron is using minimized poll https://review.openstack.org/444230 | |
| 11:28:52 | alex_xu | gmann: really hope can merge those json-schema, due to this ugly code https://review.openstack.org/#/c/451194/2/nova/api/openstack/compute/servers.py@733 | |
| 11:28:53 | openstackgerrit | Huan Xie proposed openstack/nova master: WIP: Fix race condition when neutron is using minimized poll https://review.openstack.org/444230 | |
| 11:34:13 | openstackgerrit | Alex Xu proposed openstack/nova master: Remove the rebuild extension help methods https://review.openstack.org/451346 | |
| 12:11:49 | openstackgerrit | jichenjc proposed openstack/nova master: add usage doc for resource provider https://review.openstack.org/450105 | |
| 12:29:43 | openstackgerrit | jichenjc proposed openstack/nova master: Remove the extension check for os-quota-class-sets https://review.openstack.org/451193 | |
| 12:35:32 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/451043 | |
| 12:45:38 | alex_xu | nova api meeting is in 15 mins at #openstack-meeting-4 | |
| 12:56:23 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: remove get_nw_info_for_instance from compute.utils https://review.openstack.org/451387 | |
| 12:56:23 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: remove ugly local import https://review.openstack.org/450787 | |
| 12:58:01 | gmann | alex_xu: yea scheduler_hints is really on wrong place on request | |
| 12:58:06 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-manage: Deprecate 'agent' commands https://review.openstack.org/450795 | |
| 12:58:07 | openstackgerrit | Stephen Finucane proposed openstack/nova master: nova-manage: Deprecate 'shell' commands https://review.openstack.org/450794 | |
| 12:59:27 | alex_xu | gmann: yea | |
| 13:00:26 | alex_xu | nova api meeting is running | |
| 13:34:44 | dansmith | sdague: I get this locally when running functional-py35 .. any ideas what I'm doing wrong? https://pastebin.com/28hkZ2TG | |
| 13:35:25 | dansmith | or, hmm, that stacktrace shows some 27 and some 35 in the same process I guess | |
| 13:38:38 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/451043 | |
| 13:40:31 | openstackgerrit | OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/451049 | |
| 13:43:40 | bauzas | dansmith: yup, I looked at your errors, seeems unrelated to your tests, isn't it? | |
| 13:43:51 | bauzas | your s/tests/change | |
| 13:43:59 | dansmith | bauzas: seems like it, but I wanted to try to reproduce it locally to figure it out | |
| 13:44:15 | dansmith | I figured if everyone was hitting that there would be screaming all around, so.. | |
| 13:44:17 | bauzas | one is a connection timeout AFAIK | |
| 13:44:24 | bauzas | AFAICS rather | |
| 13:44:39 | bauzas | the other says "sorry, we don't expect this but that" | |
| 13:44:48 | dansmith | I know | |
| 13:44:51 | bauzas | and both are very similar so /o\ | |
| 13:44:55 | dansmith | have you seen it elsewhere/ | |
| 13:45:16 | bauzas | nope, but honestly haven't checked logstash yet | |
| 13:45:27 | bauzas | so possibly some new cool race conditions | |
| 14:04:11 | frickler | repeating my question from #openstack here: when I have attached a volume to a server, how can I determine afterwards whether delete_on_termination is true or false? | |
| 14:06:00 | dansmith | bauzas: tox from py35 lets me run those tests, by the way | |
| 14:07:20 | bauzas | dansmith: okay, so it's either a CI issue or a race | |
| 14:07:45 | dansmith | bauzas: no, I mean I can run functional-3.5 as a target | |
| 14:07:54 | dansmith | I haven't gotten to the two specific tests yet | |
| 14:07:58 | bauzas | ah ok | |
| 14:12:59 | sdague | dansmith: the only thing I can imagine is virtualenv on your base computer is really old? | |
| 14:13:28 | dansmith | sdague: just uninstalling tox and re-installing with python3 seems to have fixed it | |
| 14:13:33 | sdague | dansmith: ah | |
| 14:13:38 | sdague | any idea how old old tox was? | |
| 14:13:45 | sdague | is that in your uninstall logs | |
| 14:14:08 | dansmith | it was from pip before, probably fairly old, not sure I'd have logs of that kind of uninstall | |
| 14:14:13 | dansmith | and it's long since gone off my screen | |
| 14:14:52 | sdague | dansmith: ok, because if there is a new min we need it would be good to know, we can do that in tox.ini, then it will at least freak out if things aren't new enough with an understood message | |
| 14:15:18 | dansmith | sdague: yeah, wish I had thought of it | |
| 14:15:24 | dansmith | I don't think I have pip logs of that anywhere | |
| 14:17:16 | sdague | I honestly expect we probably need 2.3.0 as a minimum | |
| 14:17:21 | sdague | there is a 2.2ish fix around env | |
| 14:17:49 | dansmith | bauzas: and yes, those tests all pass locally :) | |