Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-29
01:54:18 openstackgerrit Takashi NATSUME proposed openstack/nova master: Fix calling super function in setUp method https://review.openstack.org/451137
03:21:47 gaoyuan I am working on 'Remove mox from testing infrastructure - Pike'. I noticed in the blue print that we shouldn't remove any stub_out function call in the scope of this bp. But, my question is, what should I do when I came up with a self.stub.Set? Just change to stub_out, or use mock? anyone can tell me ?
05:49:31 openstackgerrit jichenjc proposed openstack/nova master: Remove the extension check for os-quota-class-sets https://review.openstack.org/451193
05:49:32 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for '/servers' endpoint instead of stevedore https://review.openstack.org/445864
05:49:33 openstackgerrit Alex Xu proposed openstack/nova master: Remove the stevedore extension point for server create https://review.openstack.org/451195
05:49:33 openstackgerrit Alex Xu proposed openstack/nova master: Remove the json-schema extension point of server create https://review.openstack.org/451194
05:54:16 openstackgerrit Alex Xu proposed openstack/nova master: Remove the stevedore extension point for server create https://review.openstack.org/451195
05:54:17 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for '/servers' endpoint instead of stevedore https://review.openstack.org/445864
06:01:00 openstackgerrit jichenjc proposed openstack/nova master: no extension for multiple create https://review.openstack.org/396622
06:02:23 openstackgerrit jichenjc proposed openstack/nova master: remove keypair server extension https://review.openstack.org/396611
06:09:02 openstackgerrit jichenjc proposed openstack/nova master: WIP: remove extension of scheduler hints totally https://review.openstack.org/331202
06:09:03 openstackgerrit jichenjc proposed openstack/nova master: WIP: remove scheduler_hints https://review.openstack.org/331194
06:10:40 alex_xu jichen: you probably want to check this https://etherpad.openstack.org/p/api-no-more-extensions-pike
06:11:25 alex_xu jichen: this is the new plan https://review.openstack.org/#/c/445864/5/nova/api/openstack/compute/routes.py@117
06:12:00 jichen alex_xu: ok, you are saying that my previous patches is no use now?
06:12:34 alex_xu jichen: I think it is still useful, but may need a little change
06:12:53 jichen alex_xu: ok, I will go through the etherpad first, thanks for point that out
06:13:14 alex_xu jichen: here is the patch you may want to check otu https://review.openstack.org/451194 and https://review.openstack.org/451195
06:13:37 alex_xu jichen: I want to remove the stevedore first, then let us merge those extensions
06:14:14 alex_xu jichen: otherwise we probably needs one or two years to reach out the point to get rid of stevedore. So try another way, remove stevedore first.
06:14:28 jichen alex_xu: I am ok to that, any work related to stevedore that might be helpful ? simple patch or need some break down?
06:15:12 jichen alex_xu: only this one https://review.openstack.org/#/c/445864/5/ or additional work to be done? I might search in etherpad :)
06:15:15 openstackgerrit Béla Vancsics proposed openstack/nova master: Using max api version in notification sample test https://review.openstack.org/443686
06:15:25 alex_xu jichen: this is one https://review.openstack.org/445864, move the servers related extesion to a routes list
06:15:38 alex_xu jichen: then probably we need to move all the extesion to that route list
06:15:52 jichen alex_xu: ok, let me check this out, thanks
06:16:34 alex_xu jichen: np, free to leave message to me, I have to go to hospital with my wife now. back later.
06:20:19 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444
06:20:23 openstackgerrit Moshe Levi proposed openstack/os-vif master: Explain why we bring up the lb in hybird mode https://review.openstack.org/447269
07:11:19 openstackgerrit Béla Vancsics proposed openstack/nova master: Remove _wait_for_state_change() calls from notification (action)tests https://review.openstack.org/451217
07:47:05 openstackgerrit Lei Zhang proposed openstack/nova master: Remove namespace check in creating traits https://review.openstack.org/451230
07:55:55 openstackgerrit Alex Xu proposed openstack/nova master: Remove the stevedore extension point for server create https://review.openstack.org/451195
07:55:56 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for '/servers' endpoint instead of stevedore https://review.openstack.org/445864
08:01:09 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Don't delete neutron port when attach failed https://review.openstack.org/403568
08:06:23 openstackgerrit Huan Xie proposed openstack/nova master: WIP: Fix race condition when neutron is using minimized poll https://review.openstack.org/444230
08:36:12 openstackgerrit Huan Xie proposed openstack/nova master: WIP: Fix race condition when neutron is using minimized poll https://review.openstack.org/444230
08:48:50 openstackgerrit Alex Xu proposed openstack/nova master: Remove the stevedore extension point for server create https://review.openstack.org/451195
08:48:51 openstackgerrit Alex Xu proposed openstack/nova master: Use plain routes list for '/servers' endpoint instead of stevedore https://review.openstack.org/445864
08:48:51 openstackgerrit Alex Xu proposed openstack/nova master: Remove the json-schema extension point of server create https://review.openstack.org/451194
08:48:52 openstackgerrit Alex Xu proposed openstack/nova master: Remove the extension check for os-networks in servers API https://review.openstack.org/450837
08:57:28 openstackgerrit Huan Xie proposed openstack/nova master: WIP: Fix race condition when neutron is using minimized poll https://review.openstack.org/444230
09:08:21 openstackgerrit Gábor Antal proposed openstack/nova master: Transform instance.volume_attach notification https://review.openstack.org/401992
09:26:26 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add description to policies in admin_password.py https://review.openstack.org/451271
09:38:42 openstackgerrit Sivasathurappan Radhakrishnan proposed openstack/nova master: Permit Live Migration of Rescued Instances https://review.openstack.org/308198
09:40:39 openstackgerrit Zhenyu Zheng proposed openstack/nova master: Add description to policies in hypervisors.py https://review.openstack.org/451294
10:06:23 mdbooth johnthetubaguy: https://review.openstack.org/#/c/451094/1/nova/image/glance.py
10:06:29 openstackgerrit Rikimaru Honjo proposed openstack/nova master: Consolidate unit tests for shelve API https://review.openstack.org/421220
10:06:45 mdbooth Apparently powervm uses a pipe here
10:06:52 mdbooth But powervm isn't in tree
10:07:27 mdbooth The change itself looks fine, but I'm wondering if we have a policy on making changes which are only relevant to things which aren't in tree.
10:20:53 openstack Launchpad bug 1643911 in OpenStack Compute (nova) "libvirt randomly crashes on xenial nodes with "*** Error in `/usr/sbin/libvirtd': malloc(): memory corruption:"" [Medium,Confirmed]
10:20:53 kashyap mdbooth: Saw your comment on https://bugs.launchpad.net/bugs/1643911, will respond in a few
10:20:57 kashyap What a nasty bug
10:24:15 johnthetubaguy mdbooth: its a good question, usually it boils down to how would we test and maintain said code, although I think thats the driver that is slowly moving in tree, unless I got it mixed up
10:24:15 mdbooth kashyap: Is it the one Dan B investigated?
10:24:51 kashyap mdbooth: Partly only. He didn't spend any more time, beyond the discussion I noted in the comments.
10:25:08 kashyap There _seems_ to be a bug somewhere. But running Valgrind is not feasible, as it'll be horrendously slow
10:34:40 openstackgerrit Andrey Volkov proposed openstack/nova master: [placement] Add api-ref for GET RP inventories https://review.openstack.org/449765
10:57:21 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Merge server create schema for availability zone extension https://review.openstack.org/451331
10:58:46 gmann alex_xu: this one - https://review.openstack.org/#/c/451194/2
10:59:10 gmann alex_xu: this also looks fine or we can remove those directly like this - https://review.openstack.org/451331
10:59:35 gmann alex_xu: or should i make those patches dependent on your one ?
11:00:54 alex_xu gmann: yes, 451331 can depend on 451194
11:01:14 alex_xu gmann: 451194 is for get rid of stevedore quickly
11:01:19 alex_xu gmann: just like this https://review.openstack.org/#/c/451195/4/setup.cfg
11:01:37 alex_xu gmann: then we can merge those schema and extension later
11:02:03 alex_xu gmann: anyway the goal is removing stevedore first
11:02:45 alex_xu gmann: the step what I think is here https://etherpad.openstack.org/p/api-no-more-extensions-pike
11:03:52 openstackgerrit Huan Xie proposed openstack/nova master: WIP: Fix race condition when neutron is using minimized poll https://review.openstack.org/444230
11:07:23 gmann alex_xu: cool. that is very nice etherpad
11:07:31 alex_xu gmann: thanks
11:07:43 gmann alex_xu: about 3rd and 6th , they are not same ?
11:08:32 alex_xu gmann: 3rd is build controller like this https://review.openstack.org/#/c/445864/5/nova/api/openstack/compute/routes.py@67
11:08:55 alex_xu gmann: 6th is like your patch, merge those extended controller into servers controller
11:09:54 alex_xu gmann: the focus should be 3rd now, after 3rd finished, we can remove the stevedore
11:10:00 gmann alex_xu: merge extended controller is 8 right?
11:10:30 alex_xu gmann: 8th is about the 'server create' extension point
11:10:52 alex_xu gmann: sorry for I didn't describe clear about those
11:11:02 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: Specify keymap on server boot https://review.openstack.org/448830
11:11:29 alex_xu gmann: 6th is for merge those thing https://github.com/openstack/nova/blob/master/setup.cfg#L73 8th is for merge those https://github.com/openstack/nova/blob/master/setup.cfg#L158
11:11:29 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration https://review.openstack.org/334732
11:11:54 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: List/show all server migration types https://review.openstack.org/407237
11:13:36 openstackgerrit Takashi NATSUME proposed openstack/nova master: Refactor a test method including 7 test cases https://review.openstack.org/395436
11:13:58 gmann alex_xu: you mean to merge all externsions not just server one in 6th right?
11:14:07 alex_xu gmann: yes
11:14:10 gmann alex_xu: and 3rd is to merge the URl mapping and controller bits
11:15:14 alex_xu gmann: yes, 3rd is to use the plain route list instead of stevedore https://review.openstack.org/#/c/445864/7/nova/api/openstack/compute/routes.py@119
11:15:41 gmann alex_xu: yea.
11:16:14 gmann alex_xu: so mainly 7 and 8 also kind of same as 6 but you separated for server create
11:16:22 openstackgerrit Takashi NATSUME proposed openstack/nova master: Refactor a test method including 3 test cases https://review.openstack.org/394738
11:16:27 alex_xu gmann: yea
11:16:45 gmann alex_xu: so you want 6, 7 and 8 in last ? i thought first these and then stevedore things
11:17:56 alex_xu gmann: yes, 6,7,8 will spend a lot of time for us, if we do those first, I feel we need a long time to reach the point of remove stevedore
11:18:00 openstackgerrit Jaivish Kothari(janonymous) proposed openstack/os-vif master: Argument should have 2 params https://review.openstack.org/451338
11:18:18 alex_xu gmann: so I try to remove the stevedore first, then let us cleanup 6,7,8 slowly
11:18:37 alex_xu gmann: I hope 3rd is easier than 6,7,8
11:19:21 gmann alex_xu: i like 6.7.8 easy :) but yea those can take much time so its good to remove the small bits early
11:20:00 gmann alex_xu: i can help on 3rd too. let's see we can touch 6,7,8 also in Pike at least little bit
11:20:30 alex_xu gmann: thanks!
11:27:07 openstackgerrit Huan Xie proposed openstack/nova master: WIP: Fix race condition when neutron is using minimized poll https://review.openstack.org/444230

Earlier   Later