Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-24
15:12:09 bauwser functional/test_server_group out of mind
15:12:50 bauwser mriedem: but it's not covering the situation that I want to remove, ie. the fact that live-migration can fail if the filter is now disabled
15:13:22 bauwser mriedem: johnthetubaguy: https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py#L367
15:14:34 bauwser mriedem: johnthetubaguy: I could be writing a test basically identical to https://github.com/openstack/nova/blob/master/nova/tests/functional/test_server_group.py#L367 that would disable the anti-affinity filter and show that the the move would fail ugly
15:14:54 bauwser mriedem: johnthetubaguy: so that I could remove that specific test in the cleanup patch I'm doing
15:14:56 bauwser wfy ?
15:15:53 johnthetubaguy just want something to prove the migrate works, and picks the correct host, or fails correctly, with and without your patch
15:16:15 johnthetubaguy maybe we have it already, thats cool
15:16:37 johnthetubaguy I guess we should have a test that fails with your bug, and we see it being fixed, ideally
15:16:42 bauwser johnthetubaguy: that's covering the migrate action, not the live-migrate action
15:16:55 johnthetubaguy bauwser: so we should have coverage for both right?
15:17:06 bauwser johnthetubaguy: yeah
15:17:13 bauwser okay, lemme see what I can do
15:25:50 mriedem hrm, what sets image size when we create a snapshot? does glance do it?
15:26:00 mriedem i can't see during a snapshot flow where we actually pass the size value to glacne
15:26:01 mriedem *glance
15:27:43 mriedem ah it is glance https://developer.openstack.org/api-ref/image/v2/index.html?expanded=create-an-image-detail#images
15:28:01 andreykurilin mriedem: sorry, it looks like my IRC bouncer had crashed and stopped sending me any messages, so I missed your messages yesterday.
15:28:27 mriedem andreykurilin: that's ok, we just disabled the trigger crash dump functional tests in novaclient,
15:28:33 mriedem because they were timing out and causing the jobs to hang
15:28:50 mriedem andreykurilin: i feel like you had found or fixed something in those tests like that not too long ago, but can't recall
15:29:56 andreykurilin mriedem: I remember that we had similar problems before, but I can recall what was done to fix it
15:33:45 openstackgerrit Anthony PERARD proposed openstack/nova master: Add exclusion list for tempest for a libvirt+xen job https://review.openstack.org/449687
15:38:19 mriedem anthonyper: some of that is old news
15:38:22 mriedem anthonyper: see d571e03b5b67a401e7774988a84df3bef16273ad
15:38:28 mriedem https://github.com/openstack/tempest/commit/d571e03b5b67a401e7774988a84df3bef16273ad
15:38:38 mriedem tempest doesn't hardcode vda anymore in test_volume_boot_pattern
15:39:31 anthonyper mriedem: Thanks, I'll tests that and change the patch.
15:40:31 openstackgerrit Sylvain Bauza proposed openstack/nova master: Fix live-migrate usage of RequestSpec https://review.openstack.org/449690
15:41:35 openstackgerrit Anthony PERARD proposed openstack/nova master: Add exclusion list for tempest for a libvirt+xen job https://review.openstack.org/449687
15:43:18 mriedem johnthetubaguy: just fyi i added L137 in here https://etherpad.openstack.org/p/BOS-TC-vm-baremetal-platform
15:43:38 johnthetubaguy mriedem: ah, cool
15:52:50 cdent alex_xu: I assume you're not around anymore today, but wanted to check before I do some rebasing of our combined stacks of code
15:54:57 mriedem johnthetubaguy: leakypipes: http://forumtopics.openstack.org/cfp/details/28
15:55:04 mriedem that might need to be two separate sessions
15:55:10 mriedem jgriffith: ildikov: Kevin_Zheng: ^
15:56:26 sdague johnthetubaguy: ok, I looked again at the new spec, I still thing you want to take it back even one step further. Let me throw a patch on top of it with an idea of tone.
15:56:55 ildikov mriedem: thanks
15:57:14 mriedem johnthetubaguy: sdague: since you guys are going to be decided forum sessions, let me know if i should split http://forumtopics.openstack.org/cfp/details/28 into 2 sessions
15:57:19 mriedem *deciding
15:57:29 mriedem if they are 40 minute blocks, 20 minutes per topic is not enough
15:57:44 ildikov mriedem: the plan is 40 minutes long sessions
15:57:55 ildikov mriedem: I would say let's split that to two
15:58:01 sdague mriedem: yeh, I'd suggest splitting
15:58:09 mriedem ok
15:58:29 ildikov mriedem: johnthetubaguy: jgriffith: I got pointed to a multi-attach related forum session proposal: http://forumtopics.openstack.org/cfp/details/17
15:58:58 mriedem ildikov: yeah i already commented on it
15:59:00 johnthetubaguy mriedem: I don't get a vote in that, its some other sub team of the TC looking at that, I believe
15:59:36 ildikov mriedem: thanks
16:00:00 johnthetubaguy but yeah, better to split to start, and combine later if needed, I guess
16:00:28 leakypipes mriedem: agreed.
16:00:55 mriedem ok done http://forumtopics.openstack.org/
16:02:06 mriedem huh, apparently if you rename it's a new topic
16:02:10 mriedem and you can't delete a topic
16:02:12 mriedem because now i have 3
16:02:29 mriedem EmilienM: ttx: do you know how to delete http://forumtopics.openstack.org/cfp/details/28 ?
16:02:54 EmilienM mriedem: Edit and Delete
16:03:08 mriedem thanks
16:03:08 mriedem ah nice
16:03:48 mriedem leakypipes: ah i see you created http://forumtopics.openstack.org/cfp/details/26 so that probably covers what i was going to submit
16:03:51 leakypipes cdent: I'm sorry, I still don't understand what you're asking for.
16:04:08 leakypipes mriedem: ya
16:04:30 mriedem we probably need a separate topic for claims in the scheduler though, i'm not sure yet
16:04:40 mriedem but we didn't talk about it at the ptg
16:04:49 leakypipes mriedem: ++
16:05:07 cdent leakypipes: maybe sean-k-mooney can take a stab at describing it? otherwise, if you're still curious I'll try a very quick spike at it after I rebase some stuff to fix merge conflicts after that float fix
16:05:33 leakypipes cdent: well, lemme try one more thing and push it.
16:06:02 cdent k
16:07:50 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257
16:09:13 openstackgerrit Matt Riedemann proposed openstack/nova master: Set 'size' during image create with FakeImageService https://review.openstack.org/449702
16:09:13 openstackgerrit Matt Riedemann proposed openstack/nova master: Regression test for local delete with an attached volume https://review.openstack.org/449334
16:09:43 mriedem sdague: ^ you'd probably appreciate that bottom change
16:11:37 openstackgerrit Matt Riedemann proposed openstack/nova master: Regression test for local delete with an attached volume https://review.openstack.org/449334
16:11:38 openstackgerrit Matt Riedemann proposed openstack/nova master: Set 'size' during image create with FakeImageService https://review.openstack.org/449702
16:13:05 mriedem superdan: pep8 https://review.openstack.org/#/c/449640/
16:13:31 superdan mriedem: yeah I have it fixed, as waiting for the run to finish before I pushed it up again
16:13:34 superdan and was on a call
16:13:38 mriedem ok
16:13:39 sdague johnthetubaguy: while I'm doing that, you want to hit this easy thing - https://review.openstack.org/#/c/448019/
16:13:40 superdan here
16:13:47 openstackgerrit Dan Smith proposed openstack/nova master: Remove legacy regeneration of RequestSpec in MigrationTask https://review.openstack.org/449640
16:15:05 johnthetubaguy sdague: got my head in the policy spec still, adding that to the queue
16:17:58 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Allow PUT and POST without bodies https://review.openstack.org/447625
16:17:59 openstackgerrit Chris Dent proposed openstack/nova master: placement: Add Traits API to placement service https://review.openstack.org/376200
16:17:59 openstackgerrit Chris Dent proposed openstack/nova master: placement: Enable attach traits to ResourceProvider https://review.openstack.org/376201
16:18:01 openstackgerrit Chris Dent proposed openstack/nova master: placement: Add Trait and TraitList objects https://review.openstack.org/376199
16:19:11 openstackgerrit Stephen Finucane proposed openstack/nova master: libvirt: Remove dead code https://review.openstack.org/449708
16:30:22 openstackgerrit Anusha Unnam proposed openstack/nova master: Add description to policies in tenant_networks.py https://review.openstack.org/449714
16:34:08 cdent leakypipes: while waiting for some tests to run I made a hack to do demo what I was thinking of. it can probably cleaned up monstrously, but shows the idea: https://github.com/cdent/pony
16:35:13 leakypipes cdent: lol, very similar to what I put together locally.
16:35:29 cdent leakypipes: ah, good, so we are understanding one another then?
16:36:06 leakypipes cdent: would seem so.\
16:36:15 openstackgerrit OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/446674
16:36:24 cdent praise be or something
16:40:25 openstackgerrit Sean Dague proposed openstack/nova-specs master: New intro https://review.openstack.org/449722
16:40:33 sdague johnthetubaguy: what about something like that?
16:42:14 openstackgerrit Chris Dent proposed openstack/nova master: [placement] Idempotent PUT /resource_classes/{name} https://review.openstack.org/448791
16:46:07 johnthetubaguy sdague: looking
16:48:41 johnthetubaguy sdague: thanks I will roll that into the patch I have cooking at the moment
17:02:35 tojuvone johnthetubaguy, Hi I had other things going like floorball. Looks that somehow I did not receive your comments in the patch.

Earlier   Later