Posted	Nick	Remark
#openstack-nova - 2017-03-23
21:36:24	dansmith	upps
21:36:26	dansmith	wtf
21:37:17	melwitt	regression :(
21:38:33	mriedem	mfing local delete
21:38:38	openstack	Launchpad bug 1675570 in OpenStack Compute (nova) "Volumes are not detached when deleting shelved offloaded servers" [High,Triaged]
21:38:38	mriedem	https://bugs.launchpad.net/nova/+bug/1675570
21:39:36	bauzas	mriedem: dansmith: hola, FYI https://review.openstack.org/#/c/391060/ is ready for reviews :)
21:41:17	melwitt	mriedem: we have the _local_delete function that does all the volume detach stuff, but we never incorporated calling it into the cells v2 short circuits of delete. I think because we were only thinking of the "not yet scheduled" case
21:41:25	mriedem	yup
21:41:31	mriedem	hold gentle caller,
21:41:33	mriedem	for the test
21:42:18	openstackgerrit	Matt Riedemann proposed openstack/nova master: Regression test for local delete with an attached volume https://review.openstack.org/449334
21:42:18	melwitt	thanks for the writing the test. *cues karate kid montage again*
21:42:19	mriedem	melwitt: dansmith: ^
21:42:32	mriedem	Kevin_Zheng gets all of the credit for reporting this to me this morning
21:42:50	melwitt	*plays montage for Kevin_Zheng too*
21:42:55	mriedem	we've never done any decent volume-related functional testing because our cinder fixture wasn't good enough
21:43:02	mriedem	that patch builds up the cinder fixture too
21:43:06	mriedem	to actually track attach/detach
21:43:32	openstackgerrit	Anusha Unnam proposed openstack/nova master: Add description to policies in used_limits https://review.openstack.org/447710
21:44:10	melwitt	mriedem: ah, yeah. I remember adding some stuff to that in my famous boot-from-volume patch. and I kept thinking to break it out into a separate thing but didn't
21:44:32	melwitt	probably because it would have been adding stuff that nothing was using
21:45:30	openstackgerrit	Matt Riedemann proposed openstack/nova master: Regression test for local delete with an attached volume https://review.openstack.org/449334
21:45:32	mriedem	is that like melwitt's famous bbq?
21:45:38	melwitt	nevermind, what you did is different than what I was thinking. I had done this https://review.openstack.org/#/c/355091/8/nova/tests/unit/volume/fake.py
21:45:49	melwitt	haha
21:49:36	openstackgerrit	Anusha Unnam proposed openstack/nova master: Add description to policies to availability_zone https://review.openstack.org/440836
21:51:32	openstackgerrit	Matt Riedemann proposed openstack/nova master: Regression test for local delete with an attached volume https://review.openstack.org/449334
21:52:34	mriedem	melwitt: yeah btw if we would have called that _local_delete method, we could have gotten the instance.delete.start/end notifications too
21:52:39	mriedem	which was the other regression
21:52:59	melwitt	/facepalm
21:53:25	mriedem	yuup
21:53:42	Apoorva_	NFS based Cinder connections seem to be broken by Nova changes. Our CI logs http://openstack-ci.tintri.com/tintri/refs-changes-59-448159-4/logs/screen-n-cpu.log.txt
21:55:48	Apoorva_	http://paste.openstack.org/show/603992/
21:59:23	openstackgerrit	Sujitha proposed openstack/nova master: [WIP] Add BDM to InstancePayload https://review.openstack.org/448779
21:59:25	openstackgerrit	Sujitha proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185
21:59:25	openstackgerrit	Sujitha proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730
21:59:27	openstackgerrit	Sujitha proposed openstack/nova master: Adding tags field to InstancePayload https://review.openstack.org/407228
22:00:04	openstackgerrit	Anusha Unnam proposed openstack/nova master: Add descripiton to policies in virtual_interfaces.py https://review.openstack.org/445652
22:00:31	Apoorva_	Can someone help me with this? http://paste.openstack.org/show/603992/
22:00:54	tjones	so i was sitting in openstack-meeting today at 2pm and no one was there… but i see i missed the meeting. so - did it move???
22:01:21	mriedem	tjones: wrong week, today was the 7pm PT
22:01:26	mriedem	*7am
22:07:32	openstackgerrit	Sujitha proposed openstack/nova master: Adding tags field to InstancePayload https://review.openstack.org/407228
22:08:26	mriedem	Apoorva_: have you diffed the _connect_volume method to see what changed the signature?
22:08:43	Apoorva_	lyarwood mriedem would this https://review.openstack.org/#/c/437665/ cause Cinder nfs based driver connections to fail?
22:08:53	mriedem	on
22:08:55	mriedem	*no
22:09:09	openstackgerrit	Sujitha proposed openstack/nova master: Adding tags field to InstancePayload https://review.openstack.org/407228
22:09:23	openstackgerrit	Sujitha proposed openstack/nova master: Change tags to default field in Instance object. https://review.openstack.org/415298
22:09:40	mriedem	Apoorva_: we have an NFS CI job running in the community infra, are you running a 3rd party Cinder NFS driver CI?
22:09:50	mriedem	this is the failure
22:09:56	openstackgerrit	Sujitha proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185
22:09:57	mriedem	TypeError: connect_volume() takes exactly 3 arguments (4 given)
22:10:21	Apoorva_	mriedem our driver inherits nfs driver.
22:10:41	melwitt	I see something, hang on
22:10:48	mriedem	my guess would be https://github.com/openstack/nova/commit/f0153fa4c87528e1dcbda8cba55d34ab7aec4e7a
22:11:33	melwitt	https://review.openstack.org/#/c/438970/
22:11:53	melwitt	yeah, I was trying to find the review
22:12:28	mriedem	yeah, so mdbooth missed the nfs driver
22:12:37	mriedem	in that change,
22:12:43	mriedem	probably because he's handling it in https://review.openstack.org/#/c/383859/ which isn't merged
22:12:46	mriedem	Apoorva_: please open a bug
22:12:59	Apoorva_	mriedem will do that
22:15:10	mriedem	Apoorva_: thanks, post it here and we'll get it fixed
22:17:48	openstackgerrit	Sujitha proposed openstack/nova master: Adding auto_disk_config field to InstancePayload https://review.openstack.org/419185
22:18:14	openstackgerrit	Sujitha proposed openstack/nova master: Reduce calls to load_tags() to 0 https://review.openstack.org/435146
22:19:00	openstack	Launchpad bug 1675584 in OpenStack Compute (nova) "TypeError: connect_volume() takes exactly 3 arguments (4 given) for NFS Cinder drivers" [Undecided,New]
22:19:00	Apoorva_	mriedem melwitt https://bugs.launchpad.net/nova/+bug/1675584
22:28:00	openstackgerrit	Sujitha proposed openstack/nova master: Add description to policies in cells_scheduler.py https://review.openstack.org/448260
22:31:51	tjones	mriedem: thanks - my schedule is messed up. stupid outloook…. i hate it
22:54:36	mriedem	i also hate outlook
22:54:52	mriedem	Apoorva_: thanks, will push a fix shortly
22:55:20	Apoorva_	mriedem appreciate it!
22:56:51	mriedem	gluster is also broken
22:57:58	mriedem	and quobyte
23:00:07	openstackgerrit	Anusha Unnam proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730
23:00:16	kaisers	mriedem: oh, good this is in the works. Saw the fails earlier and did not come around to take a more detailed look so far. Thanks!
23:00:44	kaisers	*ka-ching* and it's midnight
23:01:46	mriedem	np
23:01:57	mriedem	i'm making these abc's, they should have been anyway
23:04:07	mriedem	i have no idea why scality doesn't implement disconnect_volume
23:10:19	kaisers	hmm, same here. But i'm beyond useful anyways. Off for a few hrs of zzzzZZzz
23:10:23	mriedem	man the scality driver was added 4 years ago
23:25:44	mriedem	weird, the rbd driver doesn't implement connect_volume
23:33:47	openstackgerrit	Matt Riedemann proposed openstack/nova master: Revert "libvirt: Pass instance to connect_volume and ..." https://review.openstack.org/449362
23:34:00	mriedem	melwitt: dansmith: witness https://review.openstack.org/#/c/449362/
23:34:38	dansmith	omy
23:35:00	mriedem	i was fixing it locally but decided, you know what, nothing uses this, it's 6:34pm, and i have other things to do,
23:35:01	mriedem	so fuck it
23:35:31	dansmith	oh I was going to +W it for you but.. I guess you did :)
23:35:42	mriedem	feel free to pile on
23:38:03	mriedem	Apoorva_: https://review.openstack.org/#/c/449362/ is the fix for now
23:39:08	mriedem	oh also the scality volume driver was removed from cinder in ocata,
23:39:20	mriedem	so the libvirt volume driver for scality does nothing right now anyway
23:39:29	mriedem	so i'll follow up on removing that too
23:40:08	Apoorva_	mriedem thanks!
23:41:36	melwitt	revert makes sense to me too
23:47:50	openstackgerrit	Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444
23:55:34	openstackgerrit	Matt Riedemann proposed openstack/nova master: libvirt: remove scality volume driver https://review.openstack.org/449364

Earlier   Later