| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-23 | |||
| 17:27:57 | edleafe | kashyap: wow, you're psychic! :) | |
| 17:28:17 | kashyap | Heh | |
| 17:28:20 | edleafe | kashyap: wondering if you wanted me to send them to you to review | |
| 17:28:54 | edleafe | or should I paste the relevant sections | |
| 17:28:58 | kashyap | edleafe: Sure, do email them; but I won't promise that I'll see them tonight. Tomorrow I can. | |
| 17:29:07 | kashyap | edleafe: No, entire log would be useful. Why? | |
| 17:29:25 | kashyap | Because I can correlate the unique IDs libvirt sends out for each action it tries to coordinate with QEMU | |
| 17:29:34 | edleafe | kashyap: dunno, just being careful | |
| 17:29:40 | kashyap | If you accidentally snip out some request / response, I might lose some context | |
| 17:30:45 | edleafe | kashyap: makes sense | |
| 18:01:35 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Modify PciPassthroughFilter to accept lists https://review.openstack.org/444946 | |
| 18:01:35 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read NIC features in libvirt https://review.openstack.org/444415 | |
| 18:01:36 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova master: Read Neutron port 'binding_profile' during boot https://review.openstack.org/449257 | |
| 18:01:48 | mriedem | sdague: yeah those novaclient tests are timing out test_trigger_crash_dump_in_resized_state | |
| 18:03:16 | johnthetubaguy | mriedem: I hit some nasty rebase things on that refactor patch, will have to resolve those in the morning | |
| 18:03:49 | mriedem | johnthetubaguy: ok i'll do them today if i get a chance | |
| 18:08:10 | sdague | mriedem: yeh, I honestly think the crashdump tests probably have to be turned off | |
| 18:08:19 | openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in cells_scheduler.py https://review.openstack.org/448260 | |
| 18:08:38 | openstackgerrit | John Garbutt proposed openstack/nova master: compute: Move detach logic from manager into driver BDM https://review.openstack.org/439520 | |
| 18:09:39 | mriedem | johnthetubaguy: i guess it wasn't that bad huh :) | |
| 18:09:56 | johnthetubaguy | mriedem: so fixed my nit, but that needs a rebase after those patches we just approved | |
| 18:10:02 | mriedem | ok | |
| 18:12:22 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | |
| 18:12:38 | mriedem | sdague: alex_xu suggested that if we make that single PUT method for updating a service, we also change the response to include the full resource, like a GET call would https://review.openstack.org/#/c/447149/2/specs/pike/approved/service-hyper-uuid-in-api.rst@208 | |
| 18:12:45 | mriedem | sdague: i'd be OK with that, what do you think? | |
| 18:15:44 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/delete #1: no-ops https://review.openstack.org/438119 | |
| 18:16:44 | openstackgerrit | Vasyl Saienko proposed openstack/nova master: Implement interface attach/detach in ironic virt driver https://review.openstack.org/419975 | |
| 18:17:24 | efried | mriedem ^^ It's been tough getting flake8-import-order, rebasing, and subteam +1s all coordinated, but this one is hopefully ready to go again. | |
| 18:17:42 | efried | [Mine, not Vasyl's ;-)] | |
| 18:18:34 | sdague | mriedem: I am ok with full resource | |
| 18:18:52 | sdague | I also think it's not a terrible idea to fix that os-hypervisor query interface that's crazy at the same time | |
| 18:19:05 | sdague | given that everyone is going to need to adapt code forthis | |
| 18:24:19 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #2: functional https://review.openstack.org/438598 | |
| 18:25:22 | openstackgerrit | Monty Taylor proposed openstack/nova master: WIP Clean up and consolidate client creation https://review.openstack.org/438512 | |
| 18:27:59 | mriedem | sdague: so i should just rename to "complete unf*ch os-services and os-hypervisors" :) | |
| 18:28:11 | sdague | mriedem: ++ | |
| 18:28:25 | mriedem | wow spelling | |
| 18:38:37 | openstackgerrit | Peter Hamilton proposed openstack/nova-specs master: Add support for certificate validation https://review.openstack.org/357151 | |
| 18:40:04 | mriedem | sdague: ah it looks like we timeout and never kill a timer http://logs.openstack.org/11/449211/1/check/gate-novaclient-dsvm-functional-identity-v3-only-ubuntu-xenial-nv/9839aac/console.html#_2017-03-23_18_04_43_739252 | |
| 18:40:07 | mriedem | waiting for a server to build | |
| 18:40:41 | mriedem | i'll take a look | |
| 18:41:37 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: power_on/off and reboot https://review.openstack.org/427380 | |
| 18:42:47 | sdague | it's kind of suspicious that after a bunch of crash dumping rabbit goes sideways | |
| 18:42:58 | sdague | I'd start with disabling all those crashdump tests first | |
| 18:43:34 | mriedem | i seem to remember andreykurilin fixing something where the crash dump tests started taking a long time | |
| 18:43:44 | mriedem | andreykurilin: if you're around, do you remember something like that? | |
| 18:45:13 | openstackgerrit | Sean Dague proposed openstack/python-novaclient master: set test timout to 300 seconds https://review.openstack.org/449211 | |
| 18:45:31 | sdague | that's got the skip in there | |
| 18:45:35 | mriedem | we can use bug test_trigger_crash_dump_in_shutoff_state | |
| 18:45:39 | mriedem | oops | |
| 18:45:45 | openstack | bug 1675526 in python-novaclient "Trigger crash dump functional tests are timing out and hanging" [High,Triaged] https://launchpad.net/bugs/1675526 | |
| 18:45:45 | mriedem | bug 1675526 | |
| 18:45:54 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #3: TaskFlow https://review.openstack.org/438729 | |
| 18:45:59 | sdague | ok, feel free to update if you like, got to run away from keyboard for a bit | |
| 18:46:04 | mriedem | ok | |
| 18:55:52 | openstackgerrit | Matt Riedemann proposed openstack/python-novaclient master: Set test timout to 300 seconds https://review.openstack.org/449211 | |
| 19:09:37 | openstackgerrit | Rick Bartra proposed openstack/nova master: Add policy granularity to the Flavor API https://review.openstack.org/449288 | |
| 19:12:01 | openstackgerrit | Rick Bartra proposed openstack/nova master: Add policy granularity to the Flavor API https://review.openstack.org/449288 | |
| 19:16:32 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: spawn/destroy #4: full flavor https://review.openstack.org/391288 | |
| 19:20:09 | openstackgerrit | Sujitha proposed openstack/nova master: Adding tags field to InstancePayload https://review.openstack.org/407228 | |
| 19:26:51 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: console https://review.openstack.org/409402 | |
| 20:02:23 | openstackgerrit | Matt Riedemann proposed openstack/nova master: api-ref: fix description of volumeAttachment for attach/swap-volume https://review.openstack.org/449302 | |
| 20:33:24 | openstackgerrit | Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189 | |
| 20:42:05 | mriedem | sdague: in the api-ref for server details we have os-extended-volumes:volumes_attached which just says it's an array of attached volumes. at 2.1 it's a list of dicts with a single 'id' key which is the volume id. after 2.3 the list of dicts can also contain the 'delete_on_termination' key. | |
| 20:42:14 | mriedem | we don't describe the actual contents of that dict in the list, | |
| 20:42:20 | mriedem | i.e. the id and delete_on_termination keys, | |
| 20:42:27 | mriedem | i'm trying to figure out what's the best way to represent that, | |
| 20:42:32 | mriedem | would the name be os-extended-volumes:volumes_attached.id? | |
| 20:42:37 | mriedem | os-extended-volumes:volumes_attached.delete_on_termination? | |
| 20:42:49 | sdague | mriedem: that has been the pattern we were using | |
| 20:44:26 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in suspend_server.py https://review.openstack.org/447722 | |
| 20:44:32 | mriedem | sdague: ok, alternatively to avoid the turducken of nested parameters, i could just describe those keys in the description for the os-extended-volumes:volumes_attached parameter? | |
| 20:45:35 | sdague | you could, but it sort of breaks the flow | |
| 20:45:42 | sdague | I would honestly do the nested thing | |
| 20:45:44 | mriedem | i'll just do the normal pattern | |
| 20:45:45 | mriedem | ok | |
| 20:45:55 | mriedem | danke | |
| 20:46:09 | mriedem | writing functional regression tests that actually use our api makes you have to actually read the api docs :) | |
| 20:46:10 | mriedem | it's amazing | |
| 20:46:49 | sdague | mriedem: yeh, and it's close enough now that it's worth fixing when you find a weird issue we missed | |
| 20:46:59 | mriedem | yeah that's true | |
| 20:47:11 | mriedem | if it were a needle in a haystack i'd be much less motivated | |
| 20:58:16 | cfriesen | I'm looking at the "realtime" handling of emupcpus in _get_guest_numa_config() and I'm confused about the case where the instance isn't pinned | |
| 20:58:34 | mriedem | cfriesen: sahid and sfinucan are your people | |
| 20:58:38 | mriedem | but aren't around probably | |
| 20:59:16 | cfriesen | yeah...I'll ask tomorrow | |
| 21:36:05 | mriedem | dansmith: melwitt: just verified that local delete regression when deleting a shelved offloaded server with volumes attached | |
| 21:36:10 | mriedem | will push up the test to show it shortly | |
| 21:36:13 | mriedem | writing the bug report | |
| 21:36:21 | dansmith | uh yeahokay | |
| 21:36:24 | dansmith | upps | |
| 21:36:26 | dansmith | wtf | |
| 21:37:17 | melwitt | regression :( | |
| 21:38:33 | mriedem | mfing local delete | |
| 21:38:38 | openstack | Launchpad bug 1675570 in OpenStack Compute (nova) "Volumes are not detached when deleting shelved offloaded servers" [High,Triaged] | |
| 21:38:38 | mriedem | https://bugs.launchpad.net/nova/+bug/1675570 | |
| 21:39:36 | bauzas | mriedem: dansmith: hola, FYI https://review.openstack.org/#/c/391060/ is ready for reviews :) | |
| 21:41:17 | melwitt | mriedem: we have the _local_delete function that does all the volume detach stuff, but we never incorporated calling it into the cells v2 short circuits of delete. I think because we were only thinking of the "not yet scheduled" case | |
| 21:41:25 | mriedem | yup | |
| 21:41:31 | mriedem | hold gentle caller, | |