| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-17 | |||
| 14:23:07 | kashyap | mdbooth: Okay, noted. Just to restate: The backing file(s) must be sparse; and the overlays are loopback devices -- then try a copy among the overlays and see if sparseness is preserved | |
| 14:23:08 | mriedem | extend base class, and that gives you most of what you need | |
| 14:23:12 | mriedem | self.nova() runs the command | |
| 14:23:21 | mdbooth | kashyap: Bingo | |
| 14:23:29 | kashyap | edleafe: Don't give up! One simply does not give up in #openstack-nova channel! | |
| 14:23:38 | mdbooth | kashyap: I think that accurately represents the issue as described | |
| 14:23:57 | kashyap | Okay, with that clarity, bbiab | |
| 14:24:01 | edleafe | kashyap: heh, I figured it was taking me so long you might have thought that I just went back to bed or something | |
| 14:24:25 | ijw | The Nova team has beds now? | |
| 14:24:31 | ijw | Luxury. | |
| 14:24:37 | edleafe | Indeed! | |
| 14:24:51 | mriedem | i have a dugout in the dirt | |
| 14:24:55 | mriedem | it serves my needs | |
| 14:27:07 | markus_z | mriedem: AFAIK I provided all information for your concerns on https://review.openstack.org/#/c/406898/ Can I do anything else there? | |
| 14:30:30 | mriedem | markus_z: i've removed the -1 | |
| 14:30:37 | markus_z | thanks | |
| 14:31:56 | mriedem | markus_z: so basically there are some things backported, like the console refactor patches, which were not functionally needed, but made the target bug fix backport easier | |
| 14:32:25 | mriedem | and all of those groundwork backports are already merged by now anyway | |
| 14:33:19 | markus_z | mriedem: The refactor patches were not backported as they weren't functionally needed. That's why there are conflicts. | |
| 14:34:18 | markus_z | *if* we would have backported the "groundwork" patches, then there wouldn't have been conflicts. | |
| 14:34:35 | mriedem | sure, but that refactor series also introduced a regression in ocata, | |
| 14:34:40 | mriedem | the one about xen and libvirtd | |
| 14:34:46 | mriedem | *virtlogd | |
| 14:35:04 | markus_z | ah, damn, you're right | |
| 14:35:13 | mriedem | right, so we don't want those backports | |
| 14:35:15 | mriedem | for the refactor patches | |
| 14:35:21 | mriedem | or did we backport that to newton? | |
| 14:35:36 | markus_z | sec, I have to check the fix again, need a minute | |
| 14:35:58 | mriedem | looking at the topic branch for newton i don't think we did https://review.openstack.org/#/q/topic:%22bug+1455252%22 | |
| 14:36:23 | mriedem | i think that was https://review.openstack.org/#/c/385367/ | |
| 14:36:41 | mriedem | hmm maybe not | |
| 14:38:42 | markus_z | That was your fix: https://review.openstack.org/#/c/442550/ | |
| 14:40:43 | markus_z | I think it was this one: https://review.openstack.org/#/c/407450/3/nova/virt/libvirt/driver.py | |
| 14:41:32 | markus_z | yep, pretty sure. That's where I screwed up the log_path. | |
| 14:41:41 | mriedem | yup | |
| 14:41:45 | markus_z | That's not backported. | |
| 14:41:49 | mriedem | ok | |
| 14:43:06 | raj_sing- | mriedem: edmondsw Performance testing with service token enabled is part of our plan for Pike. I am not sure yet how to do that, but will focus once glance patch land. Currently we are debugging some errors on that patch. | |
| 14:43:13 | mriedem | markus_z: +W my german friend | |
| 14:43:29 | mriedem | sorry for the delay | |
| 14:43:30 | edmondsw | raj_sing- great, tx | |
| 14:44:53 | mriedem | mtreinish: sdague: can you take a look at these ocata backports? fixes the retry regression: https://review.openstack.org/#/q/topic:bug/1671648+branch:stable/ocata | |
| 14:45:07 | markus_z | mriedem: Thanks a lot my american hero ;P | |
| 14:45:23 | gibi | mriedem, mdbooth: I looked into the circular reference bug you found yesterday. Here is the easiest way to solve it https://review.openstack.org/#/c/446948/ | |
| 14:45:26 | sdague | mriedem: mtreinish is in singapore, so it's sat already | |
| 14:45:27 | mriedem | mtreinish: what was the anime new york hero guy again? | |
| 14:45:31 | mriedem | damn | |
| 14:45:46 | mriedem | bauzas: can you take a pass through these backports? https://review.openstack.org/#/q/topic:bug/1671648+branch:stable/ocata | |
| 14:46:49 | markus_z | frickler: Got a second about https://review.openstack.org/#/c/444164/3 ? That's the VNC setup patch. | |
| 14:49:20 | Dinesh_Bhor | Hi all, Can someone take a look at these two small patches: https://review.openstack.org/#/c/445338/ , https://review.openstack.org/#/c/445782/ Both are having one +2. | |
| 14:52:42 | openstackgerrit | Sean Dague proposed openstack/nova master: Improve descriptions for hostId, host, and hypervisor_hostname https://review.openstack.org/446761 | |
| 14:53:03 | sdague | mriedem / melwitt how about that wording ^^^^ | |
| 14:55:04 | mriedem | sdague: typos | |
| 14:55:12 | mriedem | plus other unaddressed stuff from PS1 | |
| 14:55:22 | mriedem | otherwise the new wording is good, and the example of why it's useful | |
| 14:55:51 | sdague | mriedem: I'll fix the typos, I think the adminstrator only adds are just consistent with other fields that have it | |
| 14:55:54 | sdague | so are fine | |
| 14:56:11 | mriedem | i'm pretty sure nothing else in the os-hypervisors api ref says "this field is only for admins" | |
| 14:56:31 | mriedem | https://developer.openstack.org/api-ref/compute/?expanded=show-hypervisor-details-detail#show-hypervisor-details | |
| 14:56:51 | mriedem | so if we say that for hypervisor_hostname in that API ref, then say it for all, | |
| 14:56:52 | mriedem | or none | |
| 14:57:05 | mriedem | if you're going to chew gum in class, you have to bring enough for everyone | |
| 14:57:47 | openstackgerrit | Sean Dague proposed openstack/nova master: Improve descriptions for hostId, host, and hypervisor_hostname https://review.openstack.org/446761 | |
| 14:58:04 | sdague | damn, the inline editor doesn't let you make 2 edits as once | |
| 14:59:17 | openstackgerrit | Sean Dague proposed openstack/nova master: Improve descriptions for hostId, host, and hypervisor_hostname https://review.openstack.org/446761 | |
| 14:59:40 | openstackgerrit | Sean Dague proposed openstack/nova master: Improve descriptions for hostId, host, and hypervisor_hostname https://review.openstack.org/446761 | |
| 14:59:45 | mriedem | jesus | |
| 14:59:55 | mriedem | at some point you just have to pull it down sean :() | |
| 15:00:22 | sdague | because changesets are expensive? | |
| 15:00:59 | openstackgerrit | Dan Smith proposed openstack/python-novaclient master: Fix aggregate_update name and availability_zone clash https://review.openstack.org/447009 | |
| 15:01:08 | mriedem | sdague: because it keeps getting messed up | |
| 15:01:14 | mriedem | you fix one thing but not another, and then vice-versa | |
| 15:01:24 | sdague | mriedem: ok, oh is it reverting the old ones? | |
| 15:01:28 | sdague | gah, ok | |
| 15:01:34 | mriedem | i guess? | |
| 15:01:37 | mriedem | idk man, just pull it down | |
| 15:01:53 | mriedem | i'm enjoying my -1 stat padding though | |
| 15:01:59 | sdague | heh | |
| 15:02:15 | sdague | this is one of those areas where github is *so* much better than gerrit | |
| 15:03:32 | jgriffith | mriedem johnthetubaguy hey... just want to check with the two of you. For the client.get_highest_microversion call; would you prefer that we ONLY call that when a call for a method that requires/wants the version info is requested? | |
| 15:04:26 | jgriffith | johnthetubaguy I think that might be the point you were trying to make in the review comments, so rather than ALWAYS do it on init, provide an explicit method to query that info, and then also use that mechanism when calling things like the new attach/detach methods | |
| 15:04:30 | openstackgerrit | Sean Dague proposed openstack/nova master: Improve descriptions for hostId, host, and hypervisor_hostname https://review.openstack.org/446761 | |
| 15:05:35 | leakypipes | mhenkel: yup! | |
| 15:05:53 | johnthetubaguy | jgriffith: so if you get your detach patch, and try use the logic, I think that will clear things up. That needs 3.27 or it fails with "the world is upside down" error. Only attach needs the explcit call to check if 3.27 is supported and chose the old or new path. | |
| 15:06:00 | melwitt | that api-ref wording is a hot topic I see! | |
| 15:06:13 | mriedem | +2 | |
| 15:06:14 | mriedem | finally | |
| 15:06:19 | mriedem | welcome new contributor | |
| 15:06:29 | johnthetubaguy | melwitt: looking at what dansmith has done to your quota patches, I guess you are working through that? | |
| 15:06:31 | jgriffith | johnthetubaguy ok | |
| 15:06:35 | jgriffith | johnthetubaguy thanks | |
| 15:07:00 | dansmith | johnthetubaguy: yes, I made a mess, but I knew it was going to be | |
| 15:07:03 | melwitt | johnthetubaguy: yes, sorry about that. I'm going to finish fixing those up today. we split them into smaller chunks for easier review | |
| 15:07:25 | dansmith | melwitt: I can help if you want, but probably not very parallelizeable work | |
| 15:07:38 | melwitt | johnthetubaguy: on the one you reviewed today, that "destroy all by project" is just a plain destroy. that patch is just making Quotas object read/write to API DB | |
| 15:08:26 | melwitt | dansmith: nah, it's okay, I have got it | |
| 15:09:14 | melwitt | johnthetubaguy: I think what you were thinking of was an older version of the quota counting patch where I was using a destroy with limit/offset for addressing races | |
| 15:09:18 | melwitt | I took that out | |
| 15:12:43 | openstackgerrit | Silvan Kaiser proposed openstack/nova master: Removes getfattr from Quobyte Nova driver https://review.openstack.org/428646 | |
| 15:13:05 | melwitt | johnthetubaguy: nevermind my earlier statement. I think I don't understand what you mean by "Its the delete something and the sync logic brings it back to life problem." | |