| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-16 | |||
| 18:19:19 | mriedem | mdbooth: https://bugs.launchpad.net/nova/+bug/1673375/comments/3 | |
| 18:19:32 | mriedem | the notification is coming from the wrap_exception decorator here https://github.com/openstack/nova/blob/2380659e358770a3f36253b93a112b9779a23958/nova/compute/api.py#L4602 | |
| 18:19:38 | mriedem | but i don't know what the circular reference is | |
| 18:20:55 | mdbooth | I expect if we knew that and decoded the big chunk of text above we'd discover it | |
| 18:21:53 | mriedem | something is messed up in that change of yours | |
| 18:22:01 | mriedem | TypeError: get_by_instance_mapping_list() got an unexpected keyword argument 'expected_addrs' | |
| 18:22:07 | openstackgerrit | OpenStack Proposal Bot proposed openstack/python-novaclient master: Updated from global requirements https://review.openstack.org/446674 | |
| 18:22:18 | mdbooth | mriedem: Yeah, I've fixed it since | |
| 18:22:22 | mriedem | ah ok | |
| 18:22:31 | mdbooth | It was just a typo | |
| 18:22:49 | mriedem | johnthetubaguy: https://review.openstack.org/#/c/446672/ | |
| 18:22:50 | mriedem | yup | |
| 18:22:52 | mriedem | addrs/attrs | |
| 18:23:01 | mriedem | johnthetubaguy: ^ is the cinderclient min version bump | |
| 18:23:20 | mdbooth | mriedem: Now *you* saw that straight away. I stared at it so long I became blind to it. | |
| 18:23:45 | mriedem | pair programming | |
| 18:23:54 | mriedem | the ibm execs were right! | |
| 18:24:52 | mriedem | we were told that spotify did everything correctly, and so we needed to do everything they did | |
| 18:24:53 | mriedem | like, | |
| 18:25:05 | mriedem | pair programming, squads, kanban, agile, | |
| 18:25:11 | mriedem | work around a single table in a room | |
| 18:25:14 | mriedem | eat together | |
| 18:25:17 | mriedem | sleep together | |
| 18:25:18 | mriedem | etc etc | |
| 18:25:22 | mriedem | out pops innovation | |
| 18:25:39 | mriedem | yada yada yada, 18 months later, i left ibm | |
| 18:25:41 | mriedem | ") | |
| 18:25:43 | mriedem | :) | |
| 18:26:08 | mdbooth | mriedem: So, looking at that circular reference thing, there are a few python objects on those dicts | |
| 18:26:33 | ildikov | mriedem: sounds like a long time to sleep together with the whole team :) | |
| 18:26:42 | mriedem | ildikov: you wouldn't believe the VD | |
| 18:26:44 | mdbooth | If the json dumper is trying to serialise them, and there's a circular reference in there | |
| 18:26:52 | mdbooth | Then... that would be a circular reference | |
| 18:26:57 | mdbooth | There are plenty to choose from | |
| 18:27:17 | ildikov | mriedem: VD? | |
| 18:27:24 | mdbooth | There's probably stuff in there it's just not useful to serialise, tbh | |
| 18:27:37 | mriedem | venereal disease | |
| 18:27:46 | mriedem | ildikov: a joke | |
| 18:28:21 | ildikov | mriedem: I knew it was a joke, just had no idea what VD is, LOL | |
| 18:28:43 | ildikov | mriedem: I could've guessed though :) | |
| 18:30:37 | openstackgerrit | Sujitha proposed openstack/nova master: Add helper method to add additional data about policy rule. https://review.openstack.org/434842 | |
| 18:35:01 | openstack | bug 1671648 in OpenStack Compute (nova) ocata "Instances are not rescheduled after deploy fails" [High,In progress] https://launchpad.net/bugs/1671648 - Assigned to Matt Riedemann (mriedem) | |
| 18:35:01 | openstackgerrit | melanie witt proposed openstack/nova master: Fix functional regression/recreate test for bug 1671648 https://review.openstack.org/446685 | |
| 18:35:38 | melwitt | mriedem: while I was working on making it consider two hosts while scheduling, I discovered a race. so I have put up a fix ^ | |
| 18:35:58 | melwitt | the regression test, that is | |
| 18:36:51 | mriedem | melwitt: ok, cool | |
| 18:37:20 | mriedem | i had backported the functional regression test and the retry fix to ocata already, they aren't merged, but we could hold them up for the race fix too | |
| 18:37:21 | mriedem | in the test | |
| 18:38:26 | melwitt | okay | |
| 18:40:26 | melwitt | mriedem: the "host" on the instance server attributes is the host from the start_service('compute', host=) but the "hypervisor_hostname" is the nodename, and the nodename for both hosts was the same "fake-mini" so that's how they got collapsed into only one host for scheduling | |
| 18:41:03 | dansmith | and nodes bites us in the ass once again | |
| 18:41:26 | melwitt | there's a fake.set_nodes() that lets you set the hostnames to return and you have to do it before starting each compute service fixture | |
| 18:41:38 | melwitt | yeah :( node ass-biters | |
| 18:41:58 | mriedem | ah ok | |
| 18:41:59 | mriedem | ouch | |
| 18:42:19 | mriedem | also, can you all please clean it up please, | |
| 18:42:27 | mriedem | i'd like to keep this channel classy | |
| 18:42:48 | melwitt | after I set the nodes, the race reared its head, sometimes I got a Claim, sometimes I got a NopClaim | |
| 18:43:57 | mriedem | alright, my kid just threw up in class so i'm going to the school, back in a bit | |
| 18:44:32 | mriedem | probably all those stories i told here about nodes and local delete and quotas | |
| 18:44:57 | openstackgerrit | Lee Yarwood proposed openstack/nova master: objects: Add attachment_id to BlockDeviceMapping https://review.openstack.org/437665 | |
| 18:44:58 | openstackgerrit | Lee Yarwood proposed openstack/nova master: db: Add attachment_id to block_device_mapping https://review.openstack.org/437597 | |
| 18:46:17 | openstack | bug 1671648 in OpenStack Compute (nova) ocata "Instances are not rescheduled after deploy fails" [High,In progress] https://launchpad.net/bugs/1671648 - Assigned to Matt Riedemann (mriedem) | |
| 18:46:17 | openstackgerrit | melanie witt proposed openstack/nova master: Fix functional regression/recreate test for bug 1671648 https://review.openstack.org/446685 | |
| 18:46:32 | melwitt | mriedem: hah, hope she's okay | |
| 19:06:15 | openstackgerrit | John Garbutt proposed openstack/nova-specs master: Add service-protected-server spec https://review.openstack.org/438134 | |
| 19:13:29 | mriedem | lyarwood: when are you doing for the day? | |
| 19:18:03 | mriedem | *done | |
| 19:18:13 | mriedem | i'm going to add tests to your bottom change, and fix the test in the object change | |
| 19:27:54 | mriedem | his bottom is a mess | |
| 19:28:13 | mriedem | don't want the rash to set in | |
| 19:30:59 | openstackgerrit | Steve Noyes proposed openstack/nova master: Throw exception if swap volume attempted on stopped server https://review.openstack.org/446708 | |
| 19:31:21 | openstackgerrit | Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292 | |
| 19:31:21 | openstackgerrit | Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174 | |
| 19:31:22 | openstackgerrit | Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293 | |
| 19:31:22 | openstackgerrit | Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487 | |
| 19:31:23 | openstackgerrit | Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861 | |
| 19:31:24 | openstackgerrit | Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736 | |
| 19:31:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: db: Add attachment_id to block_device_mapping https://review.openstack.org/437597 | |
| 19:31:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: objects: Add attachment_id to BlockDeviceMapping https://review.openstack.org/437665 | |
| 19:36:49 | mriedem | melwitt: per your test fix, seems we should add some better descriptions for host and hypervisor_hostname in the api-ref https://developer.openstack.org/api-ref/compute/?expanded=show-server-details-detail#id25 | |
| 19:36:57 | mriedem | host: The host name. Appears in the response for administrative users only. | |
| 19:37:05 | mriedem | hypervisor_hostname: The hypervisor host name. Appears in the response for administrative users only. | |
| 19:37:24 | mriedem | oh don't forget hostId: The ID of the host. | |
| 19:37:29 | mriedem | thanks compute api ref! | |
| 19:37:45 | melwitt | mriedem: yeah, I actually had a look at that. I wasn't sure if maybe it was intentional that they don't mention the distinction between host name and nodename | |
| 19:38:12 | melwitt | when you run for real, they the same unless you're running ironic | |
| 19:38:34 | mriedem | i'm not sure what the point in making the description unclear would be | |
| 19:38:42 | mriedem | do we get any security benefit from that? | |
| 19:39:02 | melwitt | I dunno. I was thinking maybe if there was concern about exposing implementation details like host and nodename. I'm not sure it matters | |
| 19:40:13 | melwitt | hypervisor_hostname: either the host name or the Ironic node name if ironic_driver | |
| 19:40:22 | melwitt | so, maybe that's reasonable to put there | |
| 19:40:27 | mriedem | i think so | |
| 19:40:38 | mriedem | if we can't actually explain wtf the fields are in our API response, our API sucks, right? | |
| 19:40:47 | mriedem | i'm pretty sure if cdent were around i'd get a checkmark for that | |
| 19:40:48 | melwitt | yeah. | |
| 19:40:58 | melwitt | hehe | |
| 19:41:05 | mriedem | i'll open a bug | |
| 19:41:10 | melwitt | k | |
| 19:42:32 | openstackgerrit | John Griffith proposed openstack/nova master: Add Cinder API version detection https://review.openstack.org/444465 | |