| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-15 | |||
| 00:53:17 | dansmith | otherwise there's this odd ambiguity, | |
| 00:53:44 | dansmith | and the node resource class is an ironic construct, not specifically "this is (or may be) the exact resource class in placement" | |
| 00:54:40 | mriedem | so ironic's API should then return a 400 if i try to set node.resource_class to anything with the CUSTOM_ prefix? | |
| 00:55:01 | dansmith | that's up to them, but I'd expect not | |
| 00:55:59 | dansmith | and since they haven't placed those restrictions thus far (any of the ones required to be a resource class in placement), | |
| 00:56:23 | dansmith | we should just treat that as a thing, prefix with CUSTOM_ and normalize as we need) | |
| 00:56:41 | dansmith | like, maybe they let the resource class include spaces, they clearly allow lowercase, maybe punctuation, etc | |
| 00:56:46 | dansmith | and that's cool | |
| 01:00:10 | mriedem | ok so CUSTOM_CUSTOM_BAREMETAL_GOLD just might be a thing you end up with, and if so, oops, but it doesn't break | |
| 01:00:37 | dansmith | right | |
| 01:00:58 | mriedem | not sure i want to start thinking about what it would take to unwind that if you wanted to fix it, | |
| 01:01:04 | mriedem | across both services | |
| 01:01:13 | dansmith | I don't think it's a big deal actually, but, | |
| 01:01:23 | dansmith | when they start reporting into placement, they can generate and handle their classes however they want | |
| 01:03:12 | mriedem | ok | |
| 01:03:21 | mriedem | i've left comments in the code parts, will do tests later | |
| 01:57:11 | openstackgerrit | Danfly proposed openstack/nova master: Completely remove mox from unit/network/test_linux_net.py https://review.openstack.org/445504 | |
| 02:19:44 | openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Send out notifications when instance tags changed https://review.openstack.org/429569 | |
| 02:47:36 | openstackgerrit | Wei Cao proposed openstack/nova master: vmware: Change the VM Create spec https://review.openstack.org/444119 | |
| 03:09:03 | alex_xu | gmann: johnthetubaguy some test https://review.openstack.org/445361 | |
| 03:46:51 | openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Repropose tag-instance-when-boot https://review.openstack.org/415315 | |
| 04:28:24 | openstackgerrit | Hieu LE proposed openstack/nova master: Completely remove mox from objects/test_instance.py https://review.openstack.org/343465 | |
| 05:08:44 | openstackgerrit | Wei Cao proposed openstack/nova master: vmware: Change the VM Create spec https://review.openstack.org/444119 | |
| 05:16:19 | openstackgerrit | OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/443357 | |
| 05:25:42 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add api-ref for filter/sort whitelist https://review.openstack.org/421760 | |
| 05:42:12 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Permit Live Migration of Rescued Instances https://review.openstack.org/308198 | |
| 06:55:20 | openstackgerrit | Sergey Nikitin proposed openstack/nova master: Standardization of VM diagnostics info API. https://review.openstack.org/355540 | |
| 07:08:33 | openstackgerrit | Dinesh Bhor proposed openstack/nova master: Use HostAddressOpt for opts that accept IP and hostnames https://review.openstack.org/445782 | |
| 07:11:32 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova-specs master: Live Migration of Rescued Instances https://review.openstack.org/347161 | |
| 08:10:02 | jichen | alex_xu, hi have time for a quick talk? | |
| 08:10:29 | alex_xu | jichen: yea, sure, please | |
| 08:10:47 | openstack | Launchpad bug 1670978 in OpenStack Compute (nova) "most of extended server attributes returned in 2.3 api versions should not require admin role" [Undecided,New] - Assigned to jichenjc (jichenjc) | |
| 08:10:47 | jichen | https://bugs.launchpad.net/nova/+bug/1670978, this need a spec ,right? if any changes might need to be done | |
| 08:11:12 | alex_xu | jichen: 不需要 | |
| 08:11:16 | alex_xu | sorry | |
| 08:11:19 | alex_xu | jichen: it needn't | |
| 08:11:26 | jichen | why ? | |
| 08:11:46 | jichen | API changes no spec needed any more ? | |
| 08:11:58 | alex_xu | jichen: it is only about change a default value of a policy rule from admin-only to owner_or_admin | |
| 08:12:54 | jichen | um... part of the return value affected ,I thought if we affect output format , this is API change? | |
| 08:13:33 | alex_xu | jichen: yea, that always confuse us, but actually, that can't be resolved by microversion, it should be resolved by capabilities API | |
| 08:14:09 | alex_xu | jichen: here is https://review.openstack.org/#/c/386555/ | |
| 08:14:12 | jichen | alex_xu: so this bug might need the API-WG discussion on cap talk settle down then continue? | |
| 08:14:24 | alex_xu | jichen: i think no... | |
| 08:14:29 | jichen | alex_xu: yeah, I knew this discussion | |
| 08:14:41 | jichen | ok, I will give another thought and see how to proceed this | |
| 08:14:44 | alex_xu | johnthetubaguy: ^ I think we needn't waiting for cap API, right? | |
| 08:15:19 | alex_xu | jichen: thanks, if johnthetubaguy also ensure this needn't waiting for cap API, then ping me when the patch ready | |
| 08:15:32 | jichen | ok | |
| 08:15:42 | jichen | another question | |
| 08:15:54 | alex_xu | jichen: yea, please | |
| 08:16:41 | jichen | https://review.openstack.org/307675, it's abandoned but this seems discussed before and a potential item? any discussion on PTG about it ? | |
| 08:17:15 | jichen | Change subject: Make API errors conform to API-WG schema | |
| 08:17:16 | alex_xu | jichen: there is no discussion about this in the PTG | |
| 08:17:40 | jichen | ok... I went through the ethpad and didn't find anything.... | |
| 08:17:58 | alex_xu | jichen: yea, I didn't remember we bring that idea into the api meeting before PTG also | |
| 08:18:05 | jichen | so it might be restore back later after P , Q ... :) ? | |
| 08:18:20 | alex_xu | jichen: yea, first ensure someone commit to work on it | |
| 08:18:28 | jichen | I can't remember clearly but seems I saw it's discussed somewhere | |
| 08:18:43 | alex_xu | jichen: there is proposal add that into placement API | |
| 08:18:54 | jichen | ok, can you point me the link? | |
| 08:19:02 | alex_xu | searching the link | |
| 08:19:08 | jichen | ok, thanks~ | |
| 08:19:25 | alex_xu | jichen: https://review.openstack.org/#/c/418393/ | |
| 08:19:36 | alex_xu | maybe co-work with that spec, and migrate the solution into the nova api | |
| 08:19:44 | jichen | alex_xu: great, thanks a lot~ | |
| 08:19:51 | jichen | I will take a look :) | |
| 08:19:57 | alex_xu | jichen: np :) | |
| 09:00:04 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: Make guest.BlockDevice only use the target dev of a disk https://review.openstack.org/402163 | |
| 09:00:04 | openstackgerrit | Lee Yarwood proposed openstack/nova master: libvirt: utils.get_disk return the target dev of the root device https://review.openstack.org/402716 | |
| 09:39:20 | openstackgerrit | jichenjc proposed openstack/nova master: WIP: allow owner to retrieve some data by default https://review.openstack.org/445844 | |
| 09:41:33 | openstackgerrit | jichenjc proposed openstack/nova master: WIP: allow owner to retrieve some data by default https://review.openstack.org/445844 | |
| 09:44:53 | openstackgerrit | Matthew Booth proposed openstack/nova master: Add InstanceList.get_by_instance_mapping_list() https://review.openstack.org/445141 | |
| 09:51:23 | mdbooth | lyarwood: Morning. Can you point me at your series again? | |
| 09:53:37 | lyarwood | mdbooth: https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bug/1489581 & https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/cinder-new-attach-apis | |
| 09:54:15 | lyarwood | mdbooth: the first two are just nice to have, we've been trying to get a uuid added for bdms for ages | |
| 09:54:52 | mdbooth | lyarwood: K. I'll ask a series of dumb questions throughout the morning in all likelihood | |
| 09:55:06 | openstackgerrit | Matthew Booth proposed openstack/nova master: Make server_external_events use an optimal number of db queries https://review.openstack.org/445142 | |
| 09:55:54 | lyarwood | mdbooth: np and thanks for looking at this | |
| 10:05:25 | openstackgerrit | Sergey Nikitin proposed openstack/nova-specs master: TinyFix: Changed type of CPU ID from 'String' to 'Integer' in diagnostics spec https://review.openstack.org/445855 | |
| 10:19:11 | ildikov | lyarwood: hi | |
| 10:19:45 | ildikov | lyarwood: are the BDM patches ready for review? | |
| 10:20:10 | lyarwood | ildikov: yes, mdbooth is going over them now | |
| 10:20:31 | ildikov | lyarwood: I saw on the priority etherpad that they are still listed under subteam review, but if you fixed Matt's comments, etc then I'll move them to ready | |
| 10:20:48 | ildikov | lyarwood: great, I'll move them on the etherpad too | |
| 10:20:56 | ildikov | lyarwood: tnx | |
| 10:21:42 | mdbooth | lyarwood: Do you happen to know why we don't refer to bdms by the primary key (id)? | |
| 10:22:04 | mdbooth | We don't do that anywhere, so this isn't an outlier | |
| 10:22:10 | mdbooth | Just wondering if you know why | |
| 10:23:04 | lyarwood | I wasn't aware that we ever did that so no, if we did I don't know why we stopped | |
| 10:24:31 | mdbooth | I suppose the db's primary key isn't universally unique... | |
| 10:24:52 | lyarwood | yeah, as we are moving towards multiple dbs etc I guess we needed uuids | |
| 10:27:32 | openstackgerrit | Ildiko Vancsa proposed openstack/nova master: Deprecate the Cinder API v2 support https://review.openstack.org/444253 | |
| 10:27:47 | openstackgerrit | jichenjc proposed openstack/nova master: remove keypair server extension https://review.openstack.org/396611 | |
| 10:27:57 | openstackgerrit | Alex Xu proposed openstack/nova master: Another poc for removing stevedore for nova api https://review.openstack.org/445864 | |
| 10:29:35 | arslanq | hi guys, i am confused about live migration of VMs. What is the requirement of live migration does it require shared storage ? | |
| 10:32:08 | rpodolyaka | arslanq: it does not. libvirt can 'block migrate' the storage for you | |
| 10:32:22 | rpodolyaka | arslanq: that being said, shared storage is highly recommended | |
| 10:33:16 | MasterofJOKers | https://docs.openstack.org/admin-guide/compute-configuring-migrations.html#block-migration | |
| 10:37:58 | arslanq | rpodolyaka: Thanks, i am facing some errors on block migration. i'll get back to you | |