| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-14 | |||
| 17:34:49 | mriedem | which could probably work, but wasn't something i thought of doing, at least in the mainline path | |
| 17:34:58 | dansmith | because the reservations are in the cell it's not in, right? | |
| 17:35:05 | mriedem | correct, | |
| 17:35:18 | sdague | I don't know, I just see you did a lookup call to figure out what cell the instance is in right above it | |
| 17:35:25 | mriedem | but i think sdague is asking why i have to be explicit about looking up the instance.flavor in the proper cell, rather than instance.flavor lazy-load doing that for us implicitly | |
| 17:35:32 | sdague | so from a naive pov, it seems like that could be stashed in instance itself | |
| 17:36:15 | mriedem | we could handle InstanceNotFound in the obj_load_attr in the Instance object and if the context isn't targeted for a cell (no db_connection attr) we could do an instance mapping lookup on ourselves | |
| 17:36:16 | dansmith | sdague: because that's not how it works right now | |
| 17:36:21 | dansmith | :) | |
| 17:36:26 | mriedem | but that's not going to happen in the backport | |
| 17:37:08 | mriedem | dansmith: do you think doing a notfound / lookup / re-query in the instance.obj_load_attr is worth looking into so we can avoid explicit context switching like this? | |
| 17:37:18 | dansmith | no | |
| 17:37:39 | dansmith | the instance object should never know about instancemapping | |
| 17:37:41 | mriedem | too magical and hard to debug if it's wrong? | |
| 17:37:42 | mriedem | ok | |
| 17:37:56 | dansmith | they're in different databases, and that thing will fail if we hit that notfound if we're on a compute for example | |
| 17:38:42 | mriedem | yeah | |
| 17:39:10 | sdague | ok, well this feels kind of fragile, but if that's what we got, so be it | |
| 17:40:02 | mriedem | i don't disagree that this is gorpy, the instance delete path has always been bad and this isn't helping | |
| 17:40:19 | dansmith | the instance delete path is like some of the worst code we have | |
| 17:40:26 | dansmith | right behind BDMs probably :) | |
| 17:40:34 | mriedem | what about quotas? | |
| 17:40:36 | mriedem | this is quotas + delete | |
| 17:40:38 | mriedem | worst ever | |
| 17:40:48 | openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova master: Make versioned notifications topics configurable https://review.openstack.org/444947 | |
| 17:40:48 | melwitt | local delete | |
| 17:40:54 | mriedem | i do think we have some stuff we can cleanup in the delete flow that was meant for the transition to cells v2 | |
| 17:41:13 | mriedem | i started trying that cleanup here https://review.openstack.org/#/c/443405/ | |
| 17:41:25 | mriedem | but apparently part of it is still needed | |
| 17:41:28 | melwitt | that reminds me, I still have a patch up for one of the local delete problems https://review.openstack.org/340614 | |
| 17:41:42 | mriedem | melwitt: the 10th revert of the 10th revert? | |
| 17:42:05 | melwitt | yeah | |
| 17:43:06 | mriedem | dansmith: if you can hit the 2 remaining ocata patches https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:stable/ocata then i can prep the release | |
| 17:43:16 | mriedem | i have a date with a 4th notary | |
| 17:44:33 | mriedem | jaypipes: that ironic inventory patch is on my list for the afternoon once i get rejected by this other notary | |
| 17:45:11 | johnthetubaguy | bauzas: I think there are quite a few unresolved comments from previous patch sets on this one: https://review.openstack.org/#/c/440580 | |
| 17:45:23 | johnthetubaguy | bauzas: am I missing context on another discussion that resolved them? | |
| 17:53:12 | jaypipes | mriedem: cool, thx | |
| 17:56:04 | melwitt | dansmith: on the host_manager thing, I don't think you need to change anything. I'm just missing how the double iterating would have to happen if it were changed | |
| 17:56:18 | dansmith | I just explained | |
| 17:56:36 | melwitt | from the context in that file, I just wasn't seeing it | |
| 17:56:40 | dansmith | and I've already changed it | |
| 17:57:09 | dansmith | there's not a double iteration if I put the conditional in the caller, I just thought the point was to avoid the conditional, | |
| 17:57:21 | dansmith | and if not, then I don't get the point of moving | |
| 17:57:37 | dansmith | but it's done anyway | |
| 17:58:57 | melwitt | hm, okay. I thought the point was to avoid the skip all but one in the specific cell case. but I'm probably missing something else | |
| 17:59:52 | johnthetubaguy | sfinucan: did you have some pbr fix for this: https://review.openstack.org/#/c/407364 | |
| 18:00:39 | openstack | Launchpad bug 1672624 in OpenStack Compute (nova) "Ceph volumes attached to local deleted instance could not be correctly handled" [Undecided,New] | |
| 18:00:39 | melwitt | mriedem: it looks like https://bugs.launchpad.net/nova/+bug/1672624 is another regression. I'm working on a local repro | |
| 18:03:39 | dansmith | melwitt: should we halt this and put it in the issues like the other? https://review.openstack.org/#/c/445575/ | |
| 18:05:29 | melwitt | dansmith: like the other "fix coming soon" one? argh, maybe. I'm not 100% of when this regressed and I haven't repro-d it yet. from the code, it doesn't look like it should be happening | |
| 18:05:43 | dansmith | yeah, that | |
| 18:06:45 | melwitt | I guess I hesitate about mentioning it in there when I haven't repro'd it yet | |
| 18:07:24 | melwitt | I just tried it on an older devstack ceph I have and the local delete worked fine. working on a try with master | |
| 18:20:16 | johnthetubaguy | cdent: jaypipes: I guess we don't have an api-ref site for placement yet? | |
| 18:20:37 | jaypipes | johnthetubaguy: not yet, no. one is needed for sure. | |
| 18:24:00 | johnthetubaguy | mriedem: would be nice to get this policy spec moving, folks seem generally happy with the approach now: https://review.openstack.org/#/c/433010/ | |
| 18:24:41 | dansmith | jaypipes: if I make that server_default=0 thing can I assume that just reading existing records will give me zero? | |
| 18:24:52 | dansmith | jaypipes: and, does that require writing the table again, or is it smart? | |
| 18:25:20 | jaypipes | dansmith: adding server_default="0" will allow you to make the field non-nullable from the start. | |
| 18:25:56 | dansmith | jaypipes: I assume that means "yes" to the first part | |
| 18:26:15 | jaypipes | dansmith: yes | |
| 18:26:17 | jaypipes | :) | |
| 18:26:31 | jaypipes | dansmith: and no on the second (no rewriting table) | |
| 18:26:40 | dansmith | okay | |
| 18:27:43 | openstackgerrit | Pushkar Umaranikar proposed openstack/nova-specs master: Stop using Neutron admin token https://review.openstack.org/439890 | |
| 18:36:31 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add keypairs field to InstancePayload https://review.openstack.org/419730 | |
| 18:45:25 | openstackgerrit | Maxim Nestratov proposed openstack/nova-specs master: libvirt: reintroduce runtime image type detection https://review.openstack.org/363547 | |
| 18:48:08 | dansmith | jaypipes: so.. that doesn't seem to work.. when I'm reading the result of the sql create, I don't have a mapped field, and if I try to read it, sqla lazy-loads (and fails in this case) | |
| 18:50:49 | openstackgerrit | dane-fichter proposed openstack/nova master: Use cursive for signature verification https://review.openstack.org/351232 | |
| 18:50:52 | dansmith | jaypipes: also, the oslo.db model sync checker does't seem to support sever_default | |
| 18:51:09 | dansmith | jaypipes: http://pastebin.com/ckkJXUMi | |
| 18:52:51 | jaypipes | dansmith: guh. ok... lemme +2 that patch then. | |
| 18:53:09 | dansmith | jaypipes: I'm kina disappointed, because server_default is what I want | |
| 18:53:16 | jaypipes | ya | |
| 18:53:32 | jaypipes | dansmith: vote changed :) | |
| 18:54:20 | dansmith | that probably needs fixing in oslo.db | |
| 19:04:41 | dansmith | gibi: around by chance? | |
| 19:04:50 | openstackgerrit | sean mooney proposed openstack/nova master: remove flake8-import-order for test requirements https://review.openstack.org/445622 | |
| 19:06:49 | openstackgerrit | Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754 | |
| 19:06:50 | openstackgerrit | Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163 | |
| 19:08:05 | openstackgerrit | Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025 | |
| 19:09:26 | cdent | johnthetubaguy: I've started but not made much progress: https://review.openstack.org/#/c/409340/ (and one above it). I keep asking for volunteers from the reading audience of the placement update emails, but I think labor is oversubscribed | |
| 19:13:16 | melwitt | dansmith: just looked at the update. what I was missing was that you needed the entire cell objects in _get_computes_for_cells, and not just the uuids | |
| 19:13:37 | bauzas | johnthetubaguy: good points about https://review.openstack.org/#/c/440580/5 I missed them | |
| 19:13:37 | dansmith | okay | |
| 19:14:03 | melwitt | if you only needed the uuids, then it would have saved something but since you need the whole objects, it doesn't | |
| 19:19:00 | openstackgerrit | Sarafraj Singh proposed openstack/nova-specs master: Add live-migration-force-after-timeout spec https://review.openstack.org/438467 | |
| 19:55:23 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies in volumes.py https://review.openstack.org/445637 | |
| 19:55:56 | jroll | mriedem: all the tooz traffic on the ML reminds me to bug you about this again, you had a question there, I answered it, what say you? https://review.openstack.org/#/c/399022/ | |
| 20:11:12 | efried | mriedem Re: "...how the libvirt driver handles connection failures, it will auto-disable the compute service record in the database, and when it reconnects it will auto-enable the compute service record in the DB." - can you give me a pointer to some code to look at (and shamelessly mimic)? | |
| 20:18:44 | openstackgerrit | Juan Antonio Osorio Robles proposed openstack/nova master: Make versioned notifications topics configurable https://review.openstack.org/444947 | |
| 20:30:43 | openstackgerrit | Sarafraj Singh proposed openstack/nova-specs master: Spec to add per instance timeout for LM https://review.openstack.org/442809 | |
| 20:32:35 | openstackgerrit | Anusha Unnam proposed openstack/nova master: POC: add descriptions to server tags https://review.openstack.org/434842 | |
| 20:50:45 | mriedem | dansmith: i failed to mention the van in the yard covered in snow | |
| 20:51:01 | dansmith | mriedem: not that scary | |
| 20:51:04 | mriedem | dansmith: the government center can't do the thing i need, but gene fuckin' turner gets it done | |
| 20:51:10 | dansmith | did it have wheels? | |
| 20:51:15 | dansmith | hah | |
| 20:51:16 | mriedem | gray-faced old ass pug met me at the door | |