Posted	Nick	Remark
#openstack-nova - 2017-03-12
15:56:40	openstackgerrit	Alex Szarka proposed openstack/nova master: Transform instance.resize.error notifications https://review.openstack.org/417882
15:57:04	openstackgerrit	Alex Szarka proposed openstack/nova master: Transform instance-live_migration_abort notification https://review.openstack.org/420453
15:58:01	openstackgerrit	Alex Szarka proposed openstack/nova master: Transform instance-live_migration_abort notification https://review.openstack.org/420453
15:59:46	openstackgerrit	Alex Szarka proposed openstack/nova master: Reduce code complexity in vmops._spawn method https://review.openstack.org/438502
16:18:41	openstackgerrit	Alex Szarka proposed openstack/nova master: Reduce code complexity in vmops._spawn method https://review.openstack.org/438502
17:34:43	openstackgerrit	Alex Szarka proposed openstack/nova master: Transform instance-exists notification https://review.openstack.org/403660
17:41:17	openstackgerrit	OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/443357
19:04:09	openstackgerrit	Alex Szarka proposed openstack/nova master: Reduce code complexity in vmops._spawn method https://review.openstack.org/438502
#openstack-nova - 2017-03-13
00:31:43	openstackgerrit	Alex Xu proposed openstack/nova master: placement: Add Traits API to placement service https://review.openstack.org/376200
00:31:43	openstackgerrit	Alex Xu proposed openstack/nova master: placement: Enable attach traits to ResourceProvider https://review.openstack.org/376201
00:31:44	openstackgerrit	Alex Xu proposed openstack/nova master: placement: Add resource provider traits API https://review.openstack.org/376202
00:31:44	openstackgerrit	Alex Xu proposed openstack/nova master: placement: Add Trait and TraitList objects https://review.openstack.org/376199
01:45:08	openstackgerrit	Li Yingjun proposed openstack/nova-specs master: Spec for support set vgamem for video https://review.openstack.org/438787
01:56:19	openstackgerrit	Li Yingjun proposed openstack/nova-specs master: Spec for support set vgamem for video https://review.openstack.org/438787
02:38:31	openstackgerrit	Maho Koshiya proposed openstack/nova master: Add interfaces functional negative tests https://review.openstack.org/442892
04:04:42	openstackgerrit	Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters and examples in aggregate API https://review.openstack.org/425512
04:04:54	openstackgerrit	Takashi NATSUME proposed openstack/nova master: Avoid forcing translation on logging calls https://review.openstack.org/413876
04:05:08	openstackgerrit	Takashi NATSUME proposed openstack/nova master: api-ref: Fix parameters in os-hosts.inc https://review.openstack.org/416444
04:05:12	openstackgerrit	Takashi NATSUME proposed openstack/nova-specs master: Abort Cold Migration https://review.openstack.org/334732
06:47:11	openstackgerrit	Li Yingjun proposed openstack/nova-specs master: Spec for service create and destroy notification https://review.openstack.org/444731
06:56:42	openstackgerrit	Li Yingjun proposed openstack/nova-specs master: Spec for service create and destroy notification https://review.openstack.org/444731
08:27:48	Qiming	alex_xu, there?
08:28:47	robcresswell	Quick question; someone's added a patch to Horizon that hides the Soft Reboot button if the Instance state is anything other than Active; is this correct? Had a look at the API docs but they only seem to show how to form the request, not any of the conditions around its usage.
08:31:01	openstackgerrit	Sergey Nikitin proposed openstack/nova master: Added nova objects for intance diagnostics https://review.openstack.org/434745
08:31:01	openstackgerrit	Sergey Nikitin proposed openstack/nova master: Replace diagnostics objects with Nova diagnostics objects https://review.openstack.org/394480
08:31:02	openstackgerrit	Sergey Nikitin proposed openstack/nova master: Standardization of VM diagnostics info API. https://review.openstack.org/355540
08:31:03	openstackgerrit	Sergey Nikitin proposed openstack/nova master: Completed implementation of instance diagnostics for Xen https://review.openstack.org/399613
09:00:08	bauzas	good morning Nova
09:02:31	alex_xu	Qiming: hi, i'm here
09:08:19	Qiming	alex_xu, I was checking admin password
09:11:51	Qiming	alex_xu, it turns out that I will need to use "/servers/{server_id}/os-server-password" for password GET, and DELETE, use POST /servers/{server_id}/action for password update, and the password can be created only via POST /servers
09:24:57	openstackgerrit	Ghanshyam Mann proposed openstack/nova master: Typo fix in releasenotes: deprecate network options https://review.openstack.org/444778
09:25:41	gmann	sfinucan: alex_xu oomichi simple one - https://review.openstack.org/#/c/444778/
09:26:44	sfinucan	gmann: Done
09:27:03	gmann	sfinucan: :) thanks
09:27:55	openstackgerrit	Lee Yarwood proposed openstack/nova master: compute: Move detach logic from manager into driver BDM https://review.openstack.org/439520
09:27:55	openstackgerrit	Lee Yarwood proposed openstack/nova master: compute: Use detach_volume during default rebuild https://review.openstack.org/443932
09:27:56	openstackgerrit	Lee Yarwood proposed openstack/nova master: objects: Add attachment_id to BlockDeviceMapping https://review.openstack.org/437665
09:27:56	openstackgerrit	Lee Yarwood proposed openstack/nova master: compute: Only destroy BDMs after successful detach call https://review.openstack.org/440693
09:27:57	openstackgerrit	Lee Yarwood proposed openstack/nova master: db: Add attachment_id to block_device_mapping https://review.openstack.org/437597
09:28:13	alex_xu	gmann: done
09:28:26	alex_xu	Qiming: i'm thinking whether all of those password are same thing
09:28:59	Qiming	alex_xu, they are, IMO
09:29:02	gmann	alex_xu: thanks
09:30:38	gmann	alex_xu: Qiming admin one is different(updated using changePassword) and os-server-password is metadata one
09:31:51	gmann	because delete call just remvoe from metadata which is encrypted one, it does not change in server
09:32:31	Qiming	gmann, I'm no nova expert, should I care if the password is stored in metadata or somewhere else?
09:33:09	Qiming	gmann, the doc tells me I can specify password for admin, I can change it, I can get it, and I can wipe it out
09:33:28	alex_xu	I remember the admin one is for xen driver
09:34:48	Qiming	gmann, the strange thing is that they are located in different locations, probably fine for command line tools, but not so good for SDK modeling
09:37:12	lyarwood	mdbooth: morning, https://review.openstack.org/#/q/status:open+project:openstack/nova+branch:master+topic:bp/cinder-new-attach-apis should be ready for reviews once you have time today, the focus is really on the db and object changes first if you wouldn't mind focusing on them.
09:38:16	openstackgerrit	Thomas Bechtold proposed openstack/nova master: Log exception when hypervisor version check fails https://review.openstack.org/434927
09:45:47	dakhmetov	Greetings, guys!
09:45:57	dakhmetov	Could you please review this patch: https://review.openstack.org/#/c/399679/
09:50:47	dakhmetov	I know a couple of people who are really affected by the inconsistency in instance's libvirt.xml. It will be great if you help me reviewing it.
09:54:06	johnthetubaguy	dakhmetov: so I love half of your change, and worry about the other half
09:54:34	johnthetubaguy	dakhmetov: using instance.user_id and instance.project_id totally makes sense, we should have done that for the beginning
09:55:06	johnthetubaguy	username and projectname... thats feels wrong, what about we don't add that any more?
09:55:07	dakhmetov	2 johnthetubaguy please share your concern
09:55:16	johnthetubaguy	I will add a note on the patch
09:55:23	gmann	Qiming: admin pass can be injected while creating server and change password using action API is for xen and libvirt as alex_xu mentioned
09:55:48	johnthetubaguy	dakhmetov: a related comment came up on friday at a HPC meetup I went to, so agreed it needs fixing
09:55:55	openstackgerrit	Michael Henkel proposed openstack/nova master: Implements: blueprint opencontrail-dpdk-support https://review.openstack.org/441183
09:56:39	gmann	@Qiming not sure about exact SDK requirement on that and if any issue on nova side?
09:58:48	johnthetubaguy	dakhmetov: I am worried about how usernames and project names change over time in keystone, but we keep those names just matching what they were went the instance booted
09:58:58	johnthetubaguy	dakhmetov: maybe thats OK for your use case I guess?
10:00:22	dakhmetov	2 johnthetubaguy: yes, I also thought about it. The only option to avoid this issue is open Keystone session there each time
10:01:48	johnthetubaguy	dakhmetov: my idea was to only have the ids in there, from the instance object, and leave the others blank for now?
10:02:31	johnthetubaguy	that would ensure they are "correct" in some sense, but I feel bad breaking the folks that want the names there
10:04:59	dakhmetov	johnthetubaguy: sure, there are a lot of folks who needs names there, as it described in nova xmlns 1.0
10:07:53	dakhmetov	so, what we have in current patch seems to be best solution, despite the fact that the stored user and project names can change
10:08:01	mdbooth	dakhmetov: I've reviewed a change related to this recently. Do you have a link?
10:08:49	dakhmetov	mdbooth: exactly! https://review.openstack.org/#/c/399679
10:09:09	mdbooth	Ah, ok. You fishing for a second +2?
10:09:33	dakhmetov	mdbooth: yes, a kind of :)
10:11:12	mdbooth	johnthetubaguy: My take on this is that we break things by rebuilding the libvirt xml. We shouldn't be doing that, and this is a necessary workaround.
10:11:45	mdbooth	i.e. the conversation isn't so much about what these values mean, whether they're correct, or what they really should be
10:11:52	mdbooth	But more: are they the same as before
10:12:22	mdbooth	The other conversation is also interesting, though.
10:12:29	johnthetubaguy	mdbooth: my worry is the bug that says I updated the project or user name in keystone, and now my lib virt xml is out of sync, for me its either we don't include the names or we do what dakhmetov has proposed
10:13:16	johnthetubaguy	totally agreed grabbing it from the context was exactly the wrong thing to do
10:14:17	johnthetubaguy	I was meaning the bug that is raised next time, after we fix this bit
10:14:29	mdbooth	Ah, ok.
10:14:38	mdbooth	So, that bug was always present
10:15:02	johnthetubaguy	yep
10:15:04	mdbooth	This information is static, so storing dynamic information there is suspect at best.
10:15:18	johnthetubaguy	yeah, thats my take
10:15:33	mdbooth	And I agree, and probably that we should remove username and projectname
10:15:47	mdbooth	However, that's tangential to this bug, which is that we break our existing contract
10:15:57	johnthetubaguy	cool, I was wondering if I was going down a crazy thought path
10:17:11	mdbooth	dakhmetov: Incidentally, if you're close to users who are actually relying on this, I'd be interested to know what your take is on how to fix the changing username issue.
10:17:38	johnthetubaguy	+1 thats what I was fishing for really
10:18:40	mdbooth	dakhmetov: Is the issue that people have scripted this, and scripts will require updating?
10:19:10	johnthetubaguy	FWIW, this change breaks those folks too
10:19:28	mdbooth	johnthetubaguy: Really? I missed that.
10:19:43	johnthetubaguy	all existing instance, once modified will now have no username or projectname, we are missing a unit test for that
10:20:42	mdbooth	johnthetubaguy: Ah, yes. It's a fix only for future instances, I'd glossed over that.
10:21:07	mdbooth	We could save the info before deleting it...
10:21:28	mdbooth	Meh, lets get this done before gold plating it.
10:25:14	johnthetubaguy	dakhmetov: I updated my comments to try summarise what I am thinking now, basically I would split this into two patches, and the second patch needs an extra unit test.

Earlier   Later