Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-10
15:55:40 sfinucan mriedem: ta
15:59:53 mriedem ioni: https://review.openstack.org/#/c/444374/
16:01:27 ioni mriedem, do i have to do something? :D
16:02:01 openstackgerrit Stephen Finucane proposed openstack/nova master: Always set MTU when plugging devices https://review.openstack.org/408781
16:03:52 mriedem ioni: nope
16:07:25 openstackgerrit Stephen Finucane proposed openstack/nova master: hardware: Flatten functions https://review.openstack.org/367470
16:07:26 openstackgerrit Stephen Finucane proposed openstack/nova master: Standardize '_get_XXX_constraints' functions https://review.openstack.org/385071
16:07:27 openstackgerrit Stephen Finucane proposed openstack/nova master: De-duplicate _numa_get_flavor_XXX_map_list https://review.openstack.org/385074
16:07:27 openstackgerrit Stephen Finucane proposed openstack/nova master: Rename '_numa_get_constraints_XXX' functions https://review.openstack.org/385072
16:08:04 leakypipes rfolco: morning!
16:08:25 leakypipes rfolco: so, I can support cdent's review suggestions on your patch. Go with KeyError raise.
16:08:25 rfolco leakypipes, afternoon!
16:10:10 rfolco leakypipes, nice. I can do something like: http_except = webob.exc.status_map.get(req) .... if not None, then raise http_except
16:10:23 rfolco instead of status_map[req]
16:10:54 rfolco this way I avoid keyerror and get rid of dict
16:11:41 leakypipes rfolco: well, I think cdent actually prefers raising a KeyError there, since this is a code path that is dev-only -- i.e. users cannot influence this code path and we want to bomb out early if a developer adds an call to raise_http_code_if_microversion() is passed an improper status code.
16:13:39 rfolco leakypipes, thx++
16:13:39 rfolco hmm makes sense. If keyerror is fine, easier for me :)
16:13:40 leakypipes rfolco: go for it :)
16:22:32 openstackgerrit Eric Fried proposed openstack/nova master: WIP: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189
16:30:45 openstackgerrit Stephen Finucane proposed openstack/nova master: console: introduce basic framework for security proxying https://review.openstack.org/345396
16:30:46 openstackgerrit Stephen Finucane proposed openstack/nova master: console: introduce framework for RFB authentication https://review.openstack.org/345397
16:30:47 openstackgerrit Stephen Finucane proposed openstack/nova master: console: introduce the VeNCrypt RFB authentication scheme https://review.openstack.org/345398
16:30:47 openstackgerrit Stephen Finucane proposed openstack/nova master: console: provide an RFB security proxy implementation https://review.openstack.org/345399
17:02:14 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova master: [WIP] Read NIC features in libvirt https://review.openstack.org/444415
17:06:56 mriedem1 dansmith: so no obfuscation for https://review.openstack.org/#/c/438023/25/nova/context.py ?
17:08:09 melwitt mriedem: it's not storing the url in the context anymore
17:09:30 mriedem oh cool
17:09:45 mriedem i'm going to have to rebase my quotas fix now.. :(
17:11:38 leakypipes dansmith: your once over on gibi's patch here pls: https://review.openstack.org/#/c/440347
17:14:59 melwitt leakypipes: not sure I understand the comment on that one, that instance.flavor isn't connected to data in the db. it's connected to instance_extra and can be lazy-loaded on an instance that was queried without joining with instance_extra earlier
17:15:47 mriedem melwitt: leakypipes: bauwser: also need to get these in https://review.openstack.org/#/q/topic:bug/1670627 - that's a major regression in ocata and need to get that backported for a 13.0.1 next week
17:16:01 mriedem fwiw dan was +2 on the bottom change yesterday, and had skimmed the rest of the series already
17:16:18 leakypipes melwitt: yeah, it's weird. basically, what we're attempting to prevent is the lazy-loading of flavor *projects* -- i.e. the second-stage lazy-loading of Flavor attributes.
17:16:36 mriedem i'm going to be basically MIA the rest of the afternoon, it's my last day here so lunch, exit interview and then they kick my ass out
17:16:40 mriedem and my new laptop hasn't shown up yet
17:17:03 leakypipes melwitt: so the instance.Flavor is populated when expected_attributes=['flavor'] and that's fine. But by orphaning the Flavor in instance.flavor, we prevent the instance.flavor.projects attribute from being lazy-loaded.
17:17:05 melwitt leakypipes: so like a cascading lazy-load
17:17:07 leakypipes melwitt: weird, I know :)
17:17:12 leakypipes melwitt: yeah.
17:17:26 melwitt ah, I see
17:17:39 melwitt mriedem: ack, will review those today
17:18:22 leakypipes dansmith: time for you to enter the phone booth and emerge as superdan.
17:21:33 artom Is Phone Booth is mdbooth's rapper name?
17:22:59 melwitt heh
17:44:01 andrewbogott Is 'Host xxx has more disk space than database expected' ever anything important? That message shows up in several bug reports but best I can tell the message is a red herring in all cases.
17:44:16 andrewbogott (I have 4 out of 13 compute nodes that throw that warning regularly.)
17:47:19 openstackgerrit Eric Fried proposed openstack/nova master: PowerVM Driver: SSP emphemeral disk support https://review.openstack.org/443189
17:47:59 efried thorst_afk adreznec esberglu_ ^^ live tested, works, ready for subteam review.
17:59:47 openstackgerrit Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163
17:59:47 openstackgerrit Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754
17:59:49 openstackgerrit Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891
17:59:50 openstackgerrit Dan Smith proposed openstack/nova master: Add identity helper property to CellMapping https://review.openstack.org/444038
17:59:50 openstackgerrit Dan Smith proposed openstack/nova master: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025
19:04:29 cfriesen someone pointed out to me that InstanceActionEvent.pack_action_event_finish() uses a "message" field, but the InstanceActionEvent model in the DB uses "details". Is this a bug?
19:07:53 mriedem_afk andrewbogott: this is the comment by that warning
19:07:54 mriedem_afk # can occur when an instance in database is not on host
19:08:16 mriedem andrewbogott: which is similar to the _sync_power_states periodic task in the compute manager, but that might not be a warning
19:08:18 mriedem would have to check
19:08:35 andrewbogott mriedem: thanks. I did a side-by-side comparison on one of the hosts already but maybe I missed a discrepancy.
19:08:58 andrewbogott At least… you'd expect 'nova list —host <hostname>' to show the db contents and not the disk contents, right?
19:10:10 openstackgerrit John Griffith proposed openstack/nova master: Add Cinder API version detection https://review.openstack.org/444465
19:10:30 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/443357
19:11:49 jgriffith ildikov mriedem ^^ don't know if that's more along the lines of what you'd like to see or not
19:12:23 openstackgerrit OpenStack Proposal Bot proposed openstack/os-vif master: Updated from global requirements https://review.openstack.org/395347
19:18:24 openstackgerrit Jay Pipes proposed openstack/nova master: virt: implement get_inventory() for Ironic https://review.openstack.org/441544
19:19:42 leakypipes cdent: hi. I'm getting a single unit test failure for nova.tests.unit.test_fixtures.TestPlacementFixture.test_responds_to_version locally on ^^ patch. it looks like this: http://paste.openstack.org/show/602305/
19:20:09 leakypipes cdent: nothing in the change to that patch should affect the placement API as far as I can tell. have you seen that error before?
19:20:28 cdent i've not, one sec
19:23:24 cdent leakypipes: are the functional tests running okay?
19:23:32 leakypipes cdent: yes.
19:26:12 cdent imma need to try this stuff myself leakypipes
19:26:31 leakypipes cdent: np
19:36:44 leakypipes JayF: thx for the reviews on the ironic patch. responded to your query on the latest revision.
19:37:24 JayF leakypipes: it's fine, "valid -1 on a jaypipes nova patch" will make a fine line on my resume ;)
19:37:34 leakypipes JayF: lmao
19:39:27 JayF leakypipes: re: your comment, that's exactly what I suspected, but wanted to be sure. Also get_inventory() will only ever be called on nodes that pass get_available_resources() which guarantees all our logic guarding nodes in maintenance/wrong states/etc will be intact
19:39:55 leakypipes JayF: correct. node_is_available() gates any call to get_inventory()
19:44:12 cdent leakypipes: does it fail consistently? does it only fail when you run all the tests?
19:44:36 leakypipes cdent: fails consistently when I run all unit tests. lemme try running it singularly.
19:44:38 cdent in other words, works for me when I test just that file and also a) make sure I don't have an /etc/nova/nova.conf and -r my tox
19:45:26 cdent I resisted this fixture. I figured we should just keep on doing the wsgi-intercept thing everywhere.
19:50:08 leakypipes cdent: yeah, fails when I just run tox -epy27 -- test_fixtures
19:50:23 cdent interesting, wfm
19:50:29 cdent i'm running all of them now
19:51:00 openstackgerrit Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162
19:51:00 openstackgerrit Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174
19:51:01 openstackgerrit Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293
19:51:01 openstackgerrit Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292
19:51:02 openstackgerrit Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736
19:51:02 openstackgerrit Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861
19:51:03 openstackgerrit Dan Smith proposed openstack/nova master: Clean up ClientRouter debt https://review.openstack.org/444487
20:01:50 cdent GET /resource_providers?resources=VCPU:24
20:07:55 cdent leakypipes: works when running all too
20:08:17 cdent do you have any evidence from the fixture of the internal failure (the exception within the 500)
20:19:42 leakypipes cdent: none :(
20:20:03 cdent you done a fresh tox?
20:21:09 cdent :( I dunno.
20:31:17 cdent leakypipes: I gotta go, if/when you figure it out I'm curious to know. I think it's just you though: unit tests passed in the gate for that commit
20:31:31 leakypipes yeah...

Earlier   Later