Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-10
02:55:57 Qiming all the others can be treated as extended server attributes, except for user_data
02:56:02 alex_xu but for back-compatible, we can't remove the prefix directly. at least, it needs a microversion
02:56:03 gmann Qiming: yea as alex_xu mentioned, they were old notation which we have to keep supporting
02:56:46 Qiming so, a microversion to change it (user_data) back is acceptable?
02:56:50 gmann but can you access kernel_id without prefix in server GET ?
02:57:03 Qiming gmann, no
02:57:14 gmann ok
02:57:28 Qiming kernel_id didn't come from user request, users won't expect that
02:57:54 gmann Qiming: ok on create things you mean, got it
02:57:54 alex_xu Qiming: if just change a prefix for a field, i'm not sure it is worth to do that
02:58:08 gmann because GET server has all those with prefix like OS-EXT-SERV-ATTR:kernel_id
02:58:09 Qiming same question for 'personality', which is also an "input only" attribute
02:58:26 Qiming once provided to create/POST, we get no chance to see it again, :)
02:58:30 alex_xu Qiming: personality is a field plan to remove
02:59:51 Qiming gmann, for attributes "added" at server side, it is okay to add a prefix, but for 'user_data', it is weird that its name has changed when I'm retrieving it
03:00:13 gmann alex_xu: yea and that was the reason to plan remove
03:00:58 Qiming ya, removal might be the right thing to do
03:01:36 Qiming anyway, 'personality' is not heavily used like 'user_data' AFAICT
03:02:32 Qiming in the same spirit, maybe 'host_status' for example should have a prefix, :)
03:04:17 gmann Qiming: yea those are not consistent actually due to legacy v2 way was like that and in v2.1 we try to do without prefix as no more extensions
03:04:19 alex_xu Qiming: for any new field, we won't add prefix
03:04:32 alex_xu gmann: yea
03:05:41 Qiming alex_xu, I don't think we should make the prefix decision based on whether it is 'new' or not. Instead, we may want to make the server attributes naming consistent.
03:06:16 alex_xu Qiming: yes, the 'new' one, i mean new in the request also
03:06:57 Qiming ya, that makes sense. I am just trying to raise some awareness about consistency
03:07:20 alex_xu Qiming: yea, agree with you, that should consistent
03:08:04 Qiming would it be on your agenda to remove the prefix from user_data in the response body?
03:08:16 gmann but things is we cannot change old one (which are with prefix) without microversion and still for older version they will be with prefix
03:08:56 gmann alex_xu: we can do for all those in single version bump? what you say, worthy to microversion that?
03:08:58 Qiming yes, I'm 100% with you on the requirement to bump microversion
03:09:06 alex_xu gmann: yea, i think that also
03:09:41 Qiming great, if there is a plan to "fix" it at server side, I will abandon the fix in SDK -- https://review.openstack.org/#/c/443036/
03:10:35 gmann Qiming: still we fix on nova side you need that fix on sdk to support the older version request
03:11:13 alex_xu yes, so you still have same problem on the old version
03:11:25 Qiming gmann, SDK has its own problems to fix, but I hope a full-fleged microversion support will be in place soon
03:11:28 alex_xu try to know what kind of try you got in the openstacksdk
03:12:14 alex_xu Qiming: so SDK still need to support older version of nova api, right? so it still need to care about the user_data field with prefix
03:12:53 gmann yea
03:13:21 gmann sdk fix is anyways needed irrespective of nova fix that in new version or not
03:13:26 Qiming yes, but that will become a different topic. there are still other fields that are "request-only", "response-only", "valid-in-both-direction-but-RENAMED", :_
03:13:42 Qiming gmann, exactly
03:14:51 gmann alex_xu: i think its little bit overhead to microversion that as we have lot of other inconsistency like CamelCase things etc but if we do we should do in one shot but again that can change lot of APIs :)
03:15:29 alex_xu gmann: yes, but we said we won't fix the CamelCase things
03:15:42 gmann yeaaa
03:16:14 gmann +1 on that, it unnecessary and overhead to fix those
03:17:16 alex_xu so...remove the prefix, Qiming will get benefit, and also have people already make their code aware the prefix, will get overhead to fix that.
03:18:10 alex_xu so...the question will be, how much benefit we got from removing prefix, is that enough for other people change their client code to remove fix?
03:19:23 gmann yea thats true, its overhead for existing users and benefit for new
03:21:48 alex_xu Qiming: anyway, my first todo is getting clear what kind of trouble you got in the sdk
03:22:02 Qiming okay
03:32:06 gmann yea +1
03:33:42 openstackgerrit Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162
03:33:42 openstackgerrit Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754
03:33:43 openstackgerrit Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891
03:33:44 openstackgerrit Dan Smith proposed openstack/nova master: Add get_by_instance_uuids() to InstanceMappingList https://review.openstack.org/443292
03:33:44 openstackgerrit Dan Smith proposed openstack/nova master: Sort CellMappingList.get_all() for safety https://review.openstack.org/443174
03:33:45 openstackgerrit Dan Smith proposed openstack/nova master: Remove Mitaka-era service version check https://review.openstack.org/442861
03:33:45 openstackgerrit Dan Smith proposed openstack/nova master: Make server_groups determine deleted-ness from InstanceMappingList https://review.openstack.org/443293
03:33:46 openstackgerrit Dan Smith proposed openstack/nova master: Add workaround to disable group policy check upcall https://review.openstack.org/442736
03:35:20 openstackgerrit OpenStack Proposal Bot proposed openstack/nova master: Updated from global requirements https://review.openstack.org/443357
04:36:58 takashin tox -e pep8
04:43:58 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955
05:22:50 openstackgerrit Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964
05:23:24 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042
05:23:41 openstackgerrit Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926
05:40:47 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: List/show all server migration types https://review.openstack.org/407237
05:40:54 openstackgerrit Takashi NATSUME proposed openstack/nova-specs master: List/show all server migration types https://review.openstack.org/407237
06:12:56 openstackgerrit Shunli Zhou proposed openstack/nova master: Add populate_retry to schedule_and_build_instances https://review.openstack.org/444106
06:54:03 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix keypair API parameters https://review.openstack.org/420626
06:55:32 openstackgerrit Wei Cao proposed openstack/nova master: vmware: Change the VM Create spec https://review.openstack.org/444119
06:59:44 openstackgerrit Takashi NATSUME proposed openstack/nova master: api-ref: Fix keypair API parameters https://review.openstack.org/420626
07:21:06 openstackgerrit Takashi NATSUME proposed openstack/nova master: Refactor a test method including 7 test cases https://review.openstack.org/395436
07:21:13 openstackgerrit Takashi NATSUME proposed openstack/nova master: Refactor a test method including 3 test cases https://review.openstack.org/394738
08:07:45 openstackgerrit Michael Henkel proposed openstack/nova master: Implements: blueprint opencontrail-dpdk-support https://review.openstack.org/441183
08:23:34 openstackgerrit Tomi Juvonen proposed openstack/nova-specs master: Planned host maintenance https://review.openstack.org/310510
08:26:19 bauwser good morning Nova
08:27:40 arne_r good morning bauwser :)
08:59:12 openstackgerrit Huan Xie proposed openstack/nova master: WIP: add linux bridge qbr for live migration on XenServer https://review.openstack.org/444163
09:37:58 openstackgerrit Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Enable SR-IOV NIC offload feature discovery https://review.openstack.org/435954
09:49:30 openstackgerrit Michael Henkel proposed openstack/nova master: Implements: blueprint opencontrail-dpdk-support https://review.openstack.org/441183
10:26:38 openstackgerrit Ghanshyam Mann proposed openstack/nova master: Remove duplicate attributes in sample files https://review.openstack.org/444199
10:27:29 gmann alex_xu: oomichi ^^ easy one
10:38:34 kashyap mdbooth: Hello there, wonder if you have time / energy today to make any comment here -- https://review.openstack.org/#/c/246910/
10:38:50 kashyap I know this involves Neutron voodoo, so if you shy away from it with a "meh", can understand :-)
10:39:14 kashyap Just this is causing a nasty interaction bug between Nova, Neutron, libvirt, QEMU and Virtio code
10:43:09 mdbooth kashyap: Eww
10:43:23 kashyap :-)
10:43:24 kashyap Sorry
10:43:34 mdbooth To me that just says the flow is wrong and we should be casting
10:43:38 mdbooth With callbacks
10:43:42 mdbooth if necessary
10:44:12 mdbooth kashyap: I don't feel I have the bandwidth to jump into that meaningfully right now, I'm afraid
10:44:33 kashyap mdbooth: No worries at all
10:44:38 mdbooth At first glance I'm not a fan, but I don't have an alternative
10:45:23 kashyap Yeah, I hear you. It's just feels (to me) impenetrable sometimes, with so many moving parts
10:46:15 markus_z What's our current policy for images in our docs? I see different types of image sources (*.dia, *.graphml, *odp) and also image generators like "graphviz".
10:46:27 mdbooth There are non-neutron reasons for not using a call in that flow
11:03:06 gmann sfinucan: if you can fix missing 's' on this - https://review.openstack.org/#/c/430914/4
11:34:45 openstackgerrit Huan Xie proposed openstack/nova master: WIP: Create ovs port with other params together https://review.openstack.org/444230
12:04:05 openstackgerrit Ildiko Vancsa proposed openstack/nova master: Deprecate the Cinder API v2 support https://review.openstack.org/444253

Earlier   Later