| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-09 | |||
| 15:43:15 | johnthetubaguy | mdbooth: everyone? oh dear... yeah. | |
| 15:43:33 | mdbooth | johnthetubaguy: Ok, I think that problem can be solved if we add a 'please do the copy' flag to nova's swap_volume call | |
| 15:43:53 | asettle | jaypipes: yeah just reading htem all now | |
| 15:43:53 | mdbooth | I think cinder then has enough tools in the box to do this | |
| 15:44:04 | mdbooth | Hmm, no, you'd need a quiesce operation too | |
| 15:44:05 | johnthetubaguy | mdbooth: well we would also have to call back with the attachment_ids and not the volume ids right? | |
| 15:44:41 | mdbooth | johnthetubaguy: That case requires a lot of thought | |
| 15:44:57 | mdbooth | All attached instances would have to participate | |
| 15:45:09 | openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | |
| 15:45:10 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685 | |
| 15:45:11 | openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | |
| 15:45:12 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388 | |
| 15:45:13 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200 | |
| 15:45:46 | mdbooth | johnthetubaguy: So attachment_ids are going to make that case simpler, but it's also going to involve coordinating a simultaneous volume switch amongst all attached instances. | |
| 15:45:48 | johnthetubaguy | mdbooth: its assume the user ensures only one is writing, but doesn't tell cinder right now, this is messed up, I think we should just fail this for multi-attach, for the moment at least | |
| 15:45:52 | mdbooth | The latter problem is going to be funky | |
| 15:46:01 | johnthetubaguy | mdbooth: +1 its hard | |
| 15:46:24 | dansmith | gibi: was that a regression in ocata? | |
| 15:46:33 | gibi | dansmith: yes it was | |
| 15:46:38 | gibi | dansmith: I will backport it | |
| 15:46:54 | dansmith | mriedem1: so we should rebase the quota fix on this one probably | |
| 15:46:55 | dansmith | because they will conflict | |
| 15:47:16 | mdbooth | johnthetubaguy: Yeah, I think it would be cinder's job to refuse to retype multi-attach volumes until support for that is added. | |
| 15:47:49 | mdbooth | Nova shouldn't concern itself, just do the swap, and copy if requested | |
| 15:48:24 | johnthetubaguy | mdbooth: well, Nova can't do the copy either right, when its Nova initiated | |
| 15:49:18 | mdbooth | I mean, Nova gets an api call with (att_A, att_b, do_copy=True) | |
| 15:49:41 | mdbooth | That call may come direct from a user, or from cinder which has a migration record | |
| 15:49:51 | mdbooth | Either way, Nova's behaviour is the same: | |
| 15:49:56 | mdbooth | Attach to att_b | |
| 15:50:00 | mdbooth | Copy if requested | |
| 15:50:04 | mdbooth | Detach from att_a | |
| 15:50:26 | mdbooth | call cinder with finished(att_a, att_b, instance_x, did_copy=True) | |
| 15:50:29 | dansmith | gibi: question inthere | |
| 15:51:04 | mdbooth | And we update the connection_info to be that for att_b, in all cases | |
| 15:51:24 | dansmith | gibi: unfortunately there's more cleanup in that patch than just is necessary for the backport, AFAICT | |
| 15:51:48 | mdbooth | johnthetubaguy: And we trust the caller not to do anything which is going to cause data corruption | |
| 15:51:49 | dansmith | gibi: I'm kinda conflicted on whether to just do that whole thing vs. two patches, one that is a smaller backport, followed by the cleanup | |
| 15:53:11 | mdbooth | johnthetubaguy: I think instance is redundant in that callback, btw, because it's a property of both attachments | |
| 15:53:19 | mriedem | dansmith: which one? | |
| 15:53:20 | mdbooth | It shouldn't be there | |
| 15:53:29 | dansmith | mriedem: https://review.openstack.org/#/c/437222/5 | |
| 15:53:47 | mriedem | oh yeah i knew about that, just hadn't gone through it yet | |
| 15:54:11 | gibi | dansmith: you mean do the minimal thing first, backport that then do some cleanup in a followup on master? | |
| 15:54:17 | dansmith | gibi: yeah | |
| 15:54:28 | mriedem | smaller backports are much easier and nicer | |
| 15:55:03 | cdent | jaypipes: I had to -1 get_invetory, but it is a very soft -1 | |
| 15:55:50 | mriedem | dansmith: gibi: what's the cleanup? the context manager? | |
| 15:56:03 | dansmith | mriedem: yeah, and the use of it in a few places that aren't affected, AFAICT | |
| 15:57:13 | mriedem | jaypipes: https://review.openstack.org/#/c/442200/ - that's the bottom of the series and you were +2 yesterday | |
| 15:57:21 | gibi | mriedem: I think this is the only place where it wasn't needed to restore original behavior https://review.openstack.org/#/c/437222/1/nova/compute/api.py@1868 | |
| 15:58:08 | gibi | mriedem, dansmith: I can put this ^^ to a separate patch | |
| 15:58:18 | dansmith | gibi: that's PS1 | |
| 15:58:32 | gibi | ups sorry | |
| 15:58:55 | dansmith | gibi: there are only two places we're missing the notification, | |
| 15:58:56 | dansmith | and two places you convert to the new one, right? | |
| 15:59:09 | jaypipes | mriedem: k, on it. just +2'd https://review.openstack.org/#/c/345138 BTW | |
| 15:59:36 | mriedem | ok, haven't reviewed that yet at all | |
| 15:59:43 | dansmith | I have I'll circle back | |
| 15:59:55 | gibi | dansmith: true. I looked at the wrong ps | |
| 16:00:11 | gibi | dansmith: I can split the patch | |
| 16:00:14 | dansmith | gibi: I think splitting those up would be good for backport cleanliness if you're cool with it | |
| 16:00:28 | dansmith | gibi: sweet, thanks for finding, fixing :) | |
| 16:00:29 | gibi | dansmith: cool, I will do it | |
| 16:27:53 | nikeshm | hi | |
| 16:28:24 | nikeshm | i am frequently facing the quota issue in openstack master | |
| 16:28:26 | nikeshm | https://ask.openstack.org/en/question/494/how-to-reset-incorrect-quota-count/ | |
| 16:28:39 | nikeshm | is there any bug reported | |
| 16:28:42 | nikeshm | for this | |
| 16:33:38 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Enable SR-IOV NIC offload feature discovery https://review.openstack.org/435954 | |
| 16:34:11 | openstackgerrit | Chris Friesen proposed openstack/nova master: show flavor info in server details https://review.openstack.org/434514 | |
| 16:35:35 | jaypipes | sfinucan, sean-k-mooney: time for a hangout? is rodolfo available? (btw, what's rodolfo's IRC nick?) | |
| 16:35:57 | sfinucan | jaypipes: (y) | |
| 16:36:17 | sfinucan | As for IRC nick - not a clue | |
| 16:37:04 | sean-k-mooney | jaypipes: ralonsoh | |
| 16:37:15 | sean-k-mooney | and ya im free ill ask him | |
| 16:37:19 | jaypipes | cool. | |
| 16:38:20 | ralonsoh | jaypipes, sean-k-mooney: hi, now I'm free | |
| 16:39:14 | jaypipes | sean-k-mooney, sfinucan, ralonsoh: https://hangouts.google.com/call/qqze37pjs5f4lnatg7owxiaklqe | |
| 16:41:49 | mriedem | dansmith: melwitt: Kevin_Zheng: ^ this is the regression test i was thinking of | |
| 16:41:49 | openstack | bug 1670627 in OpenStack Compute (nova) "quota is always in-use after delete the ERROR instances " [Critical,In progress] https://launchpad.net/bugs/1670627 - Assigned to Dan Smith (danms) | |
| 16:41:49 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add regression test for bug 1670627 https://review.openstack.org/443745 | |
| 16:42:41 | dansmith | mriedem: ack, and it works? | |
| 16:42:58 | mriedem | it passes | |
| 16:43:06 | mriedem | i'm going to rebase the fixes on top of it | |
| 16:43:53 | dansmith | it passes on master? | |
| 16:44:21 | dansmith | oh, I see it validates the broken behavior currently | |
| 16:47:36 | mriedem | right, that's generally how these types of tests work, | |
| 16:47:42 | mriedem | we write the recreate scenario, | |
| 16:47:49 | mriedem | then roll the fix on top and change the assertion in the test when it's fixed | |
| 16:49:16 | mriedem | ok, first victim is context.db_connection == None blows up the CellDatabases fixture | |
| 16:50:20 | dansmith | mriedem: yeah you'll have to make the change there since that fixture replaces target_cell | |
| 16:51:07 | openstack | Launchpad bug 1670627 in OpenStack Compute (nova) "quota is always in-use after delete the ERROR instances " [Critical,In progress] - Assigned to Dan Smith (danms) | |
| 16:51:07 | nikeshm | smcginnis: https://bugs.launchpad.net/nova/+bug/1670627 :) | |
| 16:51:22 | dansmith | mriedem: if it's None, just yield without calling real_target_cell | |
| 16:51:46 | dansmith | mriedem: but inside the lock | |
| 16:52:22 | mriedem | i was just going to use self._default_ctxt_mgr | |
| 16:52:55 | dansmith | not sure what you mean | |
| 16:53:26 | mriedem | sec | |
| 16:53:26 | dansmith | mriedem: before this, you need to yield if cell_mapping is None and then return https://github.com/openstack/nova/blob/master/nova/tests/fixtures.py#L402-L402 | |
| 16:54:35 | mriedem | here it comes | |