| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-07 | |||
| 17:26:15 | mdbooth | I thought the crackpot flow didn't do it though, for some reason | |
| 17:26:27 | mriedem | efried: you guys are using taskflow huh | |
| 17:26:32 | lyarwood | mdbooth: yeah volume-update does it as well | |
| 17:26:41 | efried | mriedem Yes. | |
| 17:26:45 | mdbooth | lyarwood: Thanks | |
| 17:26:49 | efried | That's... good, right mriedem ? | |
| 17:26:56 | mriedem | efried: we've never used it in nova | |
| 17:27:03 | mriedem | i know cinder uses it, sort of, for some tihngs | |
| 17:27:09 | mriedem | but never liked it enough to use it for all operations | |
| 17:27:10 | efried | Oh. I was under the impression that e.g. libvirt used it. | |
| 17:27:16 | mriedem | maybe it's fine on a small scale confied to a single virt driver | |
| 17:28:17 | efried | mriedem We find it super useful for rollbacks. | |
| 17:30:25 | mriedem | like spawn fails, detach interfaces and block devices? | |
| 17:30:31 | efried | yup | |
| 17:30:53 | mriedem | dude you can totally just have a 300LOC mega method with lots of try/excepts :) | |
| 17:31:44 | efried | Hey, y'all are the ones who wanted smaller change sets. | |
| 17:31:53 | efried | We'll bloat it later for ya. | |
| 17:33:53 | mdbooth | jaypipes: Did somebody bust you out of some meetings? | |
| 17:33:54 | jaypipes | dansmith: and yes, I'm listening to "Business Time" | |
| 17:34:01 | dansmith | good man | |
| 17:35:09 | cburgess | sdague: OMG thats awesome. I offered that up as a joke of the problems such a model could create. I love that its officially a rejected model for the reason that it makes me sad. | |
| 17:35:34 | jaypipes | mdbooth: :) | |
| 17:39:26 | mriedem | jaypipes: https://www.youtube.com/watch?v=w5Fgp-KihIA | |
| 17:39:30 | mriedem | ^ is what you're looking for | |
| 17:39:32 | sfinucan | mdbooth: Done https://review.openstack.org/#/c/438970. Thanks for breaking that out | |
| 17:39:47 | mdbooth | Thanks for looking :) | |
| 17:40:06 | dansmith | mriedem: right before we call from conductor to the compute to do the build, requested_networks is None for that test | |
| 17:40:45 | mriedem | gotta go, people looking over my shoulder waiting for lunch | |
| 17:40:47 | mriedem | will check when i'm back | |
| 17:46:21 | jaypipes | mriedem: lol | |
| 18:02:13 | macsz | bugs team meeting in #openstack-meeting-4 | |
| 18:13:30 | dansmith | jaypipes: would you prefer I double the math in the tests, keep the single-cell mock, or completely change the way that test works here? https://review.openstack.org/#/c/441388/3 | |
| 18:15:03 | dansmith | just doubling the math does verify that we're iterating over the two default cells, so maybe that's the better way | |
| 18:16:13 | jaypipes | dansmith: got it. a short comment above would suffice I think | |
| 18:16:28 | jaypipes | dansmith: just to assuage the reader of the test at a later time ;) | |
| 18:16:29 | openstackgerrit | Dan Peschman proposed openstack/nova master: No API cell up-call to delete consoleauth tokens https://review.openstack.org/415922 | |
| 18:16:51 | dansmith | jaypipes: lemme do the double math and then document that bit to explain the multiple cells thing.. that'll validate what we're doing, be less code, and more obvious I think | |
| 18:16:56 | dansmith | since it's all contained in a helper checker | |
| 18:17:11 | jaypipes | cools with me | |
| 18:23:27 | jaypipes | mdbooth: around? | |
| 18:25:10 | jaypipes | could be the admin). | |
| 18:25:10 | jaypipes | mdbooth: would you mind reading my review comment on https://review.openstack.org/#/c/399679/ and commenting on that? Basically, the patch introduces the potential of the libvirt.xml file storing in the owner metadata block a user *ID* that doesn't match the user *name* -- same for project ID being different than the project name. Because the patch sets the userid to the instance.user_id (the owner user) and username to context.user_name (which | |
| 18:44:56 | jaypipes | dansmith: Snoop Dan? :) | |
| 18:45:54 | dansmith | jaypipes: yeah, I'm o-g | |
| 18:46:15 | jaypipes | dansmith: the original grokster. | |
| 18:48:44 | mriedem | jaypipes: on the searchlight connectivity check, i replied in the spec, but i think we just handle it like we did for the placement safe_connect thing in the scheduler report client, but we don't retry | |
| 18:49:00 | mriedem | if it's there use it, else we log a warning, set a flag and don't retry until restart | |
| 18:49:16 | jaypipes | mriedem: cools with me. | |
| 18:49:48 | mriedem | figuring out if searchlight even supports versioned notifications from nova is priority 1 for me atm, because i don't think they do | |
| 18:49:52 | mriedem | which is a pretty big blocker for us | |
| 18:50:23 | cdent | mriedem: you mean being willing to store different versions, differently? | |
| 18:50:34 | mriedem | cdent: no, like actually listening for that type of notification | |
| 18:50:57 | jaypipes | mriedem: they listen on the same queue, no? | |
| 18:51:45 | mriedem | yeah i think so https://github.com/openstack/searchlight/blob/2.0.0/searchlight/elasticsearch/plugins/nova/notification_handler.py#L73 | |
| 18:52:09 | mriedem | i'm not entirely sure that this maps the same https://github.com/openstack/searchlight/blob/2.0.0/searchlight/elasticsearch/plugins/nova/notification_handler.py#L82 | |
| 18:57:35 | mriedem | cdent: jaypipes: for example, searchlight has https://github.com/openstack/searchlight/blob/2.0.0/searchlight/elasticsearch/plugins/nova/notification_handler.py#L92 | |
| 18:57:39 | mriedem | compute.instance.power_off.end | |
| 18:57:47 | mriedem | our versioned notification sample has https://github.com/openstack/nova/blob/master/doc/notification_samples/instance-power_off-end.json#L2 | |
| 18:57:51 | mriedem | instance.power_off.end | |
| 18:58:04 | mriedem | i'm not sure where the compute. prefix comes from | |
| 18:58:50 | cdent | mriedem: it looks like it may be something they are doing: https://github.com/openstack/searchlight/blob/2.0.0/searchlight/elasticsearch/plugins/ironic/notification_handlers.py | |
| 18:58:56 | cdent | (sorry, line 37) | |
| 18:59:50 | mriedem | cdent: i'm not so sure https://github.com/openstack/nova/blob/master/nova/rpc.py#L292 | |
| 19:00:10 | cdent | indeed | |
| 19:00:21 | openstackgerrit | Dan Smith proposed openstack/nova master: Get instance availability_zone without hitting the api db https://review.openstack.org/439754 | |
| 19:00:22 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162 | |
| 19:00:22 | openstackgerrit | Dan Smith proposed openstack/nova master: Enlighten server tags API about cells https://review.openstack.org/440856 | |
| 19:00:23 | openstackgerrit | Dan Smith proposed openstack/nova master: Target cell in super conductor operations https://review.openstack.org/438022 | |
| 19:00:23 | openstackgerrit | Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163 | |
| 19:00:24 | openstackgerrit | Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891 | |
| 19:00:24 | openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | |
| 19:00:25 | openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | |
| 19:00:25 | openstackgerrit | Dan Smith proposed openstack/nova master: Make consoleauth target the proper cell https://review.openstack.org/441461 | |
| 19:00:26 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388 | |
| 19:00:26 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025 | |
| 19:00:27 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-migrations about cells https://review.openstack.org/442685 | |
| 19:00:27 | openstackgerrit | Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200 | |
| 19:00:42 | cdent | even if it is problem, based on the conversations we've had with searchlight in the past they've strenuously said: we will make this work... | |
| 19:04:33 | mriedem | gibi: do you know where the compute. prefix shows up in the unversioned legacy notifications? | |
| 19:04:43 | mriedem | cdent: yeah also https://blueprints.launchpad.net/searchlight/+spec/nova-versioned-notifications | |
| 19:05:40 | cdent | ack | |
| 19:11:24 | cdent | i have continuouspartialattentionitis | |
| 19:11:49 | mriedem | i have a headache staring at this notification code | |
| 19:12:08 | mriedem | i think we've also changed compute.instance.create.start to conductor.instance.create.start | |
| 19:12:16 | mriedem | maybe | |
| 19:15:58 | openstackgerrit | Jay Pipes proposed openstack/nova master: placement: standard memory page resource classes https://review.openstack.org/442718 | |
| 19:17:19 | mriedem | cdent: i think this is where we get the compute. prefix on the unversioned notification https://github.com/openstack/nova/blob/master/nova/compute/utils.py#L324 | |
| 19:17:26 | mriedem | versioned is https://github.com/openstack/nova/blob/master/nova/compute/utils.py#L356 | |
| 19:17:29 | mriedem | which doesn't have the prefix | |
| 19:18:26 | cdent | that seems rather unfortunate | |
| 19:18:32 | cdent | he said blandly | |
| 19:21:58 | mriedem | i assume that was intentional | |
| 19:22:54 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Update docstrings for legacy notification methods https://review.openstack.org/442723 | |
| 19:23:18 | cdent | I know that there was intention to make it so you could have both of them going at the same time, but from the consumer side, having different names (instead of different topics (is that right, I'm not sure of the nomenclature)) makes switching harder | |
| 19:23:35 | mriedem | by default nova is configured to send both | |
| 19:24:09 | mriedem | http://logs.openstack.org/59/382959/17/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/f2fe0de/logs/screen-n-cpu.txt.gz#_2017-03-06_14_39_55_787 | |
| 19:24:16 | mriedem | notifications.notification_format = both | |
| 19:24:35 | mriedem | http://logs.openstack.org/59/382959/17/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/f2fe0de/logs/screen-n-cpu.txt.gz#_2017-03-06_14_39_55_756 | |
| 19:24:43 | mriedem | oslo_messaging_notifications.topics = ['notifications'] | |
| 19:24:43 | mriedem | i only see the one topic | |