Earlier  
Later
New Search
Posted Nick Remark
#openstack-nova - 2017-03-07
15:56:59 mriedem that's not the final patch is it?
15:57:04 mriedem just a side thing
15:57:10 mriedem little something something on the side
15:57:27 jaypipes mriedem: oh, it's not dependent?
15:57:29 jaypipes gotcha
15:57:42 jaypipes vdrok: k, feel free to ignore that last patch ;)
15:57:55 jaypipes vdrok: just test on 441544 :)
15:58:12 vdrok gotcha
15:58:56 mriedem jaypipes: right i just thought, while reviewing the base patch, that we could do an easy functional test to the invalid resource class case to avoid the mocked unit tests failing us later,
15:59:04 mriedem it was easier to add than i thought so i pushed it up last night
15:59:22 jaypipes mriedem: cool, thanks very much for that :)
15:59:24 openstackgerrit Jay Pipes proposed openstack/nova master: virt: implement get_inventory() for Ironic https://review.openstack.org/441544
15:59:32 jaypipes mriedem: fixed pep8^
15:59:55 openstackgerrit Matt Riedemann proposed openstack/nova master: Add test for inventory with invalid ResourceClass https://review.openstack.org/442498
16:06:19 openstack Launchpad bug 1670738 in OpenStack Compute (nova) "man page needed for "nova-manage db online_data_migrations"" [Medium,Triaged]
16:06:19 mriedem easy docs bug if someone wants to take it - will help out operators https://bugs.launchpad.net/nova/+bug/1670738
16:07:34 mriedem hmm, dansmith didn't we used to have a hook that ran online_data_migrations in the CI jobs and dump the results?
16:07:44 mriedem i'm not seeing the hook here http://logs.openstack.org/52/440652/2/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/6883d38/logs/
16:07:54 mriedem or http://logs.openstack.org/52/440652/2/check/gate-grenade-dsvm-neutron-ubuntu-xenial/74bea3f/logs/
16:08:06 dansmith mriedem: in the grenade jobs yeah
16:08:23 mriedem ok something regressed, i'll check it out
16:08:39 dansmith it's in upgrade.sh, I just grepped
16:08:51 dansmith nova/upgrade.sh
16:09:16 mriedem that's not what i'm thinking of
16:09:31 mriedem oh i'm thinking of this https://github.com/openstack/nova/blob/master/gate/post_test_hook.sh
16:11:05 mriedem hmm, unrelated but http://logs.openstack.org/52/440652/2/check/gate-grenade-dsvm-neutron-ubuntu-xenial/74bea3f/logs/grenade.sh.txt.gz#_2017-03-02_20_38_16_615
16:11:12 mriedem nova-manage cell_v2 map_cell0: error: argument --database_connection: expected one argument
16:11:22 mriedem database_connection_url: command not found
16:13:16 mriedem i see the issue
16:16:08 mriedem https://review.openstack.org/442599
16:16:13 mriedem i'm not sure why we have the || true in there
16:16:21 mriedem probably for the old bug where map_cell0 would return 1
16:17:19 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Get instance availability_zone without hitting the api db https://review.openstack.org/439754
16:17:20 openstackgerrit Dan Smith proposed openstack/nova master: Teach HostAPI about cells https://review.openstack.org/442162
16:17:20 openstackgerrit Dan Smith proposed openstack/nova master: Enlighten server tags API about cells https://review.openstack.org/440856
16:17:21 openstackgerrit Dan Smith proposed openstack/nova master: Target cell in super conductor operations https://review.openstack.org/438022
16:17:21 openstackgerrit Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163
16:17:22 openstackgerrit Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891
16:17:22 openstackgerrit Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023
16:17:23 openstackgerrit Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024
16:17:23 openstackgerrit Dan Smith proposed openstack/nova master: Make consoleauth target the proper cell https://review.openstack.org/441461
16:17:24 openstackgerrit Dan Smith proposed openstack/nova master: Teach simple_tenant_usage about cells https://review.openstack.org/441388
16:17:24 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025
16:17:25 openstackgerrit Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200
16:30:11 mriedem dansmith: the archive_deleted_rows post-test-hook only runs on the nova-next job i guess http://logs.openstack.org/52/440652/2/check/gate-tempest-dsvm-neutron-nova-next-full-ubuntu-xenial-nv/51f2ea4/logs/devstack-gate-post_test_hook.txt.gz
16:30:15 mriedem just fyi
16:31:52 dansmith hmm why is that?
16:33:06 mriedem https://github.com/openstack-infra/project-config/commit/df865a4e9d6830abb553f077ce885d8493210efa
16:33:31 mriedem i'm guessing we just put it there since it's a nova-specific job really,
16:33:42 mriedem and was a fancy snowflake at the time, which is where we put things like that
16:34:01 dansmith ah I see, because it evolved from the placement job/
16:34:29 mriedem https://review.openstack.org/#/c/376567/ says we could make it fatal
16:34:32 mriedem could/should
16:34:35 mriedem we could think about that now
16:34:45 mriedem so if archive starts breaking then we fail the job
16:34:51 dansmith yeah
16:37:12 dansmith mriedem: why is there no single-create test in this? https://github.com/openstack/tempest/blob/master/tempest/api/compute/admin/test_auto_allocate_network.py
16:37:36 mriedem there is
16:37:37 mriedem https://github.com/openstack/tempest/blob/master/tempest/api/compute/admin/test_auto_allocate_network.py#L150
16:37:52 dansmith mriedem: that tests no allocate right?
16:37:57 mriedem correct
16:38:15 dansmith but the multi one tests that there _is_ allocation
16:38:17 mriedem but we still create a server
16:38:30 mriedem why would it matter for multi cell?
16:38:58 dansmith I don't know why it's failing, and was looking for a non-multi-create test to see why that works and multi doesn't
16:39:17 mriedem log link me?
16:39:19 dansmith changing it to one server doesn't make it pass, so it must not be related to multi-create, I was just curious
16:39:47 dansmith mriedem: http://logs.openstack.org/94/436094/12/check/gate-tempest-dsvm-neutron-full-ubuntu-xenial/051cffa/logs/testr_results.html.gz
16:42:30 openstackgerrit Ed Leafe proposed openstack/nova master: Add test for inventory with invalid ResourceClass https://review.openstack.org/442498
16:43:42 dansmith I'm not even sure what to look at
16:46:25 mriedem just look into my eyes and don't be afraid
16:47:09 mriedem dansmith: so we're failing on https://github.com/openstack/tempest/blob/master/tempest/api/compute/admin/test_auto_allocate_network.py#L188
16:47:19 mriedem are we going to the proper cell to get the info_cache?
16:47:37 mriedem that test creates 3 servers and waits for them all to be ACTIVE,
16:47:55 mriedem then iterates over them and lists their addresses to make sure there was a nic assigned
16:48:09 dansmith should be.. you think that's the only test that looks at stuff from info cache?
16:48:13 mriedem so either the nic isn't getting assigned, or we're not pulling the info_cache properly
16:48:35 mriedem there should be other tests that do that for attaching interfaces
16:48:51 dansmith yeah, and those appear to work
16:49:06 mriedem i'm not sure what they assert though
16:49:11 mriedem checking the n-cpu logs now
16:49:12 dansmith mriedem: and if I boot a server manually I see an address
16:49:21 dansmith let me try with auto networks
16:49:24 mriedem dansmith: with devstack?
16:49:27 dansmith yeah
16:49:30 mriedem dansmith: that's not the same,
16:49:37 mriedem because your tenant in devstack has access to the public network already
16:49:43 mriedem so we don't hit the auto-allocate paths
16:49:45 mriedem in n-cou
16:49:47 dansmith right, I'm saying we're pulling those nic details
16:49:48 mriedem *n-cpu
16:49:50 dansmith in the api
16:50:06 mriedem yeah, but this specific test has a tenant which has no access to any existing networks
16:50:13 openstackgerrit Dan Smith proposed openstack/nova master: Make os-availability-zones know about cells https://review.openstack.org/442163
16:50:13 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Get instance availability_zone without hitting the api db https://review.openstack.org/439754
16:50:14 openstackgerrit Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891
16:50:14 openstackgerrit Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023
16:50:15 openstackgerrit Dan Smith proposed openstack/nova master: WIP: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025
16:50:15 openstackgerrit Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024
16:50:16 openstackgerrit Dan Smith proposed openstack/nova master: Teach os-aggregates about cells https://review.openstack.org/442200

Earlier   Later