| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-07 | |||
| 03:15:59 | mriedem | it took the diff between 1..2 to see it | |
| 03:16:14 | mriedem | the lack of a test in ps1 showed that the exception we'd hit there wasn't even defined :( | |
| 03:16:50 | dansmith | mriedem: how does that mean that we report the good ones and not the bad ones? | |
| 03:16:54 | dansmith | we just don't report anything right? | |
| 03:17:03 | mriedem | we won't report anything | |
| 03:17:08 | mriedem | it'll be an error | |
| 03:17:10 | dansmith | yeah | |
| 03:17:27 | dansmith | just seems like it'd be better for us to sanitize each thing and report | |
| 03:17:52 | dansmith | in the case of traits we have to be graceful about being newer than placement | |
| 03:18:03 | dansmith | might not be as much of a deal here, but still.. | |
| 03:20:38 | dansmith | mriedem: are you going to +W the latest? | |
| 03:20:58 | mriedem | i believe so, | |
| 03:21:12 | mriedem | but i'm going to mention the lack of actual functional testing of the report client and all of the mock-based tests concerns me | |
| 03:21:47 | mriedem | because there is quite a bit of per-method mocking going on for error conditions and that could miss some things later, functional tests would be best | |
| 03:22:47 | dansmith | did you seem my comments from the previous patch? | |
| 03:22:55 | dansmith | I wish he hadn't abandoned that and re-used it for one of these, but oh well | |
| 03:23:08 | dansmith | either way, I said the same thing.. I feel like the coverage is fine, but it seems like these are very unit-y tests | |
| 03:23:32 | dansmith | however, placement kinda has to be considered external to nova so not having solid functional tests seems as resonable as not having them for cinder | |
| 03:25:55 | mriedem | we do have functional tests for a lot of this report client stack though | |
| 03:26:11 | mriedem | i think for the negative scenario we need a fake virt driver that returns garbage, which is easy enough | |
| 03:26:48 | mriedem | i +Wed it just to keep it moving | |
| 03:26:57 | mriedem | i think we can hammer out a functional test as a follow on | |
| 03:29:34 | dansmith | mriedem: for the report stuff? like, it runs a placement? | |
| 03:30:51 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: [POC] Searchlight intergration https://review.openstack.org/442248 | |
| 03:30:59 | mriedem | i was thinking of self.url | |
| 03:31:01 | mriedem | damn | |
| 03:31:07 | mriedem | https://review.openstack.org/#/c/441543/2/nova/tests/functional/api/openstack/placement/test_report_client.py | |
| 03:31:15 | mriedem | but that's not running a placement service | |
| 03:31:39 | mriedem | well, actually i think it is | |
| 03:31:44 | mriedem | it deploys a wsgi app | |
| 03:31:55 | mriedem | i'm not sure how the wsgi_intercept stuff works | |
| 03:32:20 | dansmith | is that different from this patch though? it uses wsgi_intercept too | |
| 03:32:38 | openstack | Launchpad bug 1670262 in OpenStack Compute (nova) "DBNonExistenceDatabase: Unknown database "nova_cell0"" [Undecided,Incomplete] | |
| 03:32:38 | diga | mriedem: https://bugs.launchpad.net/nova/+bug/1670262 Getting this issues when setup fresh devstack & run server list command from cli | |
| 03:32:57 | mriedem | diga: then create nova_cell0 | |
| 03:34:46 | mriedem | diga: https://github.com/openstack-dev/devstack/blob/8fe48af1625cd2deca496de81dd72573e78b3ef2/lib/nova#L709 | |
| 03:35:11 | diga | mriedem: okay, will go through it | |
| 03:35:41 | diga | mriedem: may be my devstack source code is old | |
| 03:35:49 | mriedem | dansmith: i'm actually not sure why he couldn't have just modified https://review.openstack.org/#/c/441543/2/nova/tests/functional/api/openstack/placement/test_report_client.py to call set_inventory_for_provider with a garbage resource class | |
| 03:35:50 | diga | mriedem: need to pull latest | |
| 03:35:54 | diga | mriedem: thank you | |
| 03:35:59 | mriedem | and assert it raises the expected exception | |
| 03:36:03 | mriedem | i can try that quick | |
| 03:45:11 | mriedem | dansmith: yeah this would have been much easier https://gist.github.com/mriedem/1fb38bd4bb62cff0c5bcd90abb049c88 | |
| 03:48:48 | dansmith | oh well | |
| 03:49:40 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Add functional test for bad res class in set_inventory_for_provider https://review.openstack.org/442254 | |
| 03:49:42 | mriedem | dansmith: ^ oh nothing | |
| 03:50:03 | dansmith | that's what we need, more patches | |
| 03:50:16 | mriedem | "more good patches" | |
| 03:50:21 | mriedem | was the BCN phrase of the week | |
| 03:51:31 | dansmith | heh | |
| 03:54:36 | openstackgerrit | Matt Riedemann proposed openstack/nova master: autospec the virt driver mock in test_resource_tracker https://review.openstack.org/442258 | |
| 03:56:51 | mriedem | with that i'll call it a day | |
| 04:14:32 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: Port binding based on events during live migration https://review.openstack.org/434870 | |
| 04:43:27 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | |
| 04:43:42 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | |
| 04:44:00 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | |
| 04:44:43 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926 | |
| 05:05:34 | openstackgerrit | Alex Xu proposed openstack/nova master: placement: Add Trait and TraitList objects https://review.openstack.org/376199 | |
| 05:53:59 | wllabs | version 2.14 | |
| 05:54:05 | wllabs | how to define version? | |
| 05:54:27 | wllabs | how to know my code's version | |
| 06:02:52 | wllabs | qinatov | |
| 06:02:55 | wllabs | aignatov | |
| 06:42:16 | jvarlamova__ | Hi everyone! Can someone help me? I get error "Failed to allocate the network(s), not rescheduling", when trying to boot multiple instances in parallel. What could be the reason? | |
| 06:58:19 | openstackgerrit | Akira KAMIO proposed openstack/nova master: Replace root volume during rebuild https://review.openstack.org/442295 | |
| 07:46:44 | openstackgerrit | Danil Akhmetov proposed openstack/nova master: Use proper user and tenant in the owner section of libvirt.xml. https://review.openstack.org/399679 | |
| 07:51:59 | openstackgerrit | Akira KAMIO proposed openstack/nova master: Replace root volume during rebuild https://review.openstack.org/442295 | |
| 07:58:02 | bauzas | good morning Nova | |
| 08:03:49 | slaweq | hello | |
| 08:03:59 | slaweq | I have a question about rebuild of instance | |
| 08:05:24 | slaweq | (I'm using Juno release still), so sometimes when I rebuild active instance it's rebuild fine but in libvirt logs I can see something like "Cannot open log file: '/var/log/libvirt/qemu/instance-002d6c52.log'" and instance is then shutdown by libvirt | |
| 08:05:49 | slaweq | maybe someone of You got such issue already and know how to fix it? | |
| 08:06:58 | openstackgerrit | jichenjc proposed openstack/nova master: Trivial Fix https://review.openstack.org/442310 | |
| 08:08:08 | openstackgerrit | Akira KAMIO proposed openstack/nova master: Replace root volume during rebuild https://review.openstack.org/442295 | |
| 08:15:31 | openstackgerrit | jichenjc proposed openstack/nova master: Remove extension in API layer https://review.openstack.org/442312 | |
| 08:50:56 | openstackgerrit | Zhenyu Zheng proposed openstack/nova master: [POC] Searchlight intergration https://review.openstack.org/442248 | |
| 08:59:26 | openstackgerrit | Akira KAMIO proposed openstack/nova master: Replace root volume during rebuild https://review.openstack.org/442295 | |
| 09:28:11 | openstackgerrit | Akira KAMIO proposed openstack/nova master: Replace root volume during rebuild https://review.openstack.org/442295 | |
| 09:44:49 | openstackgerrit | Akira KAMIO proposed openstack/nova master: Replace root volume during rebuild https://review.openstack.org/442295 | |
| 10:08:30 | mdbooth | lyarwood: What do you know of lvm thin pools? | |
| 10:13:12 | openstackgerrit | Akira KAMIO proposed openstack/nova master: Replace root volume during rebuild https://review.openstack.org/442295 | |
| 10:14:17 | lyarwood | mdbooth: not much, I've never really had the chance to use them tbh | |
| 10:14:31 | mdbooth | lyarwood: k | |
| 10:14:59 | lyarwood | mdbooth: we don't use them in the lvm imagebackend do we? | |
| 10:15:20 | mdbooth | lyarwood: I'm just reviewing this patch: https://review.openstack.org/#/c/442126/2/nova/virt/libvirt/storage/lvm.py | |
| 10:15:44 | mdbooth | I'm curious, because I thought we already did use them if we specified sparse | |
| 10:15:55 | mdbooth | And this patch is adding something new | |
| 10:16:14 | mdbooth | I'm just reading some man pages to try to work out what's different from what we already do | |
| 10:19:21 | markus_z | lyarwood: Anything I can do for the stable/newton backport https://review.openstack.org/#/c/406898/ ? I answered all questions to that so far. | |
| 10:20:25 | sfinucan | johnthetubaguy: Could you take a look at https://review.openstack.org/#/c/435575? It's pretty noddy but it keeps getting into merge conflicts | |
| 10:20:39 | openstackgerrit | Rodolfo Alonso Hernandez proposed openstack/nova-specs master: Enable SR-IOV NIC offload feature discovery https://review.openstack.org/435954 | |
| 10:20:40 | lyarwood | markus_z: I was going to take another look at it today before matt gets online so we can hopefully close it out | |
| 10:20:54 | lyarwood | markus_z: I think you've answered his questions but just wanted to check first | |
| 10:21:03 | johnthetubaguy | sfinucan: oh, I can see what why would happen, yeah, looking | |
| 10:21:12 | sfinucan | johnthetubaguy: Cheers :) | |
| 10:21:46 | lyarwood | mdbooth: ah right, before we would just create a sparse LV and manually grow that LV (I *think*) | |
| 10:21:55 | markus_z | lyarwood: OK, thanks. JFYI, I might leave early today ~1600UTC | |
| 10:22:05 | lyarwood | at least, that's what RHEV would do back in the day with sparse LVs | |
| 10:22:14 | mdbooth | johnthetubaguy: Following our discussion last week, I suspect that even with Cinder V3 we're going to end up doing this: https://review.openstack.org/#/c/383859/ | |