| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-02 | |||
| 22:02:55 | dansmith | sdague: but yeah thanks | |
| 22:02:57 | sdague | the only question is if there is a very early 404 in wsgi | |
| 22:03:00 | dansmith | right | |
| 22:03:14 | cfriesen | mriedem: right, I saw that part. | |
| 22:03:50 | sdague | https://github.com/openstack/nova/blob/37cd9a961b065a07352b49ee72394cb210d8838b/nova/api/openstack/wsgi.py#L601 | |
| 22:03:59 | sdague | but that should show up in nova-api logs as a fault | |
| 22:04:08 | openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in admin_actions. https://review.openstack.org/440829 | |
| 22:04:48 | dansmith | oooooo | |
| 22:05:16 | dansmith | no, no. | |
| 22:05:17 | cfriesen | mriedem: that summary is useful, thanks. it might be nice if it was in the code as a comment or something. | |
| 22:05:18 | dansmith | dammit | |
| 22:05:44 | sdague | ok, you have to share before I run away | |
| 22:05:48 | sdague | because I want to know :) | |
| 22:05:48 | dansmith | there is no instance lookup in the path of the PUT | |
| 22:06:02 | dansmith | I thought there was, but it's for the server get the client does before the put of the tag | |
| 22:06:05 | dansmith | after the get returns, | |
| 22:06:13 | sdague | ah | |
| 22:06:14 | dansmith | no instance get at all | |
| 22:06:19 | dansmith | so...... | |
| 22:06:24 | sdague | right, so you are way off in 404 land | |
| 22:06:35 | dansmith | I don't like 404 land | |
| 22:08:21 | openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in admin_actions. https://review.openstack.org/440829 | |
| 22:09:46 | mriedem | dims: v | |
| 22:09:47 | mriedem | https://review.openstack.org/440832 | |
| 22:10:05 | mriedem | cfriesen: i have to go back and read the summary myself | |
| 22:10:50 | dansmith | sdague: omg I am so awesaome | |
| 22:11:36 | dansmith | sdague: RROR stevedore.extension [req-3b12728d-ad52-44bd-b79d-ba66275e1d1d None None] Could not load 'server_tags': cannot import name nova_context | |
| 22:12:35 | mriedem | cfriesen: ok so we fixed the 2 things in that thread we said we would, | |
| 22:12:44 | mriedem | which is the microversion to list instance actions for deleted instances, | |
| 22:12:53 | mriedem | and hard delete instance actions when archiving an instance | |
| 22:13:14 | mriedem | cfriesen: if you wanted to push a change to add a comment about why we don't soft delete instance actions when deleting an instance, in the instance_destroy db api method, i'd +2 that | |
| 22:13:28 | cfriesen | mriedem: okay | |
| 22:22:21 | openstackgerrit | Anusha Unnam proposed openstack/nova master: Add description to policies to availability_zone https://review.openstack.org/440836 | |
| 22:25:30 | cfriesen | one final DB question (for today, anyway). What's the story around console_auth_tokens added in Newton? Is something going to delete them? | |
| 22:25:57 | dansmith | my jar runneth over | |
| 22:28:58 | mriedem | cfriesen: talk to melwitt about the spec for that | |
| 22:29:23 | cfriesen | mriedem: I'm looking at https://blueprints.launchpad.net/nova/+spec/convert-consoles-to-objects ... looks like it got only partially implemented? | |
| 22:29:31 | mriedem | cfriesen: yes | |
| 22:29:39 | mriedem | melwitt is going to re-propose the spec for pike | |
| 22:30:25 | cfriesen | okay, cool. so in Newton the table is there but unused? | |
| 22:31:24 | melwitt | looks like it. you can see the patches that merged vs ones that ended up abandoned here https://review.openstack.org/#/q/topic:bp/convert-consoles-to-objects,n,z | |
| 22:32:18 | melwitt | so my plan is to repropose the spec and then resurrect those old patches and fix them up if needed to finish the work | |
| 22:33:12 | cfriesen | melwitt: thanks. I was looking for users of console_auth_token_create() but didn't see any. | |
| 22:33:31 | melwitt | yeah | |
| 22:36:05 | cfriesen | melwitt: okay, looks like https://review.openstack.org/#/c/325381/ introduces a periodic task to clean up expired tokens. seems maybe a bit odd to drive it from the compute nodes though. | |
| 22:38:36 | melwitt | cfriesen: yeah, although that works out for cells, since the tokens will be kept in cell databases, and only n-cpu and n-cond run in a cell | |
| 22:44:33 | jaypipes | dansmith: hey, splitting that big patch is prolly a good idea at this point, yeah. I'll do it when I get to my hotel this evening (currently sitting in SeaTac airport...) | |
| 22:44:48 | dansmith | jaypipes: okay I think it'll be easy | |
| 22:45:51 | cfriesen | just noticed something odd. at https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L1879 we soft-delete migrations when the instance is deleted, but then at https://github.com/openstack/nova/blob/master/nova/db/sqlalchemy/api.py#L6474 we special-case the migrations table like we do for instance_actions. Is that no longer needed? | |
| 22:47:30 | jaypipes | dansmith: ya, shouldn't be a big deal. | |
| 22:47:35 | mriedem1 | cfriesen: that's for dealing with migrations that were not soft deleted | |
| 22:47:51 | mriedem1 | so you'd have migrations in the db that weren't soft deleted and those would break the archive | |
| 22:48:07 | mriedem1 | anything after we started soft deleting migrations when the instance was deleted would be fine | |
| 22:48:51 | mriedem | to drop that special case code in the archive function we'd probably need a schema migration that drops those old records | |
| 22:49:09 | mriedem | or an online data migration actually | |
| 22:49:15 | mriedem | then you don't have the downtime issue | |
| 22:54:38 | cfriesen | is there anything stopping us from doing something similar to soft-delete instance_actions and instance_actions_events now in instance_destroy()? (Now that we've made the other changes from the mailing list summary, I mean.) Or is it not worth the effort? | |
| 22:55:14 | mriedem | we don't want to soft delete those because their useful for operators to find out what actions were performed on an instance, which may be deleted now | |
| 22:55:19 | mriedem | that was the reason for the microversion | |
| 22:55:24 | mriedem | *they're | |
| 22:55:26 | cfriesen | okay, got it | |
| 22:55:38 | mriedem | i'd put that in the comment you add to instance_destroy | |
| 22:55:42 | mriedem | wink wink | |
| 22:55:52 | cfriesen | that's why I asked. :) | |
| 23:05:48 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Get instance availability_zone without hitting the api db https://review.openstack.org/439754 | |
| 23:05:49 | openstackgerrit | Dan Smith proposed openstack/nova master: Change MQ targeting to honor only what is in the context https://review.openstack.org/438023 | |
| 23:05:49 | openstackgerrit | Dan Smith proposed openstack/nova master: Target cell in super conductor operations https://review.openstack.org/438022 | |
| 23:05:50 | openstackgerrit | Dan Smith proposed openstack/nova master: Add cell field to Destination object https://review.openstack.org/438024 | |
| 23:05:50 | openstackgerrit | Dan Smith proposed openstack/nova master: Make scheduler target cells to get compute node instance info https://review.openstack.org/439891 | |
| 23:05:51 | openstackgerrit | Dan Smith proposed openstack/nova master: Enlighten server tags API about cells https://review.openstack.org/440856 | |
| 23:05:51 | openstackgerrit | Dan Smith proposed openstack/nova master: WIP: Make conductor ask scheduler to limit migrates to same cell https://review.openstack.org/438025 | |
| 23:27:55 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(1/2) https://review.openstack.org/408955 | |
| 23:28:24 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Enable cold migration with target host(2/2) https://review.openstack.org/408964 | |
| 23:28:24 | dansmith | dtp: still around? | |
| 23:28:30 | dtp | yessir | |
| 23:29:00 | openstackgerrit | Takashi NATSUME proposed openstack/nova-specs master: Fix formatting errors and warnings https://review.openstack.org/407364 | |
| 23:29:14 | dansmith | dtp: there are a few other tests that I think are depending on the hypervisor listing, like the aggregates one that uses hypervisors to get a list of hostnames | |
| 23:29:34 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: Add functional tests for cold migration to same host https://review.openstack.org/414926 | |
| 23:29:44 | dansmith | so fixing that might get us a fair swipe of passing tests | |
| 23:29:47 | openstackgerrit | Takashi NATSUME proposed openstack/nova master: api-ref: Add parameters in cold migrate action https://review.openstack.org/410042 | |
| 23:31:56 | dtp | dansmith that's cool. i haven't had a chance to start on that yet | |
| 23:32:03 | dansmith | *gasp* | |
| 23:32:27 | openstackgerrit | Sujitha proposed openstack/nova master: Add description to policies in admin_actions. https://review.openstack.org/440829 | |
| 23:32:28 | dansmith | dtp: okay well, let me know if you get overly delayed | |
| 23:32:28 | dtp | yeah sorry...misjudged my week | |
| 23:32:36 | dansmith | s'ok | |
| 23:33:16 | dtp | don't let me slow you down - if it's better for you to do that one and me to come back again when i _really_ can focus, that's fine w/ me | |
| 23:33:39 | dansmith | okay I'll ping you if I break your lock | |
| 23:34:48 | dtp | okey dokey | |
| 23:53:41 | openstackgerrit | Giridhar Jayavelu proposed openstack/nova-specs master: VMware: add SR-IOV support https://review.openstack.org/317126 | |
| #openstack-nova - 2017-03-03 | |||
| 00:07:44 | openstackgerrit | Giridhar Jayavelu proposed openstack/nova-specs master: VMware: add SR-IOV support https://review.openstack.org/317126 | |
| 00:41:49 | mriedem | feel free to take them to the bridge, james brown | |
| 01:04:37 | mriedem | alex_xu: are you ok with this? https://review.openstack.org/#/c/440654/ | |
| 01:23:59 | mriedem | lyarwood: oh so close https://review.openstack.org/#/c/242602/ | |
| 01:45:11 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: [WIP] Live migration of rescued instances https://review.openstack.org/440893 | |
| 01:55:52 | openstackgerrit | Gao Yuan proposed openstack/nova master: Remove mox from nova.tests.unit.api.openstack.compute.test_block_device_mapping https://review.openstack.org/440475 | |
| 02:38:02 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Reno for additional-notification-fields-for-searchlight https://review.openstack.org/428835 | |
| 02:38:05 | openstackgerrit | Zhenyu Zheng proposed openstack/nova-specs master: Send out notifications when instance tags chaned https://review.openstack.org/429569 | |
| 02:43:50 | openstackgerrit | Sivasathurappan Radhakrishnan proposed openstack/nova master: [WIP] Live migration of rescued instances https://review.openstack.org/440904 | |
| 04:21:11 | openstackgerrit | Ghanshyam Mann proposed openstack/nova master: Add api-ref for filter/sort whitelist https://review.openstack.org/421760 | |