| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-03-02 | |||
| 20:09:57 | dansmith | _gryf: this only existed in ironic in ocata, and not even directly as a placement resource class | |
| 20:10:13 | _gryf | dansmith, oh | |
| 20:10:45 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Handle conflicts for os-assisted-volume-snapshots https://review.openstack.org/429476 | |
| 20:10:58 | melwitt | mriedem: I didn't use the previously-approved tag because I changed it to not talk about populating the quota_usages and reservations tables | |
| 20:11:13 | mriedem | oh boy | |
| 20:11:17 | mriedem | now i actually have to diff it | |
| 20:11:25 | _gryf | so yeah, I'm also uncertain why ironic is treated in special way :( | |
| 20:11:30 | melwitt | I can put it back the way it was if you want :P | |
| 20:11:46 | melwitt | it just wasn't accurate anymore | |
| 20:12:17 | mriedem | no it's good to be accurate | |
| 20:12:36 | edleafe | _gryf: because it's the only non-Nova resource provider we've considered | |
| 20:13:55 | melwitt | yeah, was just kidding | |
| 20:14:22 | _gryf | but wait. doesn't nova was able to provide bare metal before? I mean, if we track certain amount of resources, spinning out bare metal should take out such resources out of available one, isn't it? | |
| 20:15:03 | mriedem | sileht: https://review.openstack.org/#/c/440657/ passed with https://review.openstack.org/#/c/440739/ | |
| 20:15:27 | mriedem | and it looks like https://review.openstack.org/#/c/440739/ passed the cellsv1 and normal jobs | |
| 20:15:34 | mriedem | dansmith: sdague: ^ | |
| 20:15:38 | mriedem | so we should get that devstack change in | |
| 20:15:40 | mriedem | to unblock gnocchi | |
| 20:26:58 | mriedem | melwitt: +2 | |
| 20:27:27 | melwitt | thanks | |
| 20:46:53 | openstackgerrit | Matt Riedemann proposed openstack/nova master: Default firewall_driver to nova.virt.firewall.NoopFirewallDriver https://review.openstack.org/439187 | |
| 20:50:24 | mriedem | nova meeting in 10 minutes | |
| 20:51:01 | mriedem | was there a cells meeting yesterday? i spaced on that one. | |
| 20:59:54 | dtp | yes | |
| 21:21:33 | sdague | mriedem: am I the only one that feels like we're doing genetic programming on nova manage commands to move them around until least stuff breaks :) | |
| 21:31:43 | mriedem | sdague: yes you are | |
| 21:31:49 | mriedem | everyone else knows what's going on with the nova-manage commands | |
| 21:32:35 | mriedem | sdague: musical chairs is the name of the game | |
| 21:32:37 | dansmith | seriously | |
| 21:32:59 | mriedem | sdague: the commit message explains the thing, it was wrong to begin with how we were doing it, | |
| 21:33:17 | mriedem | just didn't realize that until we moved map_cell0 earlier and the telemetry extras injected itself into the middle of the stack | |
| 21:33:37 | mriedem | we were basically getting lucky before just because we did some stuff all at the end | |
| 21:33:45 | mriedem | which was wrong | |
| 21:34:19 | mriedem | sometimes i do feel like a 16th century monk that gets off on watching peas mate with each other | |
| 21:35:04 | takashin | mriedem: Would you remove -2 in https://review.openstack.org/#/c/408955/ ? | |
| 21:36:14 | openstackgerrit | Sarafraj Singh proposed openstack/nova-specs master: Add live-migration-force-after-timeout spec https://review.openstack.org/438467 | |
| 21:36:24 | mriedem | takashin: done | |
| 21:37:10 | takashin | mriedem: Thank you. | |
| 21:37:23 | openstackgerrit | Sarafraj Singh proposed openstack/nova-specs master: WIP: Add live-migration-force-after-timeout spec https://review.openstack.org/438467 | |
| 21:40:11 | mriedem | ildikov: fyi i've started a nova/cinder review priority section here, L62 https://etherpad.openstack.org/p/pike-nova-priorities-tracking | |
| 21:40:32 | mriedem | ildikov: let's keep that focused on a small set of patches per week though | |
| 21:41:15 | ildikov | mriedem: great, thank you! | |
| 21:41:26 | dims | mriedem : looks like stale data - https://governance.openstack.org/tc/goals/pike/python35.html#nova | |
| 21:41:58 | mriedem | dims: the # of tests? | |
| 21:42:00 | ildikov | mriedem: we can keep the long list on the regular etherpad and move items to the priority one when they are out of WIP for instance | |
| 21:42:25 | mriedem | dims: i'm not sure how that number was calculated to begin with | |
| 21:43:09 | mriedem | maybe that's total number of py27 tests - total number of py35 tests run | |
| 21:43:55 | mriedem | dims: hmm i also see that gate-nova-tox-functional-py35-ubuntu-xenial is non-voting but it's passing | |
| 21:43:58 | mriedem | not sure why it's still non-voting | |
| 21:44:22 | dims | mriedem : right. http://git.openstack.org/cgit/openstack/nova/tree/tests-py3.txt also shows just a handful of things | |
| 21:44:34 | dims | +1 to make it voting | |
| 21:44:57 | mriedem | dims: want to push that change? | |
| 21:45:11 | dims | project-config change, sure | |
| 21:45:31 | mriedem | yeah it's actually down to 63 tests now | |
| 21:45:35 | mriedem | i'll update the governance repo | |
| 21:47:02 | dansmith | mriedem: sdague: for something like /servers/<uuid>/tags/foo, is there some glue somewhere that looks up the instance via uuid before the show/update gets called in the server_tags extension? | |
| 21:47:16 | dansmith | something other than servers.py::show I would assume | |
| 21:48:29 | sdague | dansmith: what exactly are you looking for? | |
| 21:48:37 | sdague | just how do the routes get populated? | |
| 21:48:39 | mriedem | dansmith: this is the extension code for servers https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/server_tags.py#L182 | |
| 21:49:00 | mriedem | https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/server_tags.py#L64 | |
| 21:49:03 | sdague | https://github.com/openstack/nova/blob/37cd9a961b065a07352b49ee72394cb210d8838b/nova/api/openstack/compute/server_tags.py#L183-L190 | |
| 21:49:10 | mriedem | show is a 204 | |
| 21:49:12 | mriedem | which seems odd | |
| 21:49:14 | dansmith | sdague: sdague when I PUT /servers/<uuid>/tags/foo, I never get to server_tags.py::update() before I get NotFound looking up the instance, it seems | |
| 21:49:43 | dims | mriedem : https://review.openstack.org/440826 | |
| 21:49:48 | mriedem | dansmith: that would be this i think https://github.com/openstack/nova/blob/master/nova/api/openstack/compute/server_tags.py#L137 | |
| 21:49:56 | dansmith | sdague: do the routes just fetch uuid out of the url for me, but completely rely on me doing the 404 if I don't find the server? | |
| 21:50:15 | dansmith | mriedem: yeah I don't seem to get there | |
| 21:50:23 | dansmith | maybe I'm doing something else wrong | |
| 21:51:10 | mriedem | dansmith: that's what it looks like, the tags extensions can fail with an InstanceNotFound | |
| 21:51:15 | sdague | dansmith: I'm going to have to reload this bit back into my head | |
| 21:51:17 | mriedem | but it looks like the instance lookup is hidden in the tag object | |
| 21:51:43 | dansmith | mriedem: right I just want to make sure that's the only one, because I don't seem to make it into that method *at all* | |
| 21:51:51 | mriedem | oh | |
| 21:51:51 | mriedem | https://github.com/openstack/nova/blob/master/nova/objects/tag.py#L51 | |
| 21:51:52 | dansmith | and I'm wondering if there is some other glue that is missing the cell lookup | |
| 21:52:01 | mriedem | dansmith: microversoin? | |
| 21:52:13 | dansmith | mriedem: it's tempest | |
| 21:52:21 | mriedem | still | |
| 21:52:27 | mriedem | is it passing 2.1? | |
| 21:52:56 | mriedem | i think you need at least 2.26 | |
| 21:52:57 | dansmith | I dunno, but the test seems to work without cells. I just tried from nova client and I get the same deal | |
| 21:53:17 | mriedem | novaclient CLI will request the latest microversion available that it understands | |
| 21:53:19 | mriedem | tempest won't | |
| 21:53:35 | dansmith | PUT http://192.168.201.194:8774/v2.1/servers/0d97611d-f1d6-4146-858d-9387baf36558/tags/tagme -H "OpenStack-API-Version: compute 2.41" | |
| 21:53:36 | mriedem | i don't think anyway | |
| 21:53:37 | sdague | mriedem: the tests should be configured correctly | |
| 21:53:43 | cfriesen | related to my earlier DB question....is there a reason why "instance_actions" rows don't get deleted when the instance does? | |
| 21:53:58 | mriedem | cfriesen: have you bothered to look at the code? | |
| 21:54:45 | cfriesen | mriedem: I'm looking at instance_destroy() in the DB API code | |
| 21:55:05 | mriedem | it doesn't appear that they do there | |
| 21:55:17 | mriedem | i believe this came up in the ML in newton | |
| 21:55:30 | cfriesen | okay, I can check the archives | |
| 21:55:37 | sdague | dansmith: I'm pretty sure nothing else is validating the server id until you get into server_tags.py | |
| 21:55:43 | cfriesen | I didn't see a bug for it | |
| 21:55:48 | dansmith | sdague: okay | |
| 21:55:55 | sdague | but, it's end of day, so that's just my recollection | |
| 21:56:06 | dansmith | sdague: http://pastebin.com/bicZYZVt | |
| 21:56:20 | dansmith | sdague: with that, when I add a tag from the client, I get _none_ of my log lines in the log | |