| Posted | Nick | Remark | |
|---|---|---|---|
| #openstack-nova - 2017-02-23 | |||
| 20:23:48 | dansmith | jaypipes: that looks a lot like what I was thinking | |
| 20:23:55 | dansmith | jaypipes: I shall return to it when I have full brains | |
| 20:24:09 | dansmith | melwitt: so.......... | |
| 20:24:31 | dansmith | melwitt: target_cell doesn't target mq, only database | |
| 20:24:47 | dansmith | melwitt: which we discussed previously as handled in the rpc layer and I think re-discussed recently as also putting in target_cell | |
| 20:25:15 | dansmith | melwitt: so now I'm hitting a problem because I need to call conductor's rpcapi for an instance, and have it go to the right cell's conductor | |
| 20:25:30 | dansmith | melwitt: and since we don't have that in there, I go by default to superconductor and fail | |
| 20:25:39 | dansmith | which I think is further justification for my opinion that target_cell should do mq too | |
| 20:25:41 | melwitt | dansmith: I know. it's on my todo list to add it back to target_cell and move the caching to there, maybe | |
| 20:25:42 | dansmith | thoughts? | |
| 20:25:50 | dansmith | okay | |
| 20:26:07 | melwitt | dansmith: yeah, I agree. maybe just a small patch to start to let it be possible, then the move of the cache and everything will be a bigger haul | |
| 20:26:18 | dansmith | melwitt: yeah, I shall do that thing then | |
| 20:27:28 | melwitt | dansmith: I can put up a change based on what I had way back when, before all of it moved to compute/rpcapi | |
| 20:27:40 | melwitt | it's an earlier PS of that patch | |
| 20:28:09 | dansmith | melwitt: okay would you rather do that than me just do it? | |
| 20:30:16 | melwitt | dansmith: you can do it, I didn't remember what there was to it. turns out it was only this https://review.openstack.org/#/c/274955/12/nova/context.py | |
| 20:30:36 | dansmith | melwitt: ack, yeah, thanks | |
| 20:31:08 | melwitt | I'm not sure if we need the special-casing of 'none:///'. that was to avoid doing something for cell0 | |
| 20:31:44 | spiantino | hey all - i found some logs from november discussing adding the ability to include "<kvm><hidden state='on'/><kvm>" to the libvirt domain via nova | |
| 20:32:16 | spiantino | is there an implementation of that? or any advice on how to hackily get that field included in a VM? without it NVidia GPUs don't work in a VM | |
| 20:35:24 | spiantino | mgariepy: were you ever able to get that option added to driver.py? | |
| 20:35:40 | spiantino | happy to submit the pr | |
| 20:39:49 | oomichi | alex_xu: sdague: johnthetubaguy: can you take a look at https://review.openstack.org/#/c/406377 ? | |
| 20:40:07 | oomichi | that could fix potential server internal error | |
| 20:40:55 | miss_hypothermia | mriedem: that seems like a fair deal, I mean have the volume locked | |
| 20:41:42 | miss_hypothermia | mriedem: so in this sense I will remove the compute service version bump and the additional unreserve call and add a release note to describe the change | |
| 20:42:06 | mriedem | miss_hypothermia: ok | |
| 20:42:10 | mriedem | i think i'm ok with that :) | |
| 20:42:25 | miss_hypothermia | mriedem: \o/ :) | |
| 20:42:33 | miss_hypothermia | mriedem: thanks! | |
| 20:42:53 | openstackgerrit | Balazs Gibizer proposed openstack/nova master: Transform missing delete notifications https://review.openstack.org/410297 | |
| 20:53:28 | andreykurilin | diana_clarke: ping | |
| 20:53:38 | diana_clarke | andreykurilin: allo! | |
| 20:54:40 | andreykurilin | diana_clarke: I'm at Sheraton now, can answer all questions :) | |
| 20:54:58 | diana_clarke | It was more fun when there was video and I could see you all. | |
| 20:55:14 | andreykurilin | Oh, you are not here? | |
| 20:55:18 | andreykurilin | :( | |
| 20:56:00 | dansmith | melwitt: actually, we still need to do stuff to conductor rpcapi to make it even honor the context I guess | |
| 20:56:22 | diana_clarke | andreykurilin: No, sadly. I've been detained multiple times at the US border in the past... sitting this one out. | |
| 20:57:55 | diana_clarke | andreykurilin: Mostly, I just wanted a sanity check on the change. When you made similar changes in the past, you changed test_auth.py but that's since been deleted. | |
| 20:58:51 | andreykurilin | diana_clarke: at least I have a PC now, so I can give you some answers | |
| 20:59:03 | mriedem | sdague: https://review.openstack.org/#/c/435563/ | |
| 20:59:08 | diana_clarke | andreykurilin: I didn't look all that hard today, but before that merges it should probably have tests. But when I grep recursively for project_name, no tests cover those paths, so I wondered if you had thoughts on that front. | |
| 20:59:16 | melwitt | dansmith: ah, right. the way it is right now, you'd add a ClientRouter to conductor/rpcapi and use by_host or by_instance | |
| 20:59:30 | dansmith | melwitt: yeah | |
| 20:59:32 | dansmith | hrmph | |
| 20:59:36 | melwitt | hah | |
| 20:59:49 | andreykurilin | diana_clarke: so test_auth was only about authentication in HTTPClient | |
| 21:00:04 | andreykurilin | now it is gone and there is only session client | |
| 21:00:13 | andreykurilin | we have functional tests for it | |
| 21:00:29 | diana_clarke | andreykurilin: yeah... I gathered that. I mention it only b/c related changes originally resulted in test changes there. | |
| 21:00:51 | andreykurilin | diana_clarke: https://github.com/openstack/python-novaclient/blob/master/novaclient/tests/functional/test_auth.py | |
| 21:01:00 | andreykurilin | there is only one place of testing auth stuff | |
| 21:04:46 | diana_clarke | andreykurilin: I'm only 50% sure that change is correct given the bazillion kwargs and similar environment variables. But if you're okay with it, I trust you :) | |
| 21:05:09 | diana_clarke | andreykurilin: I did manually test it, and it does indeed make the warnings go way. | |
| 21:05:49 | diana_clarke | And I suppose it does have all of pike to stew. | |
| 21:07:38 | mriedem | sfinucan: replied to your question in https://review.openstack.org/#/c/429413/ | |
| 21:08:01 | andreykurilin | diana_clarke: actually, it looks like there is no need to transmit all those kwargs now. lol | |
| 21:09:01 | andreykurilin | they are ignored in case of sessionclient which we obtain via keystoneauth1 at cli layer | |
| 21:09:37 | mriedem | alex_xu: gmann: is the -1 on https://review.openstack.org/#/c/429476/ still just because of the nested decorated function or something else, like the allowed states? | |
| 21:10:55 | andreykurilin | diana_clarke: https://github.com/openstack/python-novaclient/blob/master/novaclient/shell.py#L748-L751 creates keystone session. session_constructor do not process anything in that case - https://github.com/openstack/python-novaclient/blob/master/novaclient/client.py#L135 | |
| 21:11:32 | openstackgerrit | Lee Yarwood proposed openstack/nova master: db: Add attachment_id to block_device_mapping https://review.openstack.org/437597 | |
| 21:11:33 | openstackgerrit | Lee Yarwood proposed openstack/nova master: WIP objects: Add attachment_id to BlockDeviceMapping https://review.openstack.org/437665 | |
| 21:12:45 | mriedem | lyarwood: i guess you got started early on that huh | |
| 21:13:20 | andreykurilin | diana_clarke: maybe it is time to simplify cli layer ;) | |
| 21:13:39 | mriedem | lyarwood: can you track those attachment_id changes against this blueprint? https://blueprints.launchpad.net/nova/+spec/cinder-new-attach-apis | |
| 21:16:14 | thorst | mriedem: hey, probably a common issue, but I’ve got a flight out tomorrow afternoon. If possible, think we could hit the PowerVM update item sometime in the AM? | |
| 21:16:35 | mriedem | thorst: yes | |
| 21:16:40 | thorst | thx | |
| 21:17:50 | diana_clarke | andreykurilin: So.... stupid question, but is this only in the devstack case, or are actual users going to see this warning for every nova command on ocata deploys? | |
| 21:18:47 | alex_xu | mriedem: i'm -1 for the allowed states as i remember | |
| 21:19:02 | mriedem | alex_xu: ok i replied again in there | |
| 21:19:13 | alex_xu | mriedem: checking just | |
| 21:19:18 | alex_xu | s/just/that | |
| 21:21:47 | diana_clarke | andreykurilin: I feel like the answer is yes, but honestly I'm really tired today & my brain is only half working. | |
| 21:22:25 | gmann | mriedem: alex_xu yea same me too for resize state. i am testing that on https://review.openstack.org/#/c/430587/ | |
| 21:22:37 | gmann | and seems like 500, let me check compute log | |
| 21:23:12 | mriedem | gmann: note that won't hit this API unless it's using an FS style volume driver, like nFS | |
| 21:23:14 | mriedem | *NFS | |
| 21:23:28 | andreykurilin | diana_clarke: yes, everybody will see that warning in 100% of CLI usage | |
| 21:23:43 | diana_clarke | andreykurilin: So backport? | |
| 21:24:27 | alex_xu | mriedem: I agree we should fix it without microversion. Just think the case when states == PAUSED, isn't the case would return 500 to the user. we only fix the case without microversion which return 500 | |
| 21:24:33 | diana_clarke | actually my brain does get why now :) | |
| 21:24:37 | alex_xu | s/when/like | |
| 21:25:01 | mriedem | alex_xu: w/o testing a snapshot of a volume-backed paused instance with NFS i can't assume that works | |
| 21:25:08 | andreykurilin | diana_clarke: I think yes, but I'm not a "stable maintainer", so it is better to ask mriedem. | |
| 21:25:09 | mriedem | we don't allow paused for normal volume-backed snapshot today | |
| 21:25:17 | andreykurilin | diana_clarke: Btw, can you extend your patch with release note? | |
| 21:25:46 | gmann | mriedem: humm yea, difficult to check the behavior | |
| 21:26:00 | mriedem | gmann: we have an NFS job | |
| 21:26:11 | mriedem | i just don't know if it's in the tempest experimental queue | |
| 21:26:21 | gmann | let me check | |
| 21:26:22 | mriedem | gmann: it is in the nova experimental queue though so you could probably test all of this with some depends-on | |
| 21:26:23 | diana_clarke | andreykurilin: Sure! (tomorrow) And then I'll backport too. Thanks for your time. Have fun at PTG! | |
| 21:27:30 | andreykurilin | diana_clarke: thanks! hope to see you at one of the next openstack events ;) | |
| 21:30:07 | gmann | mriedem: yea not on tempest side. | |
| 21:30:35 | mriedem | gmann: you could post a nova change that depends on my change and the tempest test and run the experimental queue | |
| 21:30:43 | gmann | yea | |
| 21:33:05 | diana_clarke | andreykurilin: Did they announce at the PTG where the next one will be? Is it in the US> | |